Changeset b79308b for protocols/jabber

Timestamp:

2008-04-14T13:10:53Z (17 years ago)

Author:

ulim <a.sporto+bee@…>

Branches:

master

Children:

0cab388

Parents:

6cac643 (diff), aa31117 (diff)
Note: this is a merge changeset, the changes displayed below correspond to the merge itself.
Use the (diff) links above to see all the changes relative to each parent.

Message:

merged in upstream r379 (somewhere after 1.2-3).
Just one trivial conflict in the jabber Makefile, went smoothly.

Location:

protocols/jabber

Files:

• Makefile (modified) (2 diffs)
• io.c (modified) (2 diffs)
• iq.c (modified) (2 diffs)
• jabber.c (modified) (1 diff)
• jabber_util.c (modified) (2 diffs)
• sasl.c (modified) (3 diffs)

protocols/jabber/Makefile

@@ -10 +10 @@
 
 # [SH] Program variables
-objects = conference.o io.o iq.o jabber.o jabber_util.o message.o presence.o sasl.o xmltree.o si.o s5bytestream.o
+objects = conference.o io.o iq.o jabber.o jabber_util.o message.o presence.o sasl.o si.o s5bytestream.o
 
 CFLAGS += -Wall
@@ -18 +18 @@
 all: jabber_mod.o
 check: all
-lcov:
+lcov: check
 gcov: 
         gcov *.c

protocols/jabber/io.c

@@ -241 +241 @@
         }
         
-        /* EAGAIN/etc or a successful read. */
-        return TRUE;
+        if( ssl_pending( jd->ssl ) )
+                /* OpenSSL empties the TCP buffers completely but may keep some
+                   data in its internap buffers. select() won't see that, but
+                   ssl_pending() does. */
+                return jabber_read_callback( data, fd, cond );
+        else
+                return TRUE;
 }
 
@@ -521 +526 @@
            from the server too. */
         xt_free( jd->xt );      /* In case we're RE-starting. */
-        jd->xt = xt_new( ic );
-        jd->xt->handlers = (struct xt_handler_entry*) jabber_handlers;
+        jd->xt = xt_new( jabber_handlers, ic );
         
         if( jd->r_inpa <= 0 )

protocols/jabber/iq.c

@@ -534 +534 @@
 }
 
+static xt_status jabber_add_to_roster_callback( struct im_connection *ic, struct xt_node *node, struct xt_node *orig );
+
 int jabber_add_to_roster( struct im_connection *ic, char *handle, char *name )
 {
@@ -549 +551 @@
         xt_add_attr( node, "xmlns", XMLNS_ROSTER );
         node = jabber_make_packet( "iq", "set", NULL, node );
+        jabber_cache_add( ic, node, jabber_add_to_roster_callback );
         
         st = jabber_write_packet( ic, node );
         
-        xt_free_node( node );
         return st;
+}
+
+static xt_status jabber_add_to_roster_callback( struct im_connection *ic, struct xt_node *node, struct xt_node *orig )
+{
+        char *s, *jid = NULL;
+        struct xt_node *c;
+        
+        if( ( c = xt_find_node( orig->children, "query" ) ) &&
+            ( c = xt_find_node( c->children, "item" ) ) &&
+            ( jid = xt_find_attr( c, "jid" ) ) &&
+            ( s = xt_find_attr( node, "type" ) ) &&
+            strcmp( s, "result" ) == 0 )
+        {
+                if( imcb_find_buddy( ic, jid ) == NULL )
+                        imcb_add_buddy( ic, jid, NULL );
+        }
+        else
+        {
+                imcb_log( ic, "Error while adding `%s' to your contact list.",
+                          jid ? jid : "(unknown handle)" );
+        }
+        
+        return XT_HANDLED;
 }
 

protocols/jabber/jabber.c

@@ -267 +267 @@
         xt_free( jd->xt );
         
+        g_free( jd->cached_id_prefix );
         g_free( jd->away_message );
         g_free( jd->username );

protocols/jabber/jabber_util.c

@@ -250 +250 @@
 };
 
-static void jabber_buddy_ask_yes( gpointer w, struct jabber_buddy_ask_data *bla )
-{
+static void jabber_buddy_ask_yes( void *data )
+{
+        struct jabber_buddy_ask_data *bla = data;
+        
         presence_send_request( bla->ic, bla->handle, "subscribed" );
         
@@ -261 +263 @@
 }
 
-static void jabber_buddy_ask_no( gpointer w, struct jabber_buddy_ask_data *bla )
-{
+static void jabber_buddy_ask_no( void *data )
+{
+        struct jabber_buddy_ask_data *bla = data;
+        
         presence_send_request( bla->ic, bla->handle, "subscribed" );
         

protocols/jabber/sasl.c

@@ -21 +21 @@
 *                                                                           *
 \***************************************************************************/
+
+#include <ctype.h>
 
 #include "jabber.h"
@@ -107 +109 @@
 }
 
-static char *sasl_get_part( char *data, char *field )
+/* Non-static function, but not mentioned in jabber.h because it's for internal
+   use, just that the unittest should be able to reach it... */
+char *sasl_get_part( char *data, char *field )
 {
         int i, len;
         
         len = strlen( field );
+        
+        while( isspace( *data ) || *data == ',' )
+                data ++;
         
         if( g_strncasecmp( data, field, len ) == 0 && data[len] == '=' )
@@ -129 +136 @@
                         }
                         
-                        /* If we got a comma, we got a new field. Check it. */
-                        if( data[i] == ',' &&
-                            g_strncasecmp( data + i + 1, field, len ) == 0 &&
-                            data[i+len+1] == '=' )
+                        /* If we got a comma, we got a new field. Check it,
+                           find the next key after it. */
+                        if( data[i] == ',' )
                         {
-                                i += len + 2;
-                                break;
+                                while( isspace( data[i] ) || data[i] == ',' )
+                                        i ++;
+                                
+                                if( g_strncasecmp( data + i, field, len ) == 0 &&
+                                    data[i+len] == '=' )
+                                {
+                                        i += len + 1;
+                                        break;
+                                }
                         }
                 }