Changeset ad8a810

Timestamp:

2015-10-30T10:31:09Z (9 years ago)

Author:

dequis <dx@…>

Branches:

master

Children:

2e99039

Parents:

129e282

git-author:

dequis <dx@…> (27-10-15 09:01:40)

git-committer:

dequis <dx@…> (30-10-15 10:31:09)

Message:

jabber: Don't reply XEP-0184 receipts sent over MUCs

XEP-0184 section 5.3 says those shouldn't be sent over MUCs, but some
misbehaving clients do anyway, resulting in 'forbidden' errors

File:

• protocols/jabber/message.c (modified) (1 diff)

protocols/jabber/message.c

@@ -37 +37 @@
         if (!from) {
                 return XT_HANDLED; /* Consider this packet corrupted. */
+        }
 
-        }
-        if (request && id) {
+        if (request && id && g_strcmp0(type, "groupchat") != 0) {
                 /* Send a message receipt (XEP-0184), looking like this:
-                 * <message
-                 *  from='kingrichard@royalty.england.lit/throne'
-                 *  id='bi29sg183b4v'
-                 *  to='northumberland@shakespeare.lit/westminster'>
+                 * <message from='...' id='...' to='...'>
                  *  <received xmlns='urn:xmpp:receipts' id='richard2-4.1.247'/>
-                 * </message> */
+                 * </message>
+                 *
+                 * MUC messages are excluded, since receipts aren't supposed to be sent over MUCs
+                 * (XEP-0184 section 5.3) and replying to those may result in 'forbidden' errors.
+                 */
                 struct xt_node *received, *receipt;