Changeset a73e91a

Timestamp:

2008-02-16T17:38:30Z (17 years ago)

Author:

Wilmer van der Gaast <wilmer@…>

Branches:

master

Children:

2d88d25a, 31fc3970

Parents:

ca60550

Message:

Added callback on Jabber add-to-roster requests so buddies get added to the
internal buddy list a little bit earlier. This should deal better with
Jabber servers that send presence information of a new buddy before the
roster push.

File:

• protocols/jabber/iq.c (modified) (2 diffs)

protocols/jabber/iq.c

@@ -526 +526 @@
 }
 
+static xt_status jabber_add_to_roster_callback( struct im_connection *ic, struct xt_node *node, struct xt_node *orig );
+
 int jabber_add_to_roster( struct im_connection *ic, char *handle, char *name )
 {
@@ -541 +543 @@
         xt_add_attr( node, "xmlns", XMLNS_ROSTER );
         node = jabber_make_packet( "iq", "set", NULL, node );
+        jabber_cache_add( ic, node, jabber_add_to_roster_callback );
         
         st = jabber_write_packet( ic, node );
         
-        xt_free_node( node );
         return st;
+}
+
+static xt_status jabber_add_to_roster_callback( struct im_connection *ic, struct xt_node *node, struct xt_node *orig )
+{
+        char *s, *jid = NULL;
+        struct xt_node *c;
+        
+        if( ( c = xt_find_node( orig->children, "query" ) ) &&
+            ( c = xt_find_node( c->children, "item" ) ) &&
+            ( jid = xt_find_attr( c, "jid" ) ) &&
+            ( s = xt_find_attr( node, "type" ) ) &&
+            strcmp( s, "result" ) == 0 )
+        {
+                if( imcb_find_buddy( ic, jid ) == NULL )
+                        imcb_add_buddy( ic, jid, NULL );
+        }
+        else
+        {
+                imcb_log( ic, "Error while adding `%s' to your contact list.",
+                          jid ? jid : "(unknown handle)" );
+        }
+        
+        return XT_HANDLED;
 }