Changeset a26af5c for protocols

Timestamp:

2010-07-13T20:13:46Z (14 years ago)

Author:

Wilmer van der Gaast <wilmer@…>

Branches:

master

Children:

e693ac2

Parents:

00540d4

Message:

Fixing NULL pointer dereferences in Twitter module. Based on patch from
wahjava (bug #650).

File:

• protocols/twitter/twitter_lib.c (modified) (3 diffs)

protocols/twitter/twitter_lib.c

@@ -66 +66 @@
 static void txu_free(struct twitter_xml_user *txu)
 {
+        if (txu == NULL)
+                return;
         g_free(txu->name);
         g_free(txu->screen_name);
@@ -89 +91 @@
 {
         GSList *l;
+        if (txl == NULL)
+                return;
         for ( l = txl->list; l ; l = g_slist_next(l) )
                 if (txl->type == TXL_STATUS)
@@ -473 +477 @@
         {
                 status = l->data;
+                if (status->user == NULL || status->text == NULL)
+                        continue;
+
                 twitter_add_buddy(ic, status->user->screen_name, status->user->name);