Changeset a1d30c5 for protocols

Timestamp:

2015-05-28T04:12:23Z (9 years ago)

Author:

dequis <dx@…>

Children:

d2d2b80

Parents:

ec8b369 (diff), 3d31618 (diff)
Note: this is a merge changeset, the changes displayed below correspond to the merge itself.
Use the (diff) links above to see all the changes relative to each parent.

Message:

Merge branch 'develop' into feat/hip-cat

Location:

protocols

Files:

• jabber/presence.c (modified) (3 diffs)
• msn/msn.c (modified) (4 diffs)
• msn/msn.h (modified) (4 diffs)
• msn/ns.c (modified) (6 diffs)
• skype/Makefile (modified) (3 diffs)
• skype/skyped.1 (added)

protocols/jabber/presence.c

@@ -181 +181 @@
 }
 
+static char *choose_priority(struct im_connection *ic)
+{
+        struct jabber_data *jd = ic->proto_data;
+        char *prio = set_getstr(&ic->acc->set, "priority");
+
+        if (jd->away_state->code != NULL) {
+                int new_prio = (atoi(prio) - 5);
+                if (new_prio < 0) {
+                        new_prio = 0;
+                }
+                return g_strdup_printf("%d", new_prio);
+        }
+
+        return g_strdup(prio);
+}
+
 /* Whenever presence information is updated, call this function to inform the
    server. */
@@ -189 +205 @@
         GSList *l;
         int st;
+        char *prio = choose_priority(ic);
 
         node = jabber_make_packet("presence", NULL, NULL, NULL);
-        xt_add_child(node, xt_new_node("priority", set_getstr(&ic->acc->set, "priority"), NULL));
+        xt_add_child(node, xt_new_node("priority", prio, NULL));
         if (jd->away_state) {
                 xt_add_child(node, xt_new_node("show", jd->away_state->code, NULL));
@@ -222 +239 @@
 
         xt_free_node(node);
+        g_free(prio);
         return st;
 }

protocols/msn/msn.c

@@ -144 +144 @@
 {
         struct bee_user *bu = bee_user_by_handle(ic->bee, ic, who);
-
-#ifdef DEBUG
-        if (strcmp(who, "raw") == 0) {
-                msn_ns_write(ic, -1, "%s\r\n", message);
-                return 0;
-        }
-#endif
-
-        msn_ns_sendmessage(ic, bu, message);
-        return(0);
+        msn_ns_send_message(ic, bu, message);
+        return 0;
 }
 
@@ -277 +269 @@
                 return 0;
         } else if (typing & OPT_TYPING) {
-                return(msn_buddy_msg(ic, who, TYPING_NOTIFICATION_MESSAGE, 0));
+                return msn_ns_send_typing(ic, bu);
         } else {
                 return 1;
@@ -338 +330 @@
 
         g_tree_remove(md->domaintree, bu->handle);
-}
-
-GList *msn_buddy_action_list(bee_user_t *bu)
-{
-        static GList *ret = NULL;
-
-        if (ret == NULL) {
-                static const struct buddy_action ba[2] = {
-                        { "NUDGE", "Draw attention" },
-                };
-
-                ret = g_list_prepend(ret, (void *) ba + 0);
-        }
-
-        return ret;
-}
-
-void *msn_buddy_action(struct bee_user *bu, const char *action, char * const args[], void *data)
-{
-        if (g_strcasecmp(action, "NUDGE") == 0) {
-                msn_buddy_msg(bu->ic, bu->handle, NUDGE_MESSAGE, 0);
-        }
-
-        return NULL;
 }
 
@@ -392 +360 @@
         ret->buddy_data_add = msn_buddy_data_add;
         ret->buddy_data_free = msn_buddy_data_free;
-        ret->buddy_action_list = msn_buddy_action_list;
-        ret->buddy_action = msn_buddy_action;
 
         register_protocol(ret);

protocols/msn/msn.h

@@ -26 +26 @@
 #ifndef _MSN_H
 #define _MSN_H
-
-/* Some hackish magicstrings to make special-purpose messages/switchboards.
- */
-#define TYPING_NOTIFICATION_MESSAGE "\r\r\rBEWARE, ME R TYPINK MESSAGE!!!!\r\r\r"
-#define NUDGE_MESSAGE "\r\r\rSHAKE THAT THING\r\r\r"
-#define GROUPCHAT_SWITCHBOARD_MESSAGE "\r\r\rME WANT TALK TO MANY PEOPLE\r\r\r"
-
-#ifdef DEBUG_MSN
-#define debug(text ...) imcb_log(ic, text);
-#else
-#define debug(text ...)
-#endif
 
 /* This should be MSN Messenger 7.0.0813
@@ -77 +65 @@
 #define MSN_MESSAGE_HEADERS MSN_BASE_HEADERS \
         "Messaging: 2.0\r\n" \
-        "Message-Type: Text\r\n" \
+        "Message-Type: %s\r\n" \
         "Content-Length: %zd\r\n" \
         "Content-Type: text/plain; charset=UTF-8\r\n" \
@@ -103 +91 @@
         "</user>"
 
-#define MSN_TYPING_HEADERS "MIME-Version: 1.0\r\n" \
-        "Content-Type: text/x-msmsgscontrol\r\n" \
-        "TypingUser: %s\r\n" \
-        "\r\n\r\n"
-
-#define MSN_NUDGE_HEADERS "MIME-Version: 1.0\r\n" \
-        "Content-Type: text/x-msnmsgr-datacast\r\n" \
-        "\r\n" \
-        "ID: 1\r\n" \
-        "\r\n"
-
 #define PROFILE_URL "http://members.msn.com/"
 
@@ -242 +219 @@
 void msn_auth_got_contact_list(struct im_connection *ic);
 int msn_ns_finish_login(struct im_connection *ic);
-int msn_ns_sendmessage(struct im_connection *ic, struct bee_user *bu, const char *text);
+int msn_ns_send_typing(struct im_connection *ic, struct bee_user *bu);
+int msn_ns_send_message(struct im_connection *ic, struct bee_user *bu, const char *text);
 int msn_ns_command(struct msn_data *md, char **cmd, int num_parts);
 int msn_ns_message(struct msn_data *md, char *msg, int msglen, char **cmd, int num_parts);

protocols/msn/ns.c

@@ -417 +417 @@
                         } else if (g_strncasecmp(ct, "text/x-msmsgsactivemailnotification", 35) == 0) {
                                 /* Notification that a message has been read... Ignore it */
-                        } else {
-                                debug("Can't handle %s packet from notification server", ct);
                         }
 
@@ -623 +621 @@
         char l[4];
 
-        if ((bd->flags & 7) == 0 || (bd->flags & MSN_BUDDY_ADL_SYNCED)) {
+        if ((bd->flags & (MSN_BUDDY_FL | MSN_BUDDY_AL)) == 0 || (bd->flags & MSN_BUDDY_ADL_SYNCED)) {
                 return FALSE;
         }
@@ -641 +639 @@
         }
 
-        g_snprintf(l, sizeof(l), "%d", bd->flags & 7);
+        g_snprintf(l, sizeof(l), "%d", bd->flags & (MSN_BUDDY_FL | MSN_BUDDY_AL));
         c = xt_new_node("c", NULL, NULL);
         xt_add_attr(c, "n", handle);
@@ -694 +692 @@
                 struct msn_buddy_data *bd = bu->data;
 
-                if (bu->ic != ic || (bd->flags & 7) == 0) {
+                if (bu->ic != ic || (bd->flags & (MSN_BUDDY_FL | MSN_BUDDY_AL)) == 0) {
                         continue;
                 }
@@ -724 +722 @@
 }
 
-// TODO: typing notifications, nudges lol, etc
-int msn_ns_sendmessage(struct im_connection *ic, bee_user_t *bu, const char *text)
+static int msn_ns_send_sdg(struct im_connection *ic, bee_user_t *bu, const char *message_type, const char *text)
 {
         struct msn_data *md = ic->proto_data;
@@ -731 +728 @@
         char *buf;
 
-        if (strncmp(text, "\r\r\r", 3) == 0) {
-                /* Err. Shouldn't happen but I guess it can. Don't send others
-                   any of the "SHAKE THAT THING" messages. :-D */
-                return 1;
-        }
-
-        buf = g_strdup_printf(MSN_MESSAGE_HEADERS, bu->handle, ic->acc->user, md->uuid, strlen(text), text);
+        buf = g_strdup_printf(MSN_MESSAGE_HEADERS, bu->handle, ic->acc->user, md->uuid, message_type, strlen(text), text);
         retval = msn_ns_write(ic, -1, "SDG %d %zd\r\n%s", ++md->trId, strlen(buf), buf);
         g_free(buf);
         return retval;
 }
+
+int msn_ns_send_typing(struct im_connection *ic, bee_user_t *bu)
+{
+        return msn_ns_send_sdg(ic, bu, "Control/Typing", "");
+}
+
+int msn_ns_send_message(struct im_connection *ic, bee_user_t *bu, const char *text)
+{
+        return msn_ns_send_sdg(ic, bu, "Text", text);
+}
+

protocols/skype/Makefile

@@ -7 +7 @@
 INSTALL = install
 
-
-ifdef ASCIIDOC
-MANPAGES = skyped.1
-else
-MANPAGES =
-endif
-
-all: $(MANPAGES)
-
+all:
 clean:
-        rm -f $(MANPAGES)
 
 # take this from the kernel
@@ -29 +20 @@
 
 install-doc: doc
-ifdef ASCIIDOC
         $(INSTALL) -d $(DESTDIR)$(MANDIR)/man1
         $(INSTALL) -m644 $(MANPAGES) $(DESTDIR)$(MANDIR)/man1
-endif
 
 uninstall-doc:
@@ -38 +27 @@
 
 %.1: $(_SRCDIR_)%.txt $(_SRCDIR_)asciidoc.conf
-        a2x --asciidoc-opts="-f $(_SRCDIR_)asciidoc.conf" -a bee_date=$(DATE) -f manpage -D . $<
+        a2x --asciidoc-opts="-f $(_SRCDIR_)asciidoc.conf" -a bee_date=$(DATE) -f manpage $<