Changeset 9fca0657

Timestamp:

2010-03-15T10:26:25Z (15 years ago)

Author:

Wilmer van der Gaast <wilmer@…>

Branches:

master

Children:

449a51d

Parents:

315dd4c

Message:

Deal with stupid (on first sight, at least) Yahoo! server behaviour causing
double free()s on testing ATM. Apparently it's perfectly legal to give buddy
information with an "end buddy" marker but no "begin buddy".

File:

• protocols/yahoo/libyahoo2.c (modified) (1 diff)

protocols/yahoo/libyahoo2.c

@@ -1344 +1344 @@
                 case 301:       /* End buddy */
                         if (!strcmp(pair->value, "315") && u) {
-                                users = y_list_prepend(users, u);
+                                /* Sometimes user info comes in an odd format with no
+                                   "begin buddy" but *with* an "end buddy". Don't add
+                                   it twice. */
+                                if (!y_list_find(users, u))
+                                        users = y_list_prepend(users, u);
                                 u = yd->half_user = NULL;
                         }