Changeset 977a9d5 for protocols/nogaim.c

Timestamp:

2015-12-09T07:58:59Z (9 years ago)

Author:

dequis <dx@…>

Branches:

master

Children:

4c29622

Parents:

dbca297

Message:

Revert "imc_away_send_update: Fix leak of away_states linked list"

This reverts commit ed431c389887080dc4fa45e30d051ce733f4ce57.

I'm going to let this leak. Turns out only purple allocates an empty
list for every time this is called. Other protocols have statics, and
they always return the same thing, can't free those. Whatever. The
purple leak was insignificant, just more scratching of itches.

File:

• protocols/nogaim.c (modified) (3 diffs)

protocols/nogaim.c

@@ -611 +611 @@
 {
         char *away, *msg = NULL;
-        GList *m = NULL;
 
         if (ic->acc->prpl->away_states == NULL ||
@@ -621 +620 @@
                : set_getstr(&ic->bee->set, "away");
         if (away && *away) {
-                m = ic->acc->prpl->away_states(ic);
+                GList *m = ic->acc->prpl->away_states(ic);
                 msg = ic->acc->flags & ACC_FLAG_AWAY_MESSAGE ? away : NULL;
                 away = imc_away_state_find(m, away, &msg) ? :
@@ -632 +631 @@
 
         ic->acc->prpl->set_away(ic, away, msg);
-
-        while (m) {
-                m = g_list_delete_link(m, m);
-        }
 
         return 1;