Changeset 91dd19c for protocols/jabber

Timestamp:

2015-07-30T03:20:30Z (9 years ago)

Author:

dequis <dx@…>

Branches:

master

Children:

e11216c

Parents:

adec749

Message:

Only try DIGEST-MD5 if there's no SSL/TLS or if PLAIN isn't supported

Which in practice means "don't bother with DIGEST-MD5 most of the time".

It's weak, pointless over TLS, and often breaks with some servers
(hi openfire)

File:

• protocols/jabber/sasl.c (modified) (1 diff)

protocols/jabber/sasl.c

@@ -154 +154 @@
                 xt_free_node(reply);
                 return XT_ABORT;
-        } else if (sup_digest) {
+        } else if (sup_digest && !(jd->ssl && sup_plain)) {
+                /* Only try DIGEST-MD5 if there's no SSL/TLS or if PLAIN isn't supported.
+                 * Which in practice means "don't bother with DIGEST-MD5 most of the time".
+                 * It's weak, pointless over TLS, and often breaks with some servers (hi openfire) */
+
                 xt_add_attr(reply, "mechanism", "DIGEST-MD5");