Changeset 90a45b8

Timestamp:

2016-12-26T22:38:32Z (8 years ago)

Author:

dequis <dx@…>

Branches:

master

Children:

d57484d

Parents:

26eed8a

git-author:

dequis <dx@…> (26-12-16 02:17:28)

git-committer:

dequis <dx@…> (26-12-16 22:38:32)

Message:

Fix some clang static analyzer warnings

Nothing interesting.

Files:

• lib/ftutil.c (modified) (1 diff)
• protocols/jabber/s5bytestream.c (modified) (3 diffs)
• set.c (modified) (1 diff)
• storage.c (modified) (1 diff)

lib/ftutil.c

@@ -42 +42 @@
         struct addrinfo hints, *rp;
         socklen_t ssize = sizeof(struct sockaddr_storage);
-        struct sockaddr_storage saddrs, *saddr = &saddrs;
+        struct sockaddr_storage saddrs = {0}, *saddr = &saddrs;
         static char errmsg[1024];
         char *ftlisten = global.conf->ft_listen;

protocols/jabber/s5bytestream.c

@@ -500 +500 @@
         case BS_PHASE_REPLY:
         {
-                struct socks5_message socks5_reply;
+                struct socks5_message socks5_reply = {0};
                 int ret;
 
@@ -1046 +1046 @@
                         unsigned char nmethods;
                         unsigned char method;
-                } socks5_hello;
+                } socks5_hello = {0};
 
                 if (!(ret = jabber_bs_peek(bt, &socks5_hello, sizeof(socks5_hello)))) {
@@ -1091 +1091 @@
         case BS_PHASE_REQUEST:
         {
-                struct socks5_message socks5_connect;
+                struct socks5_message socks5_connect = {0};
                 int msgsize = sizeof(struct socks5_message);
                 int ret;

set.c

@@ -165 +165 @@
         /* If there's a default setting and it's equal to what we're trying to
            set, stick with s->value = NULL. Otherwise, remember the setting. */
-        if (!s->def || (strcmp(nv, s->def) != 0)) {
+        if (!s->def || (g_strcmp0(nv, s->def) != 0)) {
                 s->value = g_strdup(nv);
         }

storage.c

@@ -74 +74 @@
 
         storage = storage_init_single(primary);
-        if (storage == NULL && storage->save == NULL) {
+        if (storage == NULL || storage->save == NULL) {
                 return NULL;
         }