Changeset 88086db

Timestamp:

2006-06-25T17:23:27Z (18 years ago)

Author:

Wilmer van der Gaast <wilmer@…>

Branches:

master

Children:

6ee9d2d

Parents:

6e1fed7

Message:

Added versioning information to the XML-file (convenient for later format
changes), got rid of confusing "Password successfully changed" message
when the user uses the identify-command and protected rc4_decode() against
short inputs.

Files:

• irc.c (modified) (1 diff)
• lib/rc4.c (modified) (1 diff)
• storage_xml.c (modified) (2 diffs)

irc.c

@@ -33 +33 @@
 GSList *irc_connection_list = NULL;
 
-static char *passchange (irc_t *irc, void *set, char *value) 
-{
-        irc_setpass (irc, value);
-        return (NULL);
+static char *passchange( irc_t *irc, void *set, char *value )
+{
+        irc_setpass( irc, value );
+        irc_usermsg( irc, "Password successfully changed" );
+        return NULL;
 }
 

lib/rc4.c

@@ -158 +158 @@
         clear_len = crypt_len - RC4_IV_LEN;
         
+        if( clear_len < 0 )
+        {
+                *clear = g_strdup( "" );
+                return 0;
+        }
+        
         /* Prepare buffers and the key + IV */
         *clear = g_malloc( clear_len + 1 );

storage_xml.c

@@ -40 +40 @@
    BitlBee would be a better solution. But this will work for now... */
 #define XML_PASS_ERRORMSG "Wrong username or password"
+#define XML_FORMAT_VERSION 1
 
 struct xml_parsedata
@@ -410 +411 @@
         pass_buf = base64_encode( (char*) pass_md5, 21 );
         
-        if( !xml_printf( fd, "<user nick=\"%s\" password=\"%s\">\n", irc->nick, pass_buf ) )
+        if( !xml_printf( fd, "<user nick=\"%s\" password=\"%s\" version=\"%d\">\n", irc->nick, pass_buf, XML_FORMAT_VERSION ) )
                 goto write_error;