Changeset 81ee561 for protocols/jabber

Timestamp:

2010-03-20T18:03:18Z (15 years ago)

Author:

Wilmer van der Gaast <wilmer@…>

Branches:

master

Children:

85693e6

Parents:

3330468 (diff), 0baed0d (diff)
Note: this is a merge changeset, the changes displayed below correspond to the merge itself.
Use the (diff) links above to see all the changes relative to each parent.

Message:

Merging head. Most changes are not so relevant because they're to IM
modules.

Location:

protocols/jabber

Files:

• io.c (modified) (1 diff)
• iq.c (modified) (3 diffs)
• jabber.c (modified) (4 diffs)
• jabber.h (modified) (3 diffs)
• jabber_util.c (modified) (15 diffs)
• message.c (modified) (1 diff)
• presence.c (modified) (1 diff)

protocols/jabber/io.c

@@ -380 +380 @@
                 jd->flags |= JFLAG_WANT_SESSION;
         
-        /* This flag is already set if we authenticated via SASL, so now
-           we can resume the session in the new stream, if we don't have
-           to bind/initialize the session. */
-        if( jd->flags & JFLAG_AUTHENTICATED && ( jd->flags & ( JFLAG_WANT_BIND | JFLAG_WANT_SESSION ) ) == 0 )
-        {
-                if( !jabber_get_roster( ic ) )
-                        return XT_ABORT;
-        }
-        else if( jd->flags & JFLAG_AUTHENTICATED )
-        {
+        if( jd->flags & JFLAG_AUTHENTICATED )
                 return jabber_pkt_bind_sess( ic, NULL, NULL );
-        }
         
         return XT_HANDLED;

protocols/jabber/iq.c

@@ -307 +307 @@
                     strcmp( s + 1, set_getstr( &ic->acc->set, "resource" ) ) != 0 )
                         imcb_log( ic, "Server changed session resource string to `%s'", s + 1 );
-                
-                jd->flags &= ~JFLAG_WANT_BIND;
-        }
-        else if( node && ( c = xt_find_node( node->children, "session" ) ) )
-        {
-                jd->flags &= ~JFLAG_WANT_SESSION;
         }
         
@@ -319 +313 @@
                 reply = xt_new_node( "bind", NULL, xt_new_node( "resource", set_getstr( &ic->acc->set, "resource" ), NULL ) );
                 xt_add_attr( reply, "xmlns", XMLNS_BIND );
+                jd->flags &= ~JFLAG_WANT_BIND;
         }
         else if( jd->flags & JFLAG_WANT_SESSION )
@@ -324 +319 @@
                 reply = xt_new_node( "session", NULL, NULL );
                 xt_add_attr( reply, "xmlns", XMLNS_SESSION );
+                jd->flags &= ~JFLAG_WANT_SESSION;
         }
         

protocols/jabber/jabber.c

@@ -58 +58 @@
         char str[16];
         
+        s = set_add( &acc->set, "activity_timeout", "600", set_eval_int, acc );
+        
         g_snprintf( str, sizeof( str ), "%d", jabber_port_list[0] );
         s = set_add( &acc->set, "port", str, set_eval_int, acc );
@@ -67 +69 @@
         s->flags |= ACC_SET_OFFLINE_ONLY;
         
-        s = set_add( &acc->set, "resource_select", "priority", NULL, acc );
+        s = set_add( &acc->set, "resource_select", "activity", NULL, acc );
         
         s = set_add( &acc->set, "server", NULL, set_eval_account, acc );
@@ -307 +309 @@
                 bud = jabber_buddy_by_ext_jid( ic, who, 0 );
         else
-                bud = jabber_buddy_by_jid( ic, who, 0 );
+                bud = jabber_buddy_by_jid( ic, who, GET_BUDDY_BARE_OK );
         
         node = xt_new_node( "body", message, NULL );
@@ -352 +354 @@
 static void jabber_get_info( struct im_connection *ic, char *who )
 {
-        struct jabber_data *jd = ic->proto_data;
         struct jabber_buddy *bud;
         
-        if( strchr( who, '/' ) )
-                bud = jabber_buddy_by_jid( ic, who, 0 );
-        else
-        {
-                char *s = jabber_normalize( who );
-                bud = g_hash_table_lookup( jd->buddies, s );
-                g_free( s );
-        }
+        bud = jabber_buddy_by_jid( ic, who, GET_BUDDY_FIRST );
         
         while( bud )

protocols/jabber/jabber.h

@@ -108 +108 @@
 };
 
+/* Somewhat messy data structure: We have a hash table with the bare JID as
+   the key and the head of a struct jabber_buddy list as the value. The head
+   is always a bare JID. If the JID has other resources (often the case,
+   except for some transports that don't support multiple resources), those
+   follow. In that case, the bare JID at the beginning doesn't actually
+   refer to a real session and should only be used for operations that
+   support incomplete JIDs. */
 struct jabber_buddy
 {
@@ -121 +128 @@
         char *away_message;
         
-        time_t last_act;
+        time_t last_msg;
         jabber_buddy_flags_t flags;
         
@@ -209 +216 @@
         GET_BUDDY_EXACT = 2,    /* Get an exact match (only makes sense with bare JIDs). */
         GET_BUDDY_FIRST = 4,    /* No selection, simply get the first resource for this JID. */
+        GET_BUDDY_BARE = 8,     /* Get the bare version of the JID (possibly inexistent). */
+        GET_BUDDY_BARE_OK = 16, /* Allow returning a bare JID if that seems better. */
 } get_buddy_flags_t;
 

protocols/jabber/jabber_util.c

@@ -4 +4 @@
 *  Jabber module - Misc. stuff                                              *
 *                                                                           *
-*  Copyright 2006 Wilmer van der Gaast <wilmer@gaast.net>                   *
+*  Copyright 2006-2010 Wilmer van der Gaast <wilmer@gaast.net>              
 *                                                                           *
 *  This program is free software; you can redistribute it and/or modify     *
@@ -345 +345 @@
         if( ( bud = g_hash_table_lookup( jd->buddies, full_jid ) ) )
         {
+                /* The first entry is always a bare JID. If there are more, we
+                   should ignore the first one here. */
+                if( bud->next )
+                        bud = bud->next;
+                
                 /* If this is a transport buddy or whatever, it can't have more
                    than one instance, so this is always wrong: */
@@ -379 +384 @@
         else
         {
-                /* Keep in mind that full_jid currently isn't really
-                   a full JID... */
-                new->bare_jid = g_strdup( full_jid );
+                new->full_jid = new->bare_jid = g_strdup( full_jid );
                 g_hash_table_insert( jd->buddies, new->bare_jid, new );
+                
+                if( s )
+                {
+                        new->next = g_new0( struct jabber_buddy, 1 );
+                        new->next->bare_jid = new->bare_jid;
+                        new = new->next;
+                }
         }
         
@@ -408 +418 @@
 {
         struct jabber_data *jd = ic->proto_data;
-        struct jabber_buddy *bud;
+        struct jabber_buddy *bud, *head;
         char *s, *jid;
         
@@ -420 +430 @@
                 if( ( bud = g_hash_table_lookup( jd->buddies, jid ) ) )
                 {
+                        bare_exists = 1;
+                        
+                        if( bud->next )
+                                bud = bud->next;
+                        
                         /* Just return the first one for this bare JID. */
                         if( flags & GET_BUDDY_FIRST )
@@ -441 +456 @@
                                         break;
                 }
-                else
-                {
-                        /* This variable tells the if down here that the bare
-                           JID already exists and we should feel free to add
-                           more resources, if the caller asked for that. */
-                        bare_exists = 1;
-                }
                 
                 if( bud == NULL && ( flags & GET_BUDDY_CREAT ) &&
-                    ( !bare_exists || imcb_find_buddy( ic, jid ) ) )
+                    ( bare_exists || imcb_find_buddy( ic, jid ) ) )
                 {
                         *s = '/';
@@ -464 +472 @@
                 char *set;
                 
-                bud = g_hash_table_lookup( jd->buddies, jid );
+                head = g_hash_table_lookup( jd->buddies, jid );
+                bud = ( head && head->next ) ? head->next : head;
                 
                 g_free( jid );
@@ -481 +490 @@
                         /* Looks like the caller doesn't care about details. */
                         return bud;
+                else if( flags & GET_BUDDY_BARE )
+                        return head;
                 
                 best_prio = best_time = bud;
@@ -487 +498 @@
                         if( bud->priority > best_prio->priority )
                                 best_prio = bud;
-                        if( bud->last_act > best_time->last_act )
+                        if( bud->last_msg > best_time->last_msg )
                                 best_time = bud;
                 }
@@ -493 +504 @@
                 if( ( set = set_getstr( &ic->acc->set, "resource_select" ) ) == NULL )
                         return NULL;
-                else if( strcmp( set, "activity" ) == 0 )
+                else if( strcmp( set, "priority" ) == 0 )
+                        return best_prio;
+                else if( flags & GET_BUDDY_BARE_OK ) /* && strcmp( set, "activity" ) == 0 */
+                {
+                        if( best_time->last_msg + set_getint( &ic->acc->set, "activity_timeout" ) >= time( NULL ) )
+                                return best_time;
+                        else
+                                return head;
+                }
+                else
                         return best_time;
-                else /* if( strcmp( set, "priority" ) == 0 ) */
-                        return best_prio;
         }
 }
@@ -538 +556 @@
 {
         struct jabber_data *jd = ic->proto_data;
-        struct jabber_buddy *bud, *prev, *bi;
+        struct jabber_buddy *bud, *prev = NULL, *bi;
         char *s, *full_jid;
         
@@ -548 +566 @@
         if( ( bud = g_hash_table_lookup( jd->buddies, full_jid ) ) )
         {
+                if( bud->next )
+                        bud = (prev=bud)->next;
+                
                 /* If there's only one item in the list (and if the resource
                    matches), removing it is simple. (And the hash reference
@@ -555 +576 @@
                       ( bud->resource && s && strcmp( bud->resource, s + 1 ) == 0 ) ) )
                 {
-                        g_hash_table_remove( jd->buddies, bud->bare_jid );
-                        g_free( bud->bare_jid );
-                        g_free( bud->ext_jid );
-                        g_free( bud->full_jid );
-                        g_free( bud->away_message );
-                        g_free( bud );
-                        
-                        g_free( full_jid );
-                        
-                        return 1;
+                        return jabber_buddy_remove_bare( ic, full_jid );
                 }
                 else if( s == NULL || bud->resource == NULL )
@@ -575 +587 @@
                 else
                 {
-                        for( bi = bud, prev = NULL; bi; bi = (prev=bi)->next )
+                        for( bi = bud; bi; bi = (prev=bi)->next )
                                 if( strcmp( bi->resource, s + 1 ) == 0 )
                                         break;
@@ -586 +598 @@
                                         prev->next = bi->next;
                                 else
-                                        /* The hash table should point at the second
-                                           item, because we're removing the first. */
+                                        /* Don't think this should ever happen anymore. */
                                         g_hash_table_replace( jd->buddies, bi->bare_jid, bi->next );
                                 

protocols/jabber/message.c

@@ -71 +71 @@
                         if( bud )
                         {
-                                bud->last_act = time( NULL );
+                                bud->last_msg = time( NULL );
                                 from = bud->ext_jid ? : bud->bare_jid;
                         }

protocols/jabber/presence.c

@@ -68 +68 @@
                 {
                         bud->away_state = NULL;
-                        /* Let's only set last_act if there's *no* away state,
-                           since it could be some auto-away thingy. */
-                        bud->last_act = time( NULL );
                 }