Changeset 7d27962

Timestamp:

2012-02-08T00:24:12Z (13 years ago)

Author:

Wilmer van der Gaast <wilmer@…>

Branches:

master

Children:

e0a0a42

Parents:

d2abcae

Message:

Take t.co URL lengthe^{Wshortening into account when counting message length
before posting a Twitter message. Disable this functionality by default for
identi.ca accounts. Hardcode post-t.co URL length to 20 since it's probably
not going to change any time soon. Bug #855. Patch by Artem Savkov, thanks!}

Files:

• doc/user-guide/commands.xml (modified) (1 diff)
• protocols/twitter/twitter.c (modified) (3 diffs)

doc/user-guide/commands.xml

@@ -1032 +1032 @@
 
         </bitlbee-setting>
+        
+        <bitlbee-setting name="target_url_length" type="integer" scope="account">
+                <default>20</default>
+
+                <description>
+                        <para>
+                                Twitter replaces every URL with fixed-length t.co URLs. BitlBee is able to take t.co urls into account when calculating <emphasis>message_length</emphasis> replacing the actual URL length with target_url_length. Setting target_url_length to 0 disables this feature.
+                        </para>
+
+                        <para>
+                                This setting is disabled for identica accounts by default and will not affect anything other than message safety checks (i.e. Twitter will still replace your URLs with t.co links, even if that makes them longer).
+                        </para>
+                </description>
+
+        </bitlbee-setting>
 
         <bitlbee-setting name="mode" type="string" scope="account">

protocols/twitter/twitter.c

@@ -197 +197 @@
 }
 
+int twitter_url_len_diff(gchar *msg, unsigned int target_len)
+{
+        int url_len_diff = 0;
+
+        static GRegex *regex = NULL;
+        GMatchInfo *match_info;
+
+        if (regex == NULL)
+                regex = g_regex_new("(^|\\s)(http(s)?://[^\\s$]+)", 0, 0, NULL);
+        
+        g_regex_match(regex, msg, 0, &match_info);
+        while (g_match_info_matches(match_info)) {
+                gchar *url = g_match_info_fetch(match_info, 2);
+                url_len_diff += target_len - g_utf8_strlen(url, -1);
+                if (g_match_info_fetch(match_info, 3) != NULL)
+                        url_len_diff += 1;
+                g_free(url);
+                g_match_info_next(match_info, NULL);
+        }
+        g_match_info_free(match_info);
+
+        return url_len_diff;
+}
+
 static gboolean twitter_length_check(struct im_connection *ic, gchar * msg)
 {
         int max = set_getint(&ic->acc->set, "message_length"), len;
-
-        if (max == 0 || (len = g_utf8_strlen(msg, -1)) <= max)
+        int target_len = set_getint(&ic->acc->set, "target_url_length");
+        int url_len_diff = 0;
+    
+        if (target_len > 0)
+                url_len_diff = twitter_url_len_diff(msg, target_len);
+
+        if (max == 0 || (len = g_utf8_strlen(msg, -1) + url_len_diff) <= max)
                 return TRUE;
 
@@ -214 +243 @@
         char *def_url;
         char *def_oauth;
+        char *def_tul;
 
         if (strcmp(acc->prpl->name, "twitter") == 0) {
                 def_url = TWITTER_API_URL;
                 def_oauth = "true";
+                def_tul = "20";
         } else {                /* if( strcmp( acc->prpl->name, "identica" ) == 0 ) */
                 def_url = IDENTICA_API_URL;
                 def_oauth = "true";
+                def_tul = "0";
         }
 
@@ -236 +268 @@
 
         s = set_add(&acc->set, "message_length", "140", set_eval_int, acc);
+
+        s = set_add(&acc->set, "target_url_length", def_tul, set_eval_int, acc);
 
         s = set_add(&acc->set, "mode", "chat", set_eval_mode, acc);