Changeset 7a9d968 for lib

Timestamp:

2018-03-10T11:30:39Z (7 years ago)

Author:

Wilmer van der Gaast <wilmer@…>

Children:

5447c59

Parents:

3f44e43 (diff), 4a9c6b0 (diff)
Note: this is a merge changeset, the changes displayed below correspond to the merge itself.
Use the (diff) links above to see all the changes relative to each parent.

Message:

Merge branch 'master' into HEAD

Location:

lib

Files:

• Makefile (modified) (3 diffs)
• canohost.c (added)
• canohost.h (added)
• ftutil.c (modified) (6 diffs)
• ftutil.h (modified) (1 diff)
• misc.c (modified) (2 diffs)
• misc.h (modified) (2 diffs)

lib/Makefile

@@ -13 +13 @@
 
 # [SH] Program variables
-objects = arc.o base64.o $(EVENT_HANDLER) ftutil.o http_client.o ini.o md5.o misc.o oauth.o oauth2.o parson.o proxy.o sha1.o $(SSL_CLIENT) url.o xmltree.o ns_parse.o
+objects = arc.o base64.o canohost.o $(EVENT_HANDLER) ftutil.o http_client.o ini.o md5.o misc.o oauth.o oauth2.o parson.o proxy.o sha1.o $(SSL_CLIENT) url.o xmltree.o ns_parse.o
 
 LFLAGS += -r
@@ -36 +36 @@
 lib.o: $(objects) $(subdirs)
         @echo '*' Linking lib.o
-        @$(LD) $(LFLAGS) $(objects) -o lib.o
+        $(VERBOSE) $(LD) $(LFLAGS) $(objects) -o lib.o
 
 $(objects): ../Makefile.settings Makefile
@@ -42 +42 @@
 $(objects): %.o: $(_SRCDIR_)%.c
         @echo '*' Compiling $<
-        @$(CC) -c $(CFLAGS) $(CFLAGS_BITLBEE) $< -o $@
+        $(VERBOSE) $(CC) -c $(CFLAGS) $(CFLAGS_BITLBEE) $< -o $@
 
 -include .depend/*.d

lib/ftutil.c

@@ -42 +42 @@
         struct addrinfo hints, *rp;
         socklen_t ssize = sizeof(struct sockaddr_storage);
-        struct sockaddr_storage saddrs, *saddr = &saddrs;
+        struct sockaddr_storage saddrs = {0}, *saddr = &saddrs;
         static char errmsg[1024];
         char *ftlisten = global.conf->ft_listen;
@@ -63 +63 @@
                         if (for_bitlbee_client) {
                                 *scolon = '\0';
-                                strncpy(host, ftlisten, HOST_NAME_MAX);
+                                strncpy(host, ftlisten, NI_MAXHOST);
                                 *scolon = ';';
                         } else {
-                                strncpy(host, scolon + 1, HOST_NAME_MAX);
+                                strncpy(host, scolon + 1, NI_MAXHOST);
                         }
                 } else {
-                        strncpy(host, ftlisten, HOST_NAME_MAX);
+                        strncpy(host, ftlisten, NI_MAXHOST);
                 }
 
@@ -78 +78 @@
         } else if (copy_fd >= 0 && getsockname(copy_fd, (struct sockaddr*) &saddrs, &ssize) == 0 &&
                    (saddrs.ss_family == AF_INET || saddrs.ss_family == AF_INET6) &&
-                   getnameinfo((struct sockaddr*) &saddrs, ssize, host, HOST_NAME_MAX,
+                   getnameinfo((struct sockaddr*) &saddrs, ssize, host, NI_MAXHOST,
                                NULL, 0, NI_NUMERICHOST) == 0) {
                 /* We just took our local address on copy_fd, which is likely to be a
@@ -84 +84 @@
                    most sensible we can get easily. */
         } else {
-                ASSERTSOCKOP(gethostname(host, HOST_NAME_MAX + 1), "gethostname()");
+                ASSERTSOCKOP(gethostname(host, NI_MAXHOST), "gethostname()");
         }
 
@@ -109 +109 @@
                        ( void * ) &(( struct sockaddr_in * ) saddr)->sin_addr.s_addr :
                        ( void * ) &(( struct sockaddr_in6 * ) saddr)->sin6_addr.s6_addr,
-                       host, HOST_NAME_MAX)) {
+                       host, NI_MAXHOST)) {
                 strcpy(errmsg, "inet_ntop failed on listening socket");
                 return -1;
@@ -128 +128 @@
 
         /* I hate static-length strings.. */
-        host[HOST_NAME_MAX - 1] = '\0';
+        host[NI_MAXHOST - 1] = '\0';
         port[5] = '\0';
 

lib/ftutil.h

@@ -26 +26 @@
 #endif
 
-/* Some ifdefs for ulibc and apparently also BSD (Thanks to Whoopie) */
-#ifndef HOST_NAME_MAX
-#include <sys/param.h>
-#ifdef MAXHOSTNAMELEN
-#define HOST_NAME_MAX MAXHOSTNAMELEN
-#else
-#define HOST_NAME_MAX 255
-#endif
-#endif
-
 /* This function should be used with care. host should be AT LEAST a
-   char[HOST_NAME_MAX+1] and port AT LEAST a char[6]. */
+   char[NI_MAXHOST+1] and port AT LEAST a char[6]. */
 int ft_listen(struct sockaddr_storage *saddr_ptr, char *host, char *port, int copy_fd, int for_bitlbee_client,
               char **errptr);

lib/misc.c

@@ -1 @@
-/********************************************************************\
+  /********************************************************************\
   * BitlBee -- An IRC to other IM-networks gateway                     *
   *                                                                    *
@@ -335 +335 @@
 }
 
-/* Wrap an IPv4 address into IPv6 space. Not thread-safe... */
-char *ipv6_wrap(char *src)
-{
-        static char dst[64];
-        int i;
-
-        for (i = 0; src[i]; i++) {
-                if ((src[i] < '0' || src[i] > '9') && src[i] != '.') {
-                        break;
-                }
-        }
-
-        /* Hmm, it's not even an IP... */
-        if (src[i]) {
-                return src;
-        }
-
-        g_snprintf(dst, sizeof(dst), "::ffff:%s", src);
-
-        return dst;
-}
-
-/* Unwrap an IPv4 address into IPv6 space. Thread-safe, because it's very simple. :-) */
-char *ipv6_unwrap(char *src)
-{
-        int i;
-
-        if (g_strncasecmp(src, "::ffff:", 7) != 0) {
-                return src;
-        }
-
-        for (i = 7; src[i]; i++) {
-                if ((src[i] < '0' || src[i] > '9') && src[i] != '.') {
-                        break;
-                }
-        }
-
-        /* Hmm, it's not even an IP... */
-        if (src[i]) {
-                return src;
-        }
-
-        return (src + 7);
-}
-
 /* Convert from one charset to another.
 

lib/misc.h

@@ -29 +29 @@
 #include <gmodule.h>
 #include <time.h>
+#include <sys/socket.h>
 
 struct ns_srv_reply {
@@ -130 +131 @@
 G_MODULE_EXPORT void http_encode(char *s);
 
-G_MODULE_EXPORT char *ipv6_wrap(char *src);
-G_MODULE_EXPORT char *ipv6_unwrap(char *src);
-
 G_MODULE_EXPORT signed int do_iconv(char *from_cs, char *to_cs, char *src, char *dst, size_t size, size_t maxbuf);