Changeset 7616eec


Ignore:
Timestamp:
2016-01-26T15:53:56Z (3 years ago)
Author:
dequis <dx@…>
Branches:
master
Children:
db5ef3a
Parents:
eee7294
git-author:
dequis <dx@…> (26-01-16 15:22:45)
git-committer:
dequis <dx@…> (26-01-16 15:53:56)
Message:

root_commands: Fix use-after-free after doing "transfer reject"

Not a big deal because as far as I can see not much happens between the
g_slist_remove() in dcc_close() and accessing files->next. I'd expect
that pointer to remain null after being freed most of the time.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • root_commands.c

    reee7294 r7616eec  
    12381238{
    12391239        GSList *files = irc->file_transfers;
     1240        GSList *next;
    12401241
    12411242        enum { LIST, REJECT, CANCEL };
     
    12551256        }
    12561257
    1257         for (; files; files = g_slist_next(files)) {
     1258        for (; files; files = next) {
     1259                next = files->next;
    12581260                file_transfer_t *file = files->data;
    12591261
Note: See TracChangeset for help on using the changeset viewer.