Changeset 7486853

Timestamp:

2016-12-26T00:20:09Z (8 years ago)

Author:

dequis <dx@…>

Branches:

master

Children:

6d212f4

Parents:

6908ab7

git-author:

dequis <dx@…> (25-12-16 23:10:58)

git-committer:

dequis <dx@…> (26-12-16 00:20:09)

Message:

Refactor: Split plugin info stuff from load_plugin() into two functions

File:

• protocols/nogaim.c (modified) (4 diffs)

protocols/nogaim.c

@@ -50 +50 @@
 }
 
+/* semi-private */
+gboolean plugin_info_validate(struct plugin_info *info, const char *path)
+{
+        GList *l;
+        gboolean loaded = FALSE;
+
+        if (!path) {
+                path = "(null)";
+        }
+
+        if (info->abiver != BITLBEE_ABI_VERSION_CODE) {
+                log_message(LOGLVL_ERROR,
+                            "`%s' uses ABI %u but %u is required\n",
+                            path, info->abiver,
+                            BITLBEE_ABI_VERSION_CODE);
+                return FALSE;
+        }
+
+        if (!info->name || !info->version) {
+                log_message(LOGLVL_ERROR,
+                            "Name or version missing from the "
+                            "plugin info in `%s'\n", path);
+                return FALSE;
+        }
+
+        for (l = plugins; l; l = l->next) {
+                struct plugin_info *i = l->data;
+
+                if (g_strcasecmp(i->name, info->name) == 0) {
+                        loaded = TRUE;
+                        break;
+                }
+        }
+
+        if (loaded) {
+                log_message(LOGLVL_WARNING,
+                            "%s plugin already loaded\n",
+                            info->name);
+                return FALSE;
+        }
+
+        return TRUE;
+}
+
+/* semi-private */
+gboolean plugin_info_add(struct plugin_info *info)
+{
+        plugins = g_list_insert_sorted_with_data(plugins, info, pluginscmp, NULL);
+        return TRUE;
+}
+
 gboolean load_plugin(char *path)
 {
-        GList *l;
-        struct plugin_info *i;
         struct plugin_info *info = NULL;
         struct plugin_info * (*info_function) (void) = NULL;
@@ -59 +108 @@
 
         GModule *mod = g_module_open(path, G_MODULE_BIND_LAZY);
-        gboolean loaded = FALSE;
 
         if (!mod) {
@@ -69 +117 @@
                 info = info_function();
 
-                if (info->abiver != BITLBEE_ABI_VERSION_CODE) {
-                        log_message(LOGLVL_ERROR,
-                                    "`%s' uses ABI %u but %u is required\n",
-                                    path, info->abiver,
-                                    BITLBEE_ABI_VERSION_CODE);
-                        g_module_close(mod);
-                        return FALSE;
-                }
-
-                if (!info->name || !info->version) {
-                        log_message(LOGLVL_ERROR,
-                                    "Name or version missing from the "
-                                    "plugin info in `%s'\n", path);
-                        g_module_close(mod);
-                        return FALSE;
-                }
-
-                for (l = plugins; l; l = l->next) {
-                        i = l->data;
-
-                        if (g_strcasecmp(i->name, info->name) == 0) {
-                                loaded = TRUE;
-                                break;
-                        }
-                }
-
-                if (loaded) {
-                        log_message(LOGLVL_WARNING,
-                                    "%s plugin already loaded\n",
-                                    info->name);
+                if (!plugin_info_validate(info, path)) {
                         g_module_close(mod);
                         return FALSE;
@@ -113 +132 @@
 
         if (info_function) {
-                plugins = g_list_insert_sorted_with_data(plugins, info,
-                                                         pluginscmp, NULL);
+                plugin_info_add(info);
         }