Changeset 7320610

Timestamp:

2015-03-10T07:33:54Z (10 years ago)

Author:

dequis <dx@…>

Branches:

master

Children:

afbad28

Parents:

8b91a1f

git-author:

dequis <dx@…> (07-03-15 04:10:59)

git-committer:

dequis <dx@…> (10-03-15 07:33:54)

Message:

Various user experience/error reporting improvements

• Show version as part of the initial message of &bitlbee
• Use g_strerror() to show actual errors when saving xml configs
• Only show "The nick is (probably) not registered" for ENOENT, use g_strerror() for the rest of OS errors when loading xml configs
• Show "Protocol not found: <name>" when find_protocol() returns null, useful when the user uninstalls a plugin accidentally.
• Suggest the user to check the system clock when getting error 401 from the twitter stream (other REST endpoints show a better error message)

Files:

• irc.c (modified) (1 diff)
• protocols/twitter/twitter_lib.c (modified) (1 diff)
• storage_xml.c (modified) (4 diffs)

irc.c

@@ -764 +764 @@
                         irc_rootmsg(irc,
                                     "Welcome to the BitlBee gateway!\n\n"
+                                    "Running %s %s\n\n"
                                     "If you've never used BitlBee before, please do read the help "
                                     "information using the \x02help\x02 command. Lots of FAQs are "
                                     "answered there.\n"
                                     "If you already have an account on this server, just use the "
-                                    "\x02identify\x02 command to identify yourself.");
+                                    "\x02identify\x02 command to identify yourself.",
+                                    PACKAGE, BITLBEE_VERSION);
 
                         /* This is for bug #209 (use PASS to identify to NickServ). */

protocols/twitter/twitter_lib.c

@@ -862 +862 @@
 
                 imcb_error(ic, "Stream closed (%s)", req->status_string);
+                if (req->status_code == 401) {
+                        imcb_error(ic, "Check your system clock.");
+                }
                 imc_logout(ic, TRUE);
                 return;

storage_xml.c

@@ -103 +103 @@
         if (protocol) {
                 prpl = find_protocol(protocol);
+                if (!prpl) {
+                        irc_rootmsg(xd->irc, "Error loading user config: Protocol not found: `%s'", protocol);
+                        return XT_ABORT;
+                }
                 local = protocol_account_islocal(protocol);
         }
@@ -197 +201 @@
         fn = g_strconcat(global.conf->configdir, xd->given_nick, ".xml", NULL);
         if ((fd = open(fn, O_RDONLY)) < 0) {
-                ret = STORAGE_NO_SUCH_USER;
+                if (errno == ENOENT) {
+                        ret = STORAGE_NO_SUCH_USER;
+                } else {
+                        irc_rootmsg(irc, "Error loading user config: %s", g_strerror(errno));
+                }
                 goto error;
         }
@@ -377 +385 @@
         strcat(path, ".XXXXXX");
         if ((fd = mkstemp(path)) < 0) {
-                irc_rootmsg(irc, "Error while opening configuration file.");
-                return STORAGE_OTHER_ERROR;
+                goto error;
         }
 
@@ -400 +407 @@
 
 error:
-        irc_rootmsg(irc, "Write error. Disk full?");
+        irc_rootmsg(irc, "Write error: %s", g_strerror(errno));
         ret = STORAGE_OTHER_ERROR;