Changeset 6b13103 for protocols/oscar

Timestamp:

2015-01-16T19:50:23Z (10 years ago)

Author:

dequis <dx@…>

Branches:

master

Children:

1065dd4, eabe6d4

Parents:

6f10697

Message:

Replace isdigit/isalpha/.../tolower/toupper with glib variants

This fixes warnings about passing signed chars to them (apparently they
are implemented as macros that do array lookups without checks in some
platforms, yay)

Specifically:

functions=isalnum|isalpha|isdigit|isspace|isxdigit|tolower|toupper
sed -ir "s/$functions/g_ascii_&/g" /*.c

Location:

protocols/oscar

Files:

• auth.c (modified) (1 diff)
• oscar.c (modified) (3 diffs)
• oscar_util.c (modified) (1 diff)

protocols/oscar/auth.c

@@ -125 +125 @@
                 return -EINVAL;
 
-        if (isdigit(sn[0]) && set_getbool(&ic->acc->set, "old_icq_auth"))
+        if (g_ascii_isdigit(sn[0]) && set_getbool(&ic->acc->set, "old_icq_auth"))
                 return goddamnicq(sess, conn, sn);
 

protocols/oscar/oscar.c

@@ -368 +368 @@
 {
         set_t *s;
-        gboolean icq = isdigit(acc->user[0]);
+        gboolean icq = g_ascii_isdigit(acc->user[0]);
         
         if (icq) {
@@ -394 +394 @@
         struct oscar_data *odata = ic->proto_data = g_new0(struct oscar_data, 1);
 
-        if (isdigit(acc->user[0]))
+        if (g_ascii_isdigit(acc->user[0]))
                 odata->icq = TRUE;
         else
@@ -2500 +2500 @@
         char * chatname, *s;
         
-        chatname = g_strdup_printf("%s%s%d", isdigit(*ic->acc->user) ? "icq" : "",
+        chatname = g_strdup_printf("%s%s%d", g_ascii_isdigit(*ic->acc->user) ? "icq" : "",
                                    ic->acc->user, chat_id++);
         
         for (s = chatname; *s; s ++)
-                if (!isalnum(*s))
+                if (!g_ascii_isalnum(*s))
                         *s = '0';
         

protocols/oscar/oscar_util.c

@@ -57 +57 @@
                                 curPtr2++;
                 } else {
-                        if ( toupper(*curPtr1) != toupper(*curPtr2))
+                        if ( g_ascii_toupper(*curPtr1) != g_ascii_toupper(*curPtr2))
                                 return 1;
                         curPtr1++;