Changeset 6b13103 for protocols/msn

Timestamp:

2015-01-16T19:50:23Z (10 years ago)

Author:

dequis <dx@…>

Branches:

master

Children:

1065dd4, eabe6d4

Parents:

6f10697

Message:

Replace isdigit/isalpha/.../tolower/toupper with glib variants

This fixes warnings about passing signed chars to them (apparently they
are implemented as macros that do array lookups without checks in some
platforms, yay)

Specifically:

functions=isalnum|isalpha|isdigit|isspace|isxdigit|tolower|toupper
sed -ir "s/$functions/g_ascii_&/g" /*.c

Location:

protocols/msn

Files:

• msn.c (modified) (1 diff)
• ns.c (modified) (2 diffs)
• sb.c (modified) (2 diffs)

protocols/msn/msn.c

@@ -377 +377 @@
         g_tree_insert( md->domaintree, bu->handle, bu );
         
-        for( handle = bu->handle; isdigit( *handle ); handle ++ );
+        for( handle = bu->handle; g_ascii_isdigit( *handle ); handle ++ );
         if( *handle == ':' )
         {

protocols/msn/ns.c

@@ -581 +581 @@
                 ic->flags |= OPT_PONGED;
         }
-        else if( isdigit( cmd[0][0] ) )
+        else if( g_ascii_isdigit( cmd[0][0] ) )
         {
                 int num = atoi( cmd[0] );
@@ -997 +997 @@
         /* This might be a federated contact. Get its network number,
            prefixed to bu->handle with a colon. Default is 1. */
-        for( handle = bu->handle; isdigit( *handle ); handle ++ )
+        for( handle = bu->handle; g_ascii_isdigit( *handle ); handle ++ )
                 type = type * 10 + *handle - '0';
         if( *handle == ':' )

protocols/msn/sb.c

@@ -506 +506 @@
         else if( strcmp( cmd[0], "CAL" ) == 0 )
         {
-                if( num_parts < 4 || !isdigit( cmd[3][0] ) )
+                if( num_parts < 4 || !g_ascii_isdigit( cmd[3][0] ) )
                 {
                         msn_sb_destroy( sb );
@@ -645 +645 @@
                 }
         }
-        else if( isdigit( cmd[0][0] ) )
+        else if( g_ascii_isdigit( cmd[0][0] ) )
         {
                 int num = atoi( cmd[0] );