Changeset 6b13103 for protocols/jabber

Timestamp:

2015-01-16T19:50:23Z (10 years ago)

Author:

dequis <dx@…>

Branches:

master

Children:

1065dd4, eabe6d4

Parents:

6f10697

Message:

Replace isdigit/isalpha/.../tolower/toupper with glib variants

This fixes warnings about passing signed chars to them (apparently they
are implemented as macros that do array lookups without checks in some
platforms, yay)

Specifically:

functions=isalnum|isalpha|isdigit|isspace|isxdigit|tolower|toupper
sed -ir "s/$functions/g_ascii_&/g" /*.c

Location:

protocols/jabber

Files:

• jabber_util.c (modified) (2 diffs)
• sasl.c (modified) (2 diffs)

protocols/jabber/jabber_util.c

@@ -321 +321 @@
                         return FALSE;
                 }
-                if( tolower( jid1[i] ) != tolower( jid2[i] ) )
+                if( g_ascii_tolower( jid1[i] ) != g_ascii_tolower( jid2[i] ) )
                 {
                         return FALSE;
@@ -342 +342 @@
            it's Unicode but feck Unicode. :-P So stop once we see a slash. */
         for( i = 0; i < len && orig[i] != '/' ; i ++ )
-                new[i] = tolower( orig[i] );
+                new[i] = g_ascii_tolower( orig[i] );
         for( ; orig[i]; i ++ )
                 new[i] = orig[i];

protocols/jabber/sasl.c

@@ -187 +187 @@
         len = strlen( field );
         
-        while( isspace( *data ) || *data == ',' )
+        while( g_ascii_isspace( *data ) || *data == ',' )
                 data ++;
         
@@ -210 +210 @@
                         if( data[i] == ',' )
                         {
-                                while( isspace( data[i] ) || data[i] == ',' )
+                                while( g_ascii_isspace( data[i] ) || data[i] == ',' )
                                         i ++;