Changeset 69cb623 for protocols

Timestamp:

2006-10-15T09:41:12Z (18 years ago)

Author:

Wilmer van der Gaast <wilmer@…>

Branches:

master

Children:

2529faf

Parents:

695e392 (diff), e97827b (diff)
Note: this is a merge changeset, the changes displayed below correspond to the merge itself.
Use the (diff) links above to see all the changes relative to each parent.

Message:

Merging with storage-xml. It seems to be working pretty well, so maybe
this way more people will test it. :-)

Location:

protocols

Files:

• Makefile (modified) (1 diff)
• http_client.h (deleted)
• jabber/jabber.c (modified) (6 diffs)
• msn/msn.c (modified) (5 diffs)
• msn/ns.c (modified) (2 diffs)
• nogaim.c (modified) (40 diffs)
• nogaim.h (modified) (7 diffs)
• oscar/oscar.c (modified) (10 diffs)
• oscar/rxhandlers.c (modified) (1 diff)
• oscar/service.c (modified) (1 diff)
• yahoo/libyahoo2.c (modified) (2 diffs)
• yahoo/yahoo.c (modified) (4 diffs)

protocols/Makefile

@@ -10 +10 @@
 
 # [SH] Program variables
-objects = $(EVENT_HANDLER) http_client.o md5.o nogaim.o proxy.o sha.o $(SSL_CLIENT)
+objects = nogaim.o
 
 # [SH] The next two lines should contain the directory name (in $(subdirs))

protocols/jabber/jabber.c

@@ -561 +561 @@
 static void gjab_start(gjconn gjc)
 {
-        struct aim_user *user;
+        account_t *acc;
         int port = -1, ssl = 0;
-        char *server = NULL, *s;
+        char *server = NULL;
 
         if (!gjc || gjc->state != JCONN_STATE_OFF)
                 return;
 
-        user = GJ_GC(gjc)->user;
-        if (*user->proto_opt[0]) {
-                /* If there's a dot, assume there's a hostname in the beginning */
-                if (strchr(user->proto_opt[0], '.')) {
-                        server = g_strdup(user->proto_opt[0]);
-                        if ((s = strchr(server, ':')))
-                                *s = 0;
-                }
-                
-                /* After the hostname, there can be a port number */
-                s = strchr(user->proto_opt[0], ':');
-                if (s && isdigit(s[1]))
-                        sscanf(s + 1, "%d", &port);
-                
-                /* And if there's the string ssl, the user wants an SSL-connection */
-                if (strstr(user->proto_opt[0], ":ssl") || g_strcasecmp(user->proto_opt[0], "ssl") == 0)
-                        ssl = 1;
-        }
-        
-        if (port == -1 && !ssl)
-                port = DEFAULT_PORT;
-        else if (port == -1 && ssl)
-                port = DEFAULT_PORT_SSL;
-        else if (port < JABBER_PORT_MIN || port > JABBER_PORT_MAX) {
+        acc = GJ_GC(gjc)->acc;
+        server = acc->server;
+        port = set_getint(&acc->set, "port");
+        ssl = set_getbool(&acc->set, "ssl");
+        
+        if (port < JABBER_PORT_MIN || port > JABBER_PORT_MAX) {
                 serv_got_crap(GJ_GC(gjc), "For security reasons, the Jabber port number must be in the %d-%d range.", JABBER_PORT_MIN, JABBER_PORT_MAX);
                 STATE_EVT(JCONN_STATE_OFF)
@@ -614 +596 @@
         }
         
-        g_free(server);
-        
-        if (!user->gc || (gjc->fd < 0)) {
+        if (!acc->gc || (gjc->fd < 0)) {
                 STATE_EVT(JCONN_STATE_OFF)
                 return;
@@ -1516 +1496 @@
 }
 
-static void jabber_login(struct aim_user *user)
-{
-        struct gaim_connection *gc = new_gaim_conn(user);
-        struct jabber_data *jd = gc->proto_data = g_new0(struct jabber_data, 1);
-        char *loginname = create_valid_jid(user->username, DEFAULT_SERVER, "BitlBee");
-
+static void jabber_acc_init(account_t *acc)
+{
+        set_t *s;
+        
+        s = set_add( &acc->set, "port", "5222", set_eval_int, acc );
+        s->flags |= ACC_SET_OFFLINE_ONLY;
+        
+        s = set_add( &acc->set, "resource", "BitlBee", NULL, acc );
+        s->flags |= ACC_SET_OFFLINE_ONLY;
+        
+        s = set_add( &acc->set, "server", NULL, set_eval_account, acc );
+        s->flags |= ACC_SET_NOSAVE | ACC_SET_OFFLINE_ONLY;
+        
+        s = set_add( &acc->set, "ssl", "false", set_eval_bool, acc );
+        s->flags |= ACC_SET_OFFLINE_ONLY;
+}
+
+static void jabber_login(account_t *acc)
+{
+        struct gaim_connection *gc;
+        struct jabber_data *jd;
+        char *resource, *loginname;
+        
+        /* Time to move some data/things from the old syntax to the new one: */
+        if (acc->server) {
+                char *s, *tmp_server;
+                int port;
+                
+                if (g_strcasecmp(acc->server, "ssl") == 0) {
+                        set_setstr(&acc->set, "server", "");
+                        set_setint(&acc->set, "port", DEFAULT_PORT_SSL);
+                        set_setstr(&acc->set, "ssl", "true");
+                        
+                        g_free(acc->server);
+                        acc->server = NULL;
+                } else if ((s = strchr(acc->server, ':'))) {
+                        if (strstr(acc->server, ":ssl")) {
+                                set_setint(&acc->set, "port", DEFAULT_PORT_SSL);
+                                set_setstr(&acc->set, "ssl", "true");
+                        }
+                        if (isdigit(s[1])) {
+                                if (sscanf(s + 1, "%d", &port) == 1)
+                                        set_setint(&acc->set, "port", port);
+                        }
+                        tmp_server = g_strndup(acc->server, s - acc->server);
+                        set_setstr(&acc->set, "server", tmp_server);
+                        g_free(tmp_server);
+                }
+        }
+        
+        gc = new_gaim_conn(acc);
+        jd = gc->proto_data = g_new0(struct jabber_data, 1);
+        
+        if( strchr( acc->user, '@' ) == NULL )
+        {
+                hide_login_progress( gc, "Invalid account name" );
+                signoff( gc );
+                return;
+        }
+        
+        resource = set_getstr(&acc->set, "resource");
+        loginname = create_valid_jid(acc->user, DEFAULT_SERVER, resource);
+        
         jd->hash = g_hash_table_new(g_str_hash, g_str_equal);
         jd->chats = NULL;       /* we have no chats yet */
@@ -1527 +1564 @@
         set_login_progress(gc, 1, _("Connecting"));
 
-        if (!(jd->gjc = gjab_new(loginname, user->password, gc))) {
+        if (!(jd->gjc = gjab_new(loginname, acc->pass, gc))) {
                 g_free(loginname);
                 hide_login_progress(gc, _("Unable to connect"));
@@ -2337 +2374 @@
         ret->name = "jabber";
         ret->away_states = jabber_away_states;
+        ret->acc_init = jabber_acc_init;
         ret->login = jabber_login;
         ret->close = jabber_close;
@@ -2349 +2387 @@
         ret->alias_buddy = jabber_roster_update;
         ret->group_buddy = jabber_group_change;
-        ret->cmp_buddynames = g_strcasecmp;
+        ret->handle_cmp = g_strcasecmp;
 
         register_protocol (ret);

protocols/msn/msn.c

@@ -27 +27 @@
 #include "msn.h"
 
-static void msn_login( struct aim_user *acct )
-{
-        struct gaim_connection *gc = new_gaim_conn( acct );
+static char *msn_set_display_name( set_t *set, char *value );
+
+static void msn_acc_init( account_t *acc )
+{
+        set_t *s;
+        
+        s = set_add( &acc->set, "display_name", NULL, msn_set_display_name, acc );
+        s->flags |= ACC_SET_NOSAVE | ACC_SET_ONLINE_ONLY;
+}
+
+static void msn_login( account_t *acc )
+{
+        struct gaim_connection *gc = new_gaim_conn( acc );
         struct msn_data *md = g_new0( struct msn_data, 1 );
         
@@ -37 +47 @@
         md->fd = -1;
         
-        if( strchr( acct->username, '@' ) == NULL )
+        if( strchr( acc->user, '@' ) == NULL )
         {
                 hide_login_progress( gc, "Invalid account name" );
@@ -212 +222 @@
 static void msn_set_info( struct gaim_connection *gc, char *info )
 {
-        char buf[1024], *fn;
-        struct msn_data *md = gc->proto_data;
-        
-        if( strlen( info ) > 129 )
-        {
-                do_error_dialog( gc, "Maximum name length exceeded", "MSN" );
-                return;
-        }
-        
-        fn = msn_http_encode( info );
-        
-        g_snprintf( buf, sizeof( buf ), "REA %d %s %s\r\n", ++md->trId, gc->username, fn );
-        msn_write( gc, buf, strlen( buf ) );
-        g_free( fn );
+        msn_set_display_name( set_find( &gc->acc->set, "display_name" ), info );
 }
 
@@ -364 +361 @@
 }
 
+static char *msn_set_display_name( set_t *set, char *value )
+{
+        account_t *acc = set->data;
+        struct gaim_connection *gc = acc->gc;
+        struct msn_data *md;
+        char buf[1024], *fn;
+        int i;
+        
+        /* Double-check. */
+        if( gc == NULL )
+                return NULL;
+        
+        md = gc->proto_data;
+        
+        if( strlen( value ) > 129 )
+        {
+                serv_got_crap( gc, "Maximum name length exceeded" );
+                return NULL;
+        }
+        
+        fn = msn_http_encode( value );
+        
+        g_snprintf( buf, sizeof( buf ), "REA %d %s %s\r\n", ++md->trId, gc->username, fn );
+        msn_write( gc, buf, strlen( buf ) );
+        g_free( fn );
+        
+        /* Returning NULL would be better, because the server still has to
+           confirm the name change. However, it looks a bit confusing to the
+           user. */
+        return value;
+}
+
 void msn_init()
 {
         struct prpl *ret = g_new0(struct prpl, 1);
+        
         ret->name = "msn";
         ret->login = msn_login;
+        ret->acc_init = msn_acc_init;
         ret->close = msn_close;
         ret->send_im = msn_send_im;
@@ -388 +419 @@
         ret->rem_deny = msn_rem_deny;
         ret->send_typing = msn_send_typing;
-        ret->cmp_buddynames = g_strcasecmp;
+        ret->handle_cmp = g_strcasecmp;
 
         register_protocol(ret);

protocols/msn/ns.c

@@ -223 +223 @@
                 else if( num_parts == 7 && strcmp( cmd[2], "OK" ) == 0 )
                 {
+                        set_t *s;
+                        
                         http_decode( cmd[4] );
                         
                         strncpy( gc->displayname, cmd[4], sizeof( gc->displayname ) );
                         gc->displayname[sizeof(gc->displayname)-1] = 0;
+                        
+                        if( ( s = set_find( &gc->acc->set, "display_name" ) ) )
+                        {
+                                g_free( s->value );
+                                s->value = g_strdup( cmd[4] );
+                        }
                         
                         set_login_progress( gc, 1, "Authenticated, getting buddy list" );
@@ -517 +525 @@
                 if( g_strcasecmp( cmd[3], gc->username ) == 0 )
                 {
+                        set_t *s;
+                        
                         http_decode( cmd[4] );
                         strncpy( gc->displayname, cmd[4], sizeof( gc->displayname ) );
                         gc->displayname[sizeof(gc->displayname)-1] = 0;
+                        
+                        if( ( s = set_find( &gc->acc->set, "display_name" ) ) )
+                        {
+                                g_free( s->value );
+                                s->value = g_strdup( cmd[4] );
+                        }
                 }
                 else

protocols/nogaim.c

@@ -145 +145 @@
 /* multi.c */
 
-struct gaim_connection *new_gaim_conn( struct aim_user *user )
+struct gaim_connection *new_gaim_conn( account_t *acc )
 {
         struct gaim_connection *gc;
-        account_t *a;
         
         gc = g_new0( struct gaim_connection, 1 );
         
-        gc->prpl = user->prpl;
-        g_snprintf( gc->username, sizeof( gc->username ), "%s", user->username );
-        g_snprintf( gc->password, sizeof( gc->password ), "%s", user->password );
-        /* [MD] BUGFIX: don't set gc->irc to the global IRC, but use the one from the struct aim_user.
-         * This fixes daemon mode breakage where IRC doesn't point to the currently active connection.
-         */
-        gc->irc = user->irc;
+        /* Maybe we should get rid of this memory waste later. ;-) */
+        g_snprintf( gc->username, sizeof( gc->username ), "%s", acc->user );
+        g_snprintf( gc->password, sizeof( gc->password ), "%s", acc->pass );
+        
+        gc->irc = acc->irc;
+        gc->acc = acc;
+        acc->gc = gc;
         
         connections = g_slist_append( connections, gc );
-        
-        user->gc = gc;
-        gc->user = user;
-        
-        // Find the account_t so we can set its gc pointer
-        for( a = gc->irc->accounts; a; a = a->next )
-                if( ( struct aim_user * ) a->gc == user )
-                {
-                        a->gc = gc;
-                        break;
-                }
         
         return( gc );
@@ -189 +177 @@
         
         connections = g_slist_remove( connections, gc );
-        g_free( gc->user );
         g_free( gc );
 }
@@ -220 +207 @@
         va_end( params );
 
-        if( ( g_strcasecmp( set_getstr( gc->irc, "strip_html" ), "always" ) == 0 ) ||
-            ( ( gc->flags & OPT_CONN_HTML ) && set_getint( gc->irc, "strip_html" ) ) )
+        if( ( g_strcasecmp( set_getstr( &gc->irc->set, "strip_html" ), "always" ) == 0 ) ||
+            ( ( gc->flags & OPT_CONN_HTML ) && set_getbool( &gc->irc->set, "strip_html" ) ) )
                 strip_html( text );
         
         /* Try to find a different connection on the same protocol. */
         for( a = gc->irc->accounts; a; a = a->next )
-                if( a->prpl == gc->prpl && a->gc != gc )
+                if( a->prpl == gc->acc->prpl && a->gc != gc )
                         break;
         
         /* If we found one, include the screenname in the message. */
         if( a )
-                irc_usermsg( gc->irc, "%s(%s) - %s", gc->prpl->name, gc->username, text );
+                irc_usermsg( gc->irc, "%s(%s) - %s", gc->acc->prpl->name, gc->username, text );
         else
-                irc_usermsg( gc->irc, "%s - %s", gc->prpl->name, text );
+                irc_usermsg( gc->irc, "%s - %s", gc->acc->prpl->name, text );
         
         g_free( text );
@@ -242 +229 @@
         struct gaim_connection *gc = d;
         
-        if( gc->prpl && gc->prpl->keepalive )
-                gc->prpl->keepalive( gc );
+        if( gc->acc->prpl->keepalive )
+                gc->acc->prpl->keepalive( gc );
         
         return TRUE;
@@ -297 +284 @@
         b_event_remove( gc->keepalive );
         gc->flags |= OPT_LOGGING_OUT;
+        
         gc->keepalive = 0;
-        gc->prpl->close( gc );
+        gc->acc->prpl->close( gc );
         b_event_remove( gc->inpa );
         
@@ -323 +311 @@
                 /* Uhm... This is very sick. */
         }
-        else if( !gc->wants_to_die && set_getint( irc, "auto_reconnect" ) )
-        {
-                int delay = set_getint( irc, "auto_reconnect_delay" );
+        else if( !gc->wants_to_die && set_getbool( &irc->set, "auto_reconnect" ) &&
+                 set_getbool( &a->set, "auto_reconnect" ) )
+        {
+                int delay = set_getint( &irc->set, "auto_reconnect_delay" );
                 
                 serv_got_crap( gc, "Reconnecting in %d seconds..", delay );
@@ -364 +353 @@
         irc_t *irc = gc->irc;
         
-        if( set_getint( irc, "debug" ) && 0 ) /* This message is too useless */
+        if( set_getbool( &irc->set, "debug" ) && 0 ) /* This message is too useless */
                 serv_got_crap( gc, "Receiving user add from handle: %s", handle );
         
         if( user_findhandle( gc, handle ) )
         {
-                if( set_getint( irc, "debug" ) )
+                if( set_getbool( &irc->set, "debug" ) )
                         serv_got_crap( gc, "User already exists, ignoring add request: %s", handle );
                 
@@ -378 +367 @@
         
         memset( nick, 0, MAX_NICK_LENGTH + 1 );
-        strcpy( nick, nick_get( gc->irc, handle, gc->prpl, realname ) );
+        strcpy( nick, nick_get( gc->acc, handle, realname ) );
         
         u = user_add( gc->irc, nick );
@@ -390 +379 @@
                 u->user = g_strndup( handle, s - handle );
         }
-        else if( gc->user->proto_opt[0] && *gc->user->proto_opt[0] )
+        else if( gc->acc->server )
         {
                 char *colon;
                 
-                if( ( colon = strchr( gc->user->proto_opt[0], ':' ) ) )
-                        u->host = g_strndup( gc->user->proto_opt[0],
-                                             colon - gc->user->proto_opt[0] );
+                if( ( colon = strchr( gc->acc->server, ':' ) ) )
+                        u->host = g_strndup( gc->acc->server,
+                                             colon - gc->acc->server );
                 else
-                        u->host = g_strdup( gc->user->proto_opt[0] );
+                        u->host = g_strdup( gc->acc->server );
                 
                 u->user = g_strdup( handle );
@@ -409 +398 @@
         else
         {
-                u->host = g_strdup( gc->user->prpl->name );
+                u->host = g_strdup( gc->acc->prpl->name );
                 u->user = g_strdup( handle );
         }
@@ -457 +446 @@
                 u->realname = g_strdup( realname );
                 
-                if( ( gc->flags & OPT_LOGGED_IN ) && set_getint( gc->irc, "display_namechanges" ) )
+                if( ( gc->flags & OPT_LOGGED_IN ) && set_getbool( &gc->irc->set, "display_namechanges" ) )
                         serv_got_crap( gc, "User `%s' changed name to `%s'", u->nick, u->realname );
         }
@@ -479 +468 @@
 void show_got_added_yes( gpointer w, struct show_got_added_data *data )
 {
-        data->gc->prpl->add_buddy( data->gc, data->handle );
+        data->gc->acc->prpl->add_buddy( data->gc, data->handle );
         add_buddy( data->gc, NULL, data->handle, data->handle );
         
@@ -513 +502 @@
         if( !u )
         {
-                if( g_strcasecmp( set_getstr( gc->irc, "handle_unknown" ), "add" ) == 0 )
+                if( g_strcasecmp( set_getstr( &gc->irc->set, "handle_unknown" ), "add" ) == 0 )
                 {
                         add_buddy( gc, NULL, handle, NULL );
@@ -520 +509 @@
                 else
                 {
-                        if( set_getint( gc->irc, "debug" ) || g_strcasecmp( set_getstr( gc->irc, "handle_unknown" ), "ignore" ) != 0 )
+                        if( set_getbool( &gc->irc->set, "debug" ) || g_strcasecmp( set_getstr( &gc->irc->set, "handle_unknown" ), "ignore" ) != 0 )
                         {
                                 serv_got_crap( gc, "serv_got_update() for handle %s:", handle );
@@ -558 +547 @@
         }
         
-        if( ( type & UC_UNAVAILABLE ) && ( !strcmp(gc->prpl->name, "oscar") || !strcmp(gc->prpl->name, "icq")) )
+        if( ( type & UC_UNAVAILABLE ) && ( strcmp( gc->acc->prpl->name, "oscar" ) == 0 || strcmp( gc->acc->prpl->name, "icq" ) == 0 ) )
         {
                 u->away = g_strdup( "Away" );
         }
-        else if( ( type & UC_UNAVAILABLE ) && ( !strcmp(gc->prpl->name, "jabber") ) )
+        else if( ( type & UC_UNAVAILABLE ) && ( strcmp( gc->acc->prpl->name, "jabber" ) == 0 ) )
         {
                 if( type & UC_DND )
@@ -571 +560 @@
                         u->away = g_strdup( "Away" );
         }
-        else if( ( type & UC_UNAVAILABLE ) && gc->prpl->get_status_string )
-        {
-                u->away = g_strdup( gc->prpl->get_status_string( gc, type ) );
+        else if( ( type & UC_UNAVAILABLE ) && gc->acc->prpl->get_status_string )
+        {
+                u->away = g_strdup( gc->acc->prpl->get_status_string( gc, type ) );
         }
         else
@@ -579 +568 @@
         
         /* LISPy... */
-        if( ( set_getint( gc->irc, "away_devoice" ) ) &&                /* Don't do a thing when user doesn't want it */
+        if( ( set_getbool( &gc->irc->set, "away_devoice" ) ) &&         /* Don't do a thing when user doesn't want it */
             ( u->online ) &&                                            /* Don't touch offline people */
             ( ( ( u->online != oo ) && !u->away ) ||                    /* Voice joining people */
@@ -598 +587 @@
         if( !u )
         {
-                char *h = set_getstr( irc, "handle_unknown" );
+                char *h = set_getstr( &irc->set, "handle_unknown" );
                 
                 if( g_strcasecmp( h, "ignore" ) == 0 )
                 {
-                        if( set_getint( irc, "debug" ) )
+                        if( set_getbool( &irc->set, "debug" ) )
                                 serv_got_crap( gc, "Ignoring message from unknown handle %s", handle );
                         
@@ -609 +598 @@
                 else if( g_strncasecmp( h, "add", 3 ) == 0 )
                 {
-                        int private = set_getint( irc, "private" );
+                        int private = set_getbool( &irc->set, "private" );
                         
                         if( h[3] )
@@ -630 +619 @@
         }
         
-        if( ( g_strcasecmp( set_getstr( gc->irc, "strip_html" ), "always" ) == 0 ) ||
-            ( ( gc->flags & OPT_CONN_HTML ) && set_getint( gc->irc, "strip_html" ) ) )
+        if( ( g_strcasecmp( set_getstr( &gc->irc->set, "strip_html" ), "always" ) == 0 ) ||
+            ( ( gc->flags & OPT_CONN_HTML ) && set_getbool( &gc->irc->set, "strip_html" ) ) )
                 strip_html( msg );
 
@@ -671 +660 @@
         user_t *u;
         
-        if( !set_getint( gc->irc, "typing_notice" ) )
+        if( !set_getbool( &gc->irc->set, "typing_notice" ) )
                 return;
         
@@ -693 +682 @@
         GList *ir;
         
-        if( set_getint( gc->irc, "debug" ) )
+        if( set_getbool( &gc->irc->set, "debug" ) )
                 serv_got_crap( gc, "You were removed from conversation %d", (int) id );
         
@@ -732 +721 @@
         
         /* Gaim sends own messages through this too. IRC doesn't want this, so kill them */
-        if( g_strcasecmp( who, gc->user->username ) == 0 )
+        if( g_strcasecmp( who, gc->username ) == 0 )
                 return;
         
@@ -738 +727 @@
         for( c = gc->conversations; c && c->id != id; c = c->next );
         
-        if( ( g_strcasecmp( set_getstr( gc->irc, "strip_html" ), "always" ) == 0 ) ||
-            ( ( gc->flags & OPT_CONN_HTML ) && set_getint( gc->irc, "strip_html" ) ) )
+        if( ( g_strcasecmp( set_getstr( &gc->irc->set, "strip_html" ), "always" ) == 0 ) ||
+            ( ( gc->flags & OPT_CONN_HTML ) && set_getbool( &gc->irc->set, "strip_html" ) ) )
                 strip_html( msg );
         
@@ -772 +761 @@
         g_free( s );
         
-        if( set_getint( gc->irc, "debug" ) )
+        if( set_getbool( &gc->irc->set, "debug" ) )
                 serv_got_crap( gc, "Creating new conversation: (id=%d,handle=%s)", id, handle );
         
@@ -786 +775 @@
         int me = 0;
         
-        if( set_getint( b->gc->irc, "debug" ) )
+        if( set_getbool( &b->gc->irc->set, "debug" ) )
                 serv_got_crap( b->gc, "User %s added to conversation %d", handle, b->id );
         
         /* It might be yourself! */
-        if( b->gc->prpl->cmp_buddynames( handle, b->gc->user->username ) == 0 )
+        if( b->gc->acc->prpl->handle_cmp( handle, b->gc->username ) == 0 )
         {
                 u = user_find( b->gc->irc, b->gc->irc->nick );
@@ -820 +809 @@
         int me = 0;
         
-        if( set_getint( b->gc->irc, "debug" ) )
+        if( set_getbool( &b->gc->irc->set, "debug" ) )
                 serv_got_crap( b->gc, "User %s removed from conversation %d (%s)", handle, b->id, reason ? reason : "" );
         
         /* It might be yourself! */
-        if( g_strcasecmp( handle, b->gc->user->username ) == 0 )
+        if( g_strcasecmp( handle, b->gc->username ) == 0 )
         {
                 u = user_find( b->gc->irc, b->gc->irc->nick );
@@ -882 +871 @@
 }
 
-char *set_eval_away_devoice( irc_t *irc, set_t *set, char *value )
-{
+char *set_eval_away_devoice( set_t *set, char *value )
+{
+        irc_t *irc = set->data;
         int st;
         
@@ -897 +887 @@
         /* Horror.... */
         
-        if( st != set_getint( irc, "away_devoice" ) )
+        if( st != set_getbool( &irc->set, "away_devoice" ) )
         {
                 char list[80] = "";
@@ -937 +927 @@
         }
         
-        return( set_eval_bool( irc, set, value ) );
+        return( set_eval_bool( set, value ) );
 }
 
@@ -957 +947 @@
         }
         
-        st = gc->prpl->send_im( gc, handle, msg, strlen( msg ), flags );
+        st = gc->acc->prpl->send_im( gc, handle, msg, strlen( msg ), flags );
         g_free( buf );
         
@@ -974 +964 @@
         }
         
-        st = gc->prpl->chat_send( gc, id, msg );
+        st = gc->acc->prpl->chat_send( gc, id, msg );
         g_free( buf );
         
@@ -988 +978 @@
         
         if( !away ) away = "";
-        ms = m = gc->prpl->away_states( gc );
+        ms = m = gc->acc->prpl->away_states( gc );
         
         while( m )
@@ -1009 +999 @@
         if( m )
         {
-                gc->prpl->set_away( gc, m->data, *away ? away : NULL );
+                gc->acc->prpl->set_away( gc, m->data, *away ? away : NULL );
         }
         else
@@ -1016 +1006 @@
                 if( s )
                 {
-                        gc->prpl->set_away( gc, s, away );
-                        if( set_getint( gc->irc, "debug" ) )
+                        gc->acc->prpl->set_away( gc, s, away );
+                        if( set_getbool( &gc->irc->set, "debug" ) )
                                 serv_got_crap( gc, "Setting away state to %s", s );
                 }
                 else
-                        gc->prpl->set_away( gc, GAIM_AWAY_CUSTOM, away );
+                        gc->acc->prpl->set_away( gc, GAIM_AWAY_CUSTOM, away );
         }
         
@@ -1073 +1063 @@
 void bim_add_allow( struct gaim_connection *gc, char *handle )
 {
-        if( g_slist_find_custom( gc->permit, handle, (GCompareFunc) gc->prpl->cmp_buddynames ) == NULL )
+        if( g_slist_find_custom( gc->permit, handle, (GCompareFunc) gc->acc->prpl->handle_cmp ) == NULL )
         {
                 gc->permit = g_slist_prepend( gc->permit, g_strdup( handle ) );
         }
         
-        gc->prpl->add_permit( gc, handle );
+        gc->acc->prpl->add_permit( gc, handle );
 }
 
@@ -1085 +1075 @@
         GSList *l;
         
-        if( ( l = g_slist_find_custom( gc->permit, handle, (GCompareFunc) gc->prpl->cmp_buddynames ) ) )
+        if( ( l = g_slist_find_custom( gc->permit, handle, (GCompareFunc) gc->acc->prpl->handle_cmp ) ) )
         {
                 g_free( l->data );
@@ -1091 +1081 @@
         }
         
-        gc->prpl->rem_permit( gc, handle );
+        gc->acc->prpl->rem_permit( gc, handle );
 }
 
 void bim_add_block( struct gaim_connection *gc, char *handle )
 {
-        if( g_slist_find_custom( gc->deny, handle, (GCompareFunc) gc->prpl->cmp_buddynames ) == NULL )
+        if( g_slist_find_custom( gc->deny, handle, (GCompareFunc) gc->acc->prpl->handle_cmp ) == NULL )
         {
                 gc->deny = g_slist_prepend( gc->deny, g_strdup( handle ) );
         }
         
-        gc->prpl->add_deny( gc, handle );
+        gc->acc->prpl->add_deny( gc, handle );
 }
 
@@ -1108 +1098 @@
         GSList *l;
         
-        if( ( l = g_slist_find_custom( gc->deny, handle, (GCompareFunc) gc->prpl->cmp_buddynames ) ) )
+        if( ( l = g_slist_find_custom( gc->deny, handle, (GCompareFunc) gc->acc->prpl->handle_cmp ) ) )
         {
                 g_free( l->data );
@@ -1114 +1104 @@
         }
         
-        gc->prpl->rem_deny( gc, handle );
-}
+        gc->acc->prpl->rem_deny( gc, handle );
+}

protocols/nogaim.h

@@ -39 +39 @@
 
 #include "bitlbee.h"
+#include "account.h"
 #include "proxy.h"
 #include "md5.h"
@@ -63 +64 @@
 struct gaim_connection
 {
-        struct prpl *prpl;
+        account_t *acc;
         guint32 flags;
         
@@ -78 +79 @@
         GSList *deny;
         int permdeny;
-        
-        struct aim_user *user;
         
         char username[64];
@@ -126 +125 @@
 };
 
-struct aim_user {
-        char username[64];
-        char alias[SELF_ALIAS_LEN]; 
-        char password[32];
-        char user_info[2048];
-        int options;
-        struct prpl *prpl;
-        /* prpls can use this to save information about the user,
-         * like which server to connect to, etc */
-        char proto_opt[7][256];
-
-        struct gaim_connection *gc;
-        irc_t *irc;
-};
-
 struct prpl {
         int options;
         const char *name;
 
-        void (* login)          (struct aim_user *);
+        void (* acc_init)       (account_t *);
+        void (* login)          (account_t *);
         void (* keepalive)      (struct gaim_connection *);
         void (* close)          (struct gaim_connection *);
@@ -180 +165 @@
         
         /* Mainly for AOL, since they think "Bung hole" == "Bu ngho le". *sigh* */
-        int (* cmp_buddynames) (const char *who1, const char *who2);
+        int (* handle_cmp) (const char *who1, const char *who2);
 };
 
@@ -206 +191 @@
 
 void nogaim_init();
-char *set_eval_away_devoice( irc_t *irc, set_t *set, char *value );
+char *set_eval_away_devoice( set_t *set, char *value );
 
 gboolean auto_reconnect( gpointer data, gint fd, b_input_condition cond );
@@ -212 +197 @@
 
 /* multi.c */
-G_MODULE_EXPORT struct gaim_connection *new_gaim_conn( struct aim_user *user );
+G_MODULE_EXPORT struct gaim_connection *new_gaim_conn( account_t *acc );
 G_MODULE_EXPORT void destroy_gaim_conn( struct gaim_connection *gc );
 G_MODULE_EXPORT void set_login_progress( struct gaim_connection *gc, int step, char *msg );

protocols/oscar/oscar.c

@@ -356 +356 @@
 }
 
-static void oscar_login(struct aim_user *user) {
+static void oscar_acc_init(account_t *acc)
+{
+        set_t *s;
+        
+        s = set_add( &acc->set, "server", NULL, set_eval_account, acc );
+        s->flags |= ACC_SET_NOSAVE | ACC_SET_OFFLINE_ONLY;
+        
+        if (isdigit(acc->user[0])) {
+                s = set_add( &acc->set, "web_aware", "false", set_eval_bool, acc );
+                s->flags |= ACC_SET_OFFLINE_ONLY;
+        }
+}
+
+static void oscar_login(account_t *acc) {
         aim_session_t *sess;
         aim_conn_t *conn;
         char buf[256];
-        struct gaim_connection *gc = new_gaim_conn(user);
+        struct gaim_connection *gc = new_gaim_conn(acc);
         struct oscar_data *odata = gc->proto_data = g_new0(struct oscar_data, 1);
 
-        if (isdigit(*user->username)) {
+        if (isdigit(acc->user[0])) {
                 odata->icq = TRUE;
                 /* This is odd but it's necessary for a proper do_import and do_export.
                    We don't do those anymore, but let's stick with it, just in case
-                   it accidentally fixes something else too... */
+                   it accidentally fixes something else too... </bitlbee> */
                 gc->password[8] = 0;
         } else {
@@ -390 +403 @@
         }
         
-        if (g_strcasecmp(user->proto_opt[USEROPT_AUTH], "login.icq.com") != 0 &&
-            g_strcasecmp(user->proto_opt[USEROPT_AUTH], "login.oscar.aol.com") != 0) {
-                serv_got_crap(gc, "Warning: Unknown OSCAR server: `%s'. Please review your configuration if the connection fails.",user->proto_opt[USEROPT_AUTH]);
+        if (acc->server == NULL) {
+                hide_login_progress(gc, "No servername specified");
+                signoff(gc);
+                return;
+        }
+        
+        if (g_strcasecmp(acc->server, "login.icq.com") != 0 &&
+            g_strcasecmp(acc->server, "login.oscar.aol.com") != 0) {
+                serv_got_crap(gc, "Warning: Unknown OSCAR server: `%s'. Please review your configuration if the connection fails.",acc->server);
         }
         
@@ -402 +421 @@
 
         conn->status |= AIM_CONN_STATUS_INPROGRESS;
-        conn->fd = proxy_connect(user->proto_opt[USEROPT_AUTH][0] ?
-                                        user->proto_opt[USEROPT_AUTH] : AIM_DEFAULT_LOGIN_SERVER,
-                                 user->proto_opt[USEROPT_AUTHPORT][0] ?
-                                        atoi(user->proto_opt[USEROPT_AUTHPORT]) : AIM_LOGIN_PORT,
-                                 oscar_login_connect, gc);
+        conn->fd = proxy_connect(acc->server, AIM_LOGIN_PORT, oscar_login_connect, gc);
         if (conn->fd < 0) {
                 hide_login_progress(gc, _("Couldn't connect to host"));
@@ -485 +500 @@
         struct aim_authresp_info *info;
         int i; char *host; int port;
-        struct aim_user *user;
         aim_conn_t *bosconn;
 
         struct gaim_connection *gc = sess->aux_data;
         struct oscar_data *od = gc->proto_data;
-        user = gc->user;
-        port = user->proto_opt[USEROPT_AUTHPORT][0] ?
-                atoi(user->proto_opt[USEROPT_AUTHPORT]) : AIM_LOGIN_PORT,
+        port = AIM_LOGIN_PORT;
 
         va_start(ap, fr);
@@ -871 +883 @@
         struct aim_redirect_data *redir;
         struct gaim_connection *gc = sess->aux_data;
-        struct aim_user *user = gc->user;
         aim_conn_t *tstconn;
         int i;
@@ -877 +888 @@
         int port;
 
-        port = user->proto_opt[USEROPT_AUTHPORT][0] ?
-                atoi(user->proto_opt[USEROPT_AUTHPORT]) : AIM_LOGIN_PORT,
-
         va_start(ap, fr);
         redir = va_arg(ap, struct aim_redirect_data *);
         va_end(ap);
 
+        port = AIM_LOGIN_PORT;
         for (i = 0; i < (int)strlen(redir->ip); i++) {
                 if (redir->ip[i] == ':') {
@@ -1242 +1251 @@
         channel = va_arg(ap, int);
         userinfo = va_arg(ap, aim_userinfo_t *);
-
-    if (set_getint(sess->aux_data, "debug")) {
-        serv_got_crap(sess->aux_data, "channel %i called", channel);
-    }
 
         switch (channel) {
@@ -1723 +1728 @@
         odata->rights.maxsiglen = odata->rights.maxawaymsglen = (guint)maxsiglen;
 
+        /* FIXME: It seems we're not really using this, and it broke now that
+           struct aim_user is dead.
         aim_bos_setprofile(sess, fr->conn, gc->user->user_info, NULL, gaim_caps);
-
+        */
+        
         return 1;
 }
@@ -2656 +2664 @@
         ret->away_states = oscar_away_states;
         ret->login = oscar_login;
+        ret->acc_init = oscar_acc_init;
         ret->close = oscar_close;
         ret->send_im = oscar_send_im;
@@ -2673 +2682 @@
         ret->set_permit_deny = oscar_set_permit_deny;
         ret->keepalive = oscar_keepalive;
-        ret->cmp_buddynames = aim_sncmp;
         ret->get_status_string = oscar_get_status_string;
         ret->send_typing = oscar_send_typing;
+        
+        ret->handle_cmp = aim_sncmp;
 
         register_protocol(ret);

protocols/oscar/rxhandlers.c

@@ -112 +112 @@
                 /* Following SNAC will be related */
         }
-
-    if (set_getint(sess->aux_data, "debug")) {
-        serv_got_crap(sess->aux_data, "snac %x/%x received", snac.family, snac.subtype);
-    }
 
         for (cur = (aim_module_t *)sess->modlistv; cur; cur = cur->next) {

protocols/oscar/service.c

@@ -732 +732 @@
         guint32 data;
         int tlvlen;
+        struct gaim_connection *gc = sess ? sess->aux_data : NULL;
 
         data = AIM_ICQ_STATE_HIDEIP | status; /* yay for error checking ;^) */
+        
+        if (gc && set_getbool(&gc->acc->set, "web_aware"))
+                data |= AIM_ICQ_STATE_WEBAWARE;
 
         tlvlen = aim_addtlvtochain32(&tl, 0x0006, data);

protocols/yahoo/libyahoo2.c

@@ -89 +89 @@
 #define vsnprintf _vsnprintf
 #endif
+
+#include "base64.h"
 
 #ifdef USE_STRUCT_CALLBACKS
@@ -695 +697 @@
 }
 
-static char base64digits[] =    "ABCDEFGHIJKLMNOPQRSTUVWXYZ"
-                                "abcdefghijklmnopqrstuvwxyz"
-                                "0123456789._";
+/* raw bytes in quasi-big-endian order to base 64 string (NUL-terminated) */
 static void to_y64(unsigned char *out, const unsigned char *in, int inlen)
-/* raw bytes in quasi-big-endian order to base 64 string (NUL-terminated) */
-{
-        for (; inlen >= 3; inlen -= 3)
-                {
-                        *out++ = base64digits[in[0] >> 2];
-                        *out++ = base64digits[((in[0]<<4) & 0x30) | (in[1]>>4)];
-                        *out++ = base64digits[((in[1]<<2) & 0x3c) | (in[2]>>6)];
-                        *out++ = base64digits[in[2] & 0x3f];
-                        in += 3;
-                }
-        if (inlen > 0)
-                {
-                        unsigned char fragment;
-
-                        *out++ = base64digits[in[0] >> 2];
-                        fragment = (in[0] << 4) & 0x30;
-                        if (inlen > 1)
-                                fragment |= in[1] >> 4;
-                        *out++ = base64digits[fragment];
-                        *out++ = (inlen < 2) ? '-' 
-                                        : base64digits[(in[1] << 2) & 0x3c];
-                        *out++ = '-';
-                }
-        *out = '\0';
+{
+        base64_encode_real(in, inlen, out, "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789._-");
 }
 

protocols/yahoo/yahoo.c

@@ -121 +121 @@
 }
 
-static void byahoo_login( struct aim_user *user )
-{
-        struct gaim_connection *gc = new_gaim_conn( user );
+static void byahoo_login( account_t *acc )
+{
+        struct gaim_connection *gc = new_gaim_conn( acc );
         struct byahoo_data *yd = gc->proto_data = g_new0( struct byahoo_data, 1 );
         
@@ -130 +130 @@
         
         set_login_progress( gc, 1, "Connecting" );
-        yd->y2_id = yahoo_init( user->username, user->password );
+        yd->y2_id = yahoo_init( acc->user, acc->pass );
         yahoo_login( yd->y2_id, yd->current_status );
 }
@@ -411 +411 @@
         ret->chat_leave = byahoo_chat_leave;
         ret->chat_open = byahoo_chat_open;
-        ret->cmp_buddynames = g_strcasecmp;
+
+        ret->handle_cmp = g_strcasecmp;
         
         register_protocol(ret);
@@ -427 +428 @@
                 yd = gc->proto_data;
                 
-                if( !strcmp(gc->prpl->name, "yahoo") && yd->y2_id == id )
+                if( strcmp( gc->acc->prpl->name, "yahoo" ) == 0 && yd->y2_id == id )
                         return( gc );
         }