Changeset 695e392

Timestamp:

2006-10-13T21:44:54Z (18 years ago)

Author:

Wilmer van der Gaast <wilmer@…>

Branches:

master

Children:

69cb623, e97827b

Parents:

54794b8

Message:

Fixed some memory leaking in the MSN Passport code.

File:

• protocols/msn/passport.c (modified) (3 diffs)

protocols/msn/passport.c

@@ -59 +59 @@
         rep->data = data;
         rep->func = func;
+        rep->header = header;
         
         server = g_strdup( prd_cached );
@@ -125 +126 @@
 static char *passport_create_header( char *cookie, char *email, char *pwd )
 {
-        char *buffer = g_new0( char, 2048 );
+        char *buffer;
         char *currenttoken;
         char *email_enc, *pwd_enc;
+        
+        currenttoken = strstr( cookie, "lc=" );
+        if( currenttoken == NULL )
+                return NULL;
         
         email_enc = g_new0( char, strlen( email ) * 3 + 1 );
@@ -137 +142 @@
         http_encode( pwd_enc );
         
-        currenttoken = strstr( cookie, "lc=" );
-        if( currenttoken == NULL )
-                return( NULL );
-        
-        g_snprintf( buffer, 2048,
-                    "Authorization: Passport1.4 OrgVerb=GET,"
-                    "OrgURL=http%%3A%%2F%%2Fmessenger%%2Emsn%%2Ecom,"
-                    "sign-in=%s,pwd=%s,%s", email_enc, pwd_enc,
-                    currenttoken );
+        buffer = g_strdup_printf( "Authorization: Passport1.4 OrgVerb=GET,"
+                                  "OrgURL=http%%3A%%2F%%2Fmessenger%%2Emsn%%2Ecom,"
+                                  "sign-in=%s,pwd=%s,%s", email_enc, pwd_enc,
+                                  currenttoken );
         
         g_free( email_enc );
         g_free( pwd_enc );
         
-        return( buffer );
+        return buffer;
 }