Diff [9730d7250bb9e938ca00b72efdd8e8b3c03b2753:6738a676c7a3895988de4bd9eacfe8fa0ef73cc3] for / – BitlBee

.bzrignore

r9730d72	r6738a67
17	17	*.gcno
18	18	*.o
	19	coverage
	20	bitlbee.info
	21	bitlbee.exe

Makefile

-                      r9730d72
+                      r6738a67
 # Program variables
 objects = account.o bitlbee.o conf.o crypting.o help.o ipc.o irc.o irc_commands.o log.o nick.o otr.o query.o root_commands.o set.o storage.o $(STORAGE_OBJS) unix.o user.o
+objects = account.o bitlbee.o crypting.o help.o ipc.o irc.o irc_commands.o nick.o query.o root_commands.o set.o storage.o $(STORAGE_OBJS) user.o
 headers = account.h bitlbee.h commands.h conf.h config.h crypting.h help.h ipc.h irc.h log.h nick.h otr.h query.h set.h sock.h storage.h user.h lib/events.h lib/http_client.h lib/ini.h lib/md5.h lib/misc.h lib/proxy.h lib/sha1.h lib/ssl_client.h lib/url.h protocols/nogaim.h
 subdirs = lib protocols
+ifeq ($(TARGET),i586-mingw32msvc)
+objects += win32.o
+LFLAGS+=-lws2_32
+EFLAGS+=-lsecur32
+OUTFILE=bitlbee.exe
+else
+objects += unix.o conf.o log.o otr.o
+OUTFILE=bitlbee
+endif
 # Expansion of variables

account.c

-                      r9730d72
+                      r6738a67
         account_t *a, *l = NULL;
+        if( acc->ic )
+                /* Caller should have checked, accounts still in use can't be deleted. */
+                return;
         for( a = irc->accounts; a; a = (l=a)->next )
                 if( a == acc )
+                {
-                        if( a->ic ) return; /* Caller should have checked, accounts still in use can't be deleted. */
                         if( l )
+                        {
                                 l->next = a->next;
+                        }
                         else
+                        {
                                 irc->accounts = a->next;
+                        }
                         while( a->set )
 …
                         g_free( a->user );
                         g_free( a->pass );
                         if( a->server ) g_free( a->server );
+                        g_free( a->server );
                         if( a->reconnect )      /* This prevents any reconnect still queued to happen */
                                 cancel_auto_reconnect( a );

bitlbee.c

-                      r9730d72
+                      r6738a67
+        ;
         i = getaddrinfo( global.conf->iface, global.conf->port, &hints, &addrinfo_bind );
+        i = getaddrinfo( global.conf->iface_in, global.conf->port, &hints, &addrinfo_bind );
         if( i )
+        {
                 log_message( LOGLVL_ERROR, "Couldn't parse address `%s': %s",
                                            global.conf->iface, gai_strerror(i) );
+                                           global.conf->iface_in, gai_strerror(i) );
                 return -1;
+        }
 …
         if( global.conf->runmode == RUNMODE_FORKDAEMON )
                 ipc_master_load_state();
+                ipc_master_load_state( getenv( "_BITLBEE_RESTART_STATE" ) );
         if( global.conf->runmode == RUNMODE_DAEMON || global.conf->runmode == RUNMODE_FORKDAEMON )
                 ipc_master_listen_socket();
+#ifndef _WIN32
         if( ( fp = fopen( global.conf->pidfile, "w" ) ) )
+        {
 …
                 log_message( LOGLVL_WARNING, "Warning: Couldn't write PID to `%s'", global.conf->pidfile );
+        }
+#endif
         return( 0 );
 …
         if( !irc_new( 0 ) )
                 return( 1 );
-        log_link( LOGLVL_ERROR, LOGOUTPUT_IRC );
-        log_link( LOGLVL_WARNING, LOGOUTPUT_IRC );
         return( 0 );
 …
         if( st == size )
+        {
-                g_free( irc->sendbuffer );
-                irc->sendbuffer = NULL;
-                irc->w_watch_source_id = 0;
                 if( irc->status & USTATUS_SHUTDOWN )
+                {
                         irc_free( irc );
+                }
+                else
+                {
+                        g_free( irc->sendbuffer );
+                        irc->sendbuffer = NULL;
+                        irc->w_watch_source_id = 0;
+                }
                 return FALSE;
 …
         struct sockaddr_in conn_info;
         int new_socket = accept( global.listen_socket, (struct sockaddr *) &conn_info, &size );
-        pid_t client_pid = 0;
         if( new_socket == -1 )
 …
+        }
+#ifndef _WIN32
         if( global.conf->runmode == RUNMODE_FORKDAEMON )
+        {
+                pid_t client_pid = 0;
                 int fds[2];
 …
+        }
         else
+#endif
+        {
                 log_message( LOGLVL_INFO, "Creating new connection with fd %d.", new_socket );

bitlbee.conf

-                      r9730d72
+                      r6738a67
 ##
 ##  Inetd -- Run from inetd (default)
+##  Daemon -- Run as a stand-alone daemon -- EXPERIMENTAL! BitlBee is not yet
+##    stable enough to serve lots of users from one process. Because of this
+##    and other reasons, the use of daemon-mode is *STRONGLY* discouraged,
+##    don't even *think* of reporting bugs when you use this.
+##  Daemon -- Run as a stand-alone daemon, serving all users from one process.
+##    This saves memory if there are more users, the downside is that when one
+##    user hits a crash-bug, all other users will also lose their connection.
 ##  ForkDaemon -- Run as a stand-alone daemon, but keep all clients in separate
 ##    child processes. This should be pretty safe and reliable to use instead
 …
 # DaemonPort = 6667
+## ClientInterface:
+##
+## If for any reason, you want BitlBee to use a specific address/interface
+## for outgoing traffic (IM connections, HTTP(S), etc.), set it here.
+##
+# ClientInterface = 0.0.0.0
 ## AuthMode
 ##
 …
 ##
 ## Password the user should enter when logging into a closed BitlBee server.
+## You can also have an MD5-encrypted password here. Format: "md5:", followed
+## by a hash as generated for the <user password=""> attribute in a BitlBee
+## XML file (for now there's no easier way to generate the hash).
 ##
 # AuthPassword = ItllBeBitlBee   ## Heh.. Our slogan. ;-)
+## or
+# AuthPassword = md5:gzkK0Ox/1xh+1XTsQjXxBJ571Vgl
 ## OperPassword
 …
 ##
 # OperPassword = ChangeMe!
+## or
+# OperPassword = md5:I0mnZbn1t4R731zzRdDN2/pK7lRX
 ## HostName

bitlbee.h

-                      r9730d72
+                      r6738a67
 #define _GNU_SOURCE /* Stupid GNU :-P */
+/* Depend on Windows 2000 for now since we need getaddrinfo() */
+#define _WIN32_WINNT 0x0501
 #define PACKAGE "BitlBee"
 #define BITLBEE_VERSION "1.1.1dev"
+#define BITLBEE_VERSION "1.2.1"
 #define VERSION BITLBEE_VERSION
 #define MAX_STRING 128
+#define MAX_STRING 511
 #if HAVE_CONFIG_H
 …
 #include <stdio.h>
 #include <ctype.h>
+#include <errno.h>
 #ifndef _WIN32
 #include <syslog.h>
-#include <errno.h>
 #endif
 …
 #undef g_main_quit
 #define g_main_quit             __PLEASE_USE_B_MAIN_QUIT__
-#ifndef F_OK
-#define F_OK 0
-#endif
 #ifndef G_GNUC_MALLOC
 …
 gboolean bitlbee_shutdown( gpointer data, gint fd, b_input_condition cond );
+char *set_eval_root_nick( set_t *set, char *new_nick );
 extern global_t global;

conf.c

-                      r9730d72
+                      r6738a67
         conf = g_new0( conf_t, 1 );
+        conf->iface = NULL;
+        conf->iface_in = NULL;
+        conf->iface_out = NULL;
         conf->port = g_strdup( "6667" );
         conf->nofork = 0;
 …
+        }
         while( argc > 0 && ( opt = getopt( argc, argv, "i:p:P:nvIDFc:d:hR:u:" ) ) >= 0 )
+        while( argc > 0 && ( opt = getopt( argc, argv, "i:p:P:nvIDFc:d:hu:" ) ) >= 0 )
         /*     ^^^^ Just to make sure we skip this step from the REHASH handler. */
+        {
                 if( opt == 'i' )
+                {
                         conf->iface = g_strdup( optarg );
+                        conf->iface_in = g_strdup( optarg );
+                }
                 else if( opt == 'p' )
 …
                                 "\n"
                                 "  -I  Classic/InetD mode. (Default)\n"
                                 "  -D  Daemon mode. (Still EXPERIMENTAL!)\n"
+                                "  -D  Daemon mode. (one process serves all)\n"
                                 "  -F  Forking daemon. (one process per client)\n"
                                 "  -u  Run daemon as specified user.\n"
 …
                         return NULL;
+                }
-                else if( opt == 'R' )
+                {
-                        /* We can't load the statefile yet (and should make very sure we do this
-                           only once), so set the filename here and load the state information
-                           when initializing ForkDaemon. (This option only makes sense in that
-                           mode anyway!) */
-                        ipc_master_set_statefile( optarg );
+                }
                 else if( opt == 'u' )
+                {
 …
                         else if( g_strcasecmp( ini->key, "daemoninterface" ) == 0 )
+                        {
                                 g_free( conf->iface );
                                 conf->iface = g_strdup( ini->value );
+                                g_free( conf->iface_in );
+                                conf->iface_in = g_strdup( ini->value );
+                        }
                         else if( g_strcasecmp( ini->key, "daemonport" ) == 0 )
 …
                                 g_free( conf->port );
                                 conf->port = g_strdup( ini->value );
+                        }
+                        else if( g_strcasecmp( ini->key, "clientinterface" ) == 0 )
+                        {
+                                g_free( conf->iface_out );
+                                conf->iface_out = g_strdup( ini->value );
+                        }
                         else if( g_strcasecmp( ini->key, "authmode" ) == 0 )
 …
+                        {
                                 g_strfreev( conf->migrate_storage );
                                 conf->migrate_storage = g_strsplit( ini->value, " \t,;", -1 );
+                                conf->migrate_storage = g_strsplit_set( ini->value, " \t,;", -1 );
+                        }
                         else if( g_strcasecmp( ini->key, "pinginterval" ) == 0 )

conf.h

r9730d72	r6738a67
32	32	typedef struct conf
33	33	{
34		char *iface;
	34	char iface_in, iface_out;
35	35	char *port;
36	36	int nofork;

configure

-                      r9730d72
+                      r6738a67
 ipcsocket='/var/run/bitlbee.sock'
 pcdir='$prefix/lib/pkgconfig'
+systemlibdirs="/lib /usr/lib /usr/local/lib"
 msn=1
 …
 --ssl=...       SSL library to use (gnutls, nss, openssl, bogus, auto)
                                                         $ssl
+--target=...    Cross compilation target                same as host
 EOF
                 exit;
 …
 PCDIR=$pcdir
+TARGET=$target
 ARCH=$arch
 CPU=$cpu
-OUTFILE=bitlbee
 DESTDIR=
 …
 EOF
+if [ -n "$target" ]; then
+        PKG_CONFIG_LIBDIR=/usr/$target/lib/pkgconfig
+        export PKG_CONFIG_LIBDIR
+        PATH=/usr/$target/bin:$PATH
+        CC=$target-cc
+        LD=$target-ld
+        systemlibdirs="/usr/$target/lib"
+fi
 if [ "$debug" = "1" ]; then
         [ -z "$CFLAGS" ] && CFLAGS=-g
 …
 echo "CC=$CC" >> Makefile.settings;
+if [ -n "$LD" ]; then
+        echo "LD=$LD" >> Makefile.settings;
+elif type ld > /dev/null 2> /dev/null; then
+        echo "LD=ld" >> Makefile.settings;
+else
+        echo 'Cannot find ld, aborting.'
+        exit 1;
+fi
+if [ -z "$LD" ]; then
+        if type ld > /dev/null 2> /dev/null; then
+                LD=ld
+        else
+                echo 'Cannot find ld, aborting.'
+                exit 1;
+        fi
+fi
+echo "LD=$LD" >> Makefile.settings
 if [ -z "$PKG_CONFIG" ]; then
 …
 detect_gnutls()
+{
+        if libgnutls-config --version > /dev/null 2> /dev/null; then
+        if $PKG_CONFIG --exists gnutls; then
+                cat <<EOF>>Makefile.settings
+EFLAGS+=`$PKG_CONFIG --libs gnutls`
+CFLAGS+=`$PKG_CONFIG --cflags gnutls`
+EOF
+                ssl=gnutls
+                ret=1
+        elif libgnutls-config --version > /dev/null 2> /dev/null; then
                 cat <<EOF>>Makefile.settings
 EFLAGS+=`libgnutls-config --libs`
 …
 elif [ "$ssl" = "nss" ]; then
         detect_nss
+elif [ "$ssl" = "sspi" ]; then
+        echo
 elif [ "$ssl" = "openssl" ]; then
         echo
 …
 echo 'SSL_CLIENT=ssl_'$ssl'.o' >> Makefile.settings
 for i in /lib /usr/lib /usr/local/lib; do
+for i in $systemlibdirs; do
         if [ -f $i/libresolv.a ]; then
                 echo '#define HAVE_RESOLV_A' >> config.h
 …
 if [ "$gcov" = "1" ]; then
         echo "CFLAGS+=-ftest-coverage -fprofile-arcs" >> Makefile.settings
         echo "EFLAGS+=-lgcov" >> Makefile.settings
+        echo "CFLAGS+=--coverage" >> Makefile.settings
+        echo "EFLAGS+=--coverage" >> Makefile.settings
 fi
 …
 fi
+otrprefix=""
+for i in / /usr /usr/local; do
+        if [ -f ${i}/lib/libotr.a ]; then
+                otrprefix=${i}
+                break
+        fi
+done
 if [ "$otr" = "auto" ]; then
+        for i in /lib /usr/lib /usr/local/lib; do
+                if [ -f $i/libotr.a ]; then
+                        otr=1
+                        break
+                fi
+        done
+fi
+if [ "$otr" = 0 ]; then
+        if [ -n "$otrprefix" ]; then
+                otr=1
+        else
+                otr=0
+        fi
+fi
+if [ "$otr" = 1 ]; then
+        echo '#define WITH_OTR' >> config.h
+        echo "EFLAGS+=-L${otrprefix}/lib -lotr" >> Makefile.settings
+        echo "CFLAGS+=-I${otrprefix}/include" >> Makefile.settings
+else
         echo '#undef WITH_OTR' >> config.h
-else
-        echo '#define WITH_OTR' >> config.h
-        echo "EFLAGS+=-lotr" >> Makefile.settings
 fi
 …
         echo 'Cygwin is not officially supported.'
 ;;
+Windows )
+;;
 * )
         echo 'We haven'\''t tested BitlBee on many platforms yet, yours is untested. YMMV.'
 …
 esac
+if [ -n "$target" ]; then
+        echo "Cross-compiling for: $target"
+fi
 echo
 echo 'Configuration done:'

debian/README.Debian

-                      r9730d72
+                      r6738a67
                    *** NEWS (Version 1.1 and later) ***
+                   *** NEWS (Version 1.2 and later) ***
 Starting from version 1.1, BitlBee has a forking daemon mode. The Debian
+Starting from version 1.2, BitlBee has a forking daemon mode. The Debian
 package now uses this mode by default, instead of inetd mode. If you don't
 want to use this, you can disable the init scripts (best way to do this is
 …
 should be necessary only once, it won't be touched during upgrades.
+--------------------------------------------------------------------------
+Another important change in BitlBee 1.2 is the file format used for your
+personal settings. Everything's now saved in a single .xml (per account,
+of course) file instead of $nick.accounts and $nick.nicks. One advantage
+of this new format is that the passwords are actually encrypted instead of
+just vaguely obfuscated. BitlBee can still read the old files, and will
+save things in the new format when you save/disconnect. After that, you
+can safely remove the old-style files (this is recommended).
+I tried making this transition (the new file format but especially, in this
+case, the inetd->forkdaemon mode change) as smooth as possible, but I'm
+aware that many BitlBee users will have their own hacks already to run the
+program. I hope the package won't break any of this for anyone. 1.2-2
+should fix at least some of the issues.
+---------------------------------------------------------------------------
 Debconf should have asked you on what port you want BitlBee to run. If it

debian/bitlbee.init

-                      r9730d72
+                      r6738a67
 #! /bin/sh
+### BEGIN INIT INFO
+# Provides:          bitlbee
+# Required-Start:    $remote_fs $syslog
+# Required-Stop:     $remote_fs $syslog
+# Default-Start:     2 3 4 5
+# Default-Stop:      1
+### END INIT INFO
+#
 # Init script for BitlBee Debian package. Based on skeleton init script:
 …
 # Default value
 BITLBEE_PORT=6667
 DAEMON_OPT=-F
+BITLBEE_OPTS=-F
 # Read config file if it is present.
 …
         start-stop-daemon --start --quiet --pidfile $PIDFILE \
+                -c bitlbee -g nogroup \
+                --exec $DAEMON -- -p $BITLBEE_PORT -P $PIDFILE $DAEMON_OPT
+                --exec $DAEMON -- -p $BITLBEE_PORT -P $PIDFILE $BITLBEE_OPTS
+}

debian/changelog

-                      r9730d72
+                      r6738a67
+bitlbee (1.1.1dev-0pre) unstable; urgency=low
+bitlbee (1.2-6) UNRELEASED; urgency=low
+  * Add Homepage and Vcs-Bzr fields.
+ -- Jelmer Vernooij <jelmer@samba.org>  Sun, 11 May 2008 14:18:16 +0200
+bitlbee (1.2-5) unstable; urgency=low
+  * Add myself to uploaders.
+  * Bump standards version to 3.8.0.
+  * Fix FSF address.
+  * Avoid changing uid from init script. (Closes: #474589)
+ -- Jelmer Vernooij <jelmer@samba.org>  Mon, 16 Jun 2008 00:53:20 +0200
+bitlbee (1.2-4) unstable; urgency=low
+  * Fixed init script to use the BITLBEE_OPTS variable, not an undefined
+    DAEMON_OPT. (Closes: #474583)
+  * Added dependency information to the init script. (Closes: #472567)
+  * Added bitlbee-dev package. Patch from RISKO Gergely <risko@debian.org>
+    with some small modifications. (Closes: #473480)
+ -- Wilmer van der Gaast <wilmer@gaast.net>  Wed, 07 May 2008 22:40:40 -0700
+bitlbee (1.2-3) unstable; urgency=low
+  * Removed DEB_BUILD_OPTIONS again (forgot to apply that change to the 1.2
+    branch when I finished 1.0.4-2, things diverged too much anyway.)
+    Closes: #472540.
+ -- Wilmer van der Gaast <wilmer@gaast.net>  Mon, 24 Mar 2008 21:10:14 +0000
+bitlbee (1.2-2) unstable; urgency=low
+  * Fixed some packaging issues reported by IRC and e-mail. (Closes: #472373)
+  * Fixed proxy support. (Closes: #472395)
+  * Added a BitlBee group so only root can edit the configs and BitlBee can
+    just *read* it.
+  * Manually deleting /var/lib/bitlbee/ when purging, deluser doesn't want to
+    do it.
+ -- Wilmer van der Gaast <wilmer@gaast.net>  Mon, 24 Mar 2008 19:48:24 +0000
+bitlbee (1.2-1) unstable; urgency=low
+  * New upstream release. (Closes: #325017, #386914, #437515)
+  * With hopefully completely sane charset handling (Closes: #296145)
   * Switched to the new forking daemon mode. Added /etc/default/bitlbee
     file, an init script. People who want to stick with inetd can do so, see
     the defaults file.
+    (Closes: #460741, #466171, #294585, #345038, #306452, #392682)
   * Got rid of debconf Woody compatibility stuff.
   * No more MPL code in BitlBee, thanks to the Jabber module rewrite!
+ -- Wilmer van der Gaast <wilmer@gaast.net>  Fri, 06 Jul 2007 09:09:36 +0100
+  * Added Italian translation, sorry for taking so long! (Closes: #448238)
+  * Added libevent dependency (more reliable event handling).
+  * Removed GLib 1.x dependency because BitlBee really requires GLib >=2.4.
+ -- Wilmer van der Gaast <wilmer@gaast.net>  Tue, 18 Mar 2008 23:44:19 +0000
+bitlbee (1.0.4-2) unstable; urgency=low
+  * Removed $DEB_BUILD_OPTIONS because apparently buildds fill it with crap.
+    (Closes: #458717)
+ -- Wilmer van der Gaast <wilmer@gaast.net>  Mon, 11 Feb 2008 19:15:33 +0000
+bitlbee (1.0.4-1) unstable; urgency=low
+  * New upstream release.
+  * Changed libnss-dev dependency. (Closes: #370442)
+  * Added build-indep rule to debian/rules. (Closes: #395673)
+ -- Wilmer van der Gaast <wilmer@gaast.net>  Wed, 29 Aug 2007 20:24:28 +0100
 bitlbee (1.0.3-1.3) unstable; urgency=low

debian/conffiles

r9730d72	r6738a67
1	1	/etc/bitlbee/motd.txt
2	2	/etc/bitlbee/bitlbee.conf
	3	/etc/init.d/bitlbee

debian/control

-                      r9730d72
+                      r6738a67
 Priority: optional
 Maintainer: Wilmer van der Gaast <wilmer@gaast.net>
+Standards-Version: 3.5.9
+Build-Depends: libglib2.0-dev | libglib-dev, libgnutls-dev | libnss-dev (>= 1.6), debconf-2.0, po-debconf
+Uploaders: Jelmer Vernooij <jelmer@samba.org>
+Standards-Version: 3.8.0
+Build-Depends: libglib2.0-dev (>= 2.4), libevent-dev, libgnutls-dev | libnss-dev (>= 1.6), debconf-2.0, po-debconf
+Homepage: http://www.bitlbee.org/
+Vcs-Bzr: http://code.bitlbee.org/bitlbee/
+DM-Upload-Allowed: yes
 Package: bitlbee
 …
  This program can be used as an IRC server which forwards everything you
  say to people on other chat networks: Jabber, ICQ, AIM, MSN and Yahoo.
+Package: bitlbee-dev
+Architecture: all
+Depends: bitlbee (= ${binary:Version})
+Description: An IRC to other chat networks gateway
+ This program can be used as an IRC server which forwards everything you
+ say to people on other chat networks: Jabber, ICQ, AIM, MSN and Yahoo.
+ .
+ This package holds development stuff for compiling plug-ins.

debian/copyright

-                      r9730d72
+                      r6738a67
   You should have received a copy of the GNU General Public License with
   the Debian GNU/Linux distribution in file /usr/share/common-licenses/GPL;
   if not, write to the Free Software Foundation, Inc., 59 Temple Place,
   Suite 330, Boston, MA  02111-1307  USA
+  if not, write to the Free Software Foundation, Inc., 51 Franklin St,
+  Fifth Floor, Boston, MA 02110-1301, USA.
 ============================================================================
 …
  Copyright (C) 2000  Free Software Foundation, Inc.
 Temple Place, Suite 330, Boston, MA  02111-1307  USA
+Franklin St, Fifth Floor, Boston, MA 02110-1301, USA.
  Everyone is permitted to copy and distribute verbatim copies
  of this license document, but changing it is not allowed.

debian/postinst

-                      r9730d72
+                      r6738a67
 BITLBEE_DISABLED=0
 BITLBEE_UPGRADE_DONT_RESTART=0
 [ -r /etc/default/bitlbee ] && source /etc/default/bitlbee
+[ -r /etc/default/bitlbee ] && . /etc/default/bitlbee
+if [ "$BITLBEE_DISABLED" = "0" ]; then
+        ## In case it's still there (if we're upgrading right now)
+if [ "$BITLBEE_DISABLED" = "0" ] && type update-inetd > /dev/null 2> /dev/null &&
+   ( expr "$2" : '0\..*' > /dev/null || expr "$2" : '1\.0\..*' > /dev/null ); then
+        ## Make sure the inetd entry is gone (can still be there from a
+        ## previous version.
         update-inetd --remove '.*/usr/sbin/bitlbee'
+        if grep -q /usr/sbin/bitlbee /etc/inetd.conf 2> /dev/null; then
+                # Thanks for breaking update-inetd! (bugs.debian.org/311111)
+                # I hope that it works at least with xinetd, because this
+                # emergency hack doesn't:
+                perl -pi -e 's:^[^#].*/usr/sbin/bitlbee$:## Now using daemon mode\: # $&:' /etc/inetd.conf
+                killall -HUP inetd || true
+        fi
 fi
 …
 fi
 adduser --system --home /var/lib/bitlbee/ --disabled-login --disabled-password bitlbee
+adduser --system --group --disabled-login --disabled-password --home /var/lib/bitlbee/ bitlbee
 chmod 700 /var/lib/bitlbee/
 ## Can't do this in packaging phase: Don't know the UID yet. Access to
+## the file should be limited, now that it stores passwords.
+chmod 600 /etc/bitlbee/bitlbee.conf
+chown bitlbee /etc/bitlbee/bitlbee.conf
+## the file should be limited, now that it stores passwords. Added
+## --group later for a little more security, but have to see if I can
+## apply this change to existing installations on upgrades. Will think
+## about that later.
+if getent group bitlbee > /dev/null; then
+        chmod 640 /etc/bitlbee/bitlbee.conf
+        chown root:bitlbee /etc/bitlbee/bitlbee.conf
+else
+        chmod 600 /etc/bitlbee/bitlbee.conf
+        chown bitlbee /etc/bitlbee/bitlbee.conf
+fi
 if [ -z "$2" ]; then

debian/postrm

-                      r9730d72
+                      r6738a67
 update-rc.d bitlbee remove > /dev/null 2>&1 || true
+deluser --remove-home bitlbee || true
+rm -f /etc/default/bitlbee
+deluser --system --remove-home bitlbee || true
+rm -rf /var/lib/bitlbee ## deluser doesn't seem to do this for homedirs in /var

debian/rules

-                      r9730d72
+                      r6738a67
 DEBUG ?= 0
+ifdef BITLBEE_VERSION
+BITLBEE_FORCE_VERSION=1
+else
 # Want to use the full package version number instead of just the release.
 BITLBEE_VERSION ?= "$(shell dpkg-parsechangelog | grep ^Version: | awk '{print $$2}')"
 export BITLBEE_VERSION
+endif
 build-arch: build-arch-stamp
 build-arch-stamp:
         if [ ! -d debian ]; then exit 1; fi
         ./configure --debug=$(DEBUG) --prefix=/usr --etcdir=/etc/bitlbee $(DEB_BUILD_OPTIONS)
+        [ -d debian ]
+        ./configure --debug=$(DEBUG) --prefix=/usr --etcdir=/etc/bitlbee --events=libevent
         $(MAKE)
 #       $(MAKE) -C doc/ all
 …
 clean:
         if [ "`whoami`" != "root" -o ! -d debian ]; then exit 1; fi
         rm -rf build-arch-stamp debian/bitlbee debian/*.substvars debian/files
         -$(MAKE) distclean
+        [ "`whoami`" = "root" -a -d debian ]
+        rm -rf build-arch-stamp debian/bitlbee debian/*.substvars debian/files debian/bitlbee-dev
+        $(MAKE) distclean
 #       -$(MAKE) -C doc/ clean
 install-arch: build-arch
         if [ "`whoami`" != "root" -o ! -d debian ]; then exit 1; fi
+        [ "`whoami`" = "root" -a -d debian ]
         mkdir -p debian/bitlbee/DEBIAN/
         $(MAKE) install install-etc DESTDIR=`pwd`/debian/bitlbee
 …
         cp doc/user-guide/user-guide.html debian/bitlbee/usr/share/doc/bitlbee/
+install-indep: install-arch
+        [ "`whoami`" = "root" -a -d debian ]
+        mkdir -p debian/bitlbee-dev/DEBIAN/
+        $(MAKE) install-dev DESTDIR=`pwd`/debian/bitlbee-dev
+        mkdir -p debian/bitlbee-dev/usr/share/doc/bitlbee-dev/
 binary-arch: build-arch install-arch
         if [ "`whoami`" != "root" -o ! -d debian ]; then exit 1; fi
+        [ "`whoami`" = "root" -a -d debian ]
         chmod 755 debian/post* debian/pre* debian/config debian/bitlbee.init
 …
                         doc/bitlbee/examples/* man/man8/bitlbee.8 man/man5/bitlbee.conf.5
         chown -R root.root debian/bitlbee/
+        chown -R root:root debian/bitlbee/
         find debian/bitlbee/usr/share/ -type d -exec chmod 755 {} \;
         find debian/bitlbee/usr/share/ -type f -exec chmod 644 {} \;
 …
                 find usr -type f -exec md5sum {} \; > DEBIAN/md5sums
         dpkg-shlibdeps -Tdebian/bitlbee.substvars -dDepends debian/bitlbee/usr/sbin/bitlbee
 ifdef BITLBEE_VERSION
+ifdef BITLBEE_FORCE_VERSION
         dpkg-gencontrol -ldebian/changelog -isp -pbitlbee -Tdebian/bitlbee.substvars -Pdebian/bitlbee -v1:$(BITLBEE_VERSION)-0 -V'debconf-depends=debconf (>= 1.2.0) | debconf-2.0'
 else
 …
         dpkg --build debian/bitlbee ..
+debug-build:
         BITLBEE_VERSION=\"`date +%Y%m%d`-`hostname`-debug\" debian/rules clean binary DEBUG=1
+binary-indep: install-indep
+        [ "`whoami`" = "root" -a -d debian ]
+binary: binary-arch
+        chown -R root.root debian/bitlbee-dev/
+        find debian/bitlbee-dev/usr/share/ -type d -exec chmod 755 {} \;
+        find debian/bitlbee-dev/usr/share/ -type f -exec chmod 644 {} \;
+        cp debian/changelog debian/bitlbee-dev/usr/share/doc/bitlbee-dev/changelog.Debian
+        gzip -9 debian/bitlbee-dev/usr/share/doc/bitlbee-dev/changelog.Debian
+        cp debian/copyright debian/bitlbee-dev/usr/share/doc/bitlbee-dev/copyright
+        cd debian/bitlbee-dev; \
+                find usr -type f -exec md5sum {} \; > DEBIAN/md5sums
+        dpkg-gencontrol -ldebian/changelog -isp -pbitlbee-dev -Pdebian/bitlbee-dev
+        dpkg --build debian/bitlbee-dev ..
+binary: binary-arch binary-indep
 build: build-arch
 install: install-arch
+install: install-arch install-indep
 .PHONY: build-arch build clean binary-arch binary install-arch install
+.PHONY: build-arch build clean binary-arch binary install-arch install binary-indep install-indep

doc/CHANGES

-                      r9730d72
+                      r6738a67
+This ChangeLog mostly lists changes relevant to users. A full log can be
+found in the bzr commit logs, for example you can try:
+http://bugs.bitlbee.org/bitlbee/timeline?daysback=90&changeset=on
+Version 1.2.1:
+- Fixed proxy support.
+- Fixed stalling issues while connecting to Jabber when using the OpenSSL
+  module.
+- Fixed problem with GLib and ForkDaemon where processes didn't die when
+  the client disconnects.
+- Fixed handling of "set charset none". (Which pretty much breaks the account
+  completely in 1.2.)
+- You can now automatically identify yourself to BitlBee by setting a server
+  password in your IRC client.
+- Compatible with all crazy kinds of line endings that clients can send.
+- Changed root nicknames are now saved.
+- Added ClientInterface setting to bind() outgoing connections to a specific
+  network interface.
+- Support for receiving Jabber chatroom invitations.
+- Relaxed port restriction of the Jabber module: added ports 80 and 443.
+- Preserving case in Jabber resources of buddies, since these should
+  officially be treated as case sensitive.
+- Fully stripping spaces from AIM screennames, this didn't happen completely
+  which severly breaks the IRC protocol.
+- Removed all the yellow tape around daemon mode, it's pretty mature by now:
+  testing.bitlbee.org serves all (~30) SSL users from one daemon mode
+  process without any serious stability issues.
+- Fixed GLib <2.6 compatibility issue.
+- Misc. memory leak/crash fixes.
+Finished 24 Jun 2008
 Version 1.2:
-- First BitlBee development/testing RELEASE. This should be quite stable
-  though (and for most people more stable than 1.0.x). It just has a couple
-  of rough edges and needs a bit more testing.
 - Added ForkDaemon mode next to the existing Daemon- and inetd modes. With
   ForkDaemon you can run BitlBee as a stand-alone daemon and every connection
 …
 .x is so old that supporting it really isn't necessary anymore.
 - Many, many, MANY little changes, improvements, fixes. Using non-blocking
+  I/O as much as possible, fixed lots of little bugs (including bugs that
+  affected daemon mode stability). See the bzr logs for more information.
+- Added units tests, will have to add some more before the real release.
+  I/O as much as possible, replaced the Gaim (0.59, IOW heavily outdated)
+  API, fixed lots of little bugs (including bugs that affected daemon mode
+  stability). See the bzr logs for more information.
+- One of the user-visible changes from the API change: You can finally see
+  all away states/messages properly.
+- Added units tests. Test coverage is very minimal for now.
+- Better charset handling: Everything is just converted from/to UTF-8 right
+  in the IRC core, and charset mismatches are detected (if possible) and the
+  user is asked to resolve this before continuing. Also, UTF-8 is the default
+  setting now, since that's how the world seems to work these days.
+- One can now keep hashed passwords in bitlbee.conf instead of the cleartext
+  version.
 - Most important change: New file format for user data (accounts, nicks and
   settings). Migration to the new format should happen transparently,
 …
   * An XML console (add xmlconsole to your contact list or see "help set
     xmlconsole" if you want it permanently).
+Finished ???
+- The Yahoo! module now says it supports YMSG protocol version 12, which will
+  hopefully keep the Yahoo module working after 2008-04-02 (when Yahoo! is
+  dropping support for version 6.x of their client).
+- MSN switchboard handling changes. Hopefully less messages will get lost now,
+  although things are still not perfect.
+Finished 17 Mar 2008
 Version 1.0.4:

doc/README

-                      r9730d72
+                      r6738a67
 by default) and chown it to the UID BitlBee is running as. Make sure this
 directory is read-/writable by this user only.
+--- (Fork)Daemon mode
+If you don't want to run any inetd daemon, you can run BitlBee in Daemon
+mode. Right now, daemon mode may be a bad idea on servers with multiple
+users, since possible fatal BitlBee bugs will crash the BitlBee process and
+disconnect all connected users at once. Instead, you can use ForkDaemon
+mode, which serves every user from a separate process, without depending on
+an inetd daemon.
+To use BitlBee in daemon mode, just start it with the right flags or enable
+it in bitlbee.conf. You probably want to write an init script to start
+BitlBee automatically after a reboot. (This is where you realise using
+a package from your distro would've been a better idea. :-P)
+Note that the BitlBee code is getting stable enough for daemon mode to be
+useful. Some public servers use it, and it saves a lot of memory by serving
+tens of users from a single process. One crash affects all users, but these
+are becoming quite rare.
 …
 versions of make, we'd love to hear it, but it seems this just isn't
 possible.
-RUNNING ON SERVERS WITH MANY USERS
-==================================
-BitlBee is not yet bug-free. Sometimes a bug causes the program to get into
-an infinite loop. Something you really don't want on a public server,
-especially when that machine is also used for other (mission-critical) things.
-For now we can't do much about it. We haven't seen that happen for a long
-time already on our own machines, but some people still manage to get
-themselves in nasty situations we haven't seen before.
-For now the best we can offer against this problem is bitlbeed, which allows
-you to setrlimit() the child processes to use no more than a specified
-number of CPU seconds. Not the best solution (not really a solution anyway),
-but certainly trashing one busy daemon process is better than trashing your
-whole machine.
-We don't believe adding a limit for bitlbee to /etc/security/limits.conf will
-work, because that file is only read by PAM (ie just for real login users,
-not daemons).
-See utils/bitlbeed.c for more information about the program.
-Just a little note: Now that we reach version 1.0, this shouldn't be that
-much of an issue anymore. However, on a public server, especially if you
-also use it for other things, it can't hurt to protect yourself against
-possible problems.

doc/bitlbee.8

-                      r9730d72
+                      r6738a67
 \fBbitlbee\fP should be called by
+.BR inetd (8).
+(Or \fBbitlbeed\fP,
+if you can't run and/or configure \fBinetd\fP.) There is an experimental
+daemon mode too, in which BitlBee will serve all clients in one process
+(and does not require inetd), but this mode is still experimental.
+There are still some bugs left in BitlBee, and if they cause a crash,
+that would terminate the BitlBee connection for all clients.
+.BR inetd (8),
+or you can run it as a stand-alone daemon.
 .PP
 .SH OPTIONS
 …
 Run in daemon mode. In this mode, BitlBee forks to the background and
 waits for new connections. All clients will be served from one process.
-This is still experimental. See the note above for more information.
 .IP "-F"
 Run in ForkDaemon mode. This is similar to ordinary daemon mode, but every
 client gets its own process. Easier to set up than inetd mode, but without
+client gets its own process. Easier to set up than inetd mode, and without
 the possible stability issues.
 .IP "-i \fIaddress\fP"

doc/user-guide/Support.xml

-                      r9730d72
+                      r6738a67
 <sect1>
 <title>BitlBee is beta software</title>
+<title>Disclaimer</title>
 <para>
+Although BitlBee has quite some functionality it is still beta. That means it
+can crash at any time, corrupt your data or whatever. Don't use it in
+any production environment and don't rely on it.
+BitlBee doesn't come with a warranty and is still (and will probably always
+be) under development. That means it can crash at any time, corrupt your
+data or whatever. Don't use it in any production environment and don't rely
+on it, or at least don't blame us if things blow up. :-)
 </para>

doc/user-guide/commands.xml

-                      r9730d72
+                      r6738a67
                         <para>
+                                If you want, you can also tell BitlBee what nick to give the new contact. Of course you can also use the <emphasis>rename</emphasis> command for that, but sometimes this might be more convenient.
+                        </para>
+                        <para>
+                                Adding -tmp adds the buddy to the internal BitlBee structures only, not to the real contact list (like done by <emphasis>set handle_unknown add</emphasis>). This allows you to talk to people who are not in your contact list.
+                                If you want, you can also tell BitlBee what nick to give the new contact. The -tmp option adds the buddy to the internal BitlBee structures only, not to the real contact list (like done by <emphasis>set handle_unknown add</emphasis>). This allows you to talk to people who are not in your contact list. This normally won't show you any presence notifications.
                         </para>
                 </description>
 …
         <bitlbee-setting name="charset" type="string" scope="global">
                 <default>iso8859-1</default>
+                <default>utf-8</default>
                 <possible-values>you can get a list of all possible values by doing 'iconv -l' in a shell</possible-values>
                 <description>
                         <para>
                                 The charset setting enables you to use different character sets in BitlBee. These get converted to UTF-8 before sending and from UTF-8 when receiving.
                         </para>
                         <para>
                                 If you don't know what's the best value for this, at least iso8859-1 is the best choice for most Western countries. You can try to find what works best for you on http://czyborra.com/charsets/iso8859.html
+                                This setting tells BitlBee what your IRC client sends and expects. It should be equal to the charset setting of your IRC client if you want to be able to send and receive non-ASCII text properly.
+                        </para>
+                        <para>
+                                Most systems use UTF-8 these days. On older systems, an iso8859 charset may work better. For example, iso8859-1 is the best choice for most Western countries. You can try to find what works best for you on http://www.unicodecharacter.com/charsets/iso8859.html
                         </para>
                 </description>
 …
         </bitlbee-setting>
+        <bitlbee-setting name="root_nick" type="string" scope="global">
+                <default>root</default>
+                <description>
+                        <para>
+                                Normally the "bot" that takes all your BitlBee commands is called "root". If you don't like this name, you can rename it to anything else using the <emphasis>rename</emphasis> command, or by changing this setting.
+                        </para>
+                </description>
+        </bitlbee-setting>
         <bitlbee-setting name="save_on_quit" type="boolean" scope="global">
                 <default>true</default>
 …
                 <description>
                         <para>
                                 Sends you a /notice when a user starts typing a message (if the protocol supports it, MSN for example). This is a bug, not a feature. (But please don't report it.. ;-) You don't want to use it. Really. In fact the typing-notification is just one of the least useful 'innovations' ever. It's just there because some guy will probably ask me about it anyway. ;-)
+                                Sends you a /notice when a user starts typing a message (if supported by the IM protocol and the user's client). To use this, you most likely want to use a script in your IRC client to show this information in a more sensible way.
                         </para>
                 </description>
 …
                 <short-description>Change friendly name, nick</short-description>
                 <syntax>nick &lt;connection&gt; [&lt;new nick&gt;]</syntax>
+                <syntax>nick</syntax>
+                <description>
+                        <para>
+                                This command allows to set the friendly name of an im account. If no new name is specified the command will report the current name. When the name contains spaces, don't forget to quote the whole nick in double quotes. Currently this command is only supported by the MSN protocol.
+                        </para>
+                        <para>
+                                It is recommended to use the per-account <emphasis>display_name</emphasis> setting to read and change this information. The <emphasis>nick</emphasis> command is deprecated.
+                <syntax>nick &lt;connection&gt;</syntax>
+                <description>
+                        <para>
+                                Deprecated: Use the per-account <emphasis>display_name</emphasis> setting to read and change this information.
                         </para>
                 </description>
                 <ircexample>
                         <ircline nick="wouter">nick 1 "Wouter Paesen"</ircline>
                         <ircline nick="root">Setting your name on connection 1 to `Wouter Paesen'</ircline>
+                        <ircline nick="wouter">account set 1/display_name "The majestik møøse"</ircline>
+                        <ircline nick="root">display_name = `The majestik møøse'</ircline>
                 </ircexample>

doc/user-guide/misc.xml

-                      r9730d72
+                      r6738a67
 </variablelist>
-<para>
-This list was extracted from <ulink url="http://help.msn.com/!data/en_us/data/messengerv50.its51/$content$/EMOTICONS.HTM?H_APP=">http://help.msn.com/!data/en_us/data/messengerv50.its51/$content$/EMOTICONS.HTM?H_APP=</ulink>.
-</para>
 </sect1>
 …
 <title>Groupchats</title>
 <para>
 Since version 0.8x, BitlBee supports groupchats on the MSN and Yahoo! networks. This text will try to explain you how they work.
+BitlBee now supports groupchats on all IM networks. This text will try to explain you how they work.
 </para>
 …
 <para>
 If you want to start a groupchat with the person <emphasis>jim_msn</emphasis> in it, just join the channel <emphasis>#jim_msn</emphasis>. BitlBee will refuse to join you to the channel with that name, but it will create a new virtual channel with root, you and jim_msn in it.
+If you want to start a groupchat with the person <emphasis>lisa_msn</emphasis> in it, just join the channel <emphasis>#lisa_msn</emphasis>. BitlBee will refuse to join you to the channel with that name, but it will create a new virtual channel with root, you and lisa_msn in it.
 </para>
 …
 <para>
 Some protocols (like Jabber) also support named groupchats. BitlBee now supports these too. You can use the <emphasis>join_chat</emphasis> command to join them. See <emphasis>help join_chat</emphasis> for more information.
-</para>
-<para>
-This is all you'll probably need to know. If you have any problems, please read <emphasis>help groupchats3</emphasis>.
-</para>
-</sect1>
-<sect1 id="groupchats3">
-<title>Groupchat channel names</title>
-<para>
-Obviously the (numbered) channel names don't make a lot of sense. Problem is that groupchats usually don't have names at all in the IM-world, while IRC insists on a name. So BitlBee just generates something random, just don't pay attention to it. :-)
-</para>
-<para>
-Please also note that BitlBee doesn't support groupchats for all protocols yet. BitlBee will tell you so. Support for other protocols will hopefully come later.
 </para>
 …
         <member>On the phone, Phone, On phone</member>
         <member>Out to lunch, Lunch, Food</member>
+        <member>Invisible, Hidden</member>
 </simplelist>
 …
 <para>
 You can also add more information to your away message. Setting it to "Busy - Fixing BitlBee bugs" will set your IM-away-states to Busy, but your away message will be more descriptive for people on IRC. Protocols like Yahoo! and Jabber will also show this complete away message to your buddies.
+You can also add more information to your away message. Setting it to "Busy - Fixing BitlBee bugs" will set your IM-away-states to Busy, but your away message will be more descriptive for people on IRC. Most IM-protocols can also show this additional information to your buddies.
 </para>

doc/user-guide/quickstart.xml

-                      r9730d72
+                      r6738a67
 <para>
 For most protocols (currently MSN, Jabber, Yahoo and AOL) BitlBee can download the contact list automatically from the IM server and all the on-line users should appear in the control channel when you log in.
+Now BitlBee logs in and downloads the contact list from the IM server. In a few seconds, all your on-line buddies should show up in the control channel.
 </para>
 <para>
 BitlBee will convert names into irc-friendly form (for instance: tux@example.com will be given the nickname tux). If you have more than one person who would have the same name by this logic (for instance: tux@example.com and tux@bitlbee.org) the second one to log on will be tux_. The same is true if you have a tux log on to AOL and a tux log on from Yahoo.
+BitlBee will convert names into IRC-friendly form (for instance: tux@example.com will be given the nickname tux). If you have more than one person who would have the same name by this logic (for instance: tux@example.com and tux@bitlbee.org) the second one to log on will be tux_. The same is true if you have a tux log on to AOL and a tux log on from Yahoo.
 </para>
 …
 <ircexample>
         <ircline nick="you">tux: hey, how's the weather down there?</ircline>
         <ircline nick="tux"> you: a bit chilly!</ircline>
+        <ircline nick="tux">you: a bit chilly!</ircline>
 </ircexample>
 <para>
+If you'd rather chat with them in a separate window use the <emphasis>/msg</emphasis> or <emphasis>/query</emphasis> command, just like you would for a private message in IRC.  If you want to have messages automatically come up in private messages rather than in the &amp;bitlbee channel, use the <emphasis>set private</emphasis> command: <emphasis>set private true</emphasis> (<emphasis>set private false</emphasis> to change back).
+Note that, although all contacts are in the &amp;bitlbee channel, only tux will actually receive this message. The &amp;bitlbee channel shouldn't be confused with a real IRC channel.
+</para>
+<para>
+If you prefer chatting in a separate window, use the <emphasis>/msg</emphasis> or <emphasis>/query</emphasis> command, just like on real IRC. BitlBee will remember how you talk to someone and show his/her responses the same way. If you want to change the default behaviour (for people you haven't talked to yet), see <emphasis>help set private</emphasis>.
 </para>

ipc.c

-                      r9730d72
+                      r6738a67
 GSList *child_list = NULL;
-static char *statefile = NULL;
 static void ipc_master_cmd_client( irc_t *data, char **cmd )
 …
+}
+static void ipc_master_cmd_deaf( irc_t *data, char **cmd )
+{
+        if( global.conf->runmode == RUNMODE_DAEMON )
+        {
+                b_event_remove( global.listen_watch_source_id );
+                close( global.listen_socket );
+                global.listen_socket = global.listen_watch_source_id = -1;
+                ipc_to_children_str( "OPERMSG :Closed listening socket, waiting "
+                                     "for all users to disconnect." );
+        }
+        else
+        {
+                ipc_to_children_str( "OPERMSG :The DEAF command only works in "
+                                     "normal daemon mode. Try DIE instead." );
+        }
+}
 void ipc_master_cmd_rehash( irc_t *data, char **cmd )
+{
 …
         { "hello",      0, ipc_master_cmd_client,     0 },
         { "die",        0, ipc_master_cmd_die,        0 },
+        { "deaf",       0, ipc_master_cmd_deaf,       0 },
         { "wallops",    1, NULL,                      IPC_CMD_TO_CHILDREN },
         { "wall",       1, NULL,                      IPC_CMD_TO_CHILDREN },
 …
+}
+/* Return just one line. Returns NULL if something broke, an empty string
+   on temporary "errors" (EAGAIN and friends). */
 static char *ipc_readline( int fd )
+{
         char *buf, *eol;
+        char buf[513], *eol;
         int size;
-        buf = g_new0( char, 513 );
         /* Because this is internal communication, it should be pretty safe
 …
            sockets and limites message length, messages should always be
            complete. Saves us quite a lot of code and buffering. */
         size = recv( fd, buf, 512, MSG_PEEK );
+        size = recv( fd, buf, sizeof( buf ) - 1, MSG_PEEK );
         if( size == 0 || ( size < 0 && !sockerr_again() ) )
                 return NULL;
 …
                 buf[size] = 0;
+        eol = strstr( buf, "\r\n" );
+        if( eol == NULL )
+        if( ( eol = strstr( buf, "\r\n" ) ) == NULL )
                 return NULL;
         else
                 size = eol - buf + 2;
-        g_free( buf );
-        buf = g_new0( char, size + 1 );
         if( recv( fd, buf, size, 0 ) != size )
                 return NULL;
         else
+                buf[size-2] = 0;
+        return buf;
+                return g_strndup( buf, size - 2 );
+}
 …
                 cmd = irc_parse_line( buf );
                 if( cmd )
+                {
                         ipc_command_exec( data, cmd, ipc_master_commands );
+        }
+        else
+                        g_free( cmd );
+                }
+                g_free( buf );
+        }
+        else
+        {
+                ipc_master_free_fd( source );
+        }
+        return TRUE;
+}
+gboolean ipc_child_read( gpointer data, gint source, b_input_condition cond )
+{
+        char *buf, **cmd;
+        if( ( buf = ipc_readline( source ) ) )
+        {
+                cmd = irc_parse_line( buf );
+                if( cmd )
+                {
+                        ipc_command_exec( data, cmd, ipc_child_commands );
+                        g_free( cmd );
+                }
+                g_free( buf );
+        }
+        else
+        {
+                ipc_child_disable();
+        }
+        return TRUE;
+}
+void ipc_to_master( char **cmd )
+{
+        if( global.conf->runmode == RUNMODE_FORKDAEMON )
+        {
+                char *s = irc_build_line( cmd );
+                ipc_to_master_str( "%s", s );
+                g_free( s );
+        }
+        else if( global.conf->runmode == RUNMODE_DAEMON )
+        {
+                ipc_command_exec( NULL, cmd, ipc_master_commands );
+        }
+}
+void ipc_to_master_str( char *format, ... )
+{
+        char *msg_buf;
+        va_list params;
+        va_start( params, format );
+        msg_buf = g_strdup_vprintf( format, params );
+        va_end( params );
+        if( strlen( msg_buf ) > 512 )
+        {
+                /* Don't send it, it's too long... */
+        }
+        else if( global.conf->runmode == RUNMODE_FORKDAEMON )
+        {
+                if( global.listen_socket >= 0 )
+                        if( write( global.listen_socket, msg_buf, strlen( msg_buf ) ) <= 0 )
+                                ipc_child_disable();
+        }
+        else if( global.conf->runmode == RUNMODE_DAEMON )
+        {
+                char **cmd, *s;
+                if( ( s = strchr( msg_buf, '\r' ) ) )
+                        *s = 0;
+                cmd = irc_parse_line( msg_buf );
+                ipc_command_exec( NULL, cmd, ipc_master_commands );
+                g_free( cmd );
+        }
+        g_free( msg_buf );
+}
+void ipc_to_children( char **cmd )
+{
+        if( global.conf->runmode == RUNMODE_FORKDAEMON )
+        {
+                char *msg_buf = irc_build_line( cmd );
+                ipc_to_children_str( "%s", msg_buf );
+                g_free( msg_buf );
+        }
+        else if( global.conf->runmode == RUNMODE_DAEMON )
+        {
                 GSList *l;
+                struct bitlbee_child *c;
+                for( l = child_list; l; l = l->next )
+                for( l = irc_connection_list; l; l = l->next )
+                        ipc_command_exec( l->data, cmd, ipc_child_commands );
+        }
+}
+void ipc_to_children_str( char *format, ... )
+{
+        char *msg_buf;
+        va_list params;
+        va_start( params, format );
+        msg_buf = g_strdup_vprintf( format, params );
+        va_end( params );
+        if( strlen( msg_buf ) > 512 )
+        {
+                /* Don't send it, it's too long... */
+        }
+        else if( global.conf->runmode == RUNMODE_FORKDAEMON )
+        {
+                int msg_len = strlen( msg_buf );
+                GSList *l, *next;
+                for( l = child_list; l; l = next )
+                {
+                        c = l->data;
+                        if( c->ipc_fd == source )
+                        struct bitlbee_child *c = l->data;
+                        next = l->next;
+                        if( write( c->ipc_fd, msg_buf, msg_len ) <= 0 )
+                        {
                                 ipc_master_free_one( c );
                                 child_list = g_slist_remove( child_list, c );
-                                break;
+                        }
+                }
+        }
-        return TRUE;
+}
-gboolean ipc_child_read( gpointer data, gint source, b_input_condition cond )
+{
-        char *buf, **cmd;
-        if( ( buf = ipc_readline( source ) ) )
+        {
-                cmd = irc_parse_line( buf );
-                if( cmd )
-                        ipc_command_exec( data, cmd, ipc_child_commands );
+        }
-        else
+        {
-                b_event_remove( global.listen_watch_source_id );
-                close( global.listen_socket );
-                global.listen_socket = -1;
+        }
-        return TRUE;
+}
-void ipc_to_master( char **cmd )
+{
-        if( global.conf->runmode == RUNMODE_FORKDAEMON )
+        {
-                char *s = irc_build_line( cmd );
-                ipc_to_master_str( "%s", s );
-                g_free( s );
+        }
-        else if( global.conf->runmode == RUNMODE_DAEMON )
+        {
-                ipc_command_exec( NULL, cmd, ipc_master_commands );
+        }
+}
-void ipc_to_master_str( char *format, ... )
+{
-        char *msg_buf;
-        va_list params;
-        va_start( params, format );
-        msg_buf = g_strdup_vprintf( format, params );
-        va_end( params );
-        if( strlen( msg_buf ) > 512 )
+        {
-                /* Don't send it, it's too long... */
+        }
-        else if( global.conf->runmode == RUNMODE_FORKDAEMON )
+        {
-                write( global.listen_socket, msg_buf, strlen( msg_buf ) );
+        }
-        else if( global.conf->runmode == RUNMODE_DAEMON )
+        {
-                char **cmd, *s;
-                if( ( s = strchr( msg_buf, '\r' ) ) )
-                        *s = 0;
-                cmd = irc_parse_line( msg_buf );
-                ipc_command_exec( NULL, cmd, ipc_master_commands );
-                g_free( cmd );
+        }
-        g_free( msg_buf );
+}
-void ipc_to_children( char **cmd )
+{
-        if( global.conf->runmode == RUNMODE_FORKDAEMON )
+        {
-                char *msg_buf = irc_build_line( cmd );
-                ipc_to_children_str( "%s", msg_buf );
-                g_free( msg_buf );
+        }
-        else if( global.conf->runmode == RUNMODE_DAEMON )
+        {
-                GSList *l;
-                for( l = irc_connection_list; l; l = l->next )
-                        ipc_command_exec( l->data, cmd, ipc_child_commands );
+        }
+}
-void ipc_to_children_str( char *format, ... )
+{
-        char *msg_buf;
-        va_list params;
-        va_start( params, format );
-        msg_buf = g_strdup_vprintf( format, params );
-        va_end( params );
-        if( strlen( msg_buf ) > 512 )
+        {
-                /* Don't send it, it's too long... */
+        }
-        else if( global.conf->runmode == RUNMODE_FORKDAEMON )
+        {
-                int msg_len = strlen( msg_buf );
-                GSList *l;
-                for( l = child_list; l; l = l->next )
+                {
-                        struct bitlbee_child *c = l->data;
-                        write( c->ipc_fd, msg_buf, msg_len );
+                }
+        }
 …
+}
+void ipc_master_free_fd( int fd )
+{
+        GSList *l;
+        struct bitlbee_child *c;
+        for( l = child_list; l; l = l->next )
+        {
+                c = l->data;
+                if( c->ipc_fd == fd )
+                {
+                        ipc_master_free_one( c );
+                        child_list = g_slist_remove( child_list, c );
+                        break;
+                }
+        }
+}
 void ipc_master_free_all()
+{
 …
+}
+void ipc_child_disable()
+{
+        b_event_remove( global.listen_watch_source_id );
+        close( global.listen_socket );
+        global.listen_socket = -1;
+}
+#ifndef _WIN32
 char *ipc_master_save_state()
+{
 …
+}
-void ipc_master_set_statefile( char *fn )
+{
-        statefile = g_strdup( fn );
+}
 static gboolean new_ipc_client( gpointer data, gint serversock, b_input_condition cond )
 …
+}
-#ifndef _WIN32
 int ipc_master_listen_socket()
+{
 …
+}
 #else
+int ipc_master_listen_socket()
+{
         /* FIXME: Open named pipe \\.\BITLBEE */
+        return 0;
+}
 #endif
 int ipc_master_load_state()
+int ipc_master_load_state( char *statefile )
+{
         struct bitlbee_child *child;
 …
         if( statefile == NULL )
                 return 0;
         fp = fopen( statefile, "r" );
         unlink( statefile );    /* Why do it later? :-) */

ipc.h

-                      r9730d72
+                      r6738a67
 void ipc_master_free_one( struct bitlbee_child *child );
+void ipc_master_free_fd( int fd );
 void ipc_master_free_all();
+void ipc_child_disable();
 void ipc_to_master( char **cmd );
 …
 char *ipc_master_save_state();
+void ipc_master_set_statefile( char *fn );
+int ipc_master_load_state();
+int ipc_master_load_state( char *statefile );
 int ipc_master_listen_socket();

irc.c

-                      r9730d72
+                      r6738a67
 #define BITLBEE_CORE
 #include "bitlbee.h"
+#include "sock.h"
 #include "crypting.h"
 #include "ipc.h"
 …
+}
+static char *set_eval_charset( set_t *set, char *value )
+{
+        irc_t *irc = set->data;
+        GIConv ic, oc;
+        if( g_strcasecmp( value, "none" ) == 0 )
+                value = g_strdup( "utf-8" );
+        if( ( ic = g_iconv_open( "utf-8", value ) ) == (GIConv) -1 )
+        {
+                return NULL;
+        }
+        if( ( oc = g_iconv_open( value, "utf-8" ) ) == (GIConv) -1 )
+        {
+                g_iconv_close( ic );
+                return NULL;
+        }
+        if( irc->iconv != (GIConv) -1 )
+                g_iconv_close( irc->iconv );
+        if( irc->oconv != (GIConv) -1 )
+                g_iconv_close( irc->oconv );
+        irc->iconv = ic;
+        irc->oconv = oc;
+        return value;
+}
 irc_t *irc_new( int fd )
+{
 …
         irc->mynick = g_strdup( ROOT_NICK );
         irc->channel = g_strdup( ROOT_CHAN );
+        irc->iconv = (GIConv) -1;
+        irc->oconv = (GIConv) -1;
         if( global.conf->hostname )
 …
         set_add( &irc->set, "private", "true", set_eval_bool, irc );
         set_add( &irc->set, "query_order", "lifo", NULL, irc );
+        set_add( &irc->set, "root_nick", irc->mynick, set_eval_root_nick, irc );
         set_add( &irc->set, "save_on_quit", "true", set_eval_bool, irc );
         set_add( &irc->set, "simulate_netsplit", "true", set_eval_bool, irc );
 …
         irc->otr = otr_new();
+        /* Evaluator sets the iconv/oconv structures. */
+        set_eval_charset( set_find( &irc->set, "charset" ), set_getstr( &irc->set, "charset" ) );
         return( irc );
+}
 …
         if( irc->sendbuffer && !immed )
+        {
+                /* We won't read from this socket anymore. Instead, we'll connect a timer
+                   to it that should shut down the connection in a second, just in case
+                   bitlbee_.._write doesn't do it first. */
+                /* Set up a timeout event that should shut down the connection
+                   in a second, just in case ..._write doesn't do it first. */
                 b_event_remove( irc->r_watch_source_id );
+                irc->r_watch_source_id = b_timeout_add( 1000, (b_event_handler) irc_free, irc );
+                irc->r_watch_source_id = 0;
+                b_event_remove( irc->ping_source_id );
+                irc->ping_source_id = b_timeout_add( 1000, (b_event_handler) irc_free, irc );
+        }
         else
 …
 /* Because we have no garbage collection, this is quite annoying */
+void irc_free(irc_t * irc)
+{
+        account_t *account;
+void irc_free( irc_t * irc )
+{
         user_t *user, *usertmp;
 …
                         irc_usermsg( irc, "Error while saving settings!" );
-        closesocket( irc->fd );
-        if( irc->ping_source_id > 0 )
-                b_event_remove( irc->ping_source_id );
-        b_event_remove( irc->r_watch_source_id );
-        if( irc->w_watch_source_id > 0 )
-                b_event_remove( irc->w_watch_source_id );
         irc_connection_list = g_slist_remove( irc_connection_list, irc );
+        for (account = irc->accounts; account; account = account->next) {
+                if (account->ic) {
+                        imc_logout(account->ic, TRUE);
+                } else if (account->reconnect) {
+                        cancel_auto_reconnect(account);
+                }
+        }
+        g_free(irc->sendbuffer);
+        g_free(irc->readbuffer);
+        g_free(irc->nick);
+        g_free(irc->user);
+        g_free(irc->host);
+        g_free(irc->realname);
+        g_free(irc->password);
+        g_free(irc->myhost);
+        g_free(irc->mynick);
+        g_free(irc->channel);
+        while (irc->queries != NULL)
+                query_del(irc, irc->queries);
+        while (irc->accounts)
+                if (irc->accounts->ic == NULL)
+                        account_del(irc, irc->accounts);
+        while( irc->accounts )
+        {
+                if( irc->accounts->ic )
+                        imc_logout( irc->accounts->ic, FALSE );
+                else if( irc->accounts->reconnect )
+                        cancel_auto_reconnect( irc->accounts );
+                if( irc->accounts->ic == NULL )
+                        account_del( irc, irc->accounts );
                 else
                         /* Nasty hack, but account_del() doesn't work in this
                            case and we don't want infinite loops, do we? ;-) */
                         irc->accounts = irc->accounts->next;
+        while (irc->set)
+                set_del(&irc->set, irc->set->key);
+        if (irc->users != NULL) {
+        }
+        while( irc->queries != NULL )
+                query_del( irc, irc->queries );
+        while( irc->set )
+                set_del( &irc->set, irc->set->key );
+        if (irc->users != NULL)
+        {
                 user = irc->users;
+                while (user != NULL) {
+                        g_free(user->nick);
+                        g_free(user->away);
+                        g_free(user->handle);
+                        if(user->user!=user->nick) g_free(user->user);
+                        if(user->host!=user->nick) g_free(user->host);
+                        if(user->realname!=user->nick) g_free(user->realname);
+                        b_event_remove(user->sendbuf_timer);
+                while( user != NULL )
+                {
+                        g_free( user->nick );
+                        g_free( user->away );
+                        g_free( user->handle );
+                        if( user->user != user->nick ) g_free( user->user );
+                        if( user->host != user->nick ) g_free( user->host );
+                        if( user->realname != user->nick ) g_free( user->realname );
+                        b_event_remove( user->sendbuf_timer );
                         usertmp = user;
                         user = user->next;
+                        g_free(usertmp);
+                }
+        }
+        g_hash_table_foreach_remove(irc->userhash, irc_free_hashkey, NULL);
+        g_hash_table_destroy(irc->userhash);
+        g_hash_table_foreach_remove(irc->watches, irc_free_hashkey, NULL);
+        g_hash_table_destroy(irc->watches);
+                        g_free( usertmp );
+                }
+        }
+        if( irc->ping_source_id > 0 )
+                b_event_remove( irc->ping_source_id );
+        if( irc->r_watch_source_id > 0 )
+                b_event_remove( irc->r_watch_source_id );
+        if( irc->w_watch_source_id > 0 )
+                b_event_remove( irc->w_watch_source_id );
+        closesocket( irc->fd );
+        irc->fd = -1;
+        g_hash_table_foreach_remove( irc->userhash, irc_free_hashkey, NULL );
+        g_hash_table_destroy( irc->userhash );
+        g_hash_table_foreach_remove( irc->watches, irc_free_hashkey, NULL );
+        g_hash_table_destroy( irc->watches );
+        if( irc->iconv != (GIConv) -1 )
+                g_iconv_close( irc->iconv );
+        if( irc->oconv != (GIConv) -1 )
+                g_iconv_close( irc->oconv );
+        g_free( irc->sendbuffer );
+        g_free( irc->readbuffer );
+        g_free( irc->nick );
+        g_free( irc->user );
+        g_free( irc->host );
+        g_free( irc->realname );
+        g_free( irc->password );
+        g_free( irc->myhost );
+        g_free( irc->mynick );
+        g_free( irc->channel );
+        g_free( irc->last_target );
         otr_free(irc->otr);
+        g_free(irc);
+        if( global.conf->runmode == RUNMODE_INETD || global.conf->runmode == RUNMODE_FORKDAEMON )
+        g_free( irc );
+        if( global.conf->runmode == RUNMODE_INETD ||
+            global.conf->runmode == RUNMODE_FORKDAEMON ||
+            ( global.conf->runmode == RUNMODE_DAEMON &&
+              global.listen_socket == -1 &&
+              irc_connection_list == NULL ) )
                 b_main_quit();
+}
 …
 void irc_process( irc_t *irc )
+{
         char **lines, *temp, **cmd, *cs;
+        char **lines, *temp, **cmd;
         int i;
 …
                 for( i = 0; *lines[i] != '\0'; i ++ )
+                {
                         char conv[IRC_MAX_LINE+1];
+                        char *conv = NULL;
+                        /* [WvG] Because irc_tokenize splits at every newline, the lines[] list
+                            should end with an empty string. This is why this actually works.
+                            Took me a while to figure out, Maurits. :-P */
+                        /* [WvG] If the last line isn't empty, it's an incomplete line and we
+                           should wait for the rest to come in before processing it. */
                         if( lines[i+1] == NULL )
+                        {
 …
+                        }
+                        if( ( cs = set_getstr( &irc->set, "charset" ) ) )
+                        {
+                                conv[IRC_MAX_LINE] = 0;
+                                if( do_iconv( cs, "UTF-8", lines[i], conv, 0, IRC_MAX_LINE - 2 ) == -1 )
+                        if( irc->iconv != (GIConv) -1 )
+                        {
+                                gsize bytes_read, bytes_written;
+                                conv = g_convert_with_iconv( lines[i], -1, irc->iconv,
+                                                             &bytes_read, &bytes_written, NULL );
+                                if( conv == NULL || bytes_read != strlen( lines[i] ) )
+                                {
                                         /* GLib can do strange things if things are not in the expected charset,
 …
                                                                   "expect by changing the charset setting. See "
                                                                   "`help set charset' for more information. Your "
+                                                                  "message was ignored.", cs );
+                                                *conv = 0;
+                                                                  "message was ignored.",
+                                                                  set_getstr( &irc->set, "charset" ) );
+                                                g_free( conv );
+                                                conv = NULL;
+                                        }
                                         else
+                                        {
                                                 irc_write( irc, ":%s NOTICE AUTH :%s", irc->myhost,
                                                            "Warning: invalid (non-UTF8) characters received at login time." );
+                                                           "Warning: invalid characters received at login time." );
                                                 strncpy( conv, lines[i], IRC_MAX_LINE );
+                                                conv = g_strdup( lines[i] );
                                                 for( temp = conv; *temp; temp ++ )
                                                         if( *temp & 0x80 )
 …
+                        }
+                        if( ( cmd = irc_parse_line( lines[i] ) ) == NULL )
+                                continue;
+                        irc_exec( irc, cmd );
+                        if( lines[i] )
+                        {
+                                if( ( cmd = irc_parse_line( lines[i] ) ) == NULL )
+                                        continue;
+                                irc_exec( irc, cmd );
+                                g_free( cmd );
+                        }
                         g_free( cmd );
+                        g_free( conv );
                         /* Shouldn't really happen, but just in case... */
 …
 char **irc_tokenize( char *buffer )
+{
         int i, j;
+        int i, j, n = 3;
         char **lines;
+        /* Count the number of elements we're gonna need. */
+        for( i = 0, j = 1; buffer[i] != '\0'; i ++ )
+        {
+                if( buffer[i] == '\n' )
+                        if( buffer[i+1] != '\r' && buffer[i+1] != '\n' )
+                                j ++;
+        }
+        /* Allocate j+1 elements. */
+        lines = g_new( char *, j + 1 );
+        /* Allocate n+1 elements. */
+        lines = g_new( char *, n + 1 );
+        lines[0] = buffer;
+        /* Split the buffer in several strings, and accept any kind of line endings,
+         * knowing that ERC on Windows may send something interesting like \r\r\n,
+         * and surely there must be clients that think just \n is enough... */
+        for( i = 0, j = 0; buffer[i] != '\0'; i ++ )
+        {
+                if( buffer[i] == '\r' || buffer[i] == '\n' )
+                {
+                        while( buffer[i] == '\r' || buffer[i] == '\n' )
+                                buffer[i++] = '\0';
+                        lines[++j] = buffer + i;
+                        if( j >= n )
+                        {
+                                n *= 2;
+                                lines = g_renew( char *, lines, n + 1 );
+                        }
+                        if( buffer[i] == '\0' )
+                                break;
+                }
+        }
         /* NULL terminate our list. */
+        lines[j] = NULL;
+        lines[0] = buffer;
+        /* Split the buffer in several strings, using \r\n as our seperator, where \r is optional.
+         * Although this is not in the RFC, some braindead ircds (newnet's) use this, so some clients might too.
+         */
+        for( i = 0, j = 0; buffer[i] != '\0'; i ++)
+        {
+                if( buffer[i] == '\n' )
+                {
+                        buffer[i] = '\0';
+                        if( i > 0 && buffer[i-1] == '\r' )
+                                buffer[i-1] = '\0';
+                        if( buffer[i+1] != '\r' && buffer[i+1] != '\n' )
+                                lines[++j] = buffer + i + 1;
+                }
+        }
+        return( lines );
+        lines[++j] = NULL;
+        return lines;
+}
 …
         return;
+}
 …
+{
         int size;
         char line[IRC_MAX_LINE+1], *cs;
+        char line[IRC_MAX_LINE+1];
         /* Don't try to write anything new anymore when shutting down. */
 …
                 return;
         line[IRC_MAX_LINE] = 0;
+        memset( line, 0, sizeof( line ) );
         g_vsnprintf( line, IRC_MAX_LINE - 2, format, params );
         strip_newlines( line );
+        if( ( cs = set_getstr( &irc->set, "charset" ) ) && ( g_strcasecmp( cs, "utf-8" ) != 0 ) )
+        {
+                char conv[IRC_MAX_LINE+1];
+                conv[IRC_MAX_LINE] = 0;
+                if( do_iconv( "UTF-8", cs, line, conv, 0, IRC_MAX_LINE - 2 ) != -1 )
+                        strcpy( line, conv );
+        }
+        strcat( line, "\r\n" );
+        if( irc->oconv != (GIConv) -1 )
+        {
+                gsize bytes_read, bytes_written;
+                char *conv;
+                conv = g_convert_with_iconv( line, -1, irc->oconv,
+                                             &bytes_read, &bytes_written, NULL );
+                if( bytes_read == strlen( line ) )
+                        strncpy( line, conv, IRC_MAX_LINE - 2 );
+                g_free( conv );
+        }
+        g_strlcat( line, "\r\n", IRC_MAX_LINE + 1 );
         if( irc->sendbuffer != NULL )
 …
         irc->umode[0] = '\0';
         irc_umode_set( irc, "+" UMODE, 1 );
+        u = user_add( irc, irc->mynick );
+u = user_add( irc, irc->mynick );
         u->host = g_strdup( irc->myhost );
         u->realname = g_strdup( ROOT_FN );
 …
         irc->status |= USTATUS_LOGGED_IN;
+        /* This is for bug #209 (use PASS to identify to NickServ). */
+        if( irc->password != NULL )
+        {
+                char *send_cmd[] = { "identify", g_strdup( irc->password ), NULL };
+                irc_setpass( irc, NULL );
+                root_command( irc, send_cmd );
+                g_free( send_cmd[1] );
+        }
+}
 …
         if( !f )
+        {
+                irc_usermsg( irc, "Welcome to the BitlBee gateway!\n\nIf you've never used BitlBee before, please do read the help information using the \x02help\x02 command. Lots of FAQs are answered there.\n\nOTR users please note: Private key files are owned by the user BitlBee is running as." );
+                irc_usermsg( irc, "Welcome to the BitlBee gateway!\n\n"
+                                  "If you've never used BitlBee before, please do read the help "
+                                  "information using the \x02help\x02 command. Lots of FAQs are "
+                                  "answered there.\n"
+                                  "OTR users please note: Private key files are owned by the user "
+                                  "BitlBee is running as.\n"
+                                  "If you already have an account on this server, just use the "
+                                  "\x02identify\x02 command to identify yourself." );
+        }
         else

irc.h

-                      r9730d72
+                      r6738a67
         char *sendbuffer;
         char *readbuffer;
+        GIConv iconv, oconv;
         int sentbytes;
 …
         char *host;
         char *realname;
+        char *password;
+        char *password; /* HACK: Used to save the user's password, but before
+                           logging in, this may contain a password we should
+                           send to identify after USER/NICK are received. */
         char umode[8];

irc_commands.c

-                      r9730d72
+                      r6738a67
 static void irc_cmd_pass( irc_t *irc, char **cmd )
+{
+        if( global.conf->auth_pass && strcmp( cmd[1], global.conf->auth_pass ) == 0 )
+        if( irc->status & USTATUS_LOGGED_IN )
+        {
+                char *send_cmd[] = { "identify", cmd[1], NULL };
+                /* We're already logged in, this client seems to send the PASS
+                   command last. (Possibly it won't send it at all if it turns
+                   out we don't require it, which will break this feature.)
+                   Try to identify using the given password. */
+                return root_command( irc, send_cmd );
+        }
+        /* Handling in pre-logged-in state, first see if this server is
+           password-protected: */
+        else if( global.conf->auth_pass &&
+            ( strncmp( global.conf->auth_pass, "md5:", 4 ) == 0 ?
+                md5_verify_password( cmd[1], global.conf->auth_pass + 4 ) == 0 :
+                strcmp( cmd[1], global.conf->auth_pass ) == 0 ) )
+        {
                 irc->status |= USTATUS_AUTHORIZED;
                 irc_check_login( irc );
+        }
         else
+        else if( global.conf->auth_pass )
+        {
                 irc_reply( irc, 464, ":Incorrect password" );
+        }
+        else
+        {
+                /* Remember the password and try to identify after USER/NICK. */
+                irc_setpass( irc, cmd[1] );
+                irc_check_login( irc );
+        }
+}
 …
 static void irc_cmd_oper( irc_t *irc, char **cmd )
+{
+        if( global.conf->oper_pass && strcmp( cmd[2], global.conf->oper_pass ) == 0 )
+        if( global.conf->oper_pass &&
+            ( strncmp( global.conf->oper_pass, "md5:", 4 ) == 0 ?
+                md5_verify_password( cmd[2], global.conf->oper_pass + 4 ) == 0 :
+                strcmp( cmd[2], global.conf->oper_pass ) == 0 ) )
+        {
                 irc_umode_set( irc, "+o", 1 );
 …
                         if( cmd[1] != irc->last_target )
+                        {
+                                if( irc->last_target )
+                                        g_free( irc->last_target );
+                                g_free( irc->last_target );
                                 irc->last_target = g_strdup( cmd[1] );
+                        }
 …
 static const command_t irc_commands[] = {
         { "pass",        1, irc_cmd_pass,        IRC_CMD_PRE_LOGIN },
+        { "pass",        1, irc_cmd_pass,        0 },
         { "user",        4, irc_cmd_user,        IRC_CMD_PRE_LOGIN },
         { "nick",        1, irc_cmd_nick,        0 },
 …
         { "completions", 0, irc_cmd_completions, IRC_CMD_LOGGED_IN },
         { "die",         0, NULL,                IRC_CMD_OPER_ONLY | IRC_CMD_TO_MASTER },
+        { "deaf",        0, NULL,                IRC_CMD_OPER_ONLY | IRC_CMD_TO_MASTER },
         { "wallops",     1, NULL,                IRC_CMD_OPER_ONLY | IRC_CMD_TO_MASTER },
         { "wall",        1, NULL,                IRC_CMD_OPER_ONLY | IRC_CMD_TO_MASTER },

lib/Makefile

r9730d72	r6738a67
10	10
11	11	# [SH] Program variables
12		objects = arc.o base64.o $(EVENT_HANDLER) http_client.o ini.o md5.o misc.o proxy.o sha1.o $(SSL_CLIENT) url.o
	12	objects = arc.o base64.o $(EVENT_HANDLER) http_client.o ini.o md5.o misc.o proxy.o sha1.o $(SSL_CLIENT) url.o xmltree.o
13	13
14	14	CFLAGS += -Wall

lib/arc.c

-                      r9730d72
+                      r6738a67
    Both functions return the number of bytes in the result string.
+   Note that if you use the pad_to argument, you will need zero-termi-
+   nation to find back the original string length after decryption. So
+   it shouldn't be used if your string contains \0s by itself!
 */
 int arc_encode( char *clear, int clear_len, unsigned char **crypt, char *password )
+int arc_encode( char *clear, int clear_len, unsigned char **crypt, char *password, int pad_to )
+{
         struct arc_state *st;
         unsigned char *key;
+        int key_len, i;
+        char *padded = NULL;
+        int key_len, i, padded_len;
         key_len = strlen( password ) + ARC_IV_LEN;
         if( clear_len <= 0 )
                 clear_len = strlen( clear );
+        /* Pad the string to the closest multiple of pad_to. This makes it
+           impossible to see the exact length of the password. */
+        if( pad_to > 0 && ( clear_len % pad_to ) > 0 )
+        {
+                padded_len = clear_len + pad_to - ( clear_len % pad_to );
+                padded = g_malloc( padded_len );
+                memcpy( padded, clear, clear_len );
+                /* First a \0 and then random data, so we don't have to do
+                   anything special when decrypting. */
+                padded[clear_len] = 0;
+                random_bytes( (unsigned char*) padded + clear_len + 1, padded_len - clear_len - 1 );
+                clear = padded;
+                clear_len = padded_len;
+        }
         /* Prepare buffers and the key + IV */
 …
         g_free( st );
+        g_free( padded );
         return clear_len + ARC_IV_LEN;

lib/arc.h

-                      r9730d72
+                      r6738a67
 };
+struct arc_state *arc_keymaker( unsigned char *key, int kl, int cycles );
+#ifndef G_GNUC_MALLOC
+#define G_GNUC_MALLOC
+#endif
+G_GNUC_MALLOC struct arc_state *arc_keymaker( unsigned char *key, int kl, int cycles );
 unsigned char arc_getbyte( struct arc_state *st );
 int arc_encode( char *clear, int clear_len, unsigned char **crypt, char *password );
+int arc_encode( char *clear, int clear_len, unsigned char **crypt, char *password, int pad_to );
 int arc_decode( unsigned char *crypt, int crypt_len, char **clear, char *password );

lib/base64.c

r9730d72	r6738a67
118	118	int i, outlen = 0;
119	119
120		for( i = 0; in[i]; i += 4 )
	120	for( i = 0; in[i] && in[i+1] && in[i+2] && in[i+3]; i += 4 )
121	121	{
122	122	int sx;

lib/events_glib.c

-                      r9730d72
+                      r6738a67
 } GaimIOClosure;
 static GMainLoop *loop;
+static GMainLoop *loop = NULL;
 void b_main_init()
+{
+        loop = g_main_new( FALSE );
+        if( loop == NULL )
+                loop = g_main_new( FALSE );
+}

lib/misc.c

-                      r9730d72
+                      r6738a67
 #define BITLBEE_CORE
 #include "nogaim.h"
+#include "base64.h"
 #include <stdio.h>
 #include <stdlib.h>
 …
         strcpy(text, text2);
         g_free(text2);
+}
-char *normalize(const char *s)
+{
-        static char buf[BUF_LEN];
-        char *t, *u;
-        int x = 0;
-        g_return_val_if_fail((s != NULL), NULL);
-        u = t = g_strdup(s);
-        strcpy(t, s);
-        g_strdown(t);
-        while (*t && (x < BUF_LEN - 1)) {
-                if (*t != ' ') {
-                        buf[x] = *t;
-                        x++;
+                }
-                t++;
+        }
-        buf[x] = '\0';
-        g_free(u);
-        return buf;
+}
 …
 void random_bytes( unsigned char *buf, int count )
+{
+#ifndef _WIN32
         static int use_dev = -1;
 …
         if( !use_dev )
+#endif
+        {
                 int i;
 …
                 return sockerr_again();
+}
+/* Returns values: -1 == Failure (base64-decoded to something unexpected)
+== Okay
+== Password doesn't match the hash. */
+int md5_verify_password( char *password, char *hash )
+{
+        md5_byte_t *pass_dec = NULL;
+        md5_byte_t pass_md5[16];
+        md5_state_t md5_state;
+        int ret = -1, i;
+        if( base64_decode( hash, &pass_dec ) == 21 )
+        {
+                md5_init( &md5_state );
+                md5_append( &md5_state, (md5_byte_t*) password, strlen( password ) );
+                md5_append( &md5_state, (md5_byte_t*) pass_dec + 16, 5 ); /* Hmmm, salt! */
+                md5_finish( &md5_state, pass_md5 );
+                for( i = 0; i < 16; i ++ )
+                {
+                        if( pass_dec[i] != pass_md5[i] )
+                        {
+                                ret = 1;
+                                break;
+                        }
+                }
+                /* If we reached the end of the loop, it was a match! */
+                if( i == 16 )
+                        ret = 0;
+        }
+        g_free( pass_dec );
+        return ret;
+}

lib/misc.h

-                      r9730d72
+                      r6738a67
 G_MODULE_EXPORT char *add_cr( char *text );
 G_MODULE_EXPORT char *strip_newlines(char *source);
-G_MODULE_EXPORT char *normalize( const char *s );
 G_MODULE_EXPORT time_t get_time( int year, int month, int day, int hour, int min, int sec );
 …
 G_MODULE_EXPORT gboolean ssl_sockerr_again( void *ssl );
+G_MODULE_EXPORT int md5_verify_password( char *password, char *hash );
 #endif

lib/proxy.c

-                      r9730d72
+                      r6738a67
+{
         struct sockaddr_in *sin;
+        struct sockaddr_in me;
         int fd = -1;
 …
         sock_make_nonblocking(fd);
+        if( global.conf->iface_out )
+        {
+                me.sin_family = AF_INET;
+                me.sin_port = 0;
+                me.sin_addr.s_addr = inet_addr( global.conf->iface_out );
+                if( bind( fd, (struct sockaddr *) &me, sizeof( me ) ) != 0 )
+                        event_debug( "bind( %d, \"%s\" ) failure\n", fd, global.conf->iface_out );
+        }
         event_debug("proxy_connect_none( \"%s\", %d ) = %d\n", host, port, fd);
 …
         struct PHB *phb;
         if (!host || !port || (port == -1) || !func || strlen(host) > 128) {
+        if (!host || port <= 0 || !func || strlen(host) > 128) {
                 return -1;
+        }
 …
         phb->data = data;
         if ((proxytype == PROXY_NONE) || strlen(proxyhost) > 0 || !proxyport || (proxyport == -1))
+        if (proxytype == PROXY_NONE || !proxyhost[0] || proxyport <= 0)
                 return proxy_connect_none(host, port, phb);
         else if (proxytype == PROXY_HTTP)

lib/ssl_bogus.c

-                      r9730d72
+                      r6738a67
         return GAIM_INPUT_READ;
+}
+int ssl_pending( void *conn )
+{
+        return 0;
+}

lib/ssl_client.h

-                      r9730d72
+                      r6738a67
 G_MODULE_EXPORT int ssl_write( void *conn, const char *buf, int len );
+/* See ssl_openssl.c for an explanation. */
+G_MODULE_EXPORT int ssl_pending( void *conn );
 /* Abort the SSL connection and disconnect the socket. Do not use close()
    directly, both the SSL library and the peer will be unhappy! */

lib/ssl_gnutls.c

r9730d72	r6738a67
216	216	}
217	217
	218	/* See ssl_openssl.c for an explanation. */
	219	int ssl_pending( void *conn )
	220	{
	221	return 0;
	222	}
	223
218	224	void ssl_disconnect( void *conn_ )
219	225	{

lib/ssl_nss.c

r9730d72	r6738a67
175	175	}
176	176
	177	/* See ssl_openssl.c for an explanation. */
	178	int ssl_pending( void *conn )
	179	{
	180	return 0;
	181	}
	182
177	183	void ssl_disconnect( void *conn_ )
178	184	{

lib/ssl_openssl.c

-                      r9730d72
+                      r6738a67
         conn->fd = proxy_connect( host, port, ssl_connected, conn );
+        if( conn->fd < 0 )
+        {
+                g_free( conn );
+                return NULL;
+        }
         conn->func = func;
         conn->data = data;
         conn->inpa = -1;
-        if( conn->fd < 0 )
+        {
-                g_free( conn );
-                return NULL;
+        }
         return conn;
 …
+}
+/* Only OpenSSL *really* needs this (and well, maybe NSS). See for more info:
+   http://www.gnu.org/software/gnutls/manual/gnutls.html#index-gnutls_005frecord_005fcheck_005fpending-209
+   http://www.openssl.org/docs/ssl/SSL_pending.html
+   Required because OpenSSL empties the TCP buffer completely but doesn't
+   necessarily give us all the unencrypted data.
+   Returns 0 if there's nothing left or if we don't have to care (GnuTLS),
+if there's more data. */
+int ssl_pending( void *conn )
+{
+        return ( ((struct scd*)conn) && ((struct scd*)conn)->established ) ?
+               SSL_pending( ((struct scd*)conn)->ssl ) > 0 : 0;
+}
 void ssl_disconnect( void *conn_ )
+{

lib/url.c

r9730d72	r6738a67
26	26	#include "url.h"
27	27
28		/* Convert an URL to a url_t structure */
	28	/* Convert an URL to a url_t structure */
29	29	int url_set( url_t url, char set_url )
30	30	{
31		char s[MAX_STRING];
	31	char s[MAX_STRING+1];
32	32	char *i;
33	33
34		/* protocol:// */
	34	memset( url, 0, sizeof( url_t ) );
	35	memset( s, 0, sizeof( s ) );
	36
	37	/* protocol:// */
35	38	if( ( i = strstr( set_url, "://" ) ) == NULL )
36	39	{
…	…
49	52	url->proto = PROTO_SOCKS5;
50	53	else
51		{
52		return( 0 );
53		}
	54	return 0;
	55
54	56	strncpy( s, i + 3, MAX_STRING );
55	57	}
56	58
57		/* Split */
	59	/* Split */
58	60	if( ( i = strchr( s, '/' ) ) == NULL )
59	61	{
…	…
67	69	strncpy( url->host, s, MAX_STRING );
68	70
69		/* Check for username in host field */
	71	/* Check for username in host field */
70	72	if( strrchr( url->host, '@' ) != NULL )
71	73	{
…	…
76	78	*url->pass = 0;
77	79	}
78		/* If not: Fill in defaults */
	80	/* If not: Fill in defaults */
79	81	else
80	82	{
…	…
82	84	}
83	85
84		/* Password? */
	86	/* Password? */
85	87	if( ( i = strchr( url->user, ':' ) ) != NULL )
86	88	{
…	…
88	90	strcpy( url->pass, i + 1 );
89	91	}
90		/* Port number? */
	92	/* Port number? */
91	93	if( ( i = strchr( url->host, ':' ) ) != NULL )
92	94	{

lib/url.h

-                      r9730d72
+                      r6738a67
 #include "bitlbee.h"
 #define PROTO_HTTP              2
 #define PROTO_HTTPS             5
 #define PROTO_SOCKS4    3
 #define PROTO_SOCKS5    4
 #define PROTO_DEFAULT   PROTO_HTTP
+#define PROTO_HTTP      2
+#define PROTO_HTTPS     5
+#define PROTO_SOCKS4    3
+#define PROTO_SOCKS5    4
+#define PROTO_DEFAULT   PROTO_HTTP
 typedef struct url
 …
         int proto;
         int port;
         char host[MAX_STRING];
         char file[MAX_STRING];
         char user[MAX_STRING];
         char pass[MAX_STRING];
+        char host[MAX_STRING+1];
+        char file[MAX_STRING+1];
+        char user[MAX_STRING+1];
+        char pass[MAX_STRING+1];
 } url_t;

nick.c

r9730d72	r6738a67
47	47
48	48	store_handle = clean_handle( handle );
	49	store_nick[MAX_NICK_LENGTH] = 0;
49	50	strncpy( store_nick, nick, MAX_NICK_LENGTH );
50	51	nick_strip( store_nick );

otr.c

-                      r9730d72
+                      r6738a67
 #include <unistd.h>
 #include <assert.h>
+#include <signal.h>
 …
 };
+typedef struct {
+        void *fst;
+        void *snd;
+} pair_t;
 /** misc. helpers/subroutines: **/
 …
 /* some yes/no handlers */
 void yes_keygen(gpointer w, void *data);
 void yes_forget_fingerprint(gpointer w, void *data);
 void yes_forget_context(gpointer w, void *data);
 void yes_forget_key(gpointer w, void *data);
+void yes_keygen(void *data);
+void yes_forget_fingerprint(void *data);
+void yes_forget_context(void *data);
+void yes_forget_key(void *data);
 /* helper to make sure accountname and protocol match the incoming "opdata" */
 …
+}
+void yes_forget_fingerprint(gpointer w, void *data)
+{
+        irc_t *irc = (irc_t *)w;
+        Fingerprint *fp = (Fingerprint *)data;
+void yes_forget_fingerprint(void *data)
+{
+        pair_t *p = (pair_t *)data;
+        irc_t *irc = (irc_t *)p->fst;
+        Fingerprint *fp = (Fingerprint *)p->snd;
+        g_free(p);
         if(fp == fp->context->active_fingerprint) {
 …
+}
+void yes_forget_context(gpointer w, void *data)
+{
+        irc_t *irc = (irc_t *)w;
+        ConnContext *ctx = (ConnContext *)data;
+void yes_forget_context(void *data)
+{
+        pair_t *p = (pair_t *)data;
+        irc_t *irc = (irc_t *)p->fst;
+        ConnContext *ctx = (ConnContext *)p->snd;
+        g_free(p);
         if(ctx->msgstate == OTRL_MSGSTATE_ENCRYPTED) {
 …
+}
 void yes_forget_key(gpointer w, void *data)
+void yes_forget_key(void *data)
+{
         OtrlPrivKey *key = (OtrlPrivKey *)data;
 …
                 char human[54];
                 char *s;
+                pair_t *p;
                 if(!args[3]) {
 …
                 otrl_privkey_hash_to_human(human, fp->fingerprint);
                 s = g_strdup_printf("about to forget fingerprint %s, are you sure?", human);
+                query_add(irc, NULL, s, yes_forget_fingerprint, NULL, fp);
+                p = g_malloc(sizeof(pair_t));
+                if(!p)
+                        return;
+                p->fst = irc;
+                p->snd = fp;
+                query_add(irc, NULL, s, yes_forget_fingerprint, NULL, p);
                 g_free(s);
+        }
 …
                 ConnContext *ctx;
                 char *s;
+                pair_t *p;
                 /* TODO: allow context specs ("user/proto/account") in 'otr forget contex'? */
 …
                 s = g_strdup_printf("about to forget otr data about %s, are you sure?", args[2]);
+                query_add(irc, NULL, s, yes_forget_context, NULL, ctx);
+                p = g_malloc(sizeof(pair_t));
+                if(!p)
+                        return;
+                p->fst = irc;
+                p->snd = ctx;
+                query_add(irc, NULL, s, yes_forget_context, NULL, p);
                 g_free(s);
+        }
 …
+}
 void yes_keygen(gpointer w, void *data)
+void yes_keygen(void *data)
+{
         account_t *acc = (account_t *)data;

protocols/jabber/Makefile

r9730d72	r6738a67
10	10
11	11	# [SH] Program variables
12		objects = conference.o io.o iq.o jabber.o jabber_util.o message.o presence.o sasl.o ~~xmltree.o~~
	12	objects = conference.o io.o iq.o jabber.o jabber_util.o message.o presence.o sasl.o
13	13
14	14	CFLAGS += -Wall

protocols/jabber/io.c

-                      r9730d72
+                      r6738a67
+        }
+        /* EAGAIN/etc or a successful read. */
+        return TRUE;
+        if( ssl_pending( jd->ssl ) )
+                /* OpenSSL empties the TCP buffers completely but may keep some
+                   data in its internap buffers. select() won't see that, but
+                   ssl_pending() does. */
+                return jabber_read_callback( data, fd, cond );
+        else
+                return TRUE;
+}
 …
            from the server too. */
         xt_free( jd->xt );      /* In case we're RE-starting. */
+        jd->xt = xt_new( ic );
+        jd->xt->handlers = (struct xt_handler_entry*) jabber_handlers;
+        jd->xt = xt_new( jabber_handlers, ic );
         if( jd->r_inpa <= 0 )

protocols/jabber/jabber.c

-                      r9730d72
+                      r6738a67
 #include "jabber.h"
 #include "md5.h"
-#include "base64.h"
 GSList *jabber_connections;
+/* First enty is the default */
+static const int jabber_port_list[] = {
+,
+,
+,
+,
+,
+,
+,
+,
+,
+,
+,
+,
+};
 static void jabber_init( account_t *acc )
+{
         set_t *s;
+        s = set_add( &acc->set, "port", JABBER_PORT_DEFAULT, set_eval_int, acc );
+        char str[16];
+        g_snprintf( str, sizeof( str ), "%d", jabber_port_list[0] );
+        s = set_add( &acc->set, "port", str, set_eval_int, acc );
         s->flags |= ACC_SET_OFFLINE_ONLY;
 …
         struct ns_srv_reply *srv = NULL;
         char *connect_to, *s;
+        int i;
         /* For now this is needed in the _connected() handlers if using
 …
         imcb_log( ic, "Connecting" );
+        if( set_getint( &acc->set, "port" ) < JABBER_PORT_MIN ||
+            set_getint( &acc->set, "port" ) > JABBER_PORT_MAX )
+        {
+                imcb_log( ic, "Incorrect port number, must be in the %d-%d range",
+                               JABBER_PORT_MIN, JABBER_PORT_MAX );
+        for( i = 0; jabber_port_list[i] > 0; i ++ )
+                if( set_getint( &acc->set, "port" ) == jabber_port_list[i] )
+                        break;
+        if( jabber_port_list[i] == 0 )
+        {
+                imcb_log( ic, "Illegal port number" );
                 imc_logout( ic, FALSE );
                 return;
 …
+}
+/* This generates an unfinished md5_state_t variable. Every time we generate
+   an ID, we finish the state by adding a sequence number and take the hash. */
 static void jabber_generate_id_hash( struct jabber_data *jd )
+{
+        md5_state_t id_hash;
+        md5_byte_t binbuf[16];
+        md5_byte_t binbuf[4];
         char *s;
         md5_init( &id_hash );
         md5_append( &id_hash, (unsigned char *) jd->username, strlen( jd->username ) );
         md5_append( &id_hash, (unsigned char *) jd->server, strlen( jd->server ) );
+        md5_init( &jd->cached_id_prefix );
+        md5_append( &jd->cached_id_prefix, (unsigned char *) jd->username, strlen( jd->username ) );
+        md5_append( &jd->cached_id_prefix, (unsigned char *) jd->server, strlen( jd->server ) );
         s = set_getstr( &jd->ic->acc->set, "resource" );
+        md5_append( &id_hash, (unsigned char *) s, strlen( s ) );
+        random_bytes( binbuf, 16 );
+        md5_append( &id_hash, binbuf, 16 );
+        md5_finish( &id_hash, binbuf );
+        s = base64_encode( binbuf, 9 );
+        jd->cached_id_prefix = g_strdup_printf( "%s%s", JABBER_CACHED_ID, s );
+        g_free( s );
+        md5_append( &jd->cached_id_prefix, (unsigned char *) s, strlen( s ) );
+        random_bytes( binbuf, 4 );
+        md5_append( &jd->cached_id_prefix, binbuf, 4 );
+}

protocols/jabber/jabber.h

-                      r9730d72
+                      r6738a67
         char *away_message;
         char *cached_id_prefix;
+        md5_state_t cached_id_prefix;
         GHashTable *node_cache;
         GHashTable *buddies;
 …
 #define JABBER_XMLCONSOLE_HANDLE "xmlconsole"
-#define JABBER_PORT_DEFAULT "5222"
-#define JABBER_PORT_MIN 5220
-#define JABBER_PORT_MAX 5229
 /* Prefixes to use for packet IDs (mainly for IQ packets ATM). Usually the

protocols/jabber/jabber_util.c

-                      r9730d72
+                      r6738a67
 #include "jabber.h"
+#include "md5.h"
+#include "base64.h"
 static unsigned int next_id = 1;
 …
         struct jabber_data *jd = ic->proto_data;
         struct jabber_cache_entry *entry = g_new0( struct jabber_cache_entry, 1 );
+        char *id;
+        id = g_strdup_printf( "%s%05x", jd->cached_id_prefix, ( next_id++ ) & 0xfffff );
+        md5_state_t id_hash;
+        md5_byte_t id_sum[16];
+        char *id, *asc_hash;
+        next_id ++;
+        id_hash = jd->cached_id_prefix;
+        md5_append( &id_hash, (md5_byte_t*) &next_id, sizeof( next_id ) );
+        md5_finish( &id_hash, id_sum );
+        asc_hash = base64_encode( id_sum, 12 );
+        id = g_strdup_printf( "%s%s", JABBER_CACHED_ID, asc_hash );
         xt_add_attr( node, "id", id );
         g_free( id );
+        g_free( asc_hash );
         entry->node = node;
 …
         if( ( s = xt_find_attr( node, "id" ) ) == NULL ||
             strncmp( s, jd->cached_id_prefix, strlen( jd->cached_id_prefix ) ) != 0 )
+            strncmp( s, JABBER_CACHED_ID, strlen( JABBER_CACHED_ID ) ) != 0 )
+        {
                 /* Silently ignore it, without an ID (or a non-cache
 …
         if( entry == NULL )
+        {
+                /*
+                There's no longer an easy way to see if we generated this
+                one or someone else, and there's a ten-minute timeout anyway,
+                so meh.
                 imcb_log( ic, "Warning: Received %s-%s packet with unknown/expired ID %s!",
                               node->name, xt_find_attr( node, "type" ) ? : "(no type)", s );
+                */
+        }
         else if( entry->func )
 …
 };
+static void jabber_buddy_ask_yes( gpointer w, struct jabber_buddy_ask_data *bla )
+{
+static void jabber_buddy_ask_yes( void *data )
+{
+        struct jabber_buddy_ask_data *bla = data;
         presence_send_request( bla->ic, bla->handle, "subscribed" );
 …
+}
+static void jabber_buddy_ask_no( gpointer w, struct jabber_buddy_ask_data *bla )
+{
+static void jabber_buddy_ask_no( void *data )
+{
+        struct jabber_buddy_ask_data *bla = data;
         presence_send_request( bla->ic, bla->handle, "subscribed" );
 …
         len = strlen( orig );
         new = g_new( char, len + 1 );
+        for( i = 0; i < len; i ++ )
+        /* So it turns out the /resource part is case sensitive. Yeah, and
+           it's Unicode but feck Unicode. :-P So stop once we see a slash. */
+        for( i = 0; i < len && orig[i] != '/' ; i ++ )
                 new[i] = tolower( orig[i] );
+        for( ; orig[i]; i ++ )
+                new[i] = orig[i];
         new[i] = 0;
 …
+                {
                         /* Check for dupes. */
                         if( g_strcasecmp( bi->resource, s + 1 ) == 0 )
+                        if( strcmp( bi->resource, s + 1 ) == 0 )
+                        {
                                 *s = '/';
 …
         if( ( s = strchr( jid, '/' ) ) )
+        {
                 int none_found = 0;
+                int bare_exists = 0;
                 *s = 0;
 …
                         /* See if there's an exact match. */
                         for( ; bud; bud = bud->next )
                                 if( g_strcasecmp( bud->resource, s + 1 ) == 0 )
+                                if( strcmp( bud->resource, s + 1 ) == 0 )
                                         break;
+                }
                 else
+                {
+                        /* This hack is there to make sure that O_CREAT will
+                           work if there's already another resouce present
+                           for this JID, even if it's an unknown buddy. This
+                           is done to handle conferences properly. */
+                        none_found = 1;
+                        /* TODO(wilmer): Find out what I was thinking when I
+                           wrote this??? And then fix it. This makes me sad... */
+                }
+                if( bud == NULL && ( flags & GET_BUDDY_CREAT ) && ( imcb_find_buddy( ic, jid ) || !none_found ) )
+                        /* This variable tells the if down here that the bare
+                           JID already exists and we should feel free to add
+                           more resources, if the caller asked for that. */
+                        bare_exists = 1;
+                }
+                if( bud == NULL && ( flags & GET_BUDDY_CREAT ) &&
+                    ( !bare_exists || imcb_find_buddy( ic, jid ) ) )
+                {
                         *s = '/';
 …
                         /* We want an exact match, so in thise case there shouldn't be a /resource. */
                         return NULL;
                 else if( ( bud->resource == NULL || bud->next == NULL ) )
+                else if( bud->resource == NULL || bud->next == NULL )
                         /* No need for selection if there's only one option. */
                         return bud;
 …
                    matches), removing it is simple. (And the hash reference
                    should be removed too!) */
+                if( bud->next == NULL && ( ( s == NULL || bud->resource == NULL ) || g_strcasecmp( bud->resource, s + 1 ) == 0 ) )
+                if( bud->next == NULL &&
+                    ( ( s == NULL && bud->resource == NULL ) ||
+                      ( bud->resource && s && strcmp( bud->resource, s + 1 ) == 0 ) ) )
+                {
                         g_hash_table_remove( jd->buddies, bud->bare_jid );
 …
+                {
                         for( bi = bud, prev = NULL; bi; bi = (prev=bi)->next )
                                 if( g_strcasecmp( bi->resource, s + 1 ) == 0 )
+                                if( strcmp( bi->resource, s + 1 ) == 0 )
                                         break;

protocols/jabber/message.c

-                      r9730d72
+                      r6738a67
+        {
                 GString *fullmsg = g_string_new( "" );
+                for( c = node->children; ( c = xt_find_node( c, "x" ) ); c = c->next )
+                {
+                        char *ns = xt_find_attr( c, "xmlns" ), *room;
+                        struct xt_node *inv, *reason;
+                        if( strcmp( ns, XMLNS_MUC_USER ) == 0 &&
+                            ( inv = xt_find_node( c->children, "invite" ) ) )
+                        {
+                                room = from;
+                                from = xt_find_attr( inv, "from" ) ? : from;
+                                g_string_append_printf( fullmsg, "<< \002BitlBee\002 - Invitation to chatroom %s >>\n", room );
+                                if( ( reason = xt_find_node( inv->children, "reason" ) ) && reason->text_len > 0 )
+                                        g_string_append( fullmsg, reason->text );
+                        }
+                }
                 if( ( s = strchr( from, '/' ) ) )

protocols/msn/msn.h

r9730d72	r6738a67
29	29	#define GROUPCHAT_SWITCHBOARD_MESSAGE "\r\r\rME WANT TALK TO MANY PEOPLE\r\r\r"
30	30
31		#ifdef DEBUG
	31	#ifdef DEBUG_MSN
32	32	#define debug( text... ) imcb_log( ic, text );
33	33	#else

protocols/msn/msn_util.c

-                      r9730d72
+                      r6738a67
 };
+static void msn_buddy_ask_yes( gpointer w, struct msn_buddy_ask_data *bla )
+{
+static void msn_buddy_ask_yes( void *data )
+{
+        struct msn_buddy_ask_data *bla = data;
         msn_buddy_list_add( bla->ic, "AL", bla->handle, bla->realname );
 …
+}
+static void msn_buddy_ask_no( gpointer w, struct msn_buddy_ask_data *bla )
+{
+static void msn_buddy_ask_no( void *data )
+{
+        struct msn_buddy_ask_data *bla = data;
         msn_buddy_list_add( bla->ic, "BL", bla->handle, bla->realname );

protocols/msn/ns.c

-                      r9730d72
+                      r6738a67
 static int msn_ns_message( gpointer data, char *msg, int msglen, char **cmd, int num_parts );
 static void msn_auth_got_passport_id( struct passport_reply *rep );
+static void msn_auth_got_passport_token( struct msn_auth_data *mad );
 gboolean msn_ns_connected( gpointer data, gint source, b_input_condition cond )
 …
                         debug( "Connecting to a new switchboard with key %s", cmd[5] );
+                        sb = msn_sb_create( ic, server, port, cmd[5], MSN_SB_NEW );
+                        if( ( sb = msn_sb_create( ic, server, port, cmd[5], MSN_SB_NEW ) ) == NULL )
+                        {
+                                /* Although this isn't strictly fatal for the NS connection, it's
+                                   definitely something serious (we ran out of file descriptors?). */
+                                imcb_error( ic, "Could not create new switchboard" );
+                                imc_logout( ic, TRUE );
+                                return( 0 );
+                        }
                         if( md->msgq )
 …
+                {
                         /* Time for some Passport black magic... */
                         if( !passport_get_id( msn_auth_got_passport_id, ic, ic->acc->user, ic->acc->pass, cmd[4] ) )
+                        if( !passport_get_token( msn_auth_got_passport_token, ic, ic->acc->user, ic->acc->pass, cmd[4] ) )
+                        {
                                 imcb_error( ic, "Error while contacting Passport server" );
 …
                 if( num_parts == 5 )
+                {
+                        int i, groupcount;
+                        groupcount = atoi( cmd[4] );
+                        if( groupcount > 0 )
+                        {
+                                /* valgrind says this is leaking memory, I'm guessing
+                                   that this happens during server redirects. */
+                                if( md->grouplist )
+                                {
+                                        for( i = 0; i < md->groupcount; i ++ )
+                                                g_free( md->grouplist[i] );
+                                        g_free( md->grouplist );
+                                }
+                                md->groupcount = groupcount;
+                                md->grouplist = g_new0( char *, md->groupcount );
+                        }
                         md->buddycount = atoi( cmd[3] );
-                        md->groupcount = atoi( cmd[4] );
-                        if( md->groupcount > 0 )
-                                md->grouplist = g_new0( char *, md->groupcount );
                         if( !*cmd[3] || md->buddycount == 0 )
                                 msn_logged_in( ic );
 …
                 debug( "Got a call from %s (session %d). Key = %s", cmd[5], session, cmd[4] );
+                sb = msn_sb_create( ic, server, port, cmd[4], session );
+                sb->who = g_strdup( cmd[5] );
+                if( ( sb = msn_sb_create( ic, server, port, cmd[4], session ) ) == NULL )
+                {
+                        /* Although this isn't strictly fatal for the NS connection, it's
+                           definitely something serious (we ran out of file descriptors?). */
+                        imcb_error( ic, "Could not create new switchboard" );
+                        imc_logout( ic, TRUE );
+                        return( 0 );
+                }
+                else
+                {
+                        sb->who = g_strdup( cmd[5] );
+                }
+        }
         else if( strcmp( cmd[0], "ADD" ) == 0 )
 …
                                         imcb_log( ic, "INBOX contains %s new messages, plus %s messages in other folders.", inbox, folders );
+                                }
+                                g_free( inbox );
+                                g_free( folders );
+                        }
                         else if( g_strncasecmp( ct, "text/x-msmsgsemailnotification", 30 ) == 0 )
 …
+}
 static void msn_auth_got_passport_id( struct passport_reply *rep )
+static void msn_auth_got_passport_token( struct msn_auth_data *mad )
+{
+        struct im_connection *ic = rep->data;
+        struct msn_data *md = ic->proto_data;
+        char *key = rep->result;
+        char buf[1024];
+        if( key == NULL )
+        {
+                imcb_error( ic, "Error during Passport authentication (%s)",
+                               rep->error_string ? rep->error_string : "Unknown error" );
+        struct im_connection *ic = mad->data;
+        struct msn_data *md;
+        /* Dead connection? */
+        if( g_slist_find( msn_connections, ic ) == NULL )
+                return;
+        md = ic->proto_data;
+        if( mad->token )
+        {
+                char buf[1024];
+                g_snprintf( buf, sizeof( buf ), "USR %d TWN S %s\r\n", ++md->trId, mad->token );
+                msn_write( ic, buf, strlen( buf ) );
+        }
+        else
+        {
+                imcb_error( ic, "Error during Passport authentication: %s", mad->error );
                 imc_logout( ic, TRUE );
+        }
-        else
+        {
-                g_snprintf( buf, sizeof( buf ), "USR %d TWN S %s\r\n", ++md->trId, key );
-                msn_write( ic, buf, strlen( buf ) );
+        }
+}

protocols/msn/passport.c

-                      r9730d72
+                      r6738a67
 /* passport.c
+/** passport.c
+ *
+ * Functions to login to microsoft passport service for Messenger
+ * Copyright (C) 2004 Wouter Paesen <wouter@blue-gate.be>
+ * Copyright (C) 2004 Wilmer van der Gaast <wilmer@gaast.net>
+ * Functions to login to Microsoft Passport service for Messenger
+ * Copyright (C) 2004-2008 Wilmer van der Gaast <wilmer@gaast.net>
+ *
  * This program is free software; you can redistribute it and/or modify
 …
 #include "msn.h"
 #include "bitlbee.h"
+#include "url.h"
+#include "misc.h"
+#include "xmltree.h"
 #include <ctype.h>
 #include <errno.h>
+#define MSN_BUF_LEN 8192
+static int passport_get_token_real( struct msn_auth_data *mad );
+static void passport_get_token_ready( struct http_request *req );
+static char *prd_cached = NULL;
+static int passport_get_id_real( gpointer func, gpointer data, char *header );
+static void passport_get_id_ready( struct http_request *req );
+static int passport_retrieve_dalogin( gpointer data, gpointer func, char *header );
+static void passport_retrieve_dalogin_ready( struct http_request *req );
+static char *passport_create_header( char *cookie, char *email, char *pwd );
+static void destroy_reply( struct passport_reply *rep );
+int passport_get_id( gpointer func, gpointer data, char *username, char *password, char *cookie )
+int passport_get_token( gpointer func, gpointer data, char *username, char *password, char *cookie )
+{
+        char *header = passport_create_header( cookie, username, password );
+        struct msn_auth_data *mad = g_new0( struct msn_auth_data, 1 );
+        int i;
+        if( prd_cached == NULL )
+                return passport_retrieve_dalogin( func, data, header );
+        else
+                return passport_get_id_real( func, data, header );
+        mad->username = g_strdup( username );
+        mad->password = g_strdup( password );
+        mad->cookie = g_strdup( cookie );
+        mad->callback = func;
+        mad->data = data;
+        mad->url = g_strdup( SOAP_AUTHENTICATION_URL );
+        mad->ttl = 3; /* Max. # of redirects. */
+        /* HTTP-escape stuff and s/,/&/ */
+        http_decode( mad->cookie );
+        for( i = 0; mad->cookie[i]; i ++ )
+                if( mad->cookie[i] == ',' )
+                        mad->cookie[i] = '&';
+        /* Microsoft doesn't allow password longer than 16 chars and silently
+           fails authentication if you give the "full version" of your passwd. */
+        if( strlen( mad->password ) > MAX_PASSPORT_PWLEN )
+                mad->password[MAX_PASSPORT_PWLEN] = 0;
+        return passport_get_token_real( mad );
+}
 static int passport_get_id_real( gpointer func, gpointer data, char *header )
+static int passport_get_token_real( struct msn_auth_data *mad )
+{
+        struct passport_reply *rep;
+        char *server, *dummy, *reqs;
+        char *post_payload, *post_request;
         struct http_request *req;
+        url_t url;
+        rep = g_new0( struct passport_reply, 1 );
+        rep->data = data;
+        rep->func = func;
+        rep->header = header;
+        url_set( &url, mad->url );
+        server = g_strdup( prd_cached );
+        dummy = strchr( server, '/' );
+        post_payload = g_markup_printf_escaped( SOAP_AUTHENTICATION_PAYLOAD,
+                                                mad->username,
+                                                mad->password,
+                                                mad->cookie );
+        if( dummy == NULL )
+        {
+                destroy_reply( rep );
+                return( 0 );
+        }
+        post_request = g_strdup_printf( SOAP_AUTHENTICATION_REQUEST,
+                                        url.file, url.host,
+                                        (int) strlen( post_payload ),
+                                        post_payload );
+        req = http_dorequest( url.host, url.port, 1, post_request,
+                              passport_get_token_ready, mad );
+        reqs = g_strdup_printf( "GET %s HTTP/1.0\r\n%s\r\n\r\n", dummy, header );
+        g_free( post_request );
+        g_free( post_payload );
+        *dummy = 0;
+        req = http_dorequest( server, 443, 1, reqs, passport_get_id_ready, rep );
+        g_free( server );
+        g_free( reqs );
+        if( req == NULL )
+                destroy_reply( rep );
+        return( req != NULL );
+        return req != NULL;
+}
+static void passport_get_id_ready( struct http_request *req )
+static xt_status passport_xt_extract_token( struct xt_node *node, gpointer data );
+static xt_status passport_xt_handle_fault( struct xt_node *node, gpointer data );
+static const struct xt_handler_entry passport_xt_handlers[] = {
+        { "wsse:BinarySecurityToken", "wst:RequestedSecurityToken", passport_xt_extract_token },
+        { "S:Fault",                  "S:Envelope",                 passport_xt_handle_fault  },
+        { NULL,                       NULL,                         NULL                      }
+};
+static void passport_get_token_ready( struct http_request *req )
+{
+        struct passport_reply *rep = req->data;
+        struct msn_auth_data *mad = req->data;
+        struct xt_parser *parser;
+        if( !g_slist_find( msn_connections, rep->data ) )
+        g_free( mad->url );
+        g_free( mad->error );
+        mad->url = mad->error = NULL;
+        if( req->status_code == 200 )
+        {
+                destroy_reply( rep );
+                return;
+        }
+        if( req->finished && req->reply_headers && req->status_code == 200 )
+        {
+                char *dummy;
+                if( ( dummy = strstr( req->reply_headers, "from-PP='" ) ) )
+                {
+                        char *responseend;
+                        dummy += strlen( "from-PP='" );
+                        responseend = strchr( dummy, '\'' );
+                        if( responseend )
+                                *responseend = 0;
+                        rep->result = g_strdup( dummy );
+                }
+                else
+                {
+                        rep->error_string = g_strdup( "Could not parse Passport server response" );
+                }
+                parser = xt_new( passport_xt_handlers, mad );
+                xt_feed( parser, req->reply_body, req->body_size );
+                xt_handle( parser, NULL, -1 );
+                xt_free( parser );
+        }
         else
+        {
                 rep->error_string = g_strdup_printf( "HTTP error: %s",
                                       req->status_string ? req->status_string : "Unknown error" );
+                mad->error = g_strdup_printf( "HTTP error %d (%s)", req->status_code,
+                                              req->status_string ? req->status_string : "unknown" );
+        }
+        rep->func( rep );
+        destroy_reply( rep );
+        if( mad->error == NULL && mad->token == NULL )
+                mad->error = g_strdup( "Could not parse Passport server response" );
+        if( mad->url && mad->token == NULL )
+        {
+                passport_get_token_real( mad );
+        }
+        else
+        {
+                mad->callback( mad );
+                g_free( mad->url );
+                g_free( mad->username );
+                g_free( mad->password );
+                g_free( mad->cookie );
+                g_free( mad->token );
+                g_free( mad->error );
+                g_free( mad );
+        }
+}
 static char *passport_create_header( char *cookie, char *email, char *pwd )
+static xt_status passport_xt_extract_token( struct xt_node *node, gpointer data )
+{
+        char *buffer;
+        char *currenttoken;
+        char *email_enc, *pwd_enc;
+        struct msn_auth_data *mad = data;
+        char *s;
+        currenttoken = strstr( cookie, "lc=" );
+        if( currenttoken == NULL )
+                return NULL;
+        if( ( s = xt_find_attr( node, "Id" ) ) && strcmp( s, "PPToken1" ) == 0 )
+                mad->token = g_memdup( node->text, node->text_len + 1 );
+        email_enc = g_new0( char, strlen( email ) * 3 + 1 );
+        strcpy( email_enc, email );
+        http_encode( email_enc );
+        pwd_enc = g_new0( char, strlen( pwd ) * 3 + 1 );
+        strcpy( pwd_enc, pwd );
+        http_encode( pwd_enc );
+        buffer = g_strdup_printf( "Authorization: Passport1.4 OrgVerb=GET,"
+                                  "OrgURL=http%%3A%%2F%%2Fmessenger%%2Emsn%%2Ecom,"
+                                  "sign-in=%s,pwd=%s,%s", email_enc, pwd_enc,
+                                  currenttoken );
+        g_free( email_enc );
+        g_free( pwd_enc );
+        return buffer;
+        return XT_HANDLED;
+}
 static int passport_retrieve_dalogin( gpointer func, gpointer data, char *header )
+static xt_status passport_xt_handle_fault( struct xt_node *node, gpointer data )
+{
+        struct passport_reply *rep = g_new0( struct passport_reply, 1 );
+        struct http_request *req;
+        struct msn_auth_data *mad = data;
+        struct xt_node *code = xt_find_node( node->children, "faultcode" );
+        struct xt_node *string = xt_find_node( node->children, "faultstring" );
+        struct xt_node *redirect = xt_find_node( node->children, "psf:redirectUrl" );
+        rep->data = data;
+        rep->func = func;
+        rep->header = header;
+        if( redirect && redirect->text_len && mad->ttl-- > 0 )
+                mad->url = g_memdup( redirect->text, redirect->text_len + 1 );
+        req = http_dorequest_url( "https://nexus.passport.com/rdr/pprdr.asp", passport_retrieve_dalogin_ready, rep );
+        if( code == NULL || code->text_len == 0 )
+                mad->error = g_strdup( "Unknown error" );
+        else
+                mad->error = g_strdup_printf( "%s (%s)", code->text, string && string->text_len ?
+                                              string->text : "no description available" );
+        if( !req )
+                destroy_reply( rep );
+        return( req != NULL );
+        return XT_HANDLED;
+}
-static void passport_retrieve_dalogin_ready( struct http_request *req )
+{
-        struct passport_reply *rep = req->data;
-        char *dalogin;
-        char *urlend;
-        if( !g_slist_find( msn_connections, rep->data ) )
+        {
-                destroy_reply( rep );
-                return;
+        }
-        if( !req->finished || !req->reply_headers || req->status_code != 200 )
+        {
-                rep->error_string = g_strdup_printf( "HTTP error while fetching DALogin: %s",
-                                        req->status_string ? req->status_string : "Unknown error" );
-                goto failure;
+        }
-        dalogin = strstr( req->reply_headers, "DALogin=" );
-        if( !dalogin )
+        {
-                rep->error_string = g_strdup( "Parse error while fetching DALogin" );
-                goto failure;
+        }
-        dalogin += strlen( "DALogin=" );
-        urlend = strchr( dalogin, ',' );
-        if( urlend )
-                *urlend = 0;
-        /* strip the http(s):// part from the url */
-        urlend = strstr( urlend, "://" );
-        if( urlend )
-                dalogin = urlend + strlen( "://" );
-        if( prd_cached == NULL )
-                prd_cached = g_strdup( dalogin );
-        if( passport_get_id_real( rep->func, rep->data, rep->header ) )
+        {
-                rep->header = NULL;
-                destroy_reply( rep );
-                return;
+        }
-failure:
-        rep->func( rep );
-        destroy_reply( rep );
+}
-static void destroy_reply( struct passport_reply *rep )
+{
-        g_free( rep->result );
-        g_free( rep->header );
-        g_free( rep->error_string );
-        g_free( rep );
+}

protocols/msn/passport.h

-                      r9730d72
+                      r6738a67
-#ifndef __PASSPORT_H__
-#define __PASSPORT_H__
 /* passport.h
+ *
+ * Functions to login to Microsoft Passport Service for Messenger
+ * Copyright (C) 2004 Wouter Paesen <wouter@blue-gate.be>,
+ *                    Wilmer van der Gaast <wilmer@gaast.net>
+ * Functions to login to Microsoft Passport service for Messenger
+ * Copyright (C) 2004-2008 Wilmer van der Gaast <wilmer@gaast.net>
+ *
  * This program is free software; you can redistribute it and/or modify
 …
  * You should have received a copy of the GNU General Public License
  * along with this program; if not, write to the Free Software
  *  Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
  */
+/* Thanks to http://msnpiki.msnfanatic.com/index.php/MSNP13:SOAPTweener
+   for the specs! */
+#ifndef __PASSPORT_H__
+#define __PASSPORT_H__
 #include <stdio.h>
 …
 #include "nogaim.h"
+struct passport_reply
+#define MAX_PASSPORT_PWLEN 16
+struct msn_auth_data
+{
+        void (*func)( struct passport_reply * );
+        void *data;
+        char *result;
+        char *header;
+        char *error_string;
+        char *url;
+        int ttl;
+        char *username;
+        char *password;
+        char *cookie;
+        /* The end result, the only thing we'll really be interested in
+           once finished. */
+        char *token;
+        char *error; /* Yeah, or that... */
+        void (*callback)( struct msn_auth_data *mad );
+        gpointer data;
 };
+int passport_get_id( gpointer func, gpointer data, char *username, char *password, char *cookie );
+#define SOAP_AUTHENTICATION_URL "https://loginnet.passport.com/RST.srf"
+#define SOAP_AUTHENTICATION_REQUEST \
+"POST %s HTTP/1.0\r\n" \
+"Accept: text/*\r\n" \
+"User-Agent: BitlBee " BITLBEE_VERSION "\r\n" \
+"Host: %s\r\n" \
+"Content-Length: %d\r\n" \
+"Cache-Control: no-cache\r\n" \
+"\r\n" \
+"%s"
+#define SOAP_AUTHENTICATION_PAYLOAD \
+"<?xml version=\"1.0\" encoding=\"UTF-8\"?>" \
+"<Envelope xmlns=\"http://schemas.xmlsoap.org/soap/envelope/\" xmlns:wsse=\"http://schemas.xmlsoap.org/ws/2003/06/secext\" xmlns:saml=\"urn:oasis:names:tc:SAML:1.0:assertion\" xmlns:wsp=\"http://schemas.xmlsoap.org/ws/2002/12/policy\" xmlns:wsu=\"http://docs.oasis-open.org/wss/2004/01/oasis-200401-wss-wssecurity-utility-1.0.xsd\" xmlns:wsa=\"http://schemas.xmlsoap.org/ws/2004/03/addressing\" xmlns:wssc=\"http://schemas.xmlsoap.org/ws/2004/04/sc\" xmlns:wst=\"http://schemas.xmlsoap.org/ws/2004/04/trust\">" \
+  "<Header>" \
+    "<ps:AuthInfo xmlns:ps=\"http://schemas.microsoft.com/Passport/SoapServices/PPCRL\" Id=\"PPAuthInfo\">" \
+      "<ps:HostingApp>{7108E71A-9926-4FCB-BCC9-9A9D3F32E423}</ps:HostingApp>" \
+      "<ps:BinaryVersion>4</ps:BinaryVersion>" \
+      "<ps:UIVersion>1</ps:UIVersion>" \
+      "<ps:Cookies></ps:Cookies>" \
+      "<ps:RequestParams>AQAAAAIAAABsYwQAAAAzMDg0</ps:RequestParams>" \
+    "</ps:AuthInfo>" \
+    "<wsse:Security>" \
+       "<wsse:UsernameToken Id=\"user\">" \
+         "<wsse:Username>%s</wsse:Username>" \
+         "<wsse:Password>%s</wsse:Password>" \
+       "</wsse:UsernameToken>" \
+    "</wsse:Security>" \
+  "</Header>" \
+  "<Body>" \
+    "<ps:RequestMultipleSecurityTokens xmlns:ps=\"http://schemas.microsoft.com/Passport/SoapServices/PPCRL\" Id=\"RSTS\">" \
+      "<wst:RequestSecurityToken Id=\"RST0\">" \
+        "<wst:RequestType>http://schemas.xmlsoap.org/ws/2004/04/security/trust/Issue</wst:RequestType>" \
+        "<wsp:AppliesTo>" \
+          "<wsa:EndpointReference>" \
+            "<wsa:Address>http://Passport.NET/tb</wsa:Address>" \
+          "</wsa:EndpointReference>" \
+        "</wsp:AppliesTo>" \
+      "</wst:RequestSecurityToken>" \
+      "<wst:RequestSecurityToken Id=\"RST1\">" \
+       "<wst:RequestType>http://schemas.xmlsoap.org/ws/2004/04/security/trust/Issue</wst:RequestType>" \
+        "<wsp:AppliesTo>" \
+          "<wsa:EndpointReference>" \
+            "<wsa:Address>messenger.msn.com</wsa:Address>" \
+          "</wsa:EndpointReference>" \
+        "</wsp:AppliesTo>" \
+        "<wsse:PolicyReference URI=\"?%s\"></wsse:PolicyReference>" \
+      "</wst:RequestSecurityToken>" \
+    "</ps:RequestMultipleSecurityTokens>" \
+  "</Body>" \
+"</Envelope>"
+int passport_get_token( gpointer func, gpointer data, char *username, char *password, char *cookie );
 #endif /* __PASSPORT_H__ */

protocols/nogaim.c

-                      r9730d72
+                      r6738a67
 /* dialogs.c */
+void imcb_ask( struct im_connection *ic, char *msg, void *data, void *doit, void *dont )
+void imcb_ask( struct im_connection *ic, char *msg, void *data,
+               query_callback doit, query_callback dont )
+{
         query_add( ic->irc, ic, msg, doit, dont, data );
 …
 };
 void show_got_added_no( gpointer w, struct show_got_added_data *data )
+{
         g_free( data->handle );
+void show_got_added_no( void *data )
+{
+        g_free( ((struct show_got_added_data*)data)->handle );
         g_free( data );
+}
+void show_got_added_yes( gpointer w, struct show_got_added_data *data )
+{
+        data->ic->acc->prpl->add_buddy( data->ic, data->handle, NULL );
+        /* imcb_add_buddy( data->ic, NULL, data->handle, data->handle ); */
+        return show_got_added_no( w, data );
+void show_got_added_yes( void *data )
+{
+        struct show_got_added_data *sga = data;
+        sga->ic->acc->prpl->add_buddy( sga->ic, sga->handle, NULL );
+        /* imcb_add_buddy( sga->ic, NULL, sga->handle, sga->handle ); */
+        return show_got_added_no( data );
+}

protocols/nogaim.h

-                      r9730d72
+                      r6738a67
 #include "account.h"
 #include "proxy.h"
+#include "query.h"
 #include "md5.h"
-#define BUF_LEN MSG_LEN
-#define BUF_LONG ( BUF_LEN * 2 )
-#define MSG_LEN 2048
-#define BUF_LEN MSG_LEN
 #define BUDDY_ALIAS_MAXLEN 388   /* because MSN names can be 387 characters */
 …
  * - 'doit' or 'dont' will be called depending of the answer of the user.
  */
 G_MODULE_EXPORT void imcb_ask( struct im_connection *ic, char *msg, void *data, void *doit, void *dont );
+G_MODULE_EXPORT void imcb_ask( struct im_connection *ic, char *msg, void *data, query_callback doit, query_callback dont );
 G_MODULE_EXPORT void imcb_ask_add( struct im_connection *ic, char *handle, const char *realname );

protocols/oscar/oscar.c

-                      r9730d72
+                      r6738a67
 #define OSCAR_GROUP "Friends"
+#define BUF_LEN 2048
+#define BUF_LONG ( BUF_LEN * 2 )
 /* Don't know if support for UTF8 is really working. For now it's UTF16 here.
 …
 };
 static int msgerrreasonlen = 25;
+/* Hurray, this function is NOT thread-safe \o/ */
+static char *normalize(const char *s)
+{
+        static char buf[BUF_LEN];
+        char *t, *u;
+        int x = 0;
+        g_return_val_if_fail((s != NULL), NULL);
+        u = t = g_strdup(s);
+        strcpy(t, s);
+        g_strdown(t);
+        while (*t && (x < BUF_LEN - 1)) {
+                if (*t != ' ' && *t != '!') {
+                        buf[x] = *t;
+                        x++;
+                }
+                t++;
+        }
+        buf[x] = '\0';
+        g_free(u);
+        return buf;
+}
 static gboolean oscar_callback(gpointer data, gint source,
 …
+        }
+        tmp = g_strdup(normalize(ic->acc->user));
+        if (!strcmp(tmp, normalize(info->sn)))
+        if (!aim_sncmp(ic->acc->user, info->sn))
                 g_snprintf(ic->displayname, sizeof(ic->displayname), "%s", info->sn);
+        g_free(tmp);
+        imcb_buddy_status(ic, info->sn, flags, state_string, NULL);
+        /* imcb_buddy_times(ic, info->sn, signon, time_idle); */
+        tmp = normalize(info->sn);
+        imcb_buddy_status(ic, tmp, flags, state_string, NULL);
+        /* imcb_buddy_times(ic, tmp, signon, time_idle); */
         return 1;
 …
         va_end(ap);
         imcb_buddy_status(ic, info->sn, 0, NULL, NULL );
+        imcb_buddy_status(ic, normalize(info->sn), 0, NULL, NULL );
         return 1;
 …
         strip_linefeed(tmp);
         imcb_buddy_msg(ic, userinfo->sn, tmp, flags, 0);
+        imcb_buddy_msg(ic, normalize(userinfo->sn), tmp, flags, 0);
         g_free(tmp);
 …
+}
 void oscar_accept_chat(gpointer w, struct aim_chat_invitation * inv);
 void oscar_reject_chat(gpointer w, struct aim_chat_invitation * inv);
+void oscar_accept_chat(void *data);
+void oscar_reject_chat(void *data);
 static int incomingim_chan2(aim_session_t *sess, aim_conn_t *conn, aim_userinfo_t *userinfo, struct aim_incomingim_ch2_args *args) {
 …
+}
+static void gaim_icq_authgrant(gpointer w, struct icq_auth *data) {
+static void gaim_icq_authgrant(void *data_) {
+        struct icq_auth *data = data_;
         char *uin, message;
         struct oscar_data *od = (struct oscar_data *)data->ic->proto_data;
 …
+}
+static void gaim_icq_authdeny(gpointer w, struct icq_auth *data) {
+static void gaim_icq_authdeny(void *data_) {
+        struct icq_auth *data = data_;
         char *uin, *message;
         struct oscar_data *od = (struct oscar_data *)data->ic->proto_data;
 …
                         message = g_strdup(args->msg);
                         strip_linefeed(message);
                         imcb_buddy_msg(ic, uin, message, 0, 0);
+                        imcb_buddy_msg(ic, normalize(uin), message, 0, 0);
                         g_free(uin);
                         g_free(message);
 …
                         strip_linefeed(message);
                         imcb_buddy_msg(ic, uin, message, 0, 0);
+                        imcb_buddy_msg(ic, normalize(uin), message, 0, 0);
                         g_free(uin);
                         g_free(m);
 …
         for (i = 0; i < count; i++)
                 imcb_chat_add_buddy(c->cnv, info[i].sn);
+                imcb_chat_add_buddy(c->cnv, normalize(info[i].sn));
         return 1;
 …
         for (i = 0; i < count; i++)
                 imcb_chat_remove_buddy(c->cnv, info[i].sn, NULL);
+                imcb_chat_remove_buddy(c->cnv, normalize(info[i].sn), NULL);
         return 1;
 …
         tmp = g_malloc(BUF_LONG);
         g_snprintf(tmp, BUF_LONG, "%s", msg);
         imcb_chat_msg(ccon->cnv, info->sn, tmp, 0, 0);
+        imcb_chat_msg(ccon->cnv, normalize(info->sn), tmp, 0, 0);
         g_free(tmp);
 …
                         g_snprintf(sender, sizeof(sender), "%u", msg->sender);
                         strip_linefeed(dialog_msg);
                         imcb_buddy_msg(ic, sender, dialog_msg, 0, t);
+                        imcb_buddy_msg(ic, normalize(sender), dialog_msg, 0, t);
                         g_free(dialog_msg);
                 } break;
 …
                         strip_linefeed(dialog_msg);
                         imcb_buddy_msg(ic, sender, dialog_msg, 0, t);
+                        imcb_buddy_msg(ic, normalize(sender), dialog_msg, 0, t);
                         g_free(dialog_msg);
                         g_free(m);
 …
         struct aim_ssi_item *curitem;
         int tmp;
+        char *nrm;
         /* Add from server list to local list */
         tmp = 0;
         for (curitem=sess->ssi.items; curitem; curitem=curitem->next) {
+                nrm = curitem->name ? normalize(curitem->name) : NULL;
                 switch (curitem->type) {
                         case 0x0000: /* Buddy */
                                 if ((curitem->name) && (!imcb_find_buddy(ic, curitem->name))) {
+                                if ((curitem->name) && (!imcb_find_buddy(ic, nrm))) {
                                         char *realname = NULL;
 …
                                                     realname = aim_gettlv_str(curitem->data, 0x0131, 1);
                                         imcb_add_buddy(ic, curitem->name, NULL);
+                                        imcb_add_buddy(ic, nrm, NULL);
                                         if (realname) {
                                                 imcb_buddy_nick_hint(ic, curitem->name, realname);
                                                 imcb_rename_buddy(ic, curitem->name, realname);
+                                                imcb_buddy_nick_hint(ic, nrm, realname);
+                                                imcb_rename_buddy(ic, nrm, realname);
                                                 g_free(realname);
+                                        }
 …
                                         if (!list) {
                                                 char *name;
                                                 name = g_strdup(normalize(curitem->name));
+                                                name = g_strdup(nrm);
                                                 ic->permit = g_slist_append(ic->permit, name);
                                                 tmp++;
 …
                                         if (!list) {
                                                 char *name;
                                                 name = g_strdup(normalize(curitem->name));
+                                                name = g_strdup(nrm);
                                                 ic->deny = g_slist_append(ic->deny, name);
                                                 tmp++;
 …
                         if( st == 0x00 )
+                        {
                                 imcb_add_buddy( sess->aux_data, list, NULL );
+                                imcb_add_buddy( sess->aux_data, normalize(list), NULL );
+                        }
                         else if( st == 0x0E )
 …
         if(type2 == 0x0002) {
                 /* User is typing */
                 imcb_buddy_typing(ic, sn, OPT_TYPING);
+                imcb_buddy_typing(ic, normalize(sn), OPT_TYPING);
+        }
         else if (type2 == 0x0001) {
                 /* User has typed something, but is not actively typing (stale) */
                 imcb_buddy_typing(ic, sn, OPT_THINKING);
+                imcb_buddy_typing(ic, normalize(sn), OPT_THINKING);
+        }
         else {
                 /* User has stopped typing */
                 imcb_buddy_typing(ic, sn, 0);
+                imcb_buddy_typing(ic, normalize(sn), 0);
+        }
 …
+}
+void oscar_accept_chat(gpointer w, struct aim_chat_invitation * inv)
+{
+void oscar_accept_chat(void *data)
+{
+        struct aim_chat_invitation * inv = data;
         oscar_chat_join(inv->ic, inv->name, NULL, NULL);
         g_free(inv->name);
 …
+}
+void oscar_reject_chat(gpointer w, struct aim_chat_invitation * inv)
+{
+void oscar_reject_chat(void *data)
+{
+        struct aim_chat_invitation * inv = data;
         g_free(inv->name);
         g_free(inv);

protocols/yahoo/libyahoo2.c

-                      r9730d72
+                      r6738a67
 #ifdef __MINGW32__
 # include <winsock2.h>
-# define write(a,b,c) send(a,b,c,0)
-# define read(a,b,c)  recv(a,b,c,0)
 #endif
 …
 /* call repeatedly to get the next one */
-/*
 static struct yahoo_input_data * find_input_by_id(int id)
+{
 …
         return NULL;
+}
-*/
 static struct yahoo_input_data * find_input_by_id_and_webcam_user(int id, const char * who)
 …
         memcpy(data + pos, "YMSG", 4); pos += 4;
         pos += yahoo_put16(data + pos, 0x0a00);
+        pos += yahoo_put16(data + pos, 0x000c);
         pos += yahoo_put16(data + pos, 0x0000);
         pos += yahoo_put16(data + pos, pktlen + extra_pad);
 …
+{
         struct yahoo_data *yd = find_conn_by_id(id);
         if(!yd)
                 return;
 …
         LOG(("write callback: id=%d fd=%d data=%p", id, fd, data));
         if(!yid || !yid->txqueues)
+        if(!yid || !yid->txqueues || !find_conn_by_id(id))
                 return -2;
 …
                                         break;
                                 case 5:
                                         if(cp != "\005")
+                                        if(strcmp(cp, "5") != 0)
                                                 yct->location = cp;
                                         k = 0;
 …
+        }
+/*      do {
+        do {
                 yahoo_input_close(yid);
+        } while((yid = find_input_by_id(id)));*/
+        } while((yid = find_input_by_id(id)));
+}

protocols/yahoo/yahoo.c

-                      r9730d72
+                      r6738a67
         g_slist_free( yd->buddygroups );
+        if( yd->logged_in )
+                yahoo_logoff( yd->y2_id );
+        else
+                yahoo_close( yd->y2_id );
+        yahoo_logoff( yd->y2_id );
         g_free( yd );
 …
         struct byahoo_data *yd = (struct byahoo_data *) c->ic->proto_data;
         yahoo_conference_invite( yd->y2_id, NULL, c->data, c->title, msg );
+        yahoo_conference_invite( yd->y2_id, NULL, c->data, c->title, msg ? msg : "" );
+}
 …
+{
         struct byahoo_write_ready_data *d = data;
-        if( !byahoo_get_ic_by_id( d->id ) )
-                /* WTF doesn't libyahoo clean this up? */
-                return FALSE;
         yahoo_write_ready( d->id, d->fd, d->data );
 …
+}
+static void byahoo_accept_conf( gpointer w, struct byahoo_conf_invitation *inv )
+{
+static void byahoo_accept_conf( void *data )
+{
+        struct byahoo_conf_invitation *inv = data;
         yahoo_conference_logon( inv->yid, NULL, inv->members, inv->name );
         imcb_chat_add_buddy( inv->c, inv->ic->acc->user );
 …
+}
+static void byahoo_reject_conf( gpointer w, struct byahoo_conf_invitation *inv )
+{
+static void byahoo_reject_conf( void *data )
+{
+        struct byahoo_conf_invitation *inv = data;
         yahoo_conference_decline( inv->yid, NULL, inv->members, inv->name, "User rejected groupchat" );
         imcb_chat_free( inv->c );

protocols/yahoo/yahoo_httplib.c

r9730d72	r6738a67
51	51	#ifdef __MINGW32__
52	52	# include <winsock2.h>
53		~~# define write(a,b,c) send(a,b,c,0)~~
54		~~# define read(a,b,c) recv(a,b,c,0)~~
55	53	# define snprintf _snprintf
56	54	#endif

query.c

-                      r9730d72
+                      r6738a67
 static query_t *query_default( irc_t *irc );
+query_t *query_add( irc_t *irc, struct im_connection *ic, char *question, void *yes, void *no, void *data )
+query_t *query_add( irc_t *irc, struct im_connection *ic, char *question,
+                    query_callback yes, query_callback no, void *data )
+{
         query_t *q = g_new0( query_t, 1 );
 …
         if( ans )
+        {
                 if(q->ic)
+                if( q->ic )
                         imcb_log( q->ic, "Accepted: %s", q->question );
                 else
                         irc_usermsg( irc, "Accepted: %s", q->question );
                 if(q->yes)
                         q->yes( q->ic ? (gpointer)q->ic : (gpointer)irc, q->data );
+                if( q->yes )
+                        q->yes( q->data );
+        }
         else
+        {
                 if(q->ic)
+                if( q->ic )
                         imcb_log( q->ic, "Rejected: %s", q->question );
                 else
                         irc_usermsg( irc, "Rejected: %s", q->question );
                 if(q->no)
                         q->no( q->ic ? (gpointer)q->ic : (gpointer)irc, q->data );
+                if( q->no )
+                        q->no( q->data );
+        }
         q->data = NULL;

query.h

-                      r9730d72
+                      r6738a67
 #define _QUERY_H
+typedef void (*query_callback) ( void *data );
 typedef struct query
+{
         struct im_connection *ic;
         char *question;
+        void (* yes) ( gpointer w, void *data );
+        void (* no) ( gpointer w, void *data );
+        query_callback yes, no;
         void *data;
         struct query *next;
 } query_t;
+query_t *query_add( irc_t *irc, struct im_connection *ic, char *question, void *yes, void *no, void *data );
+query_t *query_add( irc_t *irc, struct im_connection *ic, char *question,
+                    query_callback yes, query_callback no, void *data );
 void query_del( irc_t *irc, query_t *q );
 void query_del_by_conn( irc_t *irc, struct im_connection *ic );

root_commands.c

-                      r9730d72
+                      r6738a67
+}
+struct cmd_account_del_data
+{
+        account_t *a;
+        irc_t *irc;
+};
+void cmd_account_del_yes( void *data )
+{
+        struct cmd_account_del_data *cad = data;
+        account_t *a;
+        for( a = cad->irc->accounts; a && a != cad->a; a = a->next );
+        if( a == NULL )
+        {
+                irc_usermsg( cad->irc, "Account already deleted" );
+        }
+        else if( a->ic )
+        {
+                irc_usermsg( cad->irc, "Account is still logged in, can't delete" );
+        }
+        else
+        {
+                account_del( cad->irc, a );
+                irc_usermsg( cad->irc, "Account deleted" );
+        }
+        g_free( data );
+}
+void cmd_account_del_no( void *data )
+{
+        g_free( data );
+}
 static void cmd_account( irc_t *irc, char **cmd )
+{
 …
                 else
+                {
+                        account_del( irc, a );
+                        irc_usermsg( irc, "Account deleted" );
+                        struct cmd_account_del_data *cad;
+                        char *msg;
+                        cad = g_malloc( sizeof( struct cmd_account_del_data ) );
+                        cad->a = a;
+                        cad->irc = irc;
+                        msg = g_strdup_printf( "If you remove this account (%s(%s)), BitlBee will "
+                                               "also forget all your saved nicknames. If you want "
+                                               "to change your username/password, use the `account "
+                                               "set' command. Are you sure you want to delete this "
+                                               "account?", a->prpl->name, a->user );
+                        query_add( irc, NULL, msg, cmd_account_del_yes, cmd_account_del_no, cad );
+                        g_free( msg );
+                }
+        }
 …
                         acc_handle = g_strdup( cmd[2] );
+                if( !acc_handle )
+                {
+                        irc_usermsg( irc, "Not enough parameters given (need %d)", 3 );
+                        return;
+                }
                 if( ( tmp = strchr( acc_handle, '/' ) ) )
+                {
 …
                         g_free( irc->mynick );
                         irc->mynick = g_strdup( cmd[2] );
+                        if( strcmp( cmd[0], "set_rename" ) != 0 )
+                                set_setstr( &irc->set, "root_nick", cmd[2] );
+                }
                 else if( u->send_handler == buddy_send_handler )
 …
                 irc_usermsg( irc, "Nick successfully changed" );
+        }
+}
+char *set_eval_root_nick( set_t *set, char *new_nick )
+{
+        irc_t *irc = set->data;
+        if( strcmp( irc->mynick, new_nick ) != 0 )
+        {
+                char *cmd[] = { "set_rename", irc->mynick, new_nick, NULL };
+                cmd_rename( irc, cmd );
+        }
+        return strcmp( irc->mynick, new_nick ) == 0 ? new_nick : NULL;
+}
 …
                 else
                         irc_usermsg( irc, "%s is empty", set_name );
+                if( strchr( set_name, '/' ) )
+                        irc_usermsg( irc, "Warning: / found in setting name, you're probably looking for the `account set' command." );
+        }
         else

set.c

-                      r9730d72
+                      r6738a67
+}
-char *set_eval_charset( set_t *set, char *value )
+{
-        GIConv cd;
-        if ( g_strncasecmp( value, "none", 4 ) == 0 )
-                return value;
-        cd = g_iconv_open( "UTF-8", value );
-        if( cd == (GIConv) -1 )
-                return NULL;
-        g_iconv_close( cd );
-        return value;
+}
 /* possible values: never, opportunistic, manual, always */
 char *set_eval_otr_policy( set_t *set, char *value )

set.h

r9730d72	r6738a67
101	101	char set_eval_halfop_buddies( set_t set, char *value );
102	102	char set_eval_voice_buddies( set_t set, char *value );
103		~~char set_eval_charset( set_t set, char *value );~~
104	103	char set_eval_otr_policy( set_t set, char *value );
105	104

sock.h

-                      r9730d72
+                      r6738a67
 #else
 # include <winsock2.h>
+# ifndef _MSC_VER
+#  include <ws2tcpip.h>
+# endif
+# include <ws2tcpip.h>
 # if !defined(BITLBEE_CORE) && defined(_MSC_VER)
 #   pragma comment(lib,"bitlbee.lib")
 # endif
 # include <io.h>
-# define read(a,b,c) recv(a,b,c,0)
-# define write(a,b,c) send(a,b,c,0)
-# define umask _umask
-# define mode_t int
 # define sock_make_nonblocking(fd) { int non_block = 1; ioctlsocket(fd, FIONBIO, &non_block); }
 # define sock_make_blocking(fd) { int non_block = 0; ioctlsocket(fd, FIONBIO, &non_block); }

storage_text.c

-                      r9730d72
+                      r6738a67
 #include "bitlbee.h"
 #include "crypting.h"
+#ifdef _WIN32
+# define umask _umask
+# define mode_t int
+#endif
+#ifndef F_OK
+#define F_OK 0
+#endif
 static void text_init (void)

storage_xml.c

-                      r9730d72
+                      r6738a67
 #include "arc.h"
 #include "md5.h"
+#include <glib/gstdio.h>
+#if !GLIB_CHECK_VERSION(2,8,0)
+/* GLib < 2.8.0 doesn't have g_access, so just use the system access(). */
+#define g_access access
+#endif
 typedef enum
 …
                 char *nick = xml_attr( attr_names, attr_values, "nick" );
                 char *pass = xml_attr( attr_names, attr_values, "password" );
                 md5_byte_t *pass_dec = NULL;
+                int st;
                 if( !nick || !pass )
 …
                                      "Missing attributes for %s element", element_name );
+                }
+                else if( base64_decode( pass, &pass_dec ) != 21 )
+                {
+                else if( ( st = md5_verify_password( xd->given_pass, pass ) ) == -1 )
+                {
+                        xd->pass_st = XML_PASS_WRONG;
                         g_set_error( error, G_MARKUP_ERROR, G_MARKUP_ERROR_INVALID_CONTENT,
                                      "Error while decoding password attribute" );
+                }
+                else if( st == 0 )
+                {
+                        if( xd->pass_st != XML_PASS_CHECK_ONLY )
+                                xd->pass_st = XML_PASS_OK;
+                }
                 else
+                {
+                        md5_byte_t pass_md5[16];
+                        md5_state_t md5_state;
+                        int i;
+                        md5_init( &md5_state );
+                        md5_append( &md5_state, (md5_byte_t*) xd->given_pass, strlen( xd->given_pass ) );
+                        md5_append( &md5_state, (md5_byte_t*) pass_dec + 16, 5 ); /* Hmmm, salt! */
+                        md5_finish( &md5_state, pass_md5 );
+                        for( i = 0; i < 16; i ++ )
+                        {
+                                if( pass_dec[i] != pass_md5[i] )
+                                {
+                                        xd->pass_st = XML_PASS_WRONG;
+                                        g_set_error( error, G_MARKUP_ERROR, G_MARKUP_ERROR_INVALID_CONTENT,
+                                                     "Password mismatch" );
+                                        break;
+                                }
+                        }
+                        /* If we reached the end of the loop, it was a match! */
+                        if( i == 16 )
+                        {
+                                if( xd->pass_st != XML_PASS_CHECK_ONLY )
+                                        xd->pass_st = XML_PASS_OK;
+                        }
+                }
+                g_free( pass_dec );
+                        xd->pass_st = XML_PASS_WRONG;
+                        g_set_error( error, G_MARKUP_ERROR, G_MARKUP_ERROR_INVALID_CONTENT,
+                                     "Password mismatch" );
+                }
+        }
         else if( xd->pass_st < XML_PASS_OK )
 …
 static void xml_init( void )
+{
         if( access( global.conf->configdir, F_OK ) != 0 )
+        if( g_access( global.conf->configdir, F_OK ) != 0 )
                 log_message( LOGLVL_WARNING, "The configuration directory `%s' does not exist. Configuration won't be saved.", global.conf->configdir );
+        else if( access( global.conf->configdir, R_OK ) != 0 || access( global.conf->configdir, W_OK ) != 0 )
+        else if( g_access( global.conf->configdir, F_OK ) != 0 ||
+                 g_access( global.conf->configdir, W_OK ) != 0 )
                 log_message( LOGLVL_WARNING, "Permission problem: Can't read/write from/to `%s'.", global.conf->configdir );
+}
 …
         g_free( path2 );
         if( !overwrite && access( path, F_OK ) != -1 )
+        if( !overwrite && g_access( path, F_OK ) == 0 )
                 return STORAGE_ALREADY_EXISTS;
 …
                 int pass_len;
                 pass_len = arc_encode( acc->pass, strlen( acc->pass ), (unsigned char**) &pass_cr, irc->password );
+                pass_len = arc_encode( acc->pass, strlen( acc->pass ), (unsigned char**) &pass_cr, irc->password, 12 );
                 pass_b64 = base64_encode( pass_cr, pass_len );
                 g_free( pass_cr );
 …
 static storage_status_t xml_remove( const char *nick, const char *password )
+{
         char s[512];
+        char s[512], *lc;
         storage_status_t status;
 …
                 return status;
+        g_snprintf( s, 511, "%s%s%s", global.conf->configdir, nick, ".xml" );
+        lc = g_strdup( nick );
+        nick_lc( lc );
+        g_snprintf( s, 511, "%s%s%s", global.conf->configdir, lc, ".xml" );
+        g_free( lc );
         if( unlink( s ) == -1 )
                 return STORAGE_OTHER_ERROR;

tests/Makefile

r9730d72	r6738a67
13	13	main_objs = account.o bitlbee.o conf.o crypting.o help.o ipc.o irc.o irc_commands.o log.o nick.o query.o root_commands.o set.o storage.o storage_xml.o storage_text.o user.o
14	14
15		test_objs = check.o check_util.o check_nick.o check_md5.o check_arc.o check_irc.o check_help.o check_user.o check_crypting.o check_set.o check_jabber_sasl.o
	15	test_objs = check.o check_util.o check_nick.o check_md5.o check_arc.o check_irc.o check_help.o check_user.o check_crypting.o check_set.o check_jabber_sasl.o check_jabber_util.o
16	16
17	17	check: $(test_objs) $(addprefix ../, $(main_objs)) ../protocols/protocols.o ../lib/lib.o

tests/check.c

-                      r9730d72
+                      r6738a67
 Suite *jabber_sasl_suite(void);
+/* From check_jabber_sasl.c */
+Suite *jabber_util_suite(void);
 int main (int argc, char **argv)
+{
 …
         srunner_add_suite(sr, set_suite());
         srunner_add_suite(sr, jabber_sasl_suite());
+        srunner_add_suite(sr, jabber_util_suite());
         if (no_fork)
                 srunner_set_fork_status(sr, CK_NOFORK);

tests/check_arc.c

-                      r9730d72
+                      r6738a67
 #include "arc.h"
 char *password = "TotT";
+char *password = "ArcVier";
 char *clear_tests[] =
 …
         "ItllBeBitlBee",
         "One more boring password",
+        "Hoi hoi",
         NULL
 };
 …
                 int len;
                 len = arc_encode( clear_tests[i], 0, &crypted, password );
+                len = arc_encode( clear_tests[i], 0, &crypted, password, 12 );
                 len = arc_decode( crypted, len, &decrypted, password );
 …
 struct
+{
         unsigned char crypted[24];
+        unsigned char crypted[30];
         int len;
         char *decrypted;
 } decrypt_tests[] = {
+        /* One block with padding. */
+        {
+                {
 xc3, 0x0d, 0x43, 0xc3, 0xee, 0x80, 0xe2, 0x8c, 0x0b, 0x29, 0x32, 0x7e,
 x38, 0x05, 0x82, 0x10, 0x21, 0x1c, 0x4a, 0x00, 0x2c
                 }, 21, "Debugging sucks"
+x3f, 0x79, 0xb0, 0xf5, 0x91, 0x56, 0xd2, 0x1b, 0xd1, 0x4b, 0x67, 0xac,
+xb1, 0x31, 0xc9, 0xdb, 0xf9, 0xaa
+                }, 18, "short pass"
         },
+        /* Two blocks with padding. */
+        {
+                {
+xb0, 0x00, 0x57, 0x0d, 0x0d, 0x0d, 0x70, 0xe1, 0xc0, 0x00, 0xa4, 0x25,
+x7d, 0xbe, 0x03, 0xcc, 0x24, 0xd1, 0x0c
+                }, 19, "Testing rocks"
+xf9, 0xa6, 0xec, 0x5d, 0xc7, 0x06, 0xb8, 0x6b, 0x63, 0x9f, 0x2d, 0xb5,
+x7d, 0xaa, 0x32, 0xbb, 0xd8, 0x08, 0xfd, 0x81, 0x2e, 0xca, 0xb4, 0xd7,
+x2f, 0x36, 0x9c, 0xac, 0xa0, 0xbc
+                }, 30, "longer password"
         },
+        /* This string is exactly two "blocks" long, to make sure unpadded strings also decrypt
+           properly. */
+        {
+                {
+xb6, 0x92, 0x59, 0xe4, 0xf9, 0xc1, 0x7a, 0xf6, 0xf3, 0x18, 0xea, 0x28,
+x73, 0x6d, 0xb3, 0x0a, 0x6f, 0x0a, 0x2b, 0x43, 0x57, 0xe9, 0x3e, 0x63
+                }, 24, "OSCAR is creepy..."
+x95, 0x4d, 0xcf, 0x4d, 0x5e, 0x6c, 0xcf, 0xef, 0xb9, 0x80, 0x00, 0xef,
+x25, 0xe9, 0x17, 0xf6, 0x29, 0x6a, 0x82, 0x79, 0x1c, 0xca, 0x68, 0xb5,
+x4e, 0xd0, 0xc1, 0x41, 0x8e, 0xe6
+                }, 30, "OSCAR is really creepy.."
         },
         { "", 0, NULL }
 …
                 fail_if( strcmp( decrypt_tests[i].decrypted, decrypted ) != 0,
                          "%s didn't decrypt properly", clear_tests[i] );
+                         "`%s' didn't decrypt properly", decrypt_tests[i].decrypted );
                 g_free( decrypted );

tests/check_irc.c

-                      r9730d72
+                      r6738a67
         irc = irc_new(g_io_channel_unix_get_fd(ch1));
         fail_unless(g_io_channel_write_chars(ch2, "NICK bla\r\n"
                         "USER a a a a\r\n", -1, NULL, NULL) == G_IO_STATUS_NORMAL);
+        fail_unless(g_io_channel_write_chars(ch2, "NICK bla\r\r\n"
+                        "USER a a a a\n", -1, NULL, NULL) == G_IO_STATUS_NORMAL);
         fail_unless(g_io_channel_flush(ch2, NULL) == G_IO_STATUS_NORMAL);

tests/check_jabber_sasl.c

r9730d72	r6738a67
5	5	#include <string.h>
6	6	#include <stdio.h>
7		~~#include "arc.h"~~
8	7
9	8	char sasl_get_part( char data, char *field );

unix.c

-                      r9730d72
+                      r6738a67
 static void sighandler( int signal );
 int main( int argc, char *argv[], char **envp )
+int main( int argc, char *argv[] )
+{
         int i = 0;
 …
         if( global.conf->runmode == RUNMODE_INETD )
+        {
+                log_link( LOGLVL_ERROR, LOGOUTPUT_IRC );
+                log_link( LOGLVL_WARNING, LOGOUTPUT_IRC );
                 i = bitlbee_inetd_init();
                 log_message( LOGLVL_INFO, "Bitlbee %s starting in inetd mode.", BITLBEE_VERSION );
 …
         else if( global.conf->runmode == RUNMODE_DAEMON )
+        {
+                log_link( LOGLVL_ERROR, LOGOUTPUT_SYSLOG );
+                log_link( LOGLVL_WARNING, LOGOUTPUT_SYSLOG );
                 i = bitlbee_daemon_init();
                 log_message( LOGLVL_INFO, "Bitlbee %s starting in daemon mode.", BITLBEE_VERSION );
 …
+        {
                 char *fn = ipc_master_save_state();
-                char **args;
-                int n, i;
                 chdir( old_cwd );
+                n = 0;
+                args = g_new0( char *, argc + 3 );
+                args[n++] = argv[0];
+                if( fn )
+                {
+                        args[n++] = "-R";
+                        args[n++] = fn;
+                }
+                for( i = 1; argv[i] && i < argc; i ++ )
+                {
+                        if( strcmp( argv[i], "-R" ) == 0 )
+                                i += 2;
+                        args[n++] = argv[i];
+                }
+                setenv( "_BITLBEE_RESTART_STATE", fn, 1 );
+                g_free( fn );
                 close( global.listen_socket );
+                execve( args[0], args, envp );
+                if( execv( argv[0], argv ) == -1 )
+                        /* Apparently the execve() failed, so let's just
+                           jump back into our own/current main(). */
+                        /* Need more cleanup code to make this work. */
+                        return 1; /* main( argc, argv ); */
+        }
 …
         return( (double) time->tv_sec + (double) time->tv_usec / 1000000 );
+}

welcome.txt

r9730d72	r6738a67
2	2
3	3	If you've never used BitlBee before, please do read the help information using the help command. Lots of FAQs are answered there.
4
5	4	OTR users please note: Private key files are owned by the user BitlBee is running as.
	5	If you already have an account on this server, just use the identify command to identify yourself.

Context Navigation

Changes in / [9730d72:6738a67]

Legend:

Download in other formats: