Changeset 664bac3

Timestamp:

2015-01-16T19:50:25Z (10 years ago)

Author:

dequis <dx@…>

Branches:

master

Children:

eb4ad8d

Parents:

ecbd22a

git-author:

jgeboski <jgeboski@…> (16-01-15 19:50:25)

git-committer:

dequis <dx@…> (16-01-15 19:50:25)

Message:

irc-im: fixed invalid memory reading on chat leave

When a chat is left, prpl->chat_leave() is invoked, which is suppose
to free the groupchat. Since the data is now freed, or suppose to have
been freed, attempting to modify the data will result in bad things.
This simply removes an assignment operation, which was unneeded due to
the memory already being freed.

File:

• irc_im.c (modified) (1 diff)

irc_im.c

@@ -911 +911 @@
                 c->ic->acc->prpl->chat_leave( c );
         
-        /* Remove references in both directions now. We don't need each other anymore. */
+        /* Remove the reference. We don't need it anymore. */
         ic->data = NULL;
-        if( c )
-                c->ui_data = NULL;
         
         return TRUE;