Changeset 61e7e02

Timestamp:

2015-06-08T03:25:18Z (9 years ago)

Author:

dequis <dx@…>

Branches:

master

Children:

1201fcb, e4f08bf

Parents:

56c8a4f

Message:

twitter: fix leak of the letter "s" in twitter_url_len_diff

Yeah, just the letter s from "https", and a null byte.

Really critical stuff.

You'd have to post a million tweets to even notice this at all.

File:

• protocols/twitter/twitter.c (modified) (1 diff)

protocols/twitter/twitter.c

@@ -469 +469 @@
         g_regex_match(regex, msg, 0, &match_info);
         while (g_match_info_matches(match_info)) {
-                gchar *url = g_match_info_fetch(match_info, 2);
+                gchar *s, *url;
+
+                url = g_match_info_fetch(match_info, 2);
                 url_len_diff += target_len - g_utf8_strlen(url, -1);
+
                 /* Add another character for https://t.co/... URLs */
-                if (g_match_info_fetch(match_info, 3) != NULL) {
+                if ((s = g_match_info_fetch(match_info, 3))) {
                         url_len_diff += 1;
+                        g_free(s);
                 }
                 g_free(url);