Changeset 5a5c926 for protocols/msn

Timestamp:

2006-06-12T06:58:20Z (18 years ago)

Author:

Wilmer van der Gaast <wilmer@…>

Branches:

master

Children:

79e826a, b4e4b95

Parents:

fb62f81f

Message:

Fixed a (very rare, AFAIK) NULL-pointer dereference.

File:

• protocols/msn/msn.c (modified) (2 diffs)

protocols/msn/msn.c

@@ -64 +64 @@
         GSList *l;
         
-        if( md->fd >= 0 )
-                closesocket( md->fd );
-        
-        if( md->handler )
-        {
-                if( md->handler->rxq ) g_free( md->handler->rxq );
-                if( md->handler->cmd_text ) g_free( md->handler->cmd_text );
-                g_free( md->handler );
-        }
-        
-        while( md->switchboards )
-                msn_sb_destroy( md->switchboards->data );
-        
-        if( md->msgq )
-        {
-                struct msn_message *m;
-                
-                for( l = md->msgq; l; l = l->next )
-                {
-                        m = l->data;
-                
-                        serv_got_crap( gc, "Warning: Closing down MSN connection with unsent message to %s, you'll have to resend it.", m->who );
-                        g_free( m->who );
-                        g_free( m->text );
-                        g_free( m );
-                }
-                g_slist_free( md->msgq );
+        if( md )
+        {
+                if( md->fd >= 0 )
+                        closesocket( md->fd );
+                
+                if( md->handler )
+                {
+                        if( md->handler->rxq ) g_free( md->handler->rxq );
+                        if( md->handler->cmd_text ) g_free( md->handler->cmd_text );
+                        g_free( md->handler );
+                }
+                
+                while( md->switchboards )
+                        msn_sb_destroy( md->switchboards->data );
+                
+                if( md->msgq )
+                {
+                        struct msn_message *m;
+                        
+                        for( l = md->msgq; l; l = l->next )
+                        {
+                                m = l->data;
+                        
+                                serv_got_crap( gc, "Warning: Closing down MSN connection with unsent message to %s, you'll have to resend it.", m->who );
+                                g_free( m->who );
+                                g_free( m->text );
+                                g_free( m );
+                        }
+                        g_slist_free( md->msgq );
+                }
+                
+                g_free( md );
         }
         
@@ -100 +105 @@
                 g_free( l->data );
         g_slist_free( gc->deny );
-        
-        g_free( md );
         
         msn_connections = g_slist_remove( msn_connections, gc );