Changeset 5652d43 for skype

Timestamp:

2007-11-23T23:46:20Z (16 years ago)

Author:

Miklos Vajna <vmiklos@…>

Branches:

master

Children:

fc26bcb

Parents:

eb9cbb8

Message:

warning fix in skype_chat_with()
fix "when you start a group chat, a warning is shown saying creating the
group chat is failed, but in fact it is created"

Location:

skype

Files:

• README (modified) (1 diff)
• skype.c (modified) (6 diffs)

skype/README

@@ -230 +230 @@
 == Known bugs
 
-- When you join start a group chat, a warning is shown saying creating the
-  group chat is failed. Indeed it is created. I should improve the API to be
-  able to suppress that warning.
+- None at this time.
 
 == Screenshots

skype/skype.c

@@ -446 +446 @@
                                                 *info = '\0';
                                         info++;
+                                        /* Remove fake chat if we created one in skype_chat_with() */
+                                        struct groupchat *gc = skype_chat_by_name(ic, "");
+                                        if(gc)
+                                                imcb_chat_free(gc);
                                         if(!strcmp(info, "STATUS MULTI_SUBSCRIBED"))
                                         {
@@ -456 +460 @@
                                         else if(!strcmp(info, "STATUS DIALOG") && sd->groupchat_with)
                                         {
-                                                struct groupchat *gc = imcb_chat_new( ic, id );
+                                                gc = imcb_chat_new( ic, id );
                                                 /* According to the docs this
                                                  * is necessary. However it
@@ -477 +481 @@
                                         else if(!strcmp(info, "STATUS UNSUBSCRIBED"))
                                         {
-                                                struct groupchat *gc = skype_chat_by_name(ic, id);
+                                                gc = skype_chat_by_name(ic, id);
                                                 if(gc)
                                                         gc->data = (void*)FALSE;
@@ -490 +494 @@
                                         {
                                                 info += 6;
-                                                struct groupchat *gc = skype_chat_by_name(ic, id);
+                                                gc = skype_chat_by_name(ic, id);
                                                 if(gc && (sd->adder || sd->topic_wait))
                                                 {
@@ -506 +510 @@
                                         {
                                                 info += 14;
-                                                struct groupchat *gc = skype_chat_by_name(ic, id);
+                                                gc = skype_chat_by_name(ic, id);
                                                 /* Hack! We set ->data to TRUE
                                                  * while we're on the channel
@@ -741 +745 @@
         sd->groupchat_with = g_strdup(nick);
         g_free(nick);
-        return(NULL);
+        /* We create a fake chat for now. We will replace it with a real one in
+         * the real callback. */
+        return(imcb_chat_new( ic, "" ));
 }