Changeset 5535a47 for lib


Ignore:
Timestamp:
2015-05-07T23:12:06Z (4 years ago)
Author:
dequis <dx@…>
Branches:
master
Children:
088b070
Parents:
81a15da
git-author:
dequis <dx@…> (07-05-15 23:04:47)
git-committer:
dequis <dx@…> (07-05-15 23:12:06)
Message:

More coverity fixes!

CID 18634: 'Logically dead code' in jabber_get_info
CID 18638: 'Dereference after null check' in oauth2_access_token_done
CID 18691: 'Copy into fixed size buffer' in bee_irc_user_new
CID 20274: Leak in bee_irc_chat_invite
CID 20297, CID 20283: Leaks in crypt_main

Some the base64 leaks there weren't detected, needs modeling.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • lib/oauth2.c

    r81a15da r5535a47  
    140140        struct oauth2_access_token_data *cb_data = req->data;
    141141        char *atoken = NULL, *rtoken = NULL, *error = NULL;
    142         char *content_type;
     142        char *content_type = NULL;
    143143
    144         if (getenv("BITLBEE_DEBUG") && req->reply_body) {
     144        if (req->status_code <= 0 && !req->reply_body) {
     145                cb_data->func(cb_data->data, NULL, NULL, req->status_string);
     146                g_free(cb_data);
     147                return;
     148        }
     149
     150        if (getenv("BITLBEE_DEBUG")) {
    145151                printf("%s\n", req->reply_body);
    146152        }
Note: See TracChangeset for help on using the changeset viewer.