Changeset 5535a47 for irc_im.c

Timestamp:

2015-05-07T23:12:06Z (10 years ago)

Author:

dequis <dx@…>

Branches:

master

Children:

088b070

Parents:

81a15da

git-author:

dequis <dx@…> (07-05-15 23:04:47)

git-committer:

dequis <dx@…> (07-05-15 23:12:06)

Message:

More coverity fixes!

CID 18634: 'Logically dead code' in jabber_get_info
CID 18638: 'Dereference after null check' in oauth2_access_token_done
CID 18691: 'Copy into fixed size buffer' in bee_irc_user_new
CID 20274: Leak in bee_irc_chat_invite
CID 20297, CID 20283: Leaks in crypt_main

Some the base64 leaks there weren't detected, needs modeling.

File:

• irc_im.c (modified) (2 diffs)

irc_im.c

@@ -50 +50 @@
 
         memset(nick, 0, MAX_NICK_LENGTH + 1);
-        strcpy(nick, nick_get(bu));
+        strncpy(nick, nick_get(bu), MAX_NICK_LENGTH);
 
         bu->ui_data = iu = irc_user_new(irc, nick);
@@ -723 +723 @@
                         g_free(channel);
                         channel = s;
+                } else {
+                        g_free(s);
                 }
         }