Changeset 537d9b9 for protocols

Timestamp:

2016-11-20T08:40:36Z (8 years ago)

Author:

dequis <dx@…>

Children:

3f44e43

Parents:

ba52ac5 (diff), 9f03c47 (diff)
Note: this is a merge changeset, the changes displayed below correspond to the merge itself.
Use the (diff) links above to see all the changes relative to each parent.

Message:

Merge master up to commit '9f03c47' into parson

Location:

protocols

Files:

• account.c (modified) (2 diffs)
• account.h (modified) (2 diffs)
• bee.h (modified) (3 diffs)
• bee_chat.c (modified) (1 diff)
• bee_ft.c (modified) (1 diff)
• jabber/conference.c (modified) (8 diffs)
• jabber/iq.c (modified) (4 diffs)
• jabber/jabber.c (modified) (8 diffs)
• jabber/jabber.h (modified) (3 diffs)
• jabber/jabber_util.c (modified) (1 diff)
• jabber/message.c (modified) (2 diffs)
• jabber/presence.c (modified) (1 diff)
• jabber/s5bytestream.c (modified) (1 diff)
• jabber/sasl.c (modified) (11 diffs)
• jabber/si.c (modified) (3 diffs)
• nogaim.c (modified) (7 diffs)
• nogaim.h (modified) (5 diffs)
• oscar/conn.c (modified) (2 diffs)
• purple/bpurple.h (modified) (1 diff)
• purple/ft.c (modified) (10 diffs)
• purple/purple.c (modified) (21 diffs)
• skype/skype.c (modified) (1 diff)
• twitter/twitter.c (modified) (8 diffs)
• twitter/twitter.h (modified) (1 diff)
• twitter/twitter_http.c (modified) (1 diff)
• twitter/twitter_lib.c (modified) (21 diffs)
• twitter/twitter_lib.h (modified) (4 diffs)

protocols/account.c

@@ -63 +63 @@
 
         s = set_add(&a->set, "password", NULL, set_eval_account, a);
-        s->flags |= SET_NOSAVE | SET_NULL_OK | SET_PASSWORD;
+        s->flags |= SET_NOSAVE | SET_NULL_OK | SET_PASSWORD | ACC_SET_LOCKABLE;
 
         s = set_add(&a->set, "tag", NULL, set_eval_account, a);
@@ -69 +69 @@
 
         s = set_add(&a->set, "username", NULL, set_eval_account, a);
-        s->flags |= SET_NOSAVE | ACC_SET_OFFLINE_ONLY;
+        s->flags |= SET_NOSAVE | ACC_SET_OFFLINE_ONLY | ACC_SET_LOCKABLE;
         set_setstr(&a->set, "username", user);
 

protocols/account.h

@@ -61 +61 @@
         ACC_SET_OFFLINE_ONLY = 0x02,    /* Allow changes only if the acct is offline. */
         ACC_SET_ONLINE_ONLY = 0x04,     /* Allow changes only if the acct is online. */
+        ACC_SET_LOCKABLE = 0x08         /* Setting cannot be changed if the account is locked down */
 } account_set_flag_t;
 
@@ -68 +69 @@
         ACC_FLAG_HANDLE_DOMAINS = 0x04, /* Contact handles need a domain portion. */
         ACC_FLAG_LOCAL_CONTACTS = 0x08, /* Contact list is local. */
+        ACC_FLAG_LOCKED = 0x10,         /* Account is locked (cannot be deleted, certain settings can't changed) */
 } account_flag_t;
 

protocols/bee.h

@@ -84 +84 @@
 } bee_user_t;
 
+typedef struct bee_chat_info {
+        char *title;
+        char *topic;
+} bee_chat_info_t;
+
 /* This one's mostly used so save space and make it easier (cheaper) to
    compare groups of contacts, etc. */
@@ -131 +136 @@
 
         void (*log)(bee_t *bee, const char *tag, const char *msg);
+        gboolean (*user_nick_change)(bee_t *bee, bee_user_t *bu, const char *hint);
 } bee_ui_funcs_t;
 
@@ -184 +190 @@
 G_MODULE_EXPORT void imcb_chat_invite(struct im_connection *ic, const char *name, const char *who, const char *msg);
 
+G_GNUC_DEPRECATED G_MODULE_EXPORT void bee_chat_list_finish(struct im_connection *ic);
+G_MODULE_EXPORT void imcb_chat_list_finish(struct im_connection *ic);
+G_MODULE_EXPORT void imcb_chat_list_free(struct im_connection *ic);
+
 #endif /* __BEE_H__ */

protocols/bee_chat.c

@@ -274 +274 @@
         }
 }
+
+void imcb_chat_list_finish(struct im_connection *ic)
+{
+        cmd_chat_list_finish(ic);
+}
+
+void bee_chat_list_finish(struct im_connection *ic)
+{
+        imcb_log(ic, "Warning: using deprecated bee_chat_list_finish. This will be removed in the stable release.");
+        imcb_chat_list_finish(ic);
+}
+
+void imcb_chat_list_free(struct im_connection *ic)
+{
+        bee_chat_info_t *ci;
+        GSList *l = ic->chatlist;
+
+        while (l) {
+                ci = l->data;
+                l = g_slist_delete_link(l, l);
+
+                g_free(ci->title);
+                g_free(ci->topic);
+                g_free(ci);
+        }
+
+        ic->chatlist = NULL;
+}

protocols/bee_ft.c

@@ -31 +31 @@
         bee_user_t *bu = bee_user_by_handle(bee, ic, handle);
 
-        if (bee->ui->ft_in_start) {
+        if (bee->ui->ft_in_start && bu) {
                 return bee->ui->ft_in_start(bee, bu, file_name, file_size);
         } else {

protocols/jabber/conference.c

@@ -28 +28 @@
 static xt_status jabber_chat_self_message(struct im_connection *ic, struct xt_node *node, struct xt_node *orig);
 
-struct groupchat *jabber_chat_join(struct im_connection *ic, const char *room, const char *nick, const char *password)
+struct groupchat *jabber_chat_join(struct im_connection *ic, const char *room, const char *nick, const char *password,
+                                   gboolean always_use_nicks)
 {
         struct jabber_chat *jc;
@@ -57 +58 @@
                 g_free(jc);
                 return NULL;
+        }
+
+        if (always_use_nicks) {
+                jc->flags = JCFLAG_ALWAYS_USE_NICKS;
         }
 
@@ -95 +100 @@
         g_free(cserv);
 
-        c = jabber_chat_join(ic, rjid, jd->username, NULL);
+        c = jabber_chat_join(ic, rjid, jd->username, NULL, FALSE);
         g_free(rjid);
         if (c == NULL) {
@@ -244 +249 @@
 }
 
+static int jabber_chat_has_other_resources(struct im_connection *ic, struct jabber_buddy *bud)
+{
+        struct jabber_buddy *cur;
+
+        for (cur = jabber_buddy_by_jid(ic, bud->bare_jid, GET_BUDDY_FIRST); cur; cur = cur->next) {
+                if (cur != bud && jabber_compare_jid(cur->ext_jid, bud->ext_jid)) {
+                        return TRUE;
+                }
+        }
+        
+        return FALSE;
+}
+
 /* Not really the same syntax as the normal pkt_ functions, but this isn't
    called by the xmltree parser directly and this way I can add some extra
@@ -328 +346 @@
                         *s = 0; /* Should NEVER be NULL, but who knows... */
                 }
+
+                if (bud != jc->me && (jc->flags & JCFLAG_ALWAYS_USE_NICKS) && !(bud->flags & JBFLAG_IS_ANONYMOUS)) {
+                        imcb_buddy_nick_change(ic, bud->ext_jid, bud->resource);
+                }
+
                 imcb_chat_add_buddy(chat, bud->ext_jid);
                 if (s) {
@@ -333 +356 @@
                 }
         } else if (type) { /* type can only be NULL or "unavailable" in this function */
-                if ((bud->flags & JBFLAG_IS_CHATROOM) && bud->ext_jid) {
+                if ((bud->flags & JBFLAG_IS_CHATROOM) && bud->ext_jid && !jabber_chat_has_other_resources(ic, bud)) {
                         char *reason = NULL;
                         char *status = NULL;
@@ -443 +466 @@
 
         if (subject && chat) {
-                char *subject_text = subject->text_len > 0 ? subject->text : "";
+                char empty[1] = "";
+                char *subject_text = subject->text_len > 0 ? subject->text : empty;
                 if (g_strcmp0(chat->topic, subject_text) != 0) {
                         bare_jid = (bud) ? jabber_get_bare_jid(bud->ext_jid) : NULL;
@@ -479 +503 @@
                 bare_jid = jabber_get_bare_jid(bud->ext_jid ? bud->ext_jid : bud->full_jid);
                 final_from = bare_jid;
-                flags = (bud == jc->me) ? OPT_SELFMESSAGE : 0;
+                if (bud == jc->me || (g_strcasecmp(final_from, ic->acc->user) == 0)) {
+                        flags = OPT_SELFMESSAGE;
+                }
         } else {
                 final_from = nick;

protocols/jabber/iq.c

@@ -67 +67 @@
                         xt_add_child(reply, xt_new_node("name", set_getstr(&ic->acc->set, "user_agent"), NULL));
                         xt_add_child(reply, xt_new_node("version", BITLBEE_VERSION, NULL));
-                        xt_add_child(reply, xt_new_node("os", ARCH, NULL));
                 } else if (strcmp(s, XMLNS_TIME_OLD) == 0) {
                         time_t time_ep;
@@ -234 +233 @@
                 imcb_log(ic, "Warning: Received incomplete IQ packet while authenticating");
                 imc_logout(ic, FALSE);
-                return XT_HANDLED;
+                return XT_ABORT;
         }
 
@@ -287 +286 @@
                 imcb_log(ic, "Warning: Received incomplete IQ packet while authenticating");
                 imc_logout(ic, FALSE);
-                return XT_HANDLED;
+                return XT_ABORT;
         }
 
@@ -1060 +1059 @@
         return XT_HANDLED;
 }
+
+xt_status jabber_iq_disco_muc_response(struct im_connection *ic, struct xt_node *node, struct xt_node *orig);
+
+int jabber_iq_disco_muc(struct im_connection *ic, const char *muc_server)
+{
+        struct xt_node *node;
+        int st;
+
+        node = xt_new_node("query", NULL, NULL);
+        xt_add_attr(node, "xmlns", XMLNS_DISCO_ITEMS);
+        node = jabber_make_packet("iq", "get", (char *) muc_server, node);
+
+        jabber_cache_add(ic, node, jabber_iq_disco_muc_response);
+        st = jabber_write_packet(ic, node);
+
+        return st;
+}
+
+xt_status jabber_iq_disco_muc_response(struct im_connection *ic, struct xt_node *node, struct xt_node *orig)
+{
+        struct xt_node *query, *c;
+        struct jabber_error *err;
+        GSList *rooms =  NULL;
+
+        if ((err = jabber_error_parse(xt_find_node(node->children, "error"), XMLNS_STANZA_ERROR))) {
+                imcb_error(ic, "The server replied with an error: %s%s%s",
+                           err->code, err->text ? ": " : "", err->text ? err->text : "");
+                jabber_error_free(err);
+                return XT_HANDLED;
+        }
+
+        if (!(query = xt_find_node(node->children, "query"))) {
+                imcb_error(ic, "Received incomplete MUC list reply");
+                return XT_HANDLED;
+        }
+
+        c = query->children;
+        while ((c = xt_find_node(c, "item"))) {
+                char *jid = xt_find_attr(c, "jid");
+
+                if (!jid || !strchr(jid, '@')) {
+                        c = c->next;
+                        continue;
+                }
+
+                bee_chat_info_t *ci = g_new(bee_chat_info_t, 1);
+                ci->title = g_strdup(xt_find_attr(c, "jid"));
+                ci->topic = g_strdup(xt_find_attr(c, "name"));
+                rooms = g_slist_prepend(rooms, ci);
+
+                c = c->next;
+        }
+
+        imcb_chat_list_free(ic);
+        ic->chatlist = g_slist_reverse(rooms);
+        imcb_chat_list_finish(ic);
+
+        return XT_HANDLED;
+}

protocols/jabber/jabber.c

@@ -82 +82 @@
         s->flags |= SET_NOSAVE | ACC_SET_OFFLINE_ONLY | SET_NULL_OK;
 
+        set_add(&acc->set, "oauth", "false", set_eval_oauth, acc);
+
         if (strcmp(acc->prpl->name, "hipchat") == 0) {
                 set_setstr(&acc->set, "server", "chat.hipchat.com");
         } else {
-                set_add(&acc->set, "oauth", "false", set_eval_oauth, acc);
-
                 /* this reuses set_eval_oauth, which clears the password */
                 set_add(&acc->set, "anonymous", "false", set_eval_oauth, acc);
@@ -321 +321 @@
         struct jabber_data *jd = ic->proto_data;
 
+        imcb_chat_list_free(ic);
+
         while (jd->filetransfers) {
                 imcb_file_canceled(ic, (( struct jabber_transfer *) jd->filetransfers->data)->ft, "Logging out");
@@ -397 +399 @@
         if (g_strcasecmp(who, JABBER_OAUTH_HANDLE) == 0 &&
             !(jd->flags & OPT_LOGGED_IN) && jd->fd == -1) {
-                if (sasl_oauth2_get_refresh_token(ic, message)) {
+
+                if (jd->flags & JFLAG_HIPCHAT) {
+                        sasl_oauth2_got_token(ic, message, NULL, NULL);
+                        return 1;
+                } else if (sasl_oauth2_get_refresh_token(ic, message)) {
                         return 1;
                 } else {
@@ -577 +583 @@
         } else {
                 /* jabber_chat_join without the underscore is the conference.c one */
-                return jabber_chat_join(ic, room, final_nick, set_getstr(sets, "password"));
+                return jabber_chat_join(ic, room, final_nick, set_getstr(sets, "password"),
+                                        set_getbool(sets, "always_use_nicks"));
         }
 
@@ -586 +593 @@
 {
         return jabber_chat_with(ic, who);
+}
+
+static void jabber_chat_list_(struct im_connection *ic, const char *server)
+{
+        struct jabber_data *jd = ic->proto_data;
+
+        if (server && *server) {
+                jabber_iq_disco_muc(ic, server);
+        } else if (jd->muc_host && *jd->muc_host) {
+                jabber_iq_disco_muc(ic, jd->muc_host);
+        } else {
+                /* throw an error here, don't query conference.[server] directly.
+                 * for things like jabber.org it gets you 18000 results of garbage */
+                imcb_error(ic, "Please specify a server name such as `conference.%s'", jd->server);
+        }
 }
 
@@ -686 +708 @@
 void jabber_chat_add_settings(account_t *acc, set_t **head)
 {
+        set_add(head, "always_use_nicks", "false", set_eval_bool, NULL);
+
         /* Meh. Stupid room passwords. Not trying to obfuscate/hide
            them from the user for now. */
@@ -693 +717 @@
 void jabber_chat_free_settings(account_t *acc, set_t **head)
 {
+        set_del(head, "always_use_nicks");
+
         set_del(head, "password");
 }
@@ -759 +785 @@
         ret->chat_join = jabber_chat_join_;
         ret->chat_with = jabber_chat_with_;
+        ret->chat_list = jabber_chat_list_;
         ret->chat_add_settings = jabber_chat_add_settings;
         ret->chat_free_settings = jabber_chat_free_settings;

protocols/jabber/jabber.h

@@ -75 +75 @@
         JCFLAG_MESSAGE_SENT = 1,        /* Set this after sending the first message, so
                                            we can detect echoes/backlogs. */
+        JCFLAG_ALWAYS_USE_NICKS = 2,
 } jabber_chat_flags_t;
 
@@ -262 +263 @@
 void jabber_iq_version_send(struct im_connection *ic, struct jabber_buddy *bud, void *data);
 int jabber_iq_disco_server(struct im_connection *ic);
+int jabber_iq_disco_muc(struct im_connection *ic, const char *muc_server);
 
 /* si.c */
@@ -339 +341 @@
 int sasl_oauth2_get_refresh_token(struct im_connection *ic, const char *msg);
 int sasl_oauth2_refresh(struct im_connection *ic, const char *refresh_token);
+void sasl_oauth2_got_token(gpointer data, const char *access_token, const char *refresh_token, const char *error);
 
 extern const struct oauth2_service oauth2_service_google;
 
 /* conference.c */
-struct groupchat *jabber_chat_join(struct im_connection *ic, const char *room, const char *nick, const char *password);
+struct groupchat *jabber_chat_join(struct im_connection *ic, const char *room, const char *nick, const char *password,
+                                   gboolean always_use_nicks);
 struct groupchat *jabber_chat_with(struct im_connection *ic, char *who);
 struct groupchat *jabber_chat_by_jid(struct im_connection *ic, const char *name);

protocols/jabber/jabber_util.c

@@ -315 +315 @@
         int i;
 
+        if (!jid1 || !jid2) {
+                return FALSE;
+        }
+
         for (i = 0;; i++) {
                 if (jid1[i] == '\0' || jid1[i] == '/' || jid2[i] == '\0' || jid2[i] == '/') {

protocols/jabber/message.c

@@ -27 +27 @@
 {
         struct im_connection *ic = data;
-        struct jabber_data *jd = ic->proto_data;
         char *from = xt_find_attr(node, carbons_sent ? "to" : "from");
         char *type = xt_find_attr(node, "type");
@@ -38 +37 @@
         if (!from) {
                 return XT_HANDLED; /* Consider this packet corrupted. */
-        }
-
-        /* try to detect hipchat's own version of self-messages */
-        if (jd->flags & JFLAG_HIPCHAT) {
-                struct xt_node *c;
-
-                if ((c = xt_find_node_by_attr(node->children, "delay", "xmlns", XMLNS_DELAY)) &&
-                    (s = xt_find_attr(c, "from_jid")) &&
-                    jabber_compare_jid(s, jd->me)) {
-                        carbons_sent = TRUE;
-                }
         }
 

protocols/jabber/presence.c

@@ -222 +222 @@
         cap = xt_new_node("c", NULL, NULL);
         xt_add_attr(cap, "xmlns", XMLNS_CAPS);
-
-        if (jd->flags & JFLAG_HIPCHAT) {
-                /* hipchat specific node, whitelisted by request to receive self-messages */
-                xt_add_attr(cap, "node", "http://bitlbee.org/xmpp/caps/hipchat");
-        } else {
-                xt_add_attr(cap, "node", "http://bitlbee.org/xmpp/caps");
-        }
+        xt_add_attr(cap, "node", "http://bitlbee.org/xmpp/caps");
         xt_add_attr(cap, "ver", BITLBEE_VERSION);   /* The XEP wants this hashed, but nobody's doing that. */
         xt_add_child(node, cap);

protocols/jabber/s5bytestream.c

@@ -928 +928 @@
                 proxy = next;
         }
+
+        g_free(proxysetting);
 }
 

protocols/jabber/sasl.c

@@ -39 +39 @@
 };
 
+/* """"""""""""""""""""""""""""""oauth"""""""""""""""""""""""""""""" */
+#define HIPCHAT_SO_CALLED_OAUTH_URL "https://hipchat.com/account/api"
+
 xt_status sasl_pkt_mechanisms(struct xt_node *node, gpointer data)
 {
@@ -45 +48 @@
         struct xt_node *c, *reply;
         char *s;
-        int sup_plain = 0, sup_digest = 0, sup_gtalk = 0, sup_anonymous = 0;
+        int sup_plain = 0, sup_digest = 0, sup_gtalk = 0, sup_anonymous = 0, sup_hipchat_oauth = 0;
         int want_oauth = FALSE, want_hipchat = FALSE, want_anonymous = FALSE;
         GString *mechs;
@@ -80 +83 @@
                 } else if (c->text && g_strcasecmp(c->text, "X-OAUTH2") == 0) {
                         sup_gtalk = 1;
+                } else if (c->text && g_strcasecmp(c->text, "X-HIPCHAT-OAUTH2") == 0) {
+                        sup_hipchat_oauth = 1;
                 }
 
@@ -90 +95 @@
 
         if (!want_oauth && !sup_plain && !sup_digest) {
-                if (!sup_gtalk) {
+                if (sup_gtalk || sup_hipchat_oauth) {
                         imcb_error(ic, "This server requires OAuth "
                                    "(supported schemes:%s)", mechs->str);
@@ -110 +115 @@
         }
 
-        if (sup_gtalk && want_oauth) {
-                int len;
-
-                /* X-OAUTH2 is, not *the* standard OAuth2 SASL/XMPP implementation.
-                   It's currently used by GTalk and vaguely documented on
-                   http://code.google.com/apis/cloudprint/docs/rawxmpp.html . */
-                xt_add_attr(reply, "mechanism", "X-OAUTH2");
-
-                len = strlen(jd->username) + strlen(jd->oauth2_access_token) + 2;
-                s = g_malloc(len + 1);
-                s[0] = 0;
-                strcpy(s + 1, jd->username);
-                strcpy(s + 2 + strlen(jd->username), jd->oauth2_access_token);
-                reply->text = base64_encode((unsigned char *) s, len);
+        if ((sup_gtalk || sup_hipchat_oauth) && want_oauth) {
+                GString *gs;
+
+                gs = g_string_sized_new(128);
+
+                g_string_append_c(gs, '\0');
+
+                if (sup_gtalk) {
+                        /* X-OAUTH2 is not *the* standard OAuth2 SASL/XMPP implementation.
+                           It's currently used by GTalk and vaguely documented on
+                           http://code.google.com/apis/cloudprint/docs/rawxmpp.html */
+                        xt_add_attr(reply, "mechanism", "X-OAUTH2");
+
+                        g_string_append(gs, jd->username);
+                        g_string_append_c(gs, '\0');
+                        g_string_append(gs, jd->oauth2_access_token);
+                } else if (sup_hipchat_oauth) {
+                        /* Hipchat's variant, not standard either, is documented here:
+                           https://docs.atlassian.com/hipchat.xmpp/latest/xmpp/auth.html */
+                        xt_add_attr(reply, "mechanism", "oauth2");
+
+                        g_string_append(gs, jd->oauth2_access_token);
+                        g_string_append_c(gs, '\0');
+                        g_string_append(gs, set_getstr(&ic->acc->set, "resource"));
+                }
+
+                reply->text = base64_encode((unsigned char *) gs->str, gs->len);
                 reply->text_len = strlen(reply->text);
-                g_free(s);
+                g_string_free(gs, TRUE);
+
         } else if (want_oauth) {
                 imcb_error(ic, "OAuth requested, but not supported by server");
@@ -149 +168 @@
                 /* The rest will be done later, when we receive a <challenge/>. */
         } else if (sup_plain) {
-                int len;
                 GString *gs;
                 char *username;
@@ -174 +192 @@
                 }
 
-                len = gs->len;
-                s = g_string_free(gs, FALSE);
-
-                reply->text = base64_encode((unsigned char *) s, len);
+                reply->text = base64_encode((unsigned char *) gs->str, gs->len);
                 reply->text_len = strlen(reply->text);
-                g_free(s);
+                g_string_free(gs, TRUE);
         }
 
@@ -428 +443 @@
 {
         struct jabber_data *jd = ic->proto_data;
-        char *msg, *url;
 
         imcb_log(ic, "Starting OAuth authentication");
@@ -434 +448 @@
         /* Temporary contact, just used to receive the OAuth response. */
         imcb_add_buddy(ic, JABBER_OAUTH_HANDLE, NULL);
-        url = oauth2_url(jd->oauth2_service);
-        msg = g_strdup_printf("Open this URL in your browser to authenticate: %s", url);
-        imcb_buddy_msg(ic, JABBER_OAUTH_HANDLE, msg, 0, 0);
+
+        if (jd->flags & JFLAG_HIPCHAT) {
+                imcb_buddy_msg(ic, JABBER_OAUTH_HANDLE,
+                        "Open this URL and generate a token with 'View Group' and 'Send Message' scopes: "
+                        HIPCHAT_SO_CALLED_OAUTH_URL, 0, 0);
+        } else {
+                char *msg, *url;
+
+                url = oauth2_url(jd->oauth2_service);
+                msg = g_strdup_printf("Open this URL in your browser to authenticate: %s", url);
+                imcb_buddy_msg(ic, JABBER_OAUTH_HANDLE, msg, 0, 0);
+
+                g_free(msg);
+                g_free(url);
+        }
         imcb_buddy_msg(ic, JABBER_OAUTH_HANDLE, "Respond to this message with the returned "
                        "authorization token.", 0, 0);
 
-        g_free(msg);
-        g_free(url);
 }
 
@@ -453 +477 @@
         return FALSE;
 }
-
-static void sasl_oauth2_got_token(gpointer data, const char *access_token, const char *refresh_token,
-                                  const char *error);
 
 int sasl_oauth2_get_refresh_token(struct im_connection *ic, const char *msg)
@@ -486 +507 @@
 }
 
-static void sasl_oauth2_got_token(gpointer data, const char *access_token, const char *refresh_token, const char *error)
+void sasl_oauth2_got_token(gpointer data, const char *access_token, const char *refresh_token, const char *error)
 {
         struct im_connection *ic = data;

protocols/jabber/si.c

@@ -393 +393 @@
         struct jabber_transfer *tf = NULL;
         struct jabber_data *jd = ic->proto_data;
+        struct jabber_error *err;
 
         if (!(tgt_jid = xt_find_attr(node, "from")) ||
-            !(ini_jid = xt_find_attr(node, "to"))) {
+            !(ini_jid = xt_find_attr(node, "to")) ||
+            !(iq_id   = xt_find_attr(node, "id"))) {
                 imcb_log(ic, "Invalid SI response from=%s to=%s", tgt_jid, ini_jid);
+                return XT_HANDLED;
+        }
+
+        /* Let's see if we can find out what this bytestream should be for... */
+
+        for (tflist = jd->filetransfers; tflist; tflist = g_slist_next(tflist)) {
+                struct jabber_transfer *tft = tflist->data;
+                if ((strcmp(tft->iq_id, iq_id) == 0)) {
+                        tf = tft;
+                        break;
+                }
+        }
+
+        if (!tf) {
+                imcb_log(ic, "WARNING: Received bytestream request from %s that doesn't match an SI request", ini_jid);
+                return XT_HANDLED;
+        }
+
+        err = jabber_error_parse(xt_find_node(node->children, "error"), XMLNS_STANZA_ERROR);
+
+        if (err) {
+                if (g_strcmp0(err->code, "forbidden") == 0) {
+                        imcb_log(ic, "File %s: %s rejected the transfer", tf->ft->file_name, tgt_jid);
+                } else {
+                        imcb_log(ic, "Error: Stream initiation request failed: %s (%s)", err->code, err->text);
+                }
+                imcb_file_canceled(ic, tf->ft, "Stream initiation request failed");
+                jabber_error_free(err);
                 return XT_HANDLED;
         }
@@ -409 +439 @@
          *                                      <value>
          */
-        if (!(tgt_jid = xt_find_attr(node, "from")) ||
-            !(ini_jid = xt_find_attr(node, "to")) ||
-            !(iq_id   = xt_find_attr(node, "id")) ||
-            !(c = xt_find_node(node->children, "si")) ||
+        if (!(c = xt_find_node(node->children, "si")) ||
             !(cmp = xt_find_attr(c, "xmlns")) ||
             !(strcmp(cmp, XMLNS_SI) == 0) ||
@@ -439 +466 @@
         }
 
-        /* Let's see if we can find out what this bytestream should be for... */
-
-        for (tflist = jd->filetransfers; tflist; tflist = g_slist_next(tflist)) {
-                struct jabber_transfer *tft = tflist->data;
-                if ((strcmp(tft->iq_id, iq_id) == 0)) {
-                        tf = tft;
-                        break;
-                }
-        }
-
-        if (!tf) {
-                imcb_log(ic, "WARNING: Received bytestream request from %s that doesn't match an SI request", ini_jid);
-                return XT_HANDLED;
-        }
-
         tf->ini_jid = g_strdup(ini_jid);
         tf->tgt_jid = g_strdup(tgt_jid);

protocols/nogaim.c

@@ -40 +40 @@
 
 #ifdef WITH_PLUGINS
+GList *plugins = NULL;
+
+static gint pluginscmp(gconstpointer a, gconstpointer b, gpointer data)
+{
+        const struct plugin_info *ia = a;
+        const struct plugin_info *ib = b;
+
+        return g_strcasecmp(ia->name, ib->name);
+}
+
 gboolean load_plugin(char *path)
 {
+        GList *l;
+        struct plugin_info *i;
+        struct plugin_info *info;
+        struct plugin_info * (*info_function) (void) = NULL;
         void (*init_function) (void);
 
         GModule *mod = g_module_open(path, G_MODULE_BIND_LAZY);
+        gboolean loaded = FALSE;
 
         if (!mod) {
-                log_message(LOGLVL_ERROR, "Can't find `%s', not loading (%s)\n", path, g_module_error());
+                log_message(LOGLVL_ERROR, "Error loading plugin `%s': %s\n", path, g_module_error());
                 return FALSE;
+        }
+
+        if (g_module_symbol(mod, "init_plugin_info", (gpointer *) &info_function)) {
+                info = info_function();
+
+                if (info->abiver != BITLBEE_ABI_VERSION_CODE) {
+                        log_message(LOGLVL_ERROR,
+                                    "`%s' uses ABI %u but %u is required\n",
+                                    path, info->abiver,
+                                    BITLBEE_ABI_VERSION_CODE);
+                        g_module_close(mod);
+                        return FALSE;
+                }
+
+                if (!info->name || !info->version) {
+                        log_message(LOGLVL_ERROR,
+                                    "Name or version missing from the "
+                                    "plugin info in `%s'\n", path);
+                        g_module_close(mod);
+                        return FALSE;
+                }
+
+                for (l = plugins; l; l = l->next) {
+                        i = l->data;
+
+                        if (g_strcasecmp(i->name, info->name) == 0) {
+                                loaded = TRUE;
+                                break;
+                        }
+                }
+
+                if (loaded) {
+                        log_message(LOGLVL_WARNING,
+                                    "%s plugin already loaded\n",
+                                    info->name);
+                        g_module_close(mod);
+                        return FALSE;
+                }
+        } else {
+                log_message(LOGLVL_WARNING, "Can't find function `init_plugin_info' in `%s'\n", path);
         }
 
         if (!g_module_symbol(mod, "init_plugin", (gpointer *) &init_function)) {
                 log_message(LOGLVL_WARNING, "Can't find function `init_plugin' in `%s'\n", path);
+                g_module_close(mod);
                 return FALSE;
         }
 
+        if (info_function) {
+                plugins = g_list_insert_sorted_with_data(plugins, info,
+                                                         pluginscmp, NULL);
+        }
+
         init_function();
-
         return TRUE;
 }
@@ -73 +133 @@
 
                 while ((entry = g_dir_read_name(dir))) {
+                        if (!g_str_has_suffix(entry, "." G_MODULE_SUFFIX)) {
+                                continue;
+                        }
+
                         path = g_build_filename(global.conf->plugindir, entry, NULL);
                         if (!path) {
@@ -86 +150 @@
                 g_dir_close(dir);
         }
+}
+
+GList *get_plugins()
+{
+        return plugins;
 }
 #endif
@@ -168 +237 @@
         load_plugins();
 #endif
+}
+
+GList *get_protocols()
+{
+        return protocols;
+}
+
+GList *get_protocols_disabled()
+{
+        return disabled_protocols;
 }
 
@@ -495 +574 @@
 }
 
-/* Mainly meant for ICQ (and now also for Jabber conferences) to allow IM
-   modules to suggest a nickname for a handle. */
-void imcb_buddy_nick_hint(struct im_connection *ic, const char *handle, const char *nick)
+/* Implements either imcb_buddy_nick_hint() or imcb_buddy_nick_change() depending on the value of 'change' */
+static void buddy_nick_hint_or_change(struct im_connection *ic, const char *handle, const char *nick, gboolean change)
 {
         bee_t *bee = ic->bee;
@@ -509 +587 @@
         bu->nick = g_strdup(nick);
 
-        if (bee->ui->user_nick_hint) {
+        if (change && bee->ui->user_nick_change) {
+                bee->ui->user_nick_change(bee, bu, nick);
+        } else if (!change && bee->ui->user_nick_hint) {
                 bee->ui->user_nick_hint(bee, bu, nick);
         }
+}
+
+/* Soft variant, for newly created users. Does nothing if it's already online */
+void imcb_buddy_nick_hint(struct im_connection *ic, const char *handle, const char *nick)
+{
+        buddy_nick_hint_or_change(ic, handle, nick, FALSE);
+}
+
+/* Hard variant, always changes the nick */
+void imcb_buddy_nick_change(struct im_connection *ic, const char *handle, const char *nick)
+{
+        buddy_nick_hint_or_change(ic, handle, nick, TRUE);
 }
 
@@ -667 +759 @@
         if (away && *away) {
                 GList *m = ic->acc->prpl->away_states(ic);
+                if (m == NULL) {
+                        return 0;
+                }
                 msg = ic->acc->flags & ACC_FLAG_AWAY_MESSAGE ? away : NULL;
                 away = imc_away_state_find(m, away, &msg) ? :

protocols/nogaim.h

@@ -102 +102 @@
 
         GSList *groupchats;
+        GSList *chatlist;
 };
 
@@ -144 +145 @@
         char *description;
 };
+
+/* This enum takes a few things from libpurple and a few things from old OPT_ flags.
+ * The only flag that was used before this struct was PRPL_OPT_NOOTR.
+ *
+ * The libpurple ones only use the same values as the PurpleProtocolOptions
+ * enum for convenience, but there's no promise of direct compatibility with
+ * those values. As of libpurple 2.8.0 they use up to 0x800 (1 << 11), which is
+ * a nice coincidence.
+ */
+typedef enum {
+        /* The protocol doesn't use passwords
+         * Mirrors libpurple's OPT_PROTO_NO_PASSWORD */
+        PRPL_OPT_NO_PASSWORD = 1 << 4,
+
+        /* The protocol doesn't require passwords, but may use them
+         * Mirrors libpurple's OPT_PROTO_PASSWORD_OPTIONAL */
+        PRPL_OPT_PASSWORD_OPTIONAL = 1 << 7,
+
+        /* The protocol is not suitable for OTR, see OPT_NOOTR */
+        PRPL_OPT_NOOTR = 1 << 12,
+} prpl_options_t;
 
 struct prpl {
@@ -269 +291 @@
         gboolean (* handle_is_self) (struct im_connection *, const char *who);
 
+        /* This sets/updates the im_connection->chatlist field with a
+         * bee_chat_info_t GSList. This function should ensure the
+         * bee_chat_list_finish() function gets called at some point
+         * after the chat list is completely updated.
+         */
+        void (* chat_list) (struct im_connection *, const char *server);
+
         /* Some placeholders so eventually older plugins may cooperate with newer BitlBees. */
         void *resv1;
@@ -277 +306 @@
 };
 
+struct plugin_info
+{
+        guint abiver;
+        const char *name;
+        const char *version;
+        const char *description;
+        const char *author;
+        const char *url;
+};
+
+#ifdef WITH_PLUGINS
+G_MODULE_EXPORT GList *get_plugins();
+#endif
+
 /* im_api core stuff. */
 void nogaim_init();
+G_MODULE_EXPORT GList *get_protocols();
+G_MODULE_EXPORT GList *get_protocols_disabled();
 G_MODULE_EXPORT GSList *get_connections();
 G_MODULE_EXPORT struct prpl *find_protocol(const char *name);
@@ -330 +375 @@
 G_MODULE_EXPORT void imcb_rename_buddy(struct im_connection *ic, const char *handle, const char *realname);
 G_MODULE_EXPORT void imcb_buddy_nick_hint(struct im_connection *ic, const char *handle, const char *nick);
+G_MODULE_EXPORT void imcb_buddy_nick_change(struct im_connection *ic, const char *handle, const char *nick);
 G_MODULE_EXPORT void imcb_buddy_action_response(bee_user_t *bu, const char *action, char * const args[], void *data);
 G_MODULE_EXPORT GSList *imcb_get_local_contacts(struct im_connection *ic);

protocols/oscar/conn.c

@@ -383 +383 @@
 {
         aim_conn_t *connstruct;
-        guint16 port = AIM_LOGIN_PORT;
-        char *host;
-        int i;
 
         if (!(connstruct = aim_conn_getnext(sess))) {
@@ -400 +397 @@
         }
 
-        /*
-         * As of 23 Jul 1999, AOL now sends the port number, preceded by a
-         * colon, in the BOS redirect.  This fatally breaks all previous
-         * libfaims.  Bad, bad AOL.
-         *
-         * We put this here to catch every case.
-         *
-         */
-
-        for (i = 0; i < (int) strlen(dest); i++) {
-                if (dest[i] == ':') {
-                        port = atoi(&(dest[i + 1]));
-                        break;
-                }
-        }
-
-        host = (char *) g_malloc(i + 1);
-        strncpy(host, dest, i);
-        host[i] = '\0';
-
-        connstruct->fd = proxy_connect(host, port, NULL, NULL);
-
-        g_free(host);
+        /* The code that used to be here was very broken */
+        g_return_val_if_reached(connstruct);
 
         return connstruct;

protocols/purple/bpurple.h

@@ -13 +13 @@
     GHashTable *input_requests;
     guint next_request_id;
+    char *chat_list_server;
+    GSList *filetransfers;
 };
 

protocols/purple/ft.c

@@ -42 +42 @@
         char *fn, *handle;
         gboolean ui_wants_data;
+        int timeout;
 };
 
@@ -64 +65 @@
         struct prpl_xfer_data *px = ft->data;
 
-        purple_xfer_request_denied(px->xfer);
+        if (px->xfer) {
+                if (!purple_xfer_is_completed(px->xfer) && !purple_xfer_is_canceled(px->xfer)) {
+                        purple_xfer_cancel_local(px->xfer);
+                }
+                px->xfer->ui_data = NULL;
+                purple_xfer_unref(px->xfer);
+                px->xfer = NULL;
+        }
+}
+
+static void prpl_xfer_free(struct file_transfer *ft)
+{
+        struct prpl_xfer_data *px = ft->data;
+        struct purple_data *pd = px->ic->proto_data;
+
+        pd->filetransfers = g_slist_remove(pd->filetransfers, px);
+
+        if (px->xfer) {
+                px->xfer->ui_data = NULL;
+                purple_xfer_unref(px->xfer);
+        }
+
+        if (px->timeout) {
+                b_event_remove(px->timeout);
+        }
+
+        g_free(px->fn);
+        g_free(px->handle);
+        if (px->fd >= 0) {
+                close(px->fd);
+        }
+        g_free(px);
 }
 
 static void prplcb_xfer_new(PurpleXfer *xfer)
 {
+        purple_xfer_ref(xfer);
+
         if (purple_xfer_get_type(xfer) == PURPLE_XFER_RECEIVE) {
                 struct prpl_xfer_data *px = g_new0(struct prpl_xfer_data, 1);
+                struct purple_data *pd;
 
                 xfer->ui_data = px;
@@ -77 +112 @@
                 px->fd = -1;
                 px->ic = purple_ic_by_pa(xfer->account);
+
+                pd = px->ic->proto_data;
+                pd->filetransfers = g_slist_prepend(pd->filetransfers, px);
 
                 purple_xfer_set_local_filename(xfer, px->fn);
@@ -112 +150 @@
         px->ft->accept = prpl_xfer_accept;
         px->ft->canceled = prpl_xfer_canceled;
+        px->ft->free = prpl_xfer_free;
         px->ft->write_request = prpl_xfer_write_request;
 
@@ -164 +203 @@
 
 
-/* Generic (IM<>UI): */
 static void prplcb_xfer_destroy(PurpleXfer *xfer)
 {
         struct prpl_xfer_data *px = xfer->ui_data;
 
-        g_free(px->fn);
-        g_free(px->handle);
-        if (px->fd >= 0) {
-                close(px->fd);
-        }
-        g_free(px);
+        if (px) {
+                px->xfer = NULL;
+        }
 }
 
@@ -224 +259 @@
         struct prpl_xfer_data *px = xfer->ui_data;
 
-        if (px->ft) {
+        if (px && px->ft) {
                 imcb_file_canceled(px->ic, px->ft, "Canceled by remote end");
-        } else {
+        } else if (px) {
                 /* px->ft == NULL for sends, because of the two stages. :-/ */
                 imcb_error(px->ic, "File transfer cancelled by remote end");
@@ -240 +275 @@
 {
         struct prpl_xfer_data *px = g_new0(struct prpl_xfer_data, 1);
+        struct purple_data *pd;
         char *dir, *basename;
 
         ft->data = px;
         px->ft = ft;
+        px->ft->free = prpl_xfer_free;
 
         dir = g_strdup("/tmp/bitlbee-purple-ft.XXXXXX");
@@ -272 +309 @@
         px->handle = g_strdup(handle);
 
+        pd = px->ic->proto_data;
+        pd->filetransfers = g_slist_prepend(pd->filetransfers, px);
+
         imcb_log(ic,
                  "Due to libpurple limitations, the file has to be cached locally before proceeding with the actual file transfer. Please wait...");
 
-        b_timeout_add(0, purple_transfer_request_cb, ft);
+        px->timeout = b_timeout_add(0, purple_transfer_request_cb, ft);
 }
 
@@ -295 +335 @@
         struct prpl_xfer_data *px = ft->data;
 
+        px->timeout = 0;
+
         if (ft->write == NULL) {
                 ft->write = prpl_xfer_write;
@@ -322 +364 @@
                 px->ft = NULL;
         } else {
-                b_timeout_add(0, purple_transfer_request_cb, ft);
+                px->timeout = b_timeout_add(0, purple_transfer_request_cb, ft);
         }
 
         return TRUE;
+}
+
+void purple_transfer_cancel_all(struct im_connection *ic)
+{
+        struct purple_data *pd = ic->proto_data;
+
+        while (pd->filetransfers) {
+                struct prpl_xfer_data *px = pd->filetransfers->data;
+
+                if (px->ft) {
+                        imcb_file_canceled(ic, px->ft, "Logging out");
+                }
+
+                pd->filetransfers = g_slist_remove(pd->filetransfers, px);
+        }
 }
 

protocols/purple/purple.c

@@ -43 +43 @@
                                    const char *message, const char *who);
 
+void purple_transfer_cancel_all(struct im_connection *ic);
+
 /* purple_request_input specific stuff */
 typedef void (*ri_callback_t)(gpointer, const gchar *);
@@ -54 +56 @@
 };
 
+struct purple_roomlist_data {
+        GSList *chats;
+        gint topic;
+        gboolean initialized;
+};
+
+
 struct im_connection *purple_ic_by_pa(PurpleAccount *pa)
 {
@@ -94 +103 @@
 }
 
+static char *purple_get_account_prpl_id(account_t *acc)
+{
+        /* "oscar" is how non-purple bitlbee calls it,
+         * and it might be icq or aim, depending on the username */
+        if (g_strcmp0(acc->prpl->name, "oscar") == 0) {
+                return (g_ascii_isdigit(acc->user[0])) ? "prpl-icq" : "prpl-aim";
+        }
+
+        return acc->prpl->data;
+}
+
 static void purple_init(account_t *acc)
 {
-        PurplePlugin *prpl = purple_plugins_find_with_id((char *) acc->prpl->data);
+        char *prpl_id = purple_get_account_prpl_id(acc);
+        PurplePlugin *prpl = purple_plugins_find_with_id(prpl_id);
         PurplePluginProtocolInfo *pi = prpl->info->extra_info;
         PurpleAccount *pa;
@@ -262 +283 @@
         /* Go through all away states to figure out if away/status messages
            are possible. */
-        pa = purple_account_new(acc->user, (char *) acc->prpl->data);
+        pa = purple_account_new(acc->user, prpl_id);
         for (st = purple_account_get_status_types(pa); st; st = st->next) {
                 PurpleStatusPrimitive prim = purple_status_type_get_primitive(st->data);
@@ -345 +366 @@
 
         ic->proto_data = pd = g_new0(struct purple_data, 1);
-        pd->account = purple_account_new(acc->user, (char *) acc->prpl->data);
+        pd->account = purple_account_new(acc->user, purple_get_account_prpl_id(acc));
         pd->input_requests = g_hash_table_new_full(g_direct_hash, g_direct_equal,
                                                    NULL, g_free);
@@ -371 +392 @@
         }
 
+        if (pd->filetransfers) {
+                purple_transfer_cancel_all(ic);
+        }
+
         purple_account_set_enabled(pd->account, "BitlBee", FALSE);
         purple_connections = g_slist_remove(purple_connections, ic);
         purple_accounts_remove(pd->account);
+        imcb_chat_list_free(ic);
+        g_free(pd->chat_list_server);
         g_hash_table_destroy(pd->input_requests);
         g_free(pd);
@@ -673 +700 @@
 }
 
+void purple_chat_set_topic(struct groupchat *gc, char *topic)
+{
+        PurpleConversation *pc = gc->data;
+        PurpleConvChat *pcc = PURPLE_CONV_CHAT(pc);
+        struct purple_data *pd = gc->ic->proto_data;
+        PurplePlugin *prpl = purple_plugins_find_with_id(pd->account->protocol_id);
+        PurplePluginProtocolInfo *pi = prpl->info->extra_info;
+
+        if (pi->set_chat_topic) {
+                pi->set_chat_topic(purple_account_get_connection(pd->account),
+                                   purple_conv_chat_get_id(pcc),
+                                   topic);
+        }
+}
+
 void purple_chat_kick(struct groupchat *gc, char *who, const char *message)
 {
@@ -697 +739 @@
         GHashTable *chat_hash;
         PurpleConversation *conv;
+        struct groupchat *gc;
         GList *info, *l;
 
@@ -730 +773 @@
         g_list_free(info);
 
+        /* do this before serv_join_chat to handle cases where prplcb_conv_new is called immediately (not async) */
+        gc = imcb_chat_new(ic, room);
+
         serv_join_chat(purple_account_get_connection(pd->account), chat_hash);
 
         g_hash_table_destroy(chat_hash);
 
-        return imcb_chat_new(ic, room);
+        return gc;
+}
+
+void purple_chat_list(struct im_connection *ic, const char *server)
+{
+        PurpleRoomlist *list;
+        struct purple_data *pd = ic->proto_data;
+        PurplePlugin *prpl = purple_plugins_find_with_id(pd->account->protocol_id);
+        PurplePluginProtocolInfo *pi = prpl->info->extra_info;
+
+        if (!pi || !pi->roomlist_get_list) {
+                imcb_log(ic, "Room listing unsupported by this purple plugin");
+                return;
+        }
+
+        g_free(pd->chat_list_server);
+        pd->chat_list_server = (server && *server) ? g_strdup(server) : NULL;
+
+        list = purple_roomlist_get_list(pd->account->gc);
+
+        if (list) {
+                struct purple_roomlist_data *rld = list->ui_data;
+                rld->initialized = TRUE;
+
+                purple_roomlist_ref(list);
+        }
 }
 
@@ -970 +1041 @@
 
 /* Generic handler for IM or chat messages, covers write_chat, write_im and write_conv */
-static void handle_conv_msg(PurpleConversation *conv, const char *who, const char *message, guint32 bee_flags, time_t mtime)
+static void handle_conv_msg(PurpleConversation *conv, const char *who, const char *message_, guint32 bee_flags, time_t mtime)
 {
         struct im_connection *ic = purple_ic_by_pa(conv->account);
         struct groupchat *gc = conv->ui_data;
+        char *message = g_strdup(message_);
         PurpleBuddy *buddy;
 
@@ -982 +1054 @@
 
         if (conv->type == PURPLE_CONV_TYPE_IM) {
-                imcb_buddy_msg(ic, (char *) who, (char *) message, bee_flags, mtime);
+                imcb_buddy_msg(ic, who, message, bee_flags, mtime);
         } else if (gc) {
-                imcb_chat_msg(gc, who, (char *) message, bee_flags, mtime);
-        }
+                imcb_chat_msg(gc, who, message, bee_flags, mtime);
+        }
+
+        g_free(message);
 }
 
@@ -1171 +1245 @@
         struct im_connection *ic = purple_ic_by_pa(account);
         struct purple_data *pd = ic->proto_data;
-        struct request_input_data *ri = g_new0(struct request_input_data, 1);
-        guint id = pd->next_request_id++;
+        struct request_input_data *ri;
+        guint id;
+
+        /* hack so that jabber's chat list doesn't ask for conference server twice */
+        if (pd->chat_list_server && title && g_strcmp0(title, "Enter a Conference Server") == 0) {
+                ((ri_callback_t) ok_cb)(user_data, pd->chat_list_server);
+                g_free(pd->chat_list_server);
+                pd->chat_list_server = NULL;
+                return NULL;
+        }
+
+        id = pd->next_request_id++;
+        ri = g_new0(struct request_input_data, 1);
 
         ri->id = id;
@@ -1182 +1267 @@
 
         imcb_add_buddy(ic, ri->buddy, NULL);
-        imcb_buddy_msg(ic, ri->buddy, secondary, 0, 0);
+
+        if (title && *title) {
+                imcb_buddy_msg(ic, ri->buddy, title, 0, 0);
+        }
+
+        if (primary && *primary) {
+                imcb_buddy_msg(ic, ri->buddy, primary, 0, 0);
+        }
+
+        if (secondary && *secondary) {
+                imcb_buddy_msg(ic, ri->buddy, secondary, 0, 0);
+        }
 
         return ri;
@@ -1256 +1352 @@
         prplcb_privacy_deny_added,         /* deny_added */
         prplcb_privacy_deny_removed,       /* deny_removed */
+};
+
+static void prplcb_roomlist_create(PurpleRoomlist *list)
+{
+        struct purple_roomlist_data *rld;
+
+        list->ui_data = rld = g_new0(struct purple_roomlist_data, 1);
+        rld->topic = -1;
+}
+
+static void prplcb_roomlist_set_fields(PurpleRoomlist *list, GList *fields)
+{
+        gint topic = -1;
+        GList *l;
+        guint i;
+        PurpleRoomlistField *field;
+        struct purple_roomlist_data *rld = list->ui_data;
+
+        for (i = 0, l = fields; l; i++, l = l->next) {
+                field = l->data;
+
+                /* Use the first visible string field as a fallback topic */
+                if (i != 0 && topic < 0 && !field->hidden &&
+                    field->type == PURPLE_ROOMLIST_FIELD_STRING) {
+                        topic = i;
+                }
+
+                if ((g_strcasecmp(field->name, "description") == 0) ||
+                    (g_strcasecmp(field->name, "topic") == 0)) {
+                        if (field->type == PURPLE_ROOMLIST_FIELD_STRING) {
+                                rld->topic = i;
+                        }
+                }
+        }
+
+        if (rld->topic < 0) {
+                rld->topic = topic;
+        }
+}
+
+static void prplcb_roomlist_add_room(PurpleRoomlist *list, PurpleRoomlistRoom *room)
+{
+        bee_chat_info_t *ci;
+        const char *title;
+        const char *topic;
+        GList *fields;
+        struct purple_roomlist_data *rld = list->ui_data;
+
+        fields = purple_roomlist_room_get_fields(room);
+        title = purple_roomlist_room_get_name(room);
+
+        if (rld->topic >= 0) {
+                topic = g_list_nth_data(fields, rld->topic);
+        } else {
+                topic = NULL;
+        }
+
+        ci = g_new(bee_chat_info_t, 1);
+        ci->title = g_strdup(title);
+        ci->topic = g_strdup(topic);
+        rld->chats = g_slist_prepend(rld->chats, ci);
+}
+
+static void prplcb_roomlist_in_progress(PurpleRoomlist *list, gboolean in_progress)
+{
+        struct im_connection *ic;
+        struct purple_data *pd;
+        struct purple_roomlist_data *rld = list->ui_data;
+
+        if (in_progress || !rld) {
+                return;
+        }
+
+        ic = purple_ic_by_pa(list->account);
+        imcb_chat_list_free(ic);
+
+        pd = ic->proto_data;
+        g_free(pd->chat_list_server);
+        pd->chat_list_server = NULL;
+
+        ic->chatlist = g_slist_reverse(rld->chats);
+        rld->chats = NULL;
+
+        imcb_chat_list_finish(ic);
+
+        if (rld->initialized) {
+                purple_roomlist_unref(list);
+        }
+}
+
+static void prplcb_roomlist_destroy(PurpleRoomlist *list)
+{
+        g_free(list->ui_data);
+        list->ui_data = NULL;
+}
+
+static PurpleRoomlistUiOps bee_roomlist_uiops =
+{
+        NULL,                         /* show_with_account */
+        prplcb_roomlist_create,       /* create */
+        prplcb_roomlist_set_fields,   /* set_fields */
+        prplcb_roomlist_add_room,     /* add_room */
+        prplcb_roomlist_in_progress,  /* in_progress */
+        prplcb_roomlist_destroy,      /* destroy */
 };
 
@@ -1422 +1622 @@
         purple_request_set_ui_ops(&bee_request_uiops);
         purple_privacy_set_ui_ops(&bee_privacy_uiops);
+        purple_roomlist_set_ui_ops(&bee_roomlist_uiops);
         purple_notify_set_ui_ops(&bee_notify_uiops);
         purple_accounts_set_ui_ops(&bee_account_uiops);
@@ -1438 +1639 @@
         char *dir;
 
+        if (purple_get_core() != NULL) {
+                log_message(LOGLVL_ERROR, "libpurple already initialized. "
+                            "Please use inetd or ForkDaemon mode instead.");
+                return;
+        }
+
         g_assert((int) B_EV_IO_READ == (int) PURPLE_INPUT_READ);
         g_assert((int) B_EV_IO_WRITE == (int) PURPLE_INPUT_WRITE);
@@ -1443 +1650 @@
         dir = g_strdup_printf("%s/purple", global.conf->configdir);
         purple_util_set_user_dir(dir);
+        g_free(dir);
+
+        dir = g_strdup_printf("%s/purple", global.conf->plugindir);
+        purple_plugins_add_search_path(dir);
         g_free(dir);
 
@@ -1506 +1717 @@
         funcs.chat_with = purple_chat_with;
         funcs.chat_invite = purple_chat_invite;
+        funcs.chat_topic = purple_chat_set_topic;
         funcs.chat_kick = purple_chat_kick;
         funcs.chat_leave = purple_chat_leave;
         funcs.chat_join = purple_chat_join;
+        funcs.chat_list = purple_chat_list;
         funcs.transfer_request = purple_transfer_request;
 
@@ -1517 +1730 @@
         for (prots = purple_plugins_get_protocols(); prots; prots = prots->next) {
                 PurplePlugin *prot = prots->data;
+                PurplePluginProtocolInfo *pi = prot->info->extra_info;
                 struct prpl *ret;
 
@@ -1530 +1744 @@
                         ret->name += 5;
                 }
+
+                if (pi->options & OPT_PROTO_NO_PASSWORD) {
+                        ret->options |= PRPL_OPT_NO_PASSWORD;
+                }
+
+                if (pi->options & OPT_PROTO_PASSWORD_OPTIONAL) {
+                        ret->options |= PRPL_OPT_PASSWORD_OPTIONAL;
+                }
+
                 register_protocol(ret);
 
@@ -1539 +1762 @@
                         ret = g_memdup(&funcs, sizeof(funcs));
                         ret->name = "oscar";
-                        ret->data = prot->info->id;
+                        /* purple_get_account_prpl_id() determines the actual protocol ID (icq/aim) */
+                        ret->data = NULL;
                         register_protocol(ret);
                 }

protocols/skype/skype.c

@@ -1763 +1763 @@
         register_protocol(ret);
 }
+
+struct plugin_info *init_plugin_info(void)
+{
+        static struct plugin_info info = {
+                BITLBEE_ABI_VERSION_CODE,
+                "skype",
+                BITLBEE_VERSION,
+                "Skype protocol plugin",
+                NULL,
+                NULL
+        };
+
+        return &info;
+}

protocols/twitter/twitter.c

@@ -345 +345 @@
                 imcb_log(ic, "Getting contact list");
                 twitter_get_friends_ids(ic, -1);
+                twitter_get_mutes_ids(ic, -1);
+                twitter_get_noretweets_ids(ic, -1);
         } else {
                 twitter_main_loop_start(ic);
@@ -469 +471 @@
         g_regex_match(regex, msg, 0, &match_info);
         while (g_match_info_matches(match_info)) {
-                gchar *s, *url;
+                gchar *url;
 
                 url = g_match_info_fetch(match_info, 2);
                 url_len_diff += target_len - g_utf8_strlen(url, -1);
 
-                /* Add another character for https://t.co/... URLs */
-                if ((s = g_match_info_fetch(match_info, 3))) {
-                        url_len_diff += 1;
-                        g_free(s);
-                }
                 g_free(url);
                 g_match_info_next(match_info, NULL);
@@ -541 +538 @@
         if (strcmp(acc->prpl->name, "twitter") == 0) {
                 def_url = TWITTER_API_URL;
-                def_tul = "22";
+                def_tul = "23";
                 def_mentions = "true";
         } else {                /* if( strcmp( acc->prpl->name, "identica" ) == 0 ) */
@@ -690 +687 @@
                 }
 
+                g_slist_foreach(td->mutes_ids, (GFunc) g_free, NULL);
+                g_slist_free(td->mutes_ids);
+
+                g_slist_foreach(td->noretweets_ids, (GFunc) g_free, NULL);
+                g_slist_free(td->noretweets_ids);
+
                 http_close(td->stream);
                 twitter_filter_remove_all(ic);
@@ -948 +951 @@
         } else if ((g_strcasecmp(cmd[0], "favourite") == 0 ||
                     g_strcasecmp(cmd[0], "favorite") == 0 ||
-                    g_strcasecmp(cmd[0], "fav") == 0) && cmd[1]) {
+                    g_strcasecmp(cmd[0], "fav") == 0 ||
+                    g_strcasecmp(cmd[0], "like") == 0) && cmd[1]) {
                 if ((id = twitter_message_id_from_command_arg(ic, cmd[1], NULL))) {
                         twitter_favourite_tweet(ic, id);
@@ -960 +964 @@
         } else if (g_strcasecmp(cmd[0], "unfollow") == 0 && cmd[1]) {
                 twitter_remove_buddy(ic, cmd[1], NULL);
+                goto eof;
+        } else if (g_strcasecmp(cmd[0], "mute") == 0 && cmd[1]) {
+                twitter_mute_create_destroy(ic, cmd[1], 1);
+                goto eof;
+        } else if (g_strcasecmp(cmd[0], "unmute") == 0 && cmd[1]) {
+                twitter_mute_create_destroy(ic, cmd[1], 0);
                 goto eof;
         } else if ((g_strcasecmp(cmd[0], "report") == 0 ||
@@ -1082 +1092 @@
         struct prpl *ret = g_new0(struct prpl, 1);
 
-        ret->options = OPT_NOOTR;
+        ret->options = PRPL_OPT_NOOTR | PRPL_OPT_NO_PASSWORD;
         ret->name = "twitter";
         ret->login = twitter_login;
@@ -1109 +1119 @@
         ret = g_memdup(ret, sizeof(struct prpl));
         ret->name = "identica";
+        ret->options =  PRPL_OPT_NOOTR;
         register_protocol(ret);
 }

protocols/twitter/twitter.h

@@ -61 +61 @@
 
         GSList *follow_ids;
+        GSList *mutes_ids;
+        GSList *noretweets_ids;
         GSList *filters;
 

protocols/twitter/twitter_http.c

@@ -79 +79 @@
         g_string_printf(request, "%s %s%s%s%s HTTP/1.1\r\n"
                         "Host: %s\r\n"
-                        "User-Agent: BitlBee " BITLBEE_VERSION " " ARCH "/" CPU "\r\n",
+                        "User-Agent: BitlBee " BITLBEE_VERSION "\r\n",
                         is_post ? "POST" : "GET",
                         base_url ? base_url->file : td->url_path,

protocols/twitter/twitter_lib.c

@@ -245 +245 @@
 
 static void twitter_http_get_friends_ids(struct http_request *req);
+static void twitter_http_get_mutes_ids(struct http_request *req);
+static void twitter_http_get_noretweets_ids(struct http_request *req);
 
 /**
@@ -257 +259 @@
         args[1] = g_strdup_printf("%" G_GINT64_FORMAT, next_cursor);
         twitter_http(ic, TWITTER_FRIENDS_IDS_URL, twitter_http_get_friends_ids, ic, 0, args, 2);
+
+        g_free(args[1]);
+}
+
+/**
+ * Get the muted users ids.
+ */
+void twitter_get_mutes_ids(struct im_connection *ic, gint64 next_cursor)
+{
+        char *args[2];
+
+        args[0] = "cursor";
+        args[1] = g_strdup_printf("%" G_GINT64_FORMAT, next_cursor);
+        twitter_http(ic, TWITTER_MUTES_IDS_URL, twitter_http_get_mutes_ids, ic, 0, args, 2);
+
+        g_free(args[1]);
+}
+
+/**
+ * Get the ids for users from whom we should ignore retweets.
+ */
+void twitter_get_noretweets_ids(struct im_connection *ic, gint64 next_cursor)
+{
+        char *args[2];
+
+        args[0] = "cursor";
+        args[1] = g_strdup_printf("%" G_GINT64_FORMAT, next_cursor);
+        twitter_http(ic, TWITTER_NORETWEETS_IDS_URL, twitter_http_get_noretweets_ids, ic, 0, args, 2);
 
         g_free(args[1]);
@@ -334 +364 @@
                 twitter_get_users_lookup(ic);
         }
+
+        txl->list = NULL;
+        txl_free(txl);
+}
+
+/**
+ * Callback for getting the mutes ids.
+ */
+static void twitter_http_get_mutes_ids(struct http_request *req)
+{
+        struct im_connection *ic = req->data;
+        JSON_Value *parsed;
+        struct twitter_xml_list *txl;
+        struct twitter_data *td;
+
+        // Check if the connection is stil active
+        if (!g_slist_find(twitter_connections, ic)) {
+                return;
+        }
+
+        td = ic->proto_data;
+
+        if (req->status_code != 200) {
+                /* Fail silently */
+                return;
+        }
+
+        // Parse the data.
+        if (!(parsed = twitter_parse_response(ic, req))) {
+                return;
+        }
+
+        txl = g_new0(struct twitter_xml_list, 1);
+        txl->list = td->mutes_ids;
+
+        /* mute ids API response is similar enough to friends response
+           to reuse this method */
+        twitter_xt_get_friends_id_list(parsed, txl);
+        json_value_free(parsed);
+
+        td->mutes_ids = txl->list;
+        if (txl->next_cursor) {
+                /* Recurse while there are still more pages */
+                twitter_get_mutes_ids(ic, txl->next_cursor);
+        }
+
+        txl->list = NULL;
+        txl_free(txl);
+}
+
+/**
+ * Callback for getting the no-retweets ids.
+ */
+static void twitter_http_get_noretweets_ids(struct http_request *req)
+{
+        struct im_connection *ic = req->data;
+        JSON_Value *parsed;
+        struct twitter_xml_list *txl;
+        struct twitter_data *td;
+
+        // Check if the connection is stil active
+        if (!g_slist_find(twitter_connections, ic)) {
+                return;
+        }
+
+        if (req->status_code != 200) {
+                /* Fail silently */
+                return;
+        }
+
+        td = ic->proto_data;
+
+        // Parse the data.
+        if (!(parsed = twitter_parse_response(ic, req))) {
+                return;
+        }
+
+        txl = g_new0(struct twitter_xml_list, 1);
+        txl->list = td->noretweets_ids;
+        
+        // Process the retweet ids
+        txl->type = TXL_ID;
+        if (json_type(parsed) == JSONArray) {
+                JSON_Array *arr = json_array(parsed);
+                unsigned int i;
+                for (i = 0; i < json_array_get_count(arr); i++) {
+                        jint id = json_array_get_integer(arr, i);
+                        txl->list = g_slist_prepend(txl->list,
+                                                    g_strdup_printf("%lld", id));
+                }
+        }
+
+        json_value_free(parsed);
+        td->noretweets_ids = txl->list;
 
         txl->list = NULL;
@@ -467 +591 @@
 #endif
 
-static void expand_entities(char **text, const JSON_Object *node);
+static void expand_entities(char **text, const JSON_Object *node, const JSON_Object *extended_node);
 
 /**
@@ -479 +603 @@
 static struct twitter_xml_status *twitter_xt_get_status(const JSON_Object *node)
 {
-        struct twitter_xml_status *txs;
+        struct twitter_xml_status *txs = {0};
         const JSON_Object *rt = NULL;
+        const JSON_Value *text_value = NULL;
+        const JSON_Object *extended_node = NULL;
 
         if (!node) {
@@ -488 +614 @@
 
         JSON_O_FOREACH(node, k, v) {
-                if (strcmp("text", k) == 0 && (txs->text = g_strdup(json_string(v)))) {
-                        // TODO: Huh strip html? In json? Not sure whether I have to..
-                        strip_html(txs->text);
+                if (strcmp("text", k) == 0 && json_type(v) == JSONString && text_value == NULL) {
+                        text_value = v;
+                } else if (strcmp("full_text", k) == 0 && json_type(v) == JSONString) {
+                        text_value = v;
+                } else if (strcmp("extended_tweet", k) == 0 && json_type(v) == JSONObject) {
+                        text_value = json_object_get_value(json_object(v), "full_text");
+                        extended_node = json_object(v);
                 } else if (strcmp("retweeted_status", k) == 0 && (rt = json_object(v))) {
                         // Handling below.
@@ -516 +646 @@
                 struct twitter_xml_status *rtxs = twitter_xt_get_status(rt);
                 if (rtxs) {
-                        g_free(txs->text);
                         txs->text = g_strdup_printf("RT @%s: %s", rtxs->user->screen_name, rtxs->text);
                         txs->id = rtxs->id;
                         txs_free(rtxs);
                 }
-        } else {
-                expand_entities(&txs->text, node);
+        } else if (text_value && json_type(text_value) == JSONString) {
+                txs->text = g_strdup(json_string(text_value));
+                strip_html(txs->text);
+                expand_entities(&txs->text, node, extended_node);
         }
 
@@ -564 +695 @@
         }
 
-        expand_entities(&txs->text, node);
+        expand_entities(&txs->text, node, NULL);
 
         if (txs->text && txs->user && txs->id) {
@@ -574 +705 @@
 }
 
-static void expand_entities(char **text, const JSON_Object *node)
-{
-        JSON_Object *entities, *quoted;
+static void expand_entities(char **text, const JSON_Object *node, const JSON_Object *extended_node)
+{
+        JSON_Object *entities, *extended_entities, *quoted;
         char *quote_url = NULL, *quote_text = NULL;
 
@@ -594 +725 @@
         }
 
+        if (extended_node) {
+                extended_entities = json_object_get_object(extended_node, "entities");
+                if (extended_entities) {
+                        entities = extended_entities;
+                }
+        }
+
         JSON_O_FOREACH(entities, k, v) {
                 int i;
@@ -837 +975 @@
         struct twitter_data *td = ic->proto_data;
         char *last_id_str;
+        char *uid_str;
 
         if (status->user == NULL || status->text == NULL) {
+                return;
+        }
+        
+        /* Check this is not a tweet that should be muted */
+        uid_str = g_strdup_printf("%" G_GUINT64_FORMAT, status->user->uid);
+
+        if (g_slist_find_custom(td->mutes_ids, uid_str, (GCompareFunc)strcmp)) {
+                g_free(uid_str);
+                return;
+        }
+        if (status->id != status->rt_id && g_slist_find_custom(td->noretweets_ids, uid_str, (GCompareFunc)strcmp)) {
+                g_free(uid_str);
                 return;
         }
@@ -863 +1014 @@
         set_setstr(&ic->acc->set, "_last_tweet", last_id_str);
         g_free(last_id_str);
+        g_free(uid_str);
 }
 
@@ -880 +1032 @@
         }
 
-        ic->flags |= OPT_PONGED;
         td = ic->proto_data;
 
@@ -896 +1047 @@
                 imc_logout(ic, TRUE);
                 return;
+        }
+
+        if (req == td->stream) {
+                ic->flags |= OPT_PONGED;
         }
 
@@ -999 +1154 @@
         JSON_Object *target = json_object_get_object(o, "target");
         const char *type = json_object_get_string(o, "event");
+        struct twitter_xml_user *us = NULL;
+        struct twitter_xml_user *ut = NULL;
 
         if (!type || !source || !target) {
@@ -1005 +1162 @@
 
         if (strcmp(type, "follow") == 0) {
-                struct twitter_xml_user *us = twitter_xt_get_user(source);
-                struct twitter_xml_user *ut = twitter_xt_get_user(target);
+                us = twitter_xt_get_user(source);
+                ut = twitter_xt_get_user(target);
                 if (g_strcasecmp(us->screen_name, td->user) == 0) {
                         twitter_add_buddy(ic, ut->screen_name, ut->name);
                 }
-                txu_free(us);
-                txu_free(ut);
-        }
+        } else if (strcmp(type, "mute") == 0) {
+                GSList *found;
+                char *uid_str;
+                ut = twitter_xt_get_user(target);
+                uid_str = g_strdup_printf("%" G_GUINT64_FORMAT, ut->uid);
+                if (!(found = g_slist_find_custom(td->mutes_ids, uid_str,
+                                                  (GCompareFunc)strcmp))) {
+                        td->mutes_ids = g_slist_prepend(td->mutes_ids, uid_str);
+                }
+                twitter_log(ic, "Muted user %s", ut->screen_name);
+                if (getenv("BITLBEE_DEBUG")) {
+                        fprintf(stderr, "New mute: %s %"G_GUINT64_FORMAT"\n",
+                                ut->screen_name, ut->uid);
+                }
+        } else if (strcmp(type, "unmute") == 0) {
+                GSList *found;
+                char *uid_str;
+                ut = twitter_xt_get_user(target);
+                uid_str = g_strdup_printf("%" G_GUINT64_FORMAT, ut->uid);
+                if ((found = g_slist_find_custom(td->mutes_ids, uid_str,
+                                                (GCompareFunc)strcmp))) {
+                        char *found_str = found->data;
+                        td->mutes_ids = g_slist_delete_link(td->mutes_ids, found);
+                        g_free(found_str);
+                }
+                g_free(uid_str);
+                twitter_log(ic, "Unmuted user %s", ut->screen_name);
+                if (getenv("BITLBEE_DEBUG")) {
+                        fprintf(stderr, "New unmute: %s %"G_GUINT64_FORMAT"\n",
+                                ut->screen_name, ut->uid);
+                }
+        }
+
+        txu_free(us);
+        txu_free(ut);
 
         return TRUE;
@@ -1309 +1498 @@
         td->flags &= ~TWITTER_GOT_TIMELINE;
 
-        char *args[6];
+        char *args[8];
         args[0] = "cursor";
         args[1] = g_strdup_printf("%" G_GINT64_FORMAT, next_cursor);
         args[2] = "include_entities";
         args[3] = "true";
+        args[4] = "tweet_mode";
+        args[5] = "extended";
         if (td->timeline_id) {
-                args[4] = "since_id";
-                args[5] = g_strdup_printf("%" G_GUINT64_FORMAT, td->timeline_id);
+                args[6] = "since_id";
+                args[7] = g_strdup_printf("%" G_GUINT64_FORMAT, td->timeline_id);
         }
 
         if (twitter_http(ic, TWITTER_HOME_TIMELINE_URL, twitter_http_get_home_timeline, ic, 0, args,
-                         td->timeline_id ? 6 : 4) == NULL) {
+                         td->timeline_id ? 8 : 6) == NULL) {
                 if (++td->http_fails >= 5) {
                         imcb_error(ic, "Could not retrieve %s: %s",
@@ -1331 +1522 @@
         g_free(args[1]);
         if (td->timeline_id) {
-                g_free(args[5]);
+                g_free(args[7]);
         }
 }
@@ -1346 +1537 @@
         td->flags &= ~TWITTER_GOT_MENTIONS;
 
-        char *args[6];
+        char *args[8];
         args[0] = "cursor";
         args[1] = g_strdup_printf("%" G_GINT64_FORMAT, next_cursor);
@@ -1358 +1549 @@
                 args[5] = g_strdup_printf("%d", set_getint(&ic->acc->set, "show_old_mentions"));
         }
+        args[6] = "tweet_mode";
+        args[7] = "extended";
 
         if (twitter_http(ic, TWITTER_MENTIONS_URL, twitter_http_get_mentions,
-                         ic, 0, args, 6) == NULL) {
+                         ic, 0, args, 8) == NULL) {
                 if (++td->http_fails >= 5) {
                         imcb_error(ic, "Could not retrieve %s: %s",
@@ -1529 +1722 @@
 }
 
+/**
+ * Mute or unmute a user
+ */
+void twitter_mute_create_destroy(struct im_connection *ic, char *who, int create)
+{
+        char *args[2];
+
+        args[0] = "screen_name";
+        args[1] = who;
+        twitter_http(ic, create ? TWITTER_MUTES_CREATE_URL : TWITTER_MUTES_DESTROY_URL,
+                     twitter_http_post, ic, 1, args, 2);
+}
+
 void twitter_status_destroy(struct im_connection *ic, guint64 id)
 {

protocols/twitter/twitter_lib.h

@@ -63 +63 @@
 #define TWITTER_FRIENDS_IDS_URL "/friends/ids.json"
 #define TWITTER_FOLLOWERS_IDS_URL "/followers/ids.json"
+#define TWITTER_MUTES_IDS_URL "/mutes/users/ids.json"
+#define TWITTER_NORETWEETS_IDS_URL "/friendships/no_retweets/ids.json"
 
 /* Account URLs */
@@ -76 +78 @@
 #define TWITTER_BLOCKS_DESTROY_URL "/blocks/destroy/"
 
+/* Mute URLs */
+#define TWITTER_MUTES_CREATE_URL "/mutes/users/create.json"
+#define TWITTER_MUTES_DESTROY_URL "/mutes/users/destroy.json"
+
 /* Report spam */
 #define TWITTER_REPORT_SPAM_URL "/users/report_spam.json"
@@ -87 +93 @@
 gboolean twitter_get_timeline(struct im_connection *ic, gint64 next_cursor);
 void twitter_get_friends_ids(struct im_connection *ic, gint64 next_cursor);
+void twitter_get_mutes_ids(struct im_connection *ic, gint64 next_cursor);
+void twitter_get_noretweets_ids(struct im_connection *ic, gint64 next_cursor);
 void twitter_get_statuses_friends(struct im_connection *ic, gint64 next_cursor);
 
@@ -92 +100 @@
 void twitter_direct_messages_new(struct im_connection *ic, char *who, char *message);
 void twitter_friendships_create_destroy(struct im_connection *ic, char *who, int create);
+void twitter_mute_create_destroy(struct im_connection *ic, char *who, int create);
 void twitter_status_destroy(struct im_connection *ic, guint64 id);
 void twitter_status_retweet(struct im_connection *ic, guint64 id);