Changeset 52df5df


Ignore:
Timestamp:
2008-06-14T01:19:12Z (12 years ago)
Author:
Wilmer van der Gaast <wilmer@…>
Branches:
master
Children:
5ec4129
Parents:
b6cd9e9
Message:

This seems to fix the Yahoo! logoff code. I have no idea why this was broken
(on purpose) in libyahoo2, but this fix seems to work and at least Valgrind
is still happy. And I actually see myself log off now, and the fd is actually
cleaned up properly.

Location:
protocols/yahoo
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • protocols/yahoo/libyahoo2.c

    rb6cd9e9 r52df5df  
    381381
    382382/* call repeatedly to get the next one */
    383 /*
    384383static struct yahoo_input_data * find_input_by_id(int id)
    385384{
     
    392391        return NULL;
    393392}
    394 */
    395393
    396394static struct yahoo_input_data * find_input_by_id_and_webcam_user(int id, const char * who)
     
    797795{
    798796        struct yahoo_data *yd = find_conn_by_id(id);
     797       
    799798        if(!yd)
    800799                return;
     
    31663165
    31673166        LOG(("write callback: id=%d fd=%d data=%p", id, fd, data));
    3168         if(!yid || !yid->txqueues)
     3167        if(!yid || !yid->txqueues || !find_conn_by_id(id))
    31693168                return -2;
    31703169       
     
    38423841        }
    38433842
    3844        
    3845 /*      do {
     3843        do {
    38463844                yahoo_input_close(yid);
    3847         } while((yid = find_input_by_id(id)));*/
    3848        
     3845        } while((yid = find_input_by_id(id)));
    38493846}
    38503847
  • protocols/yahoo/yahoo.c

    rb6cd9e9 r52df5df  
    454454        struct byahoo_write_ready_data *d = data;
    455455       
    456         if( !byahoo_get_ic_by_id( d->id ) )
    457                 /* WTF doesn't libyahoo clean this up? */
    458                 return FALSE;
    459        
    460456        yahoo_write_ready( d->id, d->fd, d->data );
    461457       
Note: See TracChangeset for help on using the changeset viewer.