Changeset 43d8cc5

Timestamp:

2007-06-13T23:31:18Z (18 years ago)

Author:

Wilmer van der Gaast <wilmer@…>

Branches:

master

Children:

998b103

Parents:

7e9dc74

Message:

Fixed a memory management problem that caused some strange nickname issues.

Files:

• protocols/nogaim.c (modified) (2 diffs)
• user.c (modified) (1 diff)

protocols/nogaim.c

@@ -447 +447 @@
 {
         user_t *u = user_findhandle( ic, handle );
-        char newnick[MAX_NICK_LENGTH+1];
+        char newnick[MAX_NICK_LENGTH+1], *orig_nick;
         
         if( u && !u->online && !nick_saved( ic->acc, handle ) )
@@ -465 +465 @@
                 nick_dedupe( ic->acc, handle, newnick );
                 
-                user_rename( ic->irc, u->nick, newnick );
+                /* u->nick will be freed halfway the process, so it can't be
+                   passed as an argument. */
+                orig_nick = g_strdup( u->nick );
+                user_rename( ic->irc, orig_nick, newnick );
+                g_free( orig_nick );
         }
 }

user.c

@@ -161 +161 @@
 }
 
+/* DO NOT PASS u->nick FOR oldnick !!! */
 void user_rename( irc_t *irc, char *oldnick, char *newnick )
 {