Changeset 3c7af69 for protocols

Timestamp:

2012-12-29T10:44:24Z (11 years ago)

Author:

Miklos Vajna <vmiklos@…>

Branches:

master

Children:

e6298e5

Parents:

14d0b02

Message:

skype: make it not hang with >=2.2.0.35

Sadly reading users of larger groups using the public API just hangs in newer
Skype versions. Skype4Py already defines a timeout for requests, but still:
startup takes *minutes*. Work this around by disabling reading of groups by
default.

Location:

protocols/skype

Files:

• README (modified) (2 diffs)
• skype.c (modified) (2 diffs)

protocols/skype/README

@@ -31 +31 @@
 == Requirements
 
-* Skype >= 1.4.0.99. The latest version I've tested is 2.1.0.81.
+* Skype >= 1.4.0.99. The latest version I've tested is 2.2.0.35.
 * BitlBee >= 3.0. The latest version I've tested is @BITLBEE_VERSION@. Use
   old versions (see the NEWS file about which one) if you have older BitlBee
@@ -353 +353 @@
 - Group support:
 
+  * To enable: `account skype set read_groups true`
   * Skype groups are told to BitlBee
   * The usual `/invite` in a group channel adds the buddy to the group in skype

protocols/skype/skype.c

@@ -1046 +1046 @@
 static void skype_parse_groups(struct im_connection *ic, char *line)
 {
+        if (!set_getbool(&ic->acc->set, "read_groups"))
+                return;
+
         char **i;
         char **groups = g_strsplit(line + 7, ", ", 0);
@@ -1536 +1539 @@
         s = set_add(&acc->set, "edit_prefix", "EDIT:",
                         NULL, acc);
+
+        s = set_add(&acc->set, "read_groups", "false", set_eval_bool, acc);
 }