Changeset 3c28bd4 for protocols/msn

Timestamp:

2015-05-31T02:40:05Z (9 years ago)

Author:

dequis <dx@…>

Children:

27a057c

Parents:

b994034

git-author:

dequis <dx@…> (15-05-15 04:28:25)

git-committer:

dequis <dx@…> (31-05-15 02:40:05)

Message:

msn: fix use after free in msn_handle_command

File:

• protocols/msn/msn_util.c (modified) (1 diff)

protocols/msn/msn_util.c

@@ -195 +195 @@
         count = g_strv_length(cmd);
 
+        /* msn_data might be freed if there's a server error,
+         * so clean this up now - we don't need it anymore */
+        g_free(h->cmd_text);
+        h->cmd_text = NULL;
+
         st = msn_ns_command(h, cmd, count, msg, h->msglen);
 
         g_strfreev(cmd);
         g_free(msg);
-
-        g_free(h->cmd_text);
-        h->cmd_text = NULL;
 
         return st;