Changeset 37437f2

Timestamp:

2018-08-26T21:17:06Z (6 years ago)

Author:

dequis <dx@…>

Branches:

master

Children:

5eab9260

Parents:

61fc056

git-author:

dequis <dx@…> (26-08-18 21:08:17)

git-committer:

dequis <dx@…> (26-08-18 21:17:06)

Message:

otr: Don't block attempts to connect/smp/smpq to "offline" users

Other otr implementations don't have this check, and in many modern IM
protocols the offline status isn't a reliable indicator of message
deliverability.

Given how this applies to explicit connection attempts, it's better to
just let these go through and assume the user knows what they are doing.
The worst that can happen here is some slight disappointment.

Change suggested by arc, thanks!

File:

• otr.c (modified) (2 diffs)

otr.c

@@ -1057 +1057 @@
         if (!u || !u->bu || !u->bu->ic) {
                 irc_rootmsg(irc, "%s: unknown user", args[1]);
-                return;
-        }
-        if (!(u->bu->flags & BEE_USER_ONLINE)) {
-                irc_rootmsg(irc, "%s is offline", args[1]);
                 return;
         }
@@ -1437 +1433 @@
                 return;
         }
-        if (!(u->bu->flags & BEE_USER_ONLINE)) {
-                irc_rootmsg(irc, "%s is offline", nick);
-                return;
-        }
 
         ctx = otrl_context_find(irc->otr->us, u->bu->handle,