Changeset 33b306e

Timestamp:

2010-04-07T02:27:55Z (15 years ago)

Author:

Wilmer van der Gaast <wilmer@…>

Branches:

master

Children:

d4efddf

Parents:

7815a2b

Message:

Don't allow non-8-bit character sets like utf-16 which completely break the
IRC protocol. (Happened to at least two public server users by now and it
renders the accounts useless without manual intervention.)

File:

• irc.c (modified) (2 diffs)

irc.c

@@ -52 +52 @@
 {
         irc_t *irc = set->data;
+        char *test;
+        gsize test_bytes = 0;
         GIConv ic, oc;
 
@@ -57 +59 @@
                 value = g_strdup( "utf-8" );
 
+        if( ( oc = g_iconv_open( value, "utf-8" ) ) == (GIConv) -1 )
+        {
+                return NULL;
+        }
+        if( ( test = g_convert_with_iconv( " ", 1, oc, NULL, &test_bytes, NULL ) ) == NULL ||
+            test_bytes > 1 )
+        {
+                g_free( test );
+                g_iconv_close( oc );
+                irc_usermsg( irc, "Unsupported character set: The IRC protocol "
+                                  "only supports 8-bit character sets." );
+                return NULL;
+        }
         if( ( ic = g_iconv_open( "utf-8", value ) ) == (GIConv) -1 )
         {
-                return NULL;
-        }
-        if( ( oc = g_iconv_open( value, "utf-8" ) ) == (GIConv) -1 )
-        {
-                g_iconv_close( ic );
+                g_iconv_close( oc );
                 return NULL;
         }