Changeset 2fa825b for protocols/oscar

Timestamp:

2006-01-19T22:23:03Z (19 years ago)

Author:

Wilmer van der Gaast <wilmer@…>

Branches:

master

Children:

b8c2ace, fc50d48

Parents:

e8f8b18

Message:

Removed some very unpleasant check from the OSCAR code. (Caused
testing.bitlbee.org to get ... quite busy.)

File:

• protocols/oscar/rxqueue.c (modified) (1 diff)

protocols/oscar/rxqueue.c

@@ -353 +353 @@
                 return -1; /* its a aim_conn_close()'d connection */
 
-        if (conn->fd < 3)  /* can happen when people abuse the interface */
+        /* KIDS, THIS IS WHAT HAPPENS IF YOU USE CODE WRITTEN FOR GUIS IN A DAEMON!
+           
+           And wouldn't it make sense to return something that prevents this function
+           from being called again IMMEDIATELY (and making the program suck up all
+           CPU time)?...
+           
+        if (conn->fd < 3)
                 return 0;
+        */
 
         if (conn->status & AIM_CONN_STATUS_INPROGRESS)