Changeset 2af3e23

Timestamp:

2010-10-02T06:56:33Z (14 years ago)

Author:

Wilmer van der Gaast <wilmer@…>

Branches:

master

Children:

385fbc4, 8e9e2b7

Parents:

62f53b50

Message:

Restore MSN password truncation code. MSN still can't handle passwords
longer than 16 chars and silently fails if you give >16chars.

Files:

• doc/CHANGES (modified) (1 diff)
• protocols/msn/soap.c (modified) (2 diffs)
• protocols/msn/soap.h (modified) (1 diff)

doc/CHANGES

@@ -52 +52 @@
 - Rewritten MSN module, implementing MSNP15 instead of the old MSNP8:
   * MSNP8 support from MSN was getting pretty unreliable. There were issues
-    with remembering display names and adding contacts/auth requests.
+    with remembering display names and adding contacts/auth requests (or
+    even contacts silently getting blocked!). This upgrade should fix all
+    of that.
   * Support for sending offline messages.
   * Support for setting and reading status messages.

protocols/msn/soap.c

@@ -270 +270 @@
         struct im_connection *ic = soap_req->ic;
         struct msn_data *md = ic->proto_data;
+        char pass[MAX_PASSPORT_PWLEN+1];
         
         if( sd->redirect )
@@ -281 +282 @@
                 soap_req->url = g_strdup( SOAP_PASSPORT_SSO_URL );
         
+        strncpy( pass, ic->acc->pass, MAX_PASSPORT_PWLEN );
         soap_req->payload = g_markup_printf_escaped( SOAP_PASSPORT_SSO_PAYLOAD,
-                ic->acc->user, ic->acc->pass, md->pp_policy );
+                ic->acc->user, pass, md->pp_policy );
         
         return MSN_SOAP_OK;

protocols/msn/soap.h

@@ -63 +63 @@
 #define SOAP_PASSPORT_SSO_URL "https://login.live.com/RST.srf"
 #define SOAP_PASSPORT_SSO_URL_MSN "https://msnia.login.live.com/pp800/RST.srf"
+#define MAX_PASSPORT_PWLEN 16
 
 #define SOAP_PASSPORT_SSO_PAYLOAD \