Changeset 2288705 for protocols/jabber

Timestamp:

2009-12-07T21:54:19Z (14 years ago)

Author:

Wilmer van der Gaast <wilmer@…>

Branches:

master

Children:

1c3008a

Parents:

aac4017 (diff), 36cf9fd (diff)
Note: this is a merge changeset, the changes displayed below correspond to the merge itself.
Use the (diff) links above to see all the changes relative to each parent.

Message:

Merging head.

Location:

protocols/jabber

Files:

• conference.c (modified) (4 diffs)
• iq.c (modified) (1 diff)
• jabber.c (modified) (2 diffs)
• jabber.h (modified) (2 diffs)
• jabber_util.c (modified) (1 diff)
• presence.c (modified) (2 diffs)

protocols/jabber/conference.c

@@ -26 +26 @@
 static xt_status jabber_chat_join_failed( struct im_connection *ic, struct xt_node *node, struct xt_node *orig );
 
-struct groupchat *jabber_chat_join( struct im_connection *ic, char *room, char *nick, char *password )
+struct groupchat *jabber_chat_join( struct im_connection *ic, const char *room, const char *nick, const char *password )
 {
         struct jabber_chat *jc;
@@ -36 +36 @@
         node = xt_new_node( "x", NULL, NULL );
         xt_add_attr( node, "xmlns", XMLNS_MUC );
-        node = jabber_make_packet( "presence", NULL, roomjid, node );
         if( password )
                 xt_add_child( node, xt_new_node( "password", password, NULL ) );
+        node = jabber_make_packet( "presence", NULL, roomjid, node );
         jabber_cache_add( ic, node, jabber_chat_join_failed );
         
@@ -234 +234 @@
                             ( strcmp( s, XMLNS_MUC_USER ) == 0 ) )
                         {
-                                c = xt_find_node( c->children, "item" );
-                                if( ( s = xt_find_attr( c, "jid" ) ) )
+                                struct xt_node *item;
+                                
+                                item = xt_find_node( c->children, "item" );
+                                if( ( s = xt_find_attr( item, "jid" ) ) )
                                 {
                                         /* Yay, found what we need. :-) */
@@ -283 +285 @@
         else if( type ) /* type can only be NULL or "unavailable" in this function */
         {
-                s = strchr( bud->ext_jid, '/' );
-                if( s ) *s = 0;
-                imcb_chat_remove_buddy( chat, bud->ext_jid, NULL );
-                if( bud != jc->me && bud->flags & JBFLAG_IS_ANONYMOUS )
-                        imcb_remove_buddy( ic, bud->ext_jid, NULL );
-                if( s ) *s = '/';
+                if( ( bud->flags & JBFLAG_IS_CHATROOM ) && bud->ext_jid )
+                {
+                        s = strchr( bud->ext_jid, '/' );
+                        if( s ) *s = 0;
+                        imcb_chat_remove_buddy( chat, bud->ext_jid, NULL );
+                        if( bud != jc->me && bud->flags & JBFLAG_IS_ANONYMOUS )
+                                imcb_remove_buddy( ic, bud->ext_jid, NULL );
+                        if( s ) *s = '/';
+                }
                 
                 if( bud == jc->me )

protocols/jabber/iq.c

@@ -51 +51 @@
         {
                 if( !( ( c = xt_find_node( node->children, "query" ) ) ||
-                       ( c = xt_find_node( node->children, "ping" ) ) ) || /* O_o WHAT is wrong with just <query/> ????? */
+                       ( c = xt_find_node( node->children, "ping" ) ) ) ||
                     !( s = xt_find_attr( c, "xmlns" ) ) )
                 {
-                        imcb_log( ic, "Warning: Received incomplete IQ-%s packet", type );
+                        /* Sigh. Who decided to suddenly invent new elements
+                           instead of just sticking with <query/>? */
                         return XT_HANDLED;
                 }

protocols/jabber/jabber.c

@@ -70 +70 @@
         
         s = set_add( &acc->set, "server", NULL, set_eval_account, acc );
-        s->flags |= ACC_SET_NOSAVE | ACC_SET_OFFLINE_ONLY;
+        s->flags |= ACC_SET_NOSAVE | ACC_SET_OFFLINE_ONLY | SET_NULL_OK;
         
         s = set_add( &acc->set, "ssl", "false", set_eval_bool, acc );
@@ -439 +439 @@
 }
 
-static struct groupchat *jabber_chat_join_( struct im_connection *ic, char *room, char *nick, char *password )
+static struct groupchat *jabber_chat_join_( struct im_connection *ic, const char *room, const char *nick, const char *password )
 {
         if( strchr( room, '@' ) == NULL )

protocols/jabber/jabber.h

@@ -27 +27 @@
 #include <glib.h>
 
+#include "bitlbee.h"
+#include "md5.h"
 #include "xmltree.h"
-#include "bitlbee.h"
 
 extern GSList *jabber_connections;
@@ -302 +303 @@
 
 /* conference.c */
-struct groupchat *jabber_chat_join( struct im_connection *ic, char *room, char *nick, char *password );
+struct groupchat *jabber_chat_join( struct im_connection *ic, const char *room, const char *nick, const char *password );
 struct groupchat *jabber_chat_by_jid( struct im_connection *ic, const char *name );
 void jabber_chat_free( struct groupchat *c );

protocols/jabber/jabber_util.c

@@ -37 +37 @@
                 /* Priority is a signed 8-bit integer, according to RFC 3921. */
                 if( i < -128 || i > 127 )
-                        return NULL;
+                        return SET_INVALID;
         }
         else
-                return NULL;
+                return SET_INVALID;
         
         /* Only run this stuff if the account is online ATM,

protocols/jabber/presence.c

@@ -49 +49 @@
                 if( !( bud = jabber_buddy_by_jid( ic, from, GET_BUDDY_EXACT | GET_BUDDY_CREAT ) ) )
                 {
-                        if( set_getbool( &ic->irc->set, "debug" ) )
-                                imcb_log( ic, "Warning: Could not handle presence information from JID: %s", from );
+                        /*
+                        imcb_log( ic, "Warning: Could not handle presence information from JID: %s", from );
+                        */
                         return XT_HANDLED;
                 }
@@ -106 +107 @@
                 if( ( bud = jabber_buddy_by_jid( ic, from, 0 ) ) == NULL )
                 {
-                        if( set_getbool( &ic->irc->set, "debug" ) )
-                                imcb_log( ic, "Warning: Received presence information from unknown JID: %s", from );
+                        /*
+                        imcb_log( ic, "Warning: Received presence information from unknown JID: %s", from );
+                        */
                         return XT_HANDLED;
                 }