Changes in irc_commands.c [f9756bd:1cda4f3]

File:

• irc_commands.c (modified) (22 diffs)

irc_commands.c

@@ -30 +30 @@
 static void irc_cmd_pass( irc_t *irc, char **cmd )
 {
-        if( irc->status & USTATUS_LOGGED_IN )
-        {
-                char *send_cmd[] = { "identify", cmd[1], NULL };
-                
-                /* We're already logged in, this client seems to send the PASS
-                   command last. (Possibly it won't send it at all if it turns
-                   out we don't require it, which will break this feature.)
-                   Try to identify using the given password. */
-                return root_command( irc, send_cmd );
-        }
-        /* Handling in pre-logged-in state, first see if this server is
-           password-protected: */
-        else if( global.conf->auth_pass &&
-            ( strncmp( global.conf->auth_pass, "md5:", 4 ) == 0 ?
-                md5_verify_password( cmd[1], global.conf->auth_pass + 4 ) == 0 :
-                strcmp( cmd[1], global.conf->auth_pass ) == 0 ) )
-        {
-                irc->status |= USTATUS_AUTHORIZED;
+        if( global.conf->auth_pass && strcmp( cmd[1], global.conf->auth_pass ) == 0 )
+        {
+                irc->status = USTATUS_AUTHORIZED;
                 irc_check_login( irc );
         }
-        else if( global.conf->auth_pass )
+        else
         {
                 irc_reply( irc, 464, ":Incorrect password" );
-        }
-        else
-        {
-                /* Remember the password and try to identify after USER/NICK. */
-                irc_setpass( irc, cmd[1] );
-                irc_check_login( irc );
         }
 }
@@ -109 +88 @@
 static void irc_cmd_oper( irc_t *irc, char **cmd )
 {
-        if( global.conf->oper_pass &&
-            ( strncmp( global.conf->oper_pass, "md5:", 4 ) == 0 ?
-                md5_verify_password( cmd[2], global.conf->oper_pass + 4 ) == 0 :
-                strcmp( cmd[2], global.conf->oper_pass ) == 0 ) )
+        if( global.conf->oper_pass && strcmp( cmd[2], global.conf->oper_pass ) == 0 )
         {
                 irc_umode_set( irc, "+o", 1 );
@@ -143 +119 @@
                         if( cmd[2] )
                                 irc_umode_set( irc, cmd[2], 0 );
-                        else
-                                irc_reply( irc, 221, "+%s", irc->umode );
                 }
                 else
@@ -158 +132 @@
 static void irc_cmd_part( irc_t *irc, char **cmd )
 {
-        struct groupchat *c;
+        struct conversation *c;
         
         if( g_strcasecmp( cmd[1], irc->channel ) == 0 )
@@ -168 +142 @@
                 irc_join( irc, u, irc->channel );
         }
-        else if( ( c = irc_chat_by_channel( irc, cmd[1] ) ) )
+        else if( ( c = conv_findchannel( cmd[1] ) ) )
         {
                 user_t *u = user_find( irc, irc->nick );
@@ -174 +148 @@
                 irc_part( irc, u, c->channel );
                 
-                if( c->ic )
+                if( c->gc && c->gc->prpl )
                 {
                         c->joined = 0;
-                        c->ic->acc->prpl->chat_leave( c );
+                        c->gc->prpl->chat_leave( c->gc, c->id );
                 }
         }
@@ -197 +171 @@
                         user_t *u = user_find( irc, cmd[1] + 1 );
                         
-                        if( u && u->ic && u->ic->acc->prpl->chat_with )
+                        if( u && u->gc && u->gc->prpl && u->gc->prpl->chat_open )
                         {
                                 irc_reply( irc, 403, "%s :Initializing groupchat in a different channel", cmd[1] );
                                 
-                                if( !u->ic->acc->prpl->chat_with( u->ic, u->handle ) )
+                                if( !u->gc->prpl->chat_open( u->gc, u->handle ) )
                                 {
-                                        irc_usermsg( irc, "Could not open a groupchat with %s.", u->nick );
+                                        irc_usermsg( irc, "Could not open a groupchat with %s, maybe you don't have a connection to him/her yet?", u->nick );
                                 }
                         }
@@ -225 +199 @@
 {
         char *nick = cmd[1], *channel = cmd[2];
-        struct groupchat *c = irc_chat_by_channel( irc, channel );
+        struct conversation *c = conv_findchannel( channel );
         user_t *u = user_find( irc, nick );
         
-        if( u && c && ( u->ic == c->ic ) )
-                if( c->ic && c->ic->acc->prpl->chat_invite )
-                {
-                        c->ic->acc->prpl->chat_invite( c, u->handle, NULL );
+        if( u && c && ( u->gc == c->gc ) )
+                if( c->gc && c->gc->prpl && c->gc->prpl->chat_invite )
+                {
+                        c->gc->prpl->chat_invite( c->gc, c->id, "", u->handle );
                         irc_reply( irc, 341, "%s %s", nick, channel );
                         return;
@@ -254 +228 @@
                 {
                         unsigned int i;
-                        char *t = set_getstr( &irc->set, "default_target" );
+                        char *t = set_getstr( irc, "default_target" );
                         
                         if( g_strcasecmp( t, "last" ) == 0 && irc->last_target )
@@ -278 +252 @@
                         if( cmd[1] != irc->last_target )
                         {
-                                g_free( irc->last_target );
+                                if( irc->last_target )
+                                        g_free( irc->last_target );
                                 irc->last_target = g_strdup( cmd[1] );
                         }
@@ -286 +261 @@
                         irc->is_private = 1;
                 }
-                irc_send( irc, cmd[1], cmd[2], ( g_strcasecmp( cmd[0], "NOTICE" ) == 0 ) ? OPT_AWAY : 0 );
+                irc_send( irc, cmd[1], cmd[2], ( g_strcasecmp( cmd[0], "NOTICE" ) == 0 ) ? IM_FLAG_AWAY : 0 );
         }
 }
@@ -294 +269 @@
         char *channel = cmd[1];
         user_t *u = irc->users;
-        struct groupchat *c;
+        struct conversation *c;
         GList *l;
         
@@ -310 +285 @@
                         u = u->next;
                 }
-        else if( ( c = irc_chat_by_channel( irc, channel ) ) )
+        else if( ( c = conv_findchannel( channel ) ) )
                 for( l = c->in_room; l; l = l->next )
                 {
-                        if( ( u = user_findhandle( c->ic, l->data ) ) )
+                        if( ( u = user_findhandle( c->gc, l->data ) ) )
                                 irc_reply( irc, 352, "%s %s %s %s %s %c :0 %s", channel, u->user, u->host, irc->myhost, u->nick, u->away ? 'G' : 'H', u->realname );
                 }
@@ -356 +331 @@
         for( i = 1; cmd[i]; i ++ )
         {
-                char *this, *next;
-                
-                this = cmd[i];
-                while( *this )
-                {
-                        if( ( next = strchr( this, ' ' ) ) )
-                                *next = 0;
-                        
-                        if( ( u = user_find( irc, this ) ) && u->online )
-                        {
-                                lenleft -= strlen( u->nick ) + 1;
-                                
-                                if( lenleft < 0 )
-                                        break;
-                                
-                                strcat( buff, u->nick );
-                                strcat( buff, " " );
-                        }
-                        
-                        if( next )
-                        {
-                                *next = ' ';
-                                this = next + 1;
-                        }
-                        else
+                if( ( u = user_find( irc, cmd[i] ) ) && u->online )
+                {
+                        /* [SH] Make sure we don't use too much buffer space. */
+                        lenleft -= strlen( u->nick ) + 1;
+                        
+                        if( lenleft < 0 )
                         {
                                 break;
-                        }    
-                }
-                
-                /* *sigh* */
-                if( lenleft < 0 )
-                        break;
-        }
-        
+                        }
+                        
+                        /* [SH] Add the nick to the buffer. Note
+                         * that an extra space is always added. Even
+                         * if it's the last nick in the list. Who
+                         * cares?
+                         */
+                        
+                        strcat( buff, u->nick );
+                        strcat( buff, " " );
+                }
+        }
+        
+        /* [WvG] Well, maybe someone cares, so why not remove it? */
         if( strlen( buff ) > 0 )
                 buff[strlen(buff)-1] = '\0';
@@ -444 +406 @@
 static void irc_cmd_topic( irc_t *irc, char **cmd )
 {
-        char *channel = cmd[1];
-        char *topic = cmd[2];
-        
-        if( topic )
-        {
-                /* Send the topic */
-                struct groupchat *c = irc_chat_by_channel( irc, channel );
-                if( c && c->ic && c->ic->acc->prpl->chat_topic )
-                        c->ic->acc->prpl->chat_topic( c, topic );
-        }
-        else
-        {
-                /* Get the topic */
-                irc_topic( irc, channel );
-        }
+        if( cmd[2] )
+                irc_reply( irc, 482, "%s :Cannot change topic", cmd[1] );
+        else
+                irc_topic( irc, cmd[1] );
 }
 
@@ -494 +445 @@
         for( a = irc->accounts; a; a = a->next )
         {
-                struct im_connection *ic = a->ic;
-                
-                if( ic && ic->flags & OPT_LOGGED_IN )
-                        imc_set_away( ic, u->away );
+                struct gaim_connection *gc = a->gc;
+                
+                if( gc && gc->flags & OPT_LOGGED_IN )
+                        bim_set_away( gc, u->away );
         }
 }
@@ -510 +461 @@
                 irc_reply( irc, 311, "%s %s %s * :%s", u->nick, u->user, u->host, u->realname );
                 
-                if( u->ic )
-                        irc_reply( irc, 312, "%s %s.%s :%s network", u->nick, u->ic->acc->user,
-                                   u->ic->acc->server && *u->ic->acc->server ? u->ic->acc->server : "",
-                                   u->ic->acc->prpl->name );
+                if( u->gc )
+                        irc_reply( irc, 312, "%s %s.%s :%s network", u->nick, u->gc->user->username,
+                                   *u->gc->user->proto_opt[0] ? u->gc->user->proto_opt[0] : "", u->gc->prpl->name );
                 else
                         irc_reply( irc, 312, "%s %s :%s", u->nick, irc->myhost, IRCD_INFO );
@@ -579 +529 @@
         
         for( h = global.help; h; h = h->next )
-                irc_privmsg( irc, u, "NOTICE", irc->nick, "COMPLETIONS help ", h->title );
+                irc_privmsg( irc, u, "NOTICE", irc->nick, "COMPLETIONS help ", h->string );
         
         for( s = irc->set; s; s = s->next )
@@ -594 +544 @@
                 ipc_to_master( cmd );
         
-        irc_reply( irc, 382, "%s :Rehashing", global.conf_file );
+#ifndef _WIN32
+        irc_reply( irc, 382, "%s :Rehashing", CONF_FILE );
+#endif
 }
 
 static const command_t irc_commands[] = {
-        { "pass",        1, irc_cmd_pass,        0 },
+        { "pass",        1, irc_cmd_pass,        IRC_CMD_PRE_LOGIN },
         { "user",        4, irc_cmd_user,        IRC_CMD_PRE_LOGIN },
         { "nick",        1, irc_cmd_nick,        0 },
@@ -627 +579 @@
         { "die",         0, NULL,                IRC_CMD_OPER_ONLY | IRC_CMD_TO_MASTER },
         { "wallops",     1, NULL,                IRC_CMD_OPER_ONLY | IRC_CMD_TO_MASTER },
-        { "wall",        1, NULL,                IRC_CMD_OPER_ONLY | IRC_CMD_TO_MASTER },
+        { "lilo",        1, NULL,                IRC_CMD_OPER_ONLY | IRC_CMD_TO_MASTER },
         { "rehash",      0, irc_cmd_rehash,      IRC_CMD_OPER_ONLY },
         { "restart",     0, NULL,                IRC_CMD_OPER_ONLY | IRC_CMD_TO_MASTER },
@@ -647 +599 @@
                         for( n_arg = 0; cmd[n_arg]; n_arg ++ ); n_arg --;
                         
-                        if( irc_commands[i].flags & IRC_CMD_PRE_LOGIN && irc->status & USTATUS_LOGGED_IN )
+                        if( irc_commands[i].flags & IRC_CMD_PRE_LOGIN && irc->status >= USTATUS_LOGGED_IN )
                         {
                                 irc_reply( irc, 462, ":Only allowed before logging in" );
                         }
-                        else if( irc_commands[i].flags & IRC_CMD_LOGGED_IN && !( irc->status & USTATUS_LOGGED_IN ) )
+                        else if( irc_commands[i].flags & IRC_CMD_LOGGED_IN && irc->status < USTATUS_LOGGED_IN )
                         {
                                 irc_reply( irc, 451, ":Register first" );
@@ -674 +626 @@
                         }
                         
-                        return;
-                }
-        
-        if( irc->status >= USTATUS_LOGGED_IN )
-                irc_reply( irc, 421, "%s :Unknown command", cmd[0] );
-}
+                        break;
+                }
+}