Changes in / [c32f492:1c2eaa3]

Files:

• account.c (modified) (4 diffs)
• account.h (modified) (2 diffs)
• doc/user-guide/commands.xml (modified) (2 diffs)
• doc/user-guide/misc.xml (modified) (2 diffs)
• irc.c (modified) (3 diffs)
• irc_commands.c (modified) (2 diffs)
• protocols/jabber/jabber.c (modified) (3 diffs)
• protocols/jabber/jabber.h (modified) (1 diff)
• protocols/jabber/jabber_util.c (modified) (3 diffs)
• protocols/jabber/presence.c (modified) (3 diffs)
• protocols/msn/msn.c (modified) (2 diffs)
• protocols/msn/msn.h (modified) (1 diff)
• protocols/msn/ns.c (modified) (2 diffs)
• protocols/msn/tables.c (modified) (3 diffs)
• protocols/nogaim.c (modified) (5 diffs)
• protocols/nogaim.h (modified) (3 diffs)
• protocols/oscar/oscar.c (modified) (6 diffs)
• protocols/yahoo/libyahoo2.c (modified) (2 diffs)
• protocols/yahoo/yahoo.c (modified) (5 diffs)

account.c

@@ -2 +2 @@
   * BitlBee -- An IRC to other IM-networks gateway                     *
   *                                                                    *
-  * Copyright 2002-2010 Wilmer van der Gaast and others                *
+  * Copyright 2002-2004 Wilmer van der Gaast and others                *
   \********************************************************************/
 
@@ -69 +69 @@
                 prpl->init( a );
         
-        s = set_add( &a->set, "away", NULL, set_eval_account, a );
-        s->flags |= SET_NULL_OK;
-        
-        if( a->flags & ACC_FLAG_STATUS_MESSAGE )
-        {
-                s = set_add( &a->set, "status", NULL, set_eval_account, a );
-                s->flags |= SET_NULL_OK;
-        }
-        
-        return a;
+        return( a );
 }
 
@@ -130 +121 @@
                 
                 acc->auto_connect = bool2int( value );
-                return value;
-        }
-        else if( strcmp( set->key, "away" ) == 0 ||
-                 strcmp( set->key, "status" ) == 0 )
-        {
-                if( acc->ic && acc->ic->flags & OPT_LOGGED_IN )
-                {
-                        /* If we're currently on-line, set the var now already
-                           (bit of a hack) and send an update. */
-                        g_free( set->value );
-                        set->value = g_strdup( value );
-                        
-                        imc_away_send_update( acc->ic );
-                }
-                
                 return value;
         }
@@ -291 +267 @@
         p->max = 86400;
         
-        /* Format: /[0-9]+([*+][0-9]+(<[0-9+])?)?/ */
+        /* Format: /[0-9]+([*+][0-9]+(<[0-9+]))/ */
         while( *value && isdigit( *value ) )
                 p->start = p->start * 10 + *value++ - '0';

account.h

@@ -37 +37 @@
         int auto_reconnect_delay;
         int reconnect;
-        int flags;
         
         set_t *set;
@@ -57 +56 @@
 int account_reconnect_delay( account_t *a );
 
-typedef enum
-{
-        ACC_SET_NOSAVE = 0x01,          /* Don't save this setting (i.e. stored elsewhere). */
-        ACC_SET_OFFLINE_ONLY = 0x02,    /* Allow changes only if the acct is offline. */
-        ACC_SET_ONLINE_ONLY = 0x04,     /* Allow changes only if the acct is online. */
-} account_set_flag_t;
-
-typedef enum
-{
-        ACC_FLAG_AWAY_MESSAGE = 0x01,   /* Supports away messages instead of just states. */
-        ACC_FLAG_STATUS_MESSAGE = 0x02, /* Supports status messages (without being away). */
-} account_flag_t;
+#define ACC_SET_NOSAVE          0x01
+#define ACC_SET_OFFLINE_ONLY    0x02
+#define ACC_SET_ONLINE_ONLY     0x04
 
 #endif

doc/user-guide/commands.xml

@@ -436 +436 @@
         </bitlbee-setting>
 
-        <bitlbee-setting name="away" type="string" scope="both">
-                <description>
-                        <para>
-                                To mark yourself as away, it is recommended to just use <emphasis>/away</emphasis>, like on normal IRC networks. If you want to mark yourself as away on only one IM network, you can use this per-account setting.
-                        </para>
-
-                        <para>
-                                You can set it to any value and BitlBee will try to map it to the most appropriate away state for every open IM connection, or set it as a free-form away message where possible.
-                        </para>
-
-                        <para>
-                                Any per-account away setting will override globally set away states. To un-set the setting, use <emphasis>set -del away</emphasis>.
-                        </para>
-                </description>
-        </bitlbee-setting>
-
         <bitlbee-setting name="away_devoice" type="boolean" scope="global">
                 <default>true</default>
@@ -763 +747 @@
         </bitlbee-setting>
 
-        <bitlbee-setting name="status" type="string" scope="both">
-                <description>
-                        <para>
-                                Certain protocols (like Jabber/XMPP) support status messages, similar to away messages. They can be used to indicate things like your location or activity, without showing up as away/busy.
-                        </para>
-
-                        <para>
-                                This setting can be used to set such a message. It will be available as a per-account setting for protocols that support it, and also as a global setting (which will then automatically be used for all protocols that support it).
-                        </para>
-
-                        <para>
-                                Away states set using <emphasis>/away</emphasis> or the <emphasis>away</emphasis> setting will override this setting. To un-set the setting, use <emphasis>set -del status</emphasis>.
-                        </para>
-                </description>
-        </bitlbee-setting>
-
         <bitlbee-setting name="strip_html" type="boolean" scope="global">
                 <default>true</default>

doc/user-guide/misc.xml

@@ -86 +86 @@
 
 <para>
-To mark yourself as away, you can just use the <emphasis>/away</emphasis> command in your IRC client. BitlBee supports most away-states supported by the protocols.
+As you might've expected, you can just use the <emphasis>/away</emphasis> command in your IRC client to set an away-state. BitlBee supports most away-states supported by the protocols.
 </para>
 
 <para>
-Away states have different names accross different protocols. BitlBee will try to pick the best available option for every connection:
+Not all away states are supported by all protocols, and some protocols have different names for them. BitlBee will try to pick the best available alias from this list for every connection:
 </para>
 
 <simplelist>
-        <member>Away</member>
-        <member>NA</member>
-        <member>Busy, DND</member>
-        <member>BRB</member>
-        <member>Phone</member>
-        <member>Lunch, Food</member>
+        <member>Away from computer, Away, Extended away</member>
+        <member>NA, N/A, Not available</member>
+        <member>Busy, Do not disturb, DND, Occupied</member>
+        <member>Be right back, BRB</member>
+        <member>On the phone, Phone, On phone</member>
+        <member>Out to lunch, Lunch, Food</member>
         <member>Invisible, Hidden</member>
 </simplelist>
 
 <para>
-So <emphasis>/away Food</emphasis> will set your state to "Out to lunch" on your MSN connection, and for most other connections the default, "Away" will be chosen.
+So <emphasis>/away Food</emphasis> will set your state to "Out to lunch" on your MSN connection, and for most other connections the default, "Away" or "Away from computer" will be chosen.
 </para>
 
@@ -111 +111 @@
 </para>
 
-<para>
-If you want to set an away state for only one of your connections, you can use the per-account <emphasis>away</emphasis> setting. See <emphasis>help set away</emphasis>.
-</para>
-
 </sect1>
 

irc.c

@@ -78 +78 @@
 }
 
-static char *set_eval_away_status( set_t *set, char *value )
-{
-        irc_t *irc = set->data;
-        account_t *a;
-        
-        g_free( set->value );
-        set->value = g_strdup( value );
-        
-        for( a = irc->accounts; a; a = a->next )
-        {
-                struct im_connection *ic = a->ic;
-                
-                if( ic && ic->flags & OPT_LOGGED_IN )
-                        imc_away_send_update( ic );
-        }
-        
-        return value;
-}
-
 irc_t *irc_new( int fd )
 {
@@ -162 +143 @@
         irc_connection_list = g_slist_append( irc_connection_list, irc );
         
-        s = set_add( &irc->set, "away", NULL,  set_eval_away_status, irc );
-        s->flags |= SET_NULL_OK;
         s = set_add( &irc->set, "away_devoice", "true",  set_eval_away_devoice, irc );
         s = set_add( &irc->set, "auto_connect", "true", set_eval_bool, irc );
@@ -184 +163 @@
         s = set_add( &irc->set, "save_on_quit", "true", set_eval_bool, irc );
         s = set_add( &irc->set, "simulate_netsplit", "true", set_eval_bool, irc );
-        s = set_add( &irc->set, "status", NULL,  set_eval_away_status, irc );
-        s->flags |= SET_NULL_OK;
         s = set_add( &irc->set, "strip_html", "true", NULL, irc );
         s = set_add( &irc->set, "to_char", ": ", set_eval_to_char, irc );

irc_commands.c

@@ -448 +448 @@
         user_t *u = user_find( irc, irc->nick );
         char *away = cmd[1];
+        account_t *a;
         
         if( !u ) return;
@@ -474 +475 @@
         }
         
-        set_setstr( &irc->set, "away", u->away );
+        for( a = irc->accounts; a; a = a->next )
+        {
+                struct im_connection *ic = a->ic;
+                
+                if( ic && ic->flags & OPT_LOGGED_IN )
+                        imc_set_away( ic, u->away );
+        }
 }
 

protocols/jabber/jabber.c

@@ -80 +80 @@
         s = set_add( &acc->set, "xmlconsole", "false", set_eval_bool, acc );
         s->flags |= ACC_SET_OFFLINE_ONLY;
-        
-        acc->flags |= ACC_FLAG_AWAY_MESSAGE | ACC_FLAG_STATUS_MESSAGE;
 }
 
@@ -366 +364 @@
         while( bud )
         {
-                imcb_log( ic, "Buddy %s (%d) information:", bud->full_jid, bud->priority );
-                if( bud->away_state )
-                        imcb_log( ic, "Away state: %s", bud->away_state->full_name );
-                imcb_log( ic, "Status message: %s", bud->away_message ? : "(none)" );
-                
+                imcb_log( ic, "Buddy %s (%d) information:\nAway state: %s\nAway message: %s",
+                                   bud->full_jid, bud->priority,
+                                   bud->away_state ? bud->away_state->full_name : "(none)",
+                                   bud->away_message ? : "(none)" );
                 bud = bud->next;
         }
@@ -380 +377 @@
 {
         struct jabber_data *jd = ic->proto_data;
-        
-        /* state_txt == NULL -> Not away.
-           Unknown state -> fall back to the first defined away state. */
-        jd->away_state = state_txt ? jabber_away_state_by_name( state_txt )
-                         ? : jabber_away_state_list : NULL;
-        
+        struct jabber_away_state *state;
+        
+        /* Save all this info. We need it, for example, when changing the priority setting. */
+        state = (void *) jabber_away_state_by_name( state_txt );
+        jd->away_state = state ? state : (void *) jabber_away_state_list; /* Fall back to "Away" if necessary. */
         g_free( jd->away_message );
         jd->away_message = ( message && *message ) ? g_strdup( message ) : NULL;

protocols/jabber/jabber.h

@@ -84 +84 @@
         /* After changing one of these two (or the priority setting), call
            presence_send_update() to inform the server about the changes. */
-        const struct jabber_away_state *away_state;
+        struct jabber_away_state *away_state;
         char *away_message;
         

protocols/jabber/jabber_util.c

@@ -228 +228 @@
 {
         { "away",  "Away" },
-        { "chat",  "Free for Chat" },   /* WTF actually uses this? */
+        { "chat",  "Free for Chat" },
         { "dnd",   "Do not Disturb" },
         { "xa",    "Extended Away" },
+        { "",      "Online" },
         { "",      NULL }
 };
@@ -237 +238 @@
 {
         int i;
-        
-        if( code == NULL )
-                return NULL;
         
         for( i = 0; jabber_away_state_list[i].full_name; i ++ )
@@ -251 +249 @@
 {
         int i;
-        
-        if( name == NULL )
-                return NULL;
         
         for( i = 0; jabber_away_state_list[i].full_name; i ++ )

protocols/jabber/presence.c

@@ -190 +190 @@
                 int is_away = 0;
 
-                if( send_presence->away_state &&
-                    strcmp( send_presence->away_state->code, "chat" ) != 0 )
+                if( send_presence->away_state && !( *send_presence->away_state->code == 0 ||
+                    strcmp( send_presence->away_state->code, "chat" ) == 0 ) )
                         is_away = OPT_AWAY;
 
                 imcb_buddy_status( ic, send_presence->bare_jid, OPT_LOGGED_IN | is_away,
-                                   is_away ? send_presence->away_state->full_name : NULL,
+                                   ( is_away && send_presence->away_state ) ?
+                                   send_presence->away_state->full_name : NULL,
                                    send_presence->away_message );
         }
@@ -208 +209 @@
         struct jabber_data *jd = ic->proto_data;
         struct xt_node *node, *cap;
+        char *show = jd->away_state->code;
+        char *status = jd->away_message;
         struct groupchat *c;
         int st;
@@ -213 +216 @@
         node = jabber_make_packet( "presence", NULL, NULL, NULL );
         xt_add_child( node, xt_new_node( "priority", set_getstr( &ic->acc->set, "priority" ), NULL ) );
-        if( jd->away_state )
-                xt_add_child( node, xt_new_node( "show", jd->away_state->code, NULL ) );
-        if( jd->away_message )
-                xt_add_child( node, xt_new_node( "status", jd->away_message, NULL ) );
+        if( show && *show )
+                xt_add_child( node, xt_new_node( "show", show, NULL ) );
+        if( status )
+                xt_add_child( node, xt_new_node( "status", status, NULL ) );
         
         /* This makes the packet slightly bigger, but clients interested in

protocols/msn/msn.c

@@ -139 +139 @@
         
         if( l == NULL )
-                for( i = 0; *msn_away_state_list[i].code; i ++ )
-                        if( *msn_away_state_list[i].name )
-                                l = g_list_append( l, (void*) msn_away_state_list[i].name );
+                for( i = 0; msn_away_state_list[i].number > -1; i ++ )
+                        l = g_list_append( l, (void*) msn_away_state_list[i].name );
         
         return l;
@@ -150 +149 @@
         char buf[1024];
         struct msn_data *md = ic->proto_data;
-        
-        if( state )
-                md->away_state = msn_away_state_by_name( state ) ? :
-                                 msn_away_state_list + 1;
+        const struct msn_away_state *st;
+        
+        if( strcmp( state, GAIM_AWAY_CUSTOM ) == 0 )
+                st = msn_away_state_by_name( "Away" );
         else
-                md->away_state = msn_away_state_list;
-        
-        g_snprintf( buf, sizeof( buf ), "CHG %d %s\r\n", ++md->trId, md->away_state->code );
+                st = msn_away_state_by_name( state );
+        
+        if( !st ) st = msn_away_state_list;
+        md->away_state = st;
+        
+        g_snprintf( buf, sizeof( buf ), "CHG %d %s\r\n", ++md->trId, st->code );
         msn_write( ic, buf, strlen( buf ) );
 }

protocols/msn/msn.h

@@ -97 +97 @@
 struct msn_away_state
 {
+        int number;
         char code[4];
         char name[16];

protocols/msn/ns.c

@@ -420 +420 @@
                 {
                         /* FIXME: Warn/Bomb about unknown away state? */
-                        st = msn_away_state_list + 1;
-                }
-                
-                imcb_buddy_status( ic, cmd[3], OPT_LOGGED_IN | 
-                                   ( st != msn_away_state_list ? OPT_AWAY : 0 ),
-                                   st->name, NULL );
+                        st = msn_away_state_list;
+                }
+                
+                imcb_buddy_status( ic, cmd[3], OPT_LOGGED_IN |
+                                   ( st->number ? OPT_AWAY : 0 ), st->name, NULL );
         }
         else if( strcmp( cmd[0], "FLN" ) == 0 )
@@ -450 +449 @@
                 {
                         /* FIXME: Warn/Bomb about unknown away state? */
-                        st = msn_away_state_list + 1;
-                }
-                
-                imcb_buddy_status( ic, cmd[2], OPT_LOGGED_IN | 
-                                   ( st != msn_away_state_list ? OPT_AWAY : 0 ),
-                                   st->name, NULL );
+                        st = msn_away_state_list;
+                }
+                
+                imcb_buddy_status( ic, cmd[2], OPT_LOGGED_IN |
+                                   ( st->number ? OPT_AWAY : 0 ), st->name, NULL );
         }
         else if( strcmp( cmd[0], "RNG" ) == 0 )

protocols/msn/tables.c

@@ -29 +29 @@
 const struct msn_away_state msn_away_state_list[] =
 {
-        { "NLN", "" },
-        { "AWY", "Away" },
-        { "BSY", "Busy" },
-        { "IDL", "Idle" },
-        { "BRB", "Be Right Back" },
-        { "PHN", "On the Phone" },
-        { "LUN", "Out to Lunch" },
-        { "HDN", "Hidden" },
-        { "",    "" }
+        {  0, "NLN", "Available" },
+        {  1, "BSY", "Busy" },
+        {  3, "IDL", "Idle" },
+        {  5, "BRB", "Be Right Back" },
+        {  7, "AWY", "Away" },
+        {  9, "PHN", "On the Phone" },
+        { 11, "LUN", "Out to Lunch" },
+        { 13, "HDN", "Hidden" },
+        { -1, "",    "" }
 };
+
+const struct msn_away_state *msn_away_state_by_number( int number )
+{
+        int i;
+        
+        for( i = 0; msn_away_state_list[i].number > -1; i ++ )
+                if( msn_away_state_list[i].number == number )
+                        return( msn_away_state_list + i );
+        
+        return( NULL );
+}
 
 const struct msn_away_state *msn_away_state_by_code( char *code )
@@ -44 +55 @@
         int i;
         
-        for( i = 0; *msn_away_state_list[i].code; i ++ )
+        for( i = 0; msn_away_state_list[i].number > -1; i ++ )
                 if( g_strcasecmp( msn_away_state_list[i].code, code ) == 0 )
                         return( msn_away_state_list + i );
         
-        return NULL;
+        return( NULL );
 }
 
@@ -55 +66 @@
         int i;
         
-        for( i = 0; *msn_away_state_list[i].code; i ++ )
+        for( i = 0; msn_away_state_list[i].number > -1; i ++ )
                 if( g_strcasecmp( msn_away_state_list[i].name, name ) == 0 )
                         return( msn_away_state_list + i );
         
-        return NULL;
+        return( NULL );
 }
 

protocols/nogaim.c

@@ -2 +2 @@
   * BitlBee -- An IRC to other IM-networks gateway                     *
   *                                                                    *
-  * Copyright 2002-2010 Wilmer van der Gaast and others                *
+  * Copyright 2002-2006 Wilmer van der Gaast and others                *
   \********************************************************************/
 
@@ -268 +268 @@
         ic->flags |= OPT_LOGGED_IN;
         
-        /* Necessary to send initial presence status, even if we're not away. */
-        imc_away_send_update( ic );
+        /* Also necessary when we're not away, at least for some of the
+           protocols. */
+        imc_set_away( ic, u->away );
         
         /* Apparently we're connected successfully, so reset the
@@ -1069 +1070 @@
 }
 
-static char *imc_away_state_find( GList *gcm, char *away, char **message );
-
-int imc_away_send_update( struct im_connection *ic )
-{
-        char *away, *msg;
-        
-        away = set_getstr( &ic->acc->set, "away" ) ?
-             : set_getstr( &ic->irc->set, "away" );
-        if( away && *away )
-        {
-                GList *m = ic->acc->prpl->away_states( ic );
-                msg = ic->acc->flags & ACC_FLAG_AWAY_MESSAGE ? away : NULL;
-                away = imc_away_state_find( m, away, &msg ) ? : m->data;
-        }
-        else if( ic->acc->flags & ACC_FLAG_STATUS_MESSAGE )
-        {
-                away = NULL;
-                msg = set_getstr( &ic->acc->set, "status" ) ?
-                    : set_getstr( &ic->irc->set, "status" );
-        }
-        
-        ic->acc->prpl->set_away( ic, away, msg );
-        
-        return 1;
+static char *imc_away_alias_find( GList *gcm, char *away );
+
+int imc_set_away( struct im_connection *ic, char *away )
+{
+        GList *m, *ms;
+        char *s;
+        
+        if( !away ) away = "";
+        ms = m = ic->acc->prpl->away_states( ic );
+        
+        while( m )
+        {
+                if( *away )
+                {
+                        if( g_strncasecmp( m->data, away, strlen( m->data ) ) == 0 )
+                                break;
+                }
+                else
+                {
+                        if( g_strcasecmp( m->data, "Available" ) == 0 )
+                                break;
+                        if( g_strcasecmp( m->data, "Online" ) == 0 )
+                                break;
+                }
+                m = m->next;
+        }
+        
+        if( m )
+        {
+                ic->acc->prpl->set_away( ic, m->data, *away ? away : NULL );
+        }
+        else
+        {
+                s = imc_away_alias_find( ms, away );
+                if( s )
+                {
+                        ic->acc->prpl->set_away( ic, s, away );
+                        if( set_getbool( &ic->irc->set, "debug" ) )
+                                imcb_log( ic, "Setting away state to %s", s );
+                }
+                else
+                        ic->acc->prpl->set_away( ic, GAIM_AWAY_CUSTOM, away );
+        }
+        
+        return( 1 );
 }
 
@@ -1107 +1129 @@
 };
 
-static char *imc_away_state_find( GList *gcm, char *away, char **message )
+static char *imc_away_alias_find( GList *gcm, char *away )
 {
         GList *m;
         int i, j;
         
-        for( m = gcm; m; m = m->next )
-                if( g_strncasecmp( m->data, away, strlen( m->data ) ) == 0 )
-                {
-                        /* At least the Yahoo! module works better if message
-                           contains no data unless it adds something to what
-                           we have in state already. */
-                        if( strlen( m->data ) == strlen( away ) )
-                                *message = NULL;
-                        
-                        return m->data;
-                }
-        
         for( i = 0; *imc_away_alias_list[i]; i ++ )
         {
-                int keep_message;
-                
                 for( j = 0; imc_away_alias_list[i][j]; j ++ )
                         if( g_strncasecmp( away, imc_away_alias_list[i][j], strlen( imc_away_alias_list[i][j] ) ) == 0 )
-                        {
-                                keep_message = strlen( away ) != strlen( imc_away_alias_list[i][j] );
                                 break;
-                        }
                 
                 if( !imc_away_alias_list[i][j] )        /* If we reach the end, this row */
@@ -1141 +1146 @@
                 for( j = 0; imc_away_alias_list[i][j]; j ++ )
                 {
-                        for( m = gcm; m; m = m->next )
+                        m = gcm;
+                        while( m )
+                        {
                                 if( g_strcasecmp( imc_away_alias_list[i][j], m->data ) == 0 )
-                                {
-                                        if( !keep_message )
-                                                *message = NULL;
-                                        
-                                        return imc_away_alias_list[i][j];
-                                }
-                }
-                
-                /* No need to look further, apparently this state doesn't
-                   have any good alias for this protocol. */
-                break;
-        }
-        
-        return NULL;
+                                        return( imc_away_alias_list[i][j] );
+                                m = m->next;
+                        }
+                }
+        }
+        
+        return( NULL );
 }
 

protocols/nogaim.h

@@ -49 +49 @@
 
 #define WEBSITE "http://www.bitlbee.org/"
+#define GAIM_AWAY_CUSTOM "Custom"
 
 /* Sharing flags between all kinds of things. I just hope I won't hit any
@@ -217 +218 @@
         
         /* You can tell what away states your protocol supports, so that
-         * BitlBee will try to map the IRC away reasons to them. If your
-         * protocol doesn't have any, just return one generic "Away". */
+         * BitlBee will try to map the IRC away reasons to them, or use
+         * GAIM_AWAY_CUSTOM when calling skype_set_away(). */
         GList *(* away_states)(struct im_connection *ic);
         
@@ -314 +315 @@
 
 /* Actions, or whatever. */
-int imc_away_send_update( struct im_connection *ic );
+int imc_set_away( struct im_connection *ic, char *away );
 int imc_buddy_msg( struct im_connection *ic, char *handle, char *msg, int flags );
 int imc_chat_msg( struct groupchat *c, char *msg, int flags );

protocols/oscar/oscar.c

@@ -380 +380 @@
                 s->flags |= ACC_SET_OFFLINE_ONLY;
         }
-        
-        acc->flags |= ACC_FLAG_AWAY_MESSAGE;
 }
 
@@ -1954 +1952 @@
 static void oscar_set_away_aim(struct im_connection *ic, struct oscar_data *od, const char *state, const char *message)
 {
-        if (state == NULL)
-                state = "";
 
         if (!g_strcasecmp(state, _("Visible"))) {
@@ -1963 +1959 @@
                 aim_setextstatus(od->sess, od->conn, AIM_ICQ_STATE_INVISIBLE);
                 return;
-        } else if (message == NULL) {
-                message = state;
-        }
+        } /* else... */
 
         if (od->rights.maxawaymsglen == 0)
@@ -2008 +2002 @@
         }
 
-        if (state == NULL) {
+        if (!g_strcasecmp(state, "Online")) {
                 aim_setextstatus(od->sess, od->conn, AIM_ICQ_STATE_NORMAL);
         } else if (!g_strcasecmp(state, "Away")) {
@@ -2033 +2027 @@
                 aim_setextstatus(od->sess, od->conn, AIM_ICQ_STATE_INVISIBLE);
                 ic->away = g_strdup(msg);
-        } else {
+        } else if (!g_strcasecmp(state, GAIM_AWAY_CUSTOM)) {
                 if (no_message) {
                         aim_setextstatus(od->sess, od->conn, AIM_ICQ_STATE_NORMAL);
@@ -2282 +2276 @@
 {
         struct oscar_data *od = ic->proto_data;
-
-        if (od->icq) {
-                static GList *m = NULL;
-                m = g_list_append(m, "Away");
-                m = g_list_append(m, "Do Not Disturb");
-                m = g_list_append(m, "Not Available");
-                m = g_list_append(m, "Occupied");
-                m = g_list_append(m, "Free For Chat");
-                m = g_list_append(m, "Invisible");
-                return m;
-        } else {
-                static GList *m = NULL;
-                m = g_list_append(m, "Away");
-                return m;
-        }
+        GList *m = NULL;
+
+        if (!od->icq)
+                return g_list_append(m, GAIM_AWAY_CUSTOM);
+
+        m = g_list_append(m, "Online");
+        m = g_list_append(m, "Away");
+        m = g_list_append(m, "Do Not Disturb");
+        m = g_list_append(m, "Not Available");
+        m = g_list_append(m, "Occupied");
+        m = g_list_append(m, "Free For Chat");
+        m = g_list_append(m, "Invisible");
+
+        return m;
 }
 

protocols/yahoo/libyahoo2.c

@@ -4099 +4099 @@
 
         yd = yid->yd;
+
         old_status = yd->current_status;
-        yd->current_status = state;
+
+        if (msg && strncmp(msg,"Invisible",9)) {
+                yd->current_status = YAHOO_STATUS_CUSTOM;
+        } else {
+                yd->current_status = state;
+        }
 
         /* Thank you libpurple :) */
@@ -4115 +4121 @@
         snprintf(s, sizeof(s), "%d", yd->current_status);
         yahoo_packet_hash(pkt, 10, s);
-        yahoo_packet_hash(pkt, 19, msg && state == YAHOO_STATUS_CUSTOM ? msg : "");
+         
+        if (yd->current_status == YAHOO_STATUS_CUSTOM) {
+                yahoo_packet_hash(pkt, 19, msg);
+        } else {
+                yahoo_packet_hash(pkt, 19, "");
+        }
+        
         yahoo_packet_hash(pkt, 47, (away == 2)? "2": (away) ?"1":"0");
+
         yahoo_send_packet(yid, pkt, 0);
         yahoo_packet_free(pkt);

protocols/yahoo/yahoo.c

@@ -130 +130 @@
 {
         set_add( &acc->set, "mail_notifications", "false", set_eval_bool, acc );
-        
-        acc->flags |= ACC_FLAG_AWAY_MESSAGE | ACC_FLAG_STATUS_MESSAGE;
 }
 
@@ -199 +197 @@
 {
         struct byahoo_data *yd = (struct byahoo_data *) ic->proto_data;
-        
-        if( state && msg == NULL )
-        {
-                /* Use these states only if msg doesn't contain additional
-                   info since away messages are only supported with CUSTOM. */
-                if( g_strcasecmp( state, "Be Right Back" ) == 0 )
+        char *away;
+        
+        away = NULL;
+        
+        if( state && msg && g_strcasecmp( state, msg ) != 0 )
+        {
+                yd->current_status = YAHOO_STATUS_CUSTOM;
+                away = "";
+        }
+        else if( state )
+        {
+                /* Set msg to NULL since (if it isn't NULL already) it's equal
+                   to state. msg must be empty if we want to use an existing
+                   away state. */
+                msg = NULL;
+                
+                away = "";
+                if( g_strcasecmp( state, "Available" ) == 0 )
+                {
+                        yd->current_status = YAHOO_STATUS_AVAILABLE;
+                        away = NULL;
+                }
+                else if( g_strcasecmp( state, "Be Right Back" ) == 0 )
                         yd->current_status = YAHOO_STATUS_BRB;
                 else if( g_strcasecmp( state, "Busy" ) == 0 )
@@ -224 +239 @@
                 else if( g_strcasecmp( state, "Invisible" ) == 0 )
                         yd->current_status = YAHOO_STATUS_INVISIBLE;
-                else
-                        yd->current_status = YAHOO_STATUS_CUSTOM;
-        }
-        else if( state )
-                yd->current_status = YAHOO_STATUS_CUSTOM;
+                else if( g_strcasecmp( state, GAIM_AWAY_CUSTOM ) == 0 )
+                {
+                        yd->current_status = YAHOO_STATUS_AVAILABLE;
+                        
+                        away = NULL;
+                }
+        }
         else
                 yd->current_status = YAHOO_STATUS_AVAILABLE;
         
-        yahoo_set_away( yd->y2_id, yd->current_status, msg, state ? 2 : 0 );
+        yahoo_set_away( yd->y2_id, yd->current_status, msg, away != NULL ? 2 : 0 );
 }
 
@@ -241 +258 @@
         if( m == NULL )
         {
+                m = g_list_append( m, "Available" );
                 m = g_list_append( m, "Be Right Back" );
                 m = g_list_append( m, "Busy" );
@@ -251 +269 @@
                 m = g_list_append( m, "Stepped Out" );
                 m = g_list_append( m, "Invisible" );
+                m = g_list_append( m, GAIM_AWAY_CUSTOM );
         }