Changeset 19176513 for protocols/jabber

Timestamp:

2009-06-03T16:10:36Z (16 years ago)

Author:

Wilmer van der Gaast <wilmer@…>

Branches:

master

Children:

b9369b5

Parents:

9e768da

Message:

Fixed a bug that caused crashes when joining certain kinds of Google Talk
chatrooms. Doesn't seem to be Google Talk specific, other than that this
is the first time I see empty <x xmlns="​http://jabber.org/protocol/muc#user"/>
elements that cause this crash.

A more proper/efficient fix may be to just move the break outside the inner if.

File:

• protocols/jabber/conference.c (modified) (1 diff)

protocols/jabber/conference.c

@@ -234 +234 @@
                             ( strcmp( s, XMLNS_MUC_USER ) == 0 ) )
                         {
-                                c = xt_find_node( c->children, "item" );
-                                if( ( s = xt_find_attr( c, "jid" ) ) )
+                                struct xt_node *item;
+                                
+                                item = xt_find_node( c->children, "item" );
+                                if( ( s = xt_find_attr( item, "jid" ) ) )
                                 {
                                         /* Yay, found what we need. :-) */