Timestamp:
2018-02-11T21:27:17Z (7 years ago)
Author:
dequis <dx@…>
Branches:
master
Children:
8167346
Parents:
1dcbd3e
Message:

root_commands: Improve 'chat add' error/success messages

This handles the most common error case with an obvious error message
(channel already exists, join it, etc), and the rarer ones with vague
but different wording. For those cases:

  • "Could not add chatroom." This wording is not present in this version anymore, likely means the channel already exists.
  • "Error creating channel for chatroom." irc_channel_new() failed but the channel doesn't exist already. This could be that some name validation failed, but this function already generates a suitable name.
  • "Error adding chatroom." irc_channel_new() succeeded, but one of the set_setstr() failed. There are account checks earlier, and the room setting is not normally validated at this point.

Can't really imagine situations where these vague errors would still
show up, but at least now you only get those for unknown cases.

(No files)

Note: See TracChangeset for help on using the changeset viewer.