Changes in / [123cac7:1014cab]

Files:

• Makefile (modified) (2 diffs)
• account.c (modified) (5 diffs)
• account.h (modified) (2 diffs)
• bitlbee.c (modified) (3 diffs)
• bitlbee.conf (modified) (2 diffs)
• bitlbee.h (modified) (3 diffs)
• conf.c (modified) (4 diffs)
• conf.h (modified) (1 diff)
• configure (modified) (5 diffs)
• crypting.c (modified) (1 diff)
• debian/bitlbee.init (modified) (1 diff)
• debian/changelog (modified) (1 diff)
• debian/config (modified) (1 diff)
• debian/control (modified) (1 diff)
• debian/patches/bitlbee.conf.diff (modified) (1 diff)
• debian/po/POTFILES.in (modified) (1 diff)
• debian/po/ru.po (deleted)
• debian/postinst (modified) (2 diffs)
• debian/prerm (modified) (1 diff)
• doc/CHANGES (modified) (1 diff)
• doc/user-guide/commands.xml (modified) (8 diffs)
• doc/user-guide/misc.xml (modified) (2 diffs)
• irc.c (modified) (5 diffs)
• irc_commands.c (modified) (3 diffs)
• lib/misc.c (modified) (3 diffs)
• lib/misc.h (modified) (1 diff)
• protocols/jabber/io.c (modified) (3 diffs)
• protocols/jabber/iq.c (modified) (2 diffs)
• protocols/jabber/jabber.c (modified) (6 diffs)
• protocols/jabber/jabber.h (modified) (5 diffs)
• protocols/jabber/jabber_util.c (modified) (18 diffs)
• protocols/jabber/message.c (modified) (2 diffs)
• protocols/jabber/presence.c (modified) (4 diffs)
• protocols/msn/msn.c (modified) (6 diffs)
• protocols/msn/msn.h (modified) (4 diffs)
• protocols/msn/msn_util.c (modified) (3 diffs)
• protocols/msn/ns.c (modified) (9 diffs)
• protocols/msn/tables.c (modified) (3 diffs)
• protocols/nogaim.c (modified) (20 diffs)
• protocols/nogaim.h (modified) (7 diffs)
• protocols/oscar/oscar.c (modified) (7 diffs)
• protocols/yahoo/libyahoo2.c (modified) (12 diffs)
• protocols/yahoo/yahoo.c (modified) (5 diffs)
• protocols/yahoo/yahoo2_types.h (modified) (2 diffs)
• root_commands.c (modified) (7 diffs)
• tests/check_jabber_util.c (modified) (3 diffs)
• unix.c (modified) (5 diffs)
• user.h (modified) (1 diff)

Makefile

@@ -49 +49 @@
 
 clean: $(subdirs)
-        rm -f *.o $(OUTFILE) core utils/bitlbeed
+        rm -f *.o $(OUTFILE) core utils/bitlbeed encode decode
         $(MAKE) -C tests clean
 
@@ -124 +124 @@
 endif
 
+encode: crypting.c
+        $(CC) crypting.c lib/md5.c $(CFLAGS) -o encode -DCRYPTING_MAIN $(CFLAGS) $(EFLAGS) $(LFLAGS)
+
+decode: encode
+        cp encode decode
+
 ctags: 
         ctags `find . -name "*.c"` `find . -name "*.h"`

account.c

@@ -2 +2 @@
   * BitlBee -- An IRC to other IM-networks gateway                     *
   *                                                                    *
-  * Copyright 2002-2010 Wilmer van der Gaast and others                *
+  * Copyright 2002-2004 Wilmer van der Gaast and others                *
   \********************************************************************/
 
@@ -55 +55 @@
         s = set_add( &a->set, "auto_reconnect", "true", set_eval_bool, a );
         
-        s = set_add( &a->set, "nick_source", "handle", NULL, a );
-        
         s = set_add( &a->set, "password", NULL, set_eval_account, a );
         s->flags |= ACC_SET_NOSAVE | SET_NULL_OK;
@@ -71 +69 @@
                 prpl->init( a );
         
-        s = set_add( &a->set, "away", NULL, set_eval_account, a );
-        s->flags |= SET_NULL_OK;
-        
-        if( a->flags & ACC_FLAG_STATUS_MESSAGE )
-        {
-                s = set_add( &a->set, "status", NULL, set_eval_account, a );
-                s->flags |= SET_NULL_OK;
-        }
-        
-        return a;
+        return( a );
 }
 
@@ -132 +121 @@
                 
                 acc->auto_connect = bool2int( value );
-                return value;
-        }
-        else if( strcmp( set->key, "away" ) == 0 ||
-                 strcmp( set->key, "status" ) == 0 )
-        {
-                if( acc->ic && acc->ic->flags & OPT_LOGGED_IN )
-                {
-                        /* If we're currently on-line, set the var now already
-                           (bit of a hack) and send an update. */
-                        g_free( set->value );
-                        set->value = g_strdup( value );
-                        
-                        imc_away_send_update( acc->ic );
-                }
-                
                 return value;
         }
@@ -293 +267 @@
         p->max = 86400;
         
-        /* Format: /[0-9]+([*+][0-9]+(<[0-9+])?)?/ */
+        /* Format: /[0-9]+([*+][0-9]+(<[0-9+]))/ */
         while( *value && isdigit( *value ) )
                 p->start = p->start * 10 + *value++ - '0';

account.h

@@ -37 +37 @@
         int auto_reconnect_delay;
         int reconnect;
-        int flags;
         
         set_t *set;
@@ -57 +56 @@
 int account_reconnect_delay( account_t *a );
 
-typedef enum
-{
-        ACC_SET_NOSAVE = 0x01,          /* Don't save this setting (i.e. stored elsewhere). */
-        ACC_SET_OFFLINE_ONLY = 0x02,    /* Allow changes only if the acct is offline. */
-        ACC_SET_ONLINE_ONLY = 0x04,     /* Allow changes only if the acct is online. */
-} account_set_flag_t;
-
-typedef enum
-{
-        ACC_FLAG_AWAY_MESSAGE = 0x01,   /* Supports away messages instead of just states. */
-        ACC_FLAG_STATUS_MESSAGE = 0x02, /* Supports status messages (without being away). */
-} account_flag_t;
+#define ACC_SET_NOSAVE          0x01
+#define ACC_SET_OFFLINE_ONLY    0x02
+#define ACC_SET_ONLINE_ONLY     0x04
 
 #endif

bitlbee.c

@@ -70 +70 @@
                         continue;
 
-#ifdef IPV6_V6ONLY              
-                if( res->ai_family == AF_INET6 )
-                {
-                        i = 0;
-                        setsockopt( global.listen_socket, IPPROTO_IPV6, IPV6_V6ONLY,
-                                    (char *) &i, sizeof( i ) );
-                }
-#endif
-
                 /* TIME_WAIT (?) sucks.. */
                 i = 1;
@@ -89 +80 @@
                         return( -1 );
                 }
+
                 break;
         }
@@ -117 +109 @@
                 chdir( "/" );
                 
-                if( getenv( "_BITLBEE_RESTART_STATE" ) == NULL )
-                        for( i = 0; i < 3; i ++ )
-                                if( close( i ) == 0 )
-                                {
-                                        /* Keep something bogus on those fd's just in case. */
-                                        open( "/dev/null", O_WRONLY );
-                                }
+                /* Sometimes std* are already closed (for example when we're in a RESTARTed
+                   BitlBee process. So let's only close TTY-fds. */
+                if( isatty( 0 ) ) close( 0 );
+                if( isatty( 1 ) ) close( 1 );
+                if( isatty( 2 ) ) close( 2 );
         }
 #endif

bitlbee.conf

@@ -55 +55 @@
 ##
 ## Password the user should enter when logging into a closed BitlBee server.
-## You can also have a BitlBee-style MD5 hash here. Format: "md5:", followed
-## by a hash as generated by "bitlbee -x hash <password>".
+## You can also have an MD5-encrypted password here. Format: "md5:", followed
+## by a hash as generated for the <user password=""> attribute in a BitlBee
+## XML file (for now there's no easier way to generate the hash).
 ##
 # AuthPassword = ItllBeBitlBee   ## Heh.. Our slogan. ;-)
@@ -120 +121 @@
 ## Proxy = socks5://socksproxy.localnet.com
 
-## Protocols offered by bitlbee
-## 
-## As recompiling may be quite unpractical for some people, this option
-## allows to remove the support of protocol, even if compiled in. If
-## nothing is given, there are no restrictions.
-## 
-## Protocols = jabber yahoo
-
 
 [defaults]

bitlbee.h

@@ -27 +27 @@
 #define _BITLBEE_H
 
-#ifndef _GNU_SOURCE
 #define _GNU_SOURCE /* Stupid GNU :-P */
-#endif
 
 /* Depend on Windows 2000 for now since we need getaddrinfo() */
@@ -35 +33 @@
 
 #define PACKAGE "BitlBee"
-#define BITLBEE_VERSION "1.2.5"
+#define BITLBEE_VERSION "1.2.4"
 #define VERSION BITLBEE_VERSION
 
@@ -163 +161 @@
 
 char *set_eval_root_nick( set_t *set, char *new_nick );
-char *set_eval_control_channel( set_t *set, char *new_name );
 
 extern global_t global;

conf.c

@@ -63 +63 @@
         conf->ping_timeout = 300;
         conf->user = NULL;
-        conf->protocols = NULL;
         proxytype = 0;
         
@@ -128 +127 @@
                 {
                         printf( "Usage: bitlbee [-D/-F [-i <interface>] [-p <port>] [-n] [-v]] [-I]\n"
-                                "               [-c <file>] [-d <dir>] [-x] [-h]\n"
+                                "               [-c <file>] [-d <dir>] [-h]\n"
                                 "\n"
                                 "An IRC-to-other-chat-networks gateway\n"
@@ -144 +143 @@
                                 "  -c  Load alternative configuration file\n"
                                 "  -d  Specify alternative user configuration directory\n"
-                                "  -x  Command-line interface to password encryption/hashing\n"
                                 "  -h  Show this help page.\n" );
                         return NULL;
@@ -308 +306 @@
                                 conf->user = g_strdup( ini->value );
                         }
-                        else if( g_strcasecmp( ini->key, "protocols" ) == 0 )
-                        {
-                                g_strfreev( conf->protocols );
-                                conf->protocols = g_strsplit_set( ini->value, " \t,;", -1 );
-                        }
                         else
                         {

conf.h

@@ -50 +50 @@
         int ping_timeout;
         char *user;
-        char **protocols;
 } conf_t;
 

configure

@@ -20 +20 @@
 ipcsocket='/var/run/bitlbee.sock'
 pcdir='$prefix/lib/pkgconfig'
-systemlibdirs="/lib /lib64 /usr/lib /usr/lib64 /usr/local/lib /usr/local/lib64"
+systemlibdirs="/lib /usr/lib /usr/local/lib"
 
 msn=1
@@ -297 +297 @@
 detect_resolv_dynamic()
 {
-        TMPFILE=$(mktemp)
-        ret=1
-        echo "$RESOLV_TESTCODE" | $CC -o $TMPFILE -x c - -lresolv >/dev/null 2>/dev/null
+        echo "$RESOLV_TESTCODE" | $CC -o /dev/null -x c - -lresolv >/dev/null 2>/dev/null
         if [ "$?" = "0" ]; then
                 echo 'EFLAGS+=-lresolv' >> Makefile.settings
-                ret=0
-        fi
-
-        rm -f $TMPFILE
-        return $ret
+                return 0
+        fi
+
+        return 1
 }
 
 detect_resolv_static()
 {
-        TMPFILE=$(mktemp)
-        ret=1
         for i in $systemlibdirs; do
                 if [ -f $i/libresolv.a ]; then
-                        echo "$RESOLV_TESTCODE" | $CC -o $TMPFILE -x c - -Wl,$i/libresolv.a >/dev/null 2>/dev/null
+                        echo "$RESOLV_TESTCODE" | $CC -o /dev/null -x c - -Wl,$i/libresolv.a >/dev/null 2>/dev/null
                         if [ "$?" = "0" ]; then
                                 echo 'EFLAGS+='$i'/libresolv.a' >> Makefile.settings
-                                ret=0
+                                return 0
                         fi
                 fi
         done
 
-        rm -f $TMPFILE
-        return $ret
+        return 1
 }
 
@@ -368 +362 @@
         
         ## Yes, you, at the console! How can you authenticate if you don't have any SSL!?
-        if [ "$msn" = "1" -o "$yahoo" = "1" ]; then
+        if [ "$msn" = "1" ]; then
                 echo
-                echo 'WARNING: The MSN and Yahoo! modules will not work without SSL. Disabling.'
+                echo 'Real SSL support is necessary for MSN authentication, will build without'
+                echo 'MSN protocol support.'
                 msn=0
-                yahoo=0
         fi
         
@@ -452 +446 @@
 fi
 
-if [ ! -e doc/user-guide/help.txt ] && ! type xmlto > /dev/null 2> /dev/null; then
-        echo
-        echo 'WARNING: Building from an unreleased source tree without prebuilt helpfile.'
-        echo 'Install xmlto if you want online help to work.'
-fi
-
 echo
 if [ -z "$BITLBEE_VERSION" -a -d .bzr ] && type bzr > /dev/null 2> /dev/null; then
@@ -551 +539 @@
 ;;
 Darwin )
-        echo 'STRIP=\# skip strip' >> Makefile.settings
 ;;
 IRIX )

crypting.c

@@ -132 +132 @@
         return (rv);
 }
+
+#ifdef CRYPTING_MAIN
+
+/* A little main() function for people who want a stand-alone program to
+   encode/decode BitlCrypted files. */
+
+int main( int argc, char *argv[] )
+{
+        char *hash, *action, line[256];
+        char* (*func)( char *, const char * );
+        
+        if( argc < 2 )
+        {
+                fprintf( stderr, "Usage: %s <password>\n\n"
+                                 "Reads from stdin, writes to stdout.\n"
+                                 "Call as \"encode\" to encode, \"decode\" to decode.\n", argv[0] );
+                return( 1 );
+        }
+        
+        hash = hashpass( argv[1] );
+        action = argv[0] + strlen( argv[0] ) - strlen( "encode" );
+        
+        if( strcmp( action, "encode" ) == 0 )
+        {
+                fwrite( hash, 32, 1, stdout );
+                func = obfucrypt;
+        }
+        else if( strcmp( action, "decode" ) == 0 )
+        {
+                char hash2[32];
+                
+                fread( hash2, 32, 1, stdin );
+                if( memcmp( hash, hash2, 32 ) != 0 )
+                {
+                        fprintf( stderr, "Passwords don't match. Can't decode.\n" );
+                        return( 1 );
+                }
+                func = deobfucrypt;
+        }
+        else
+        {
+                return( main( 0, NULL ) );
+        }
+        
+        while( fscanf( stdin, "%[^\n]255s", line ) > 0 )
+        {
+                char *out;
+                
+                /* Flush the newline */
+                fgetc( stdin );
+                
+                out = func( line, argv[1] );
+                printf( "%s\n", out );
+                g_free( out );
+        }
+        
+        return( 0 );
+}
+
+#endif

debian/bitlbee.init

@@ -41 +41 @@
         chown bitlbee: /var/run/bitlbee.pid
         
-        start-stop-daemon --start --quiet --pidfile $PIDFILE \
+        # Clean up after the bug between 1.2-5 and 1.2.1-2 where BitlBee ran
+        # as root. (#494656 and #495877) Fixing this in the postinst script
+        # is not enough since the user will restart his BitlBee after up-
+        # grading the package, and the BitlBee running as root will then
+        # save its settings, re-setting ownership of the file to root.
+        # TODO: Remove this after a few revisions.
+        find /var/lib/bitlbee -uid 0 -name '*.xml' -exec chown bitlbee: {} \;
+
+        start-stop-daemon --start --quiet \
                 --exec $DAEMON -- -p $BITLBEE_PORT -P $PIDFILE $BITLBEE_OPTS
 }

debian/changelog

@@ -1 @@
-bitlbee (1.2.5-1) unstable; urgency=low
-
-  * New upstream version.
-  * Fixed issues with server-side MSN nickname corruption. (Closes: #538756)
-  * Debconf translation fixes/additions. (Closes: #541754, #563504)
-
- -- Wilmer van der Gaast <wilmer@gaast.net>  Wed, 17 Mar 2010 14:59:27 +0000
-
-bitlbee (1.2.4-2) unstable; urgency=low
-
-  * Merging in some changes from bzr-head:
-  * Use libresolv.so where possible. (Closes: #551775)
-  * Some include file changes that make the bitlbee-dev package useful again.
-
- -- Wilmer van der Gaast <wilmer@gaast.net>  Thu, 19 Nov 2009 23:02:43 +0000
-
-bitlbee (1.2.4-1) unstable; urgency=low
-
-  * New upstream version.
-  * Fixed issues with Yahoo! (Closes: #536178)
-
- -- Wilmer van der Gaast <wilmer@gaast.net>  Sat, 17 Oct 2009 18:12:45 +0100
-
-bitlbee (1.2.3-2) unstable; urgency=low
-
-  * Fixed bitblee typo in prerm (introduced by NMU 1.2.1-1.1).
-    (Closes: #531287)
-  * Fixed bitlbee.deb dep in bitlbee-dev to deal with binary NMUs.
-    (Closes: #531219)
-  * Fixed free port detection code in debian/config which was a bit limited
-    and also buggy.
-  * Removing code that edits bitlbee.conf from postinst (and chown code in
-    the init script), it's not really necessary anymore; bitlbee may only
-    still run as root if the admin doesn't read conffile diffs.
-    (Closes: #514572)
-  * No longer overwriting port number info in /etc/default/bitlbee with
-    what's in debconf. (Closes: #514148)
-  * Added notes about the above two changes to bitlbee.conf.
-
- -- Wilmer van der Gaast <wilmer@gaast.net>  Sun, 07 Jun 2009 21:17:39 +0100
-
-bitlbee (1.2.3-1) unstable; urgency=critical
-
-  * New upstream version.
-  * Fixes another account hijacking issue. (Closes: #498159)
-  * Restored --pidfile argument to start-stop-daemon, otherwise the init
-    script fails to restart BitlBee when users are connected.
-
- -- Wilmer van der Gaast <wilmer@gaast.net>  Sun, 07 Sep 2008 18:53:04 +0100
-
 bitlbee (1.2.2-1) unstable; urgency=critical
 

debian/config

@@ -2 +2 @@
 
 . /usr/share/debconf/confmodule
-[ -f /etc/default/bitlbee ] && . /etc/default/bitlbee
 
 db_title BitlBee
 
-if [ -n "$BITLBEE_PORT" ]; then
-        db_set bitlbee/serveport "$BITLBEE_PORT"
-else
-        db_get bitlbee/serveport
-        if [ "$RET" = "stillhavetoask" ]; then
-                listens=$(netstat -ltn | awk '{print $4}')
-                for port in 6667 6666 6668 6669; do
-                        if [ $(expr "$listens " : ".*:$port\s") = "0" ]; then
-                                break
-                        fi
-                done
-                db_set bitlbee/serveport $port;
+db_get bitlbee/serveport
+if [ "$RET" = "stillhavetoask" ]; then
+        if netstat -ltn | grep ':6667' 2> /dev/null > /dev/null; then
+                port=6668;
+        else
+                port=6667;
         fi
+        db_set bitlbee/serveport $port;
 fi
 

debian/control

@@ -19 +19 @@
 Package: bitlbee-dev
 Architecture: all
-Depends: bitlbee (>= ${source:Version}), bitlbee (<< ${source:Version}.1~)
+Depends: bitlbee (= ${binary:Version})
 Description: An IRC to other chat networks gateway
  This program can be used as an IRC server which forwards everything you

debian/patches/bitlbee.conf.diff

@@ -1 @@
---- debian/bitlbee/etc/bitlbee/bitlbee.conf     2009-06-01 00:20:24.000000000 +0100
-+++ debian/bitlbee/etc/bitlbee/bitlbee.conf     2009-06-07 21:16:19.000000000 +0100
-@@ -23,13 +23,18 @@
+=== modified file 'bitlbee.conf'
+--- debian/bitlbee/etc/bitlbee/bitlbee.conf     2008-08-26 22:33:54 +0000
++++ debian/bitlbee/etc/bitlbee/bitlbee.conf     2008-08-27 23:18:13 +0000
+@@ -23,7 +23,7 @@
  ## If BitlBee is started by root as a daemon, it can drop root privileges,
  ## and change to the specified user.
  ##
 -# User = bitlbee
-+## DEBIAN NOTE: Without this, BitlBee will run as root!
-+##
 +User = bitlbee
  
  ## DaemonPort/DaemonInterface:
  ##
- ## For daemon mode, you can specify on what interface and port the daemon
- ## should be listening for connections.
- ##
-+## DEBIAN NOTE: The init script passes the -p flag to use the port number
-+## set using debconf, this overrides the DaemonPort setting here.
-+##
- # DaemonInterface = 0.0.0.0
- # DaemonPort = 6667
- 
+

debian/po/POTFILES.in

@@ -1 @@
-[type: gettext/rfc822deb] templates
+[type: gettext/rfc822deb] bitlbee.templates.master

debian/postinst

@@ -33 +33 @@
 ## /etc/default/bitlbee: Auto-generated/updated script.
 ##
-## If running in (fork)daemon mode, listen on this TCP port.
+## Don't edit this line, use dpkg-reconfigure bitlbee
 BITLBEE_PORT="$PORT"
 
@@ -61 +61 @@
         else
                 mv /usr/share/bitlbee/help.upgrading /usr/share/bitlbee/help.txt
+        fi
+fi
+
+if ! grep -qi '^User *= *' /etc/bitlbee/bitlbee.conf; then
+        echo 'Updating configuration file, enabling User-setting...'
+        if ! sed -i -e 's/# *User *= *.*/User = bitlbee/i' /etc/bitlbee/bitlbee.conf; then
+                echo 'Failed! BitlBee may run as root now, please check your configs.'
         fi
 fi

debian/prerm

@@ -11 +11 @@
 else
         if which invoke-rc.d >/dev/null 2>&1; then
-                invoke-rc.d bitlbee stop || exit 0
+                invoke-rc.d bitblee stop || exit 0
         else
                 /etc/init.d/bitlbee stop || exit 0

doc/CHANGES

@@ -3 +3 @@
 
 http://bugs.bitlbee.org/bitlbee/timeline?daysback=90&changeset=on
-
-Version 1.2.5:
-- Many bug fixes, including a fix for MSN login issues, Jabber login timing
-  issues, Yahoo! crashes at login time with huge contact lists,
-- Avoid linking in a static version of libresolv now that glibc has all
-  relevant functions available in the dynamic version.
-- Improved away state code and added the ability to set (non-away) status
-  messages using "set status" (also possible per account) and see them in
-  blist and /whois output.
-- Added a post-1.2 equivalent of encode/decode to quickly encrypt/decrypt
-  passwords in a way that BitlBee can read them.
-- Allow using the full name for generating nicknames, instead of just the
-  handle. This is especially useful when using the Facebook XMPP server.
-- Auto reconnect is now enabled by default since all protocols can properly
-  detect cases where auto reconnect should be avoided (i.e. concurrent
-  logins).
-- Changed the default resource_select setting which should reduce message
-  routing issues on Jabber (i.e. messages going someone's phone instead of
-  the main client).
-
-Fixed 17 Mar 2010
 
 Version 1.2.4:

doc/user-guide/commands.xml

@@ -436 +436 @@
         </bitlbee-setting>
 
-        <bitlbee-setting name="away" type="string" scope="both">
-                <description>
-                        <para>
-                                To mark yourself as away, it is recommended to just use <emphasis>/away</emphasis>, like on normal IRC networks. If you want to mark yourself as away on only one IM network, you can use this per-account setting.
-                        </para>
-
-                        <para>
-                                You can set it to any value and BitlBee will try to map it to the most appropriate away state for every open IM connection, or set it as a free-form away message where possible.
-                        </para>
-
-                        <para>
-                                Any per-account away setting will override globally set away states. To un-set the setting, use <emphasis>set -del away</emphasis>.
-                        </para>
-                </description>
-        </bitlbee-setting>
-
         <bitlbee-setting name="away_devoice" type="boolean" scope="global">
                 <default>true</default>
@@ -509 +493 @@
                 </description>
 
-        </bitlbee-setting>
-
-        <bitlbee-setting name="control_channel" type="string" scope="global">
-                <default>&amp;bitlbee</default>
-
-                <description>
-                        <para>
-                                Normally the control channel where you can see all your contacts is called "&amp;bitlbee". If you don't like this name, you can rename it to anything else using the <emphasis>rename</emphasis> command, or by changing this setting.
-                        </para>
-                </description>
         </bitlbee-setting>
 
@@ -587 +561 @@
         </bitlbee-setting>
 
-        <bitlbee-setting name="ignore_auth_requests" type="boolean" scope="account">
-                <default>true</default>
-
-                <description>
-                        <para>
-                                Only supported by OSCAR so far, you can use this setting to ignore ICQ authorization requests, which are hardly used for legitimate (i.e. non-spam) reasons anymore.
-                        </para>
-                </description>
-
-        </bitlbee-setting>
-
         <bitlbee-setting name="lcnicks" type="boolean" scope="global">
                 <default>true</default>
@@ -609 +572 @@
         </bitlbee-setting>
 
-        <bitlbee-setting name="local_display_name" type="boolean" scope="account">
-                <default>false</default>
-
-                <description>
-                        <para>
-                                Mostly meant to work around a bug in MSN servers (forgetting the display name set by the user), this setting tells BitlBee to store your display name locally and set this name on the MSN servers when connecting.
-                        </para>
-                </description>
-
-        </bitlbee-setting>
-
         <bitlbee-setting name="mail_notifications" type="boolean" scope="account">
                 <default>false</default>
@@ -636 +588 @@
                         <para>
                                 You can use this option to set your nickname in a chatroom. You won't see this nickname yourself, but other people in the room will. By default, BitlBee will use your username as the chatroom nickname.
-                        </para>
-                </description>
-        </bitlbee-setting>
-
-        <bitlbee-setting name="nick_source" type="string" scope="account">
-                <default>handle</default>
-                <possible-values>handle, full_name, first_name</possible-values>
-
-                <description>
-                        <para>
-                                By default, BitlBee generates a nickname for every contact by taking its handle and chopping off everything after the @. In some cases, this gives very inconvenient nicknames. The Facebook XMPP server is a good example, as all Facebook XMPP handles are numeric.
-                        </para>
-
-                        <para>
-                                With this setting set to <emphasis>full_name</emphasis>, the person's full name is used to generate a nickname. Or if you don't like long nicknames, set this setting to <emphasis>first_name</emphasis> instead and only the first word will be used. Note that the full name can be full of non-ASCII characters which will be stripped off.
                         </para>
                 </description>
@@ -748 +685 @@
 
         <bitlbee-setting name="resource_select" type="string" scope="account">
-                <default>activity</default>
+                <default>priority</default>
                 <possible-values>priority, activity</possible-values>
 
@@ -810 +747 @@
         </bitlbee-setting>
 
-        <bitlbee-setting name="status" type="string" scope="both">
-                <description>
-                        <para>
-                                Certain protocols (like Jabber/XMPP) support status messages, similar to away messages. They can be used to indicate things like your location or activity, without showing up as away/busy.
-                        </para>
-
-                        <para>
-                                This setting can be used to set such a message. It will be available as a per-account setting for protocols that support it, and also as a global setting (which will then automatically be used for all protocols that support it).
-                        </para>
-
-                        <para>
-                                Away states set using <emphasis>/away</emphasis> or the <emphasis>away</emphasis> setting will override this setting. To un-set the setting, use <emphasis>set -del status</emphasis>.
-                        </para>
-                </description>
-        </bitlbee-setting>
-
         <bitlbee-setting name="strip_html" type="boolean" scope="global">
                 <default>true</default>
@@ -835 +756 @@
                         <para>
                                 If BitlBee fails to detect this sometimes (most likely in AIM messages over an ICQ connection), you can set this setting to <emphasis>always</emphasis>, but this might sometimes accidentally strip non-HTML things too.
-                        </para>
-                </description>
-        </bitlbee-setting>
-
-        <bitlbee-setting name="timezone" type="string" scope="global">
-                <default>local</default>
-                <possible-values>local, utc, gmt, timezone-spec</possible-values>
-
-                <description>
-                        <para>
-                                If message timestamps are available for offline messages or chatroom backlogs, BitlBee will display them as part of the message. By default it will use the local timezone. If you're not in the same timezone as the BitlBee server, you can adjust the timestamps using this setting.
-                        </para>
-
-                        <para>
-                                Values local/utc/gmt should be self-explanatory. timezone-spec is a time offset in hours:minutes, for example: -8 for Pacific Standard Time, +2 for Central European Summer Time, +5:30 for Indian Standard Time.
                         </para>
                 </description>

doc/user-guide/misc.xml

@@ -86 +86 @@
 
 <para>
-To mark yourself as away, you can just use the <emphasis>/away</emphasis> command in your IRC client. BitlBee supports most away-states supported by the protocols.
+As you might've expected, you can just use the <emphasis>/away</emphasis> command in your IRC client to set an away-state. BitlBee supports most away-states supported by the protocols.
 </para>
 
 <para>
-Away states have different names accross different protocols. BitlBee will try to pick the best available option for every connection:
+Not all away states are supported by all protocols, and some protocols have different names for them. BitlBee will try to pick the best available alias from this list for every connection:
 </para>
 
 <simplelist>
-        <member>Away</member>
-        <member>NA</member>
-        <member>Busy, DND</member>
-        <member>BRB</member>
-        <member>Phone</member>
-        <member>Lunch, Food</member>
+        <member>Away from computer, Away, Extended away</member>
+        <member>NA, N/A, Not available</member>
+        <member>Busy, Do not disturb, DND, Occupied</member>
+        <member>Be right back, BRB</member>
+        <member>On the phone, Phone, On phone</member>
+        <member>Out to lunch, Lunch, Food</member>
         <member>Invisible, Hidden</member>
 </simplelist>
 
 <para>
-So <emphasis>/away Food</emphasis> will set your state to "Out to lunch" on your MSN connection, and for most other connections the default, "Away" will be chosen.
+So <emphasis>/away Food</emphasis> will set your state to "Out to lunch" on your MSN connection, and for most other connections the default, "Away" or "Away from computer" will be chosen.
 </para>
 
@@ -111 +111 @@
 </para>
 
-<para>
-If you want to set an away state for only one of your connections, you can use the per-account <emphasis>away</emphasis> setting. See <emphasis>help set away</emphasis>.
-</para>
-
 </sect1>
 

irc.c

@@ -52 +52 @@
 {
         irc_t *irc = set->data;
-        char *test;
-        gsize test_bytes = 0;
         GIConv ic, oc;
 
@@ -59 +57 @@
                 value = g_strdup( "utf-8" );
 
+        if( ( ic = g_iconv_open( "utf-8", value ) ) == (GIConv) -1 )
+        {
+                return NULL;
+        }
         if( ( oc = g_iconv_open( value, "utf-8" ) ) == (GIConv) -1 )
         {
-                return NULL;
-        }
-        if( ( test = g_convert_with_iconv( " ", 1, oc, NULL, &test_bytes, NULL ) ) == NULL ||
-            test_bytes > 1 )
-        {
-                g_free( test );
-                g_iconv_close( oc );
-                irc_usermsg( irc, "Unsupported character set: The IRC protocol "
-                                  "only supports 8-bit character sets." );
-                return NULL;
-        }
-        if( ( ic = g_iconv_open( "utf-8", value ) ) == (GIConv) -1 )
-        {
-                g_iconv_close( oc );
+                g_iconv_close( ic );
                 return NULL;
         }
@@ -89 +78 @@
 }
 
-static char *set_eval_away_status( set_t *set, char *value )
-{
-        irc_t *irc = set->data;
-        account_t *a;
-        
-        g_free( set->value );
-        set->value = g_strdup( value );
-        
-        for( a = irc->accounts; a; a = a->next )
-        {
-                struct im_connection *ic = a->ic;
-                
-                if( ic && ic->flags & OPT_LOGGED_IN )
-                        imc_away_send_update( ic );
-        }
-        
-        return value;
-}
-
 irc_t *irc_new( int fd )
 {
@@ -173 +143 @@
         irc_connection_list = g_slist_append( irc_connection_list, irc );
         
-        s = set_add( &irc->set, "away", NULL,  set_eval_away_status, irc );
-        s->flags |= SET_NULL_OK;
         s = set_add( &irc->set, "away_devoice", "true",  set_eval_away_devoice, irc );
         s = set_add( &irc->set, "auto_connect", "true", set_eval_bool, irc );
-        s = set_add( &irc->set, "auto_reconnect", "true", set_eval_bool, irc );
+        s = set_add( &irc->set, "auto_reconnect", "false", set_eval_bool, irc );
         s = set_add( &irc->set, "auto_reconnect_delay", "5*3<900", set_eval_account_reconnect_delay, irc );
         s = set_add( &irc->set, "buddy_sendbuffer", "false", set_eval_bool, irc );
         s = set_add( &irc->set, "buddy_sendbuffer_delay", "200", set_eval_int, irc );
         s = set_add( &irc->set, "charset", "utf-8", set_eval_charset, irc );
-        s = set_add( &irc->set, "control_channel", irc->channel, set_eval_control_channel, irc );
         s = set_add( &irc->set, "debug", "false", set_eval_bool, irc );
         s = set_add( &irc->set, "default_target", "root", NULL, irc );
@@ -196 +163 @@
         s = set_add( &irc->set, "save_on_quit", "true", set_eval_bool, irc );
         s = set_add( &irc->set, "simulate_netsplit", "true", set_eval_bool, irc );
-        s = set_add( &irc->set, "status", NULL,  set_eval_away_status, irc );
-        s->flags |= SET_NULL_OK;
         s = set_add( &irc->set, "strip_html", "true", NULL, irc );
-        s = set_add( &irc->set, "timezone", "local", set_eval_timezone, irc );
         s = set_add( &irc->set, "to_char", ": ", set_eval_to_char, irc );
         s = set_add( &irc->set, "typing_notice", "false", set_eval_bool, irc );

irc_commands.c

@@ -448 +448 @@
         user_t *u = user_find( irc, irc->nick );
         char *away = cmd[1];
+        account_t *a;
         
         if( !u ) return;
@@ -474 +475 @@
         }
         
-        set_setstr( &irc->set, "away", u->away );
+        for( a = irc->accounts; a; a = a->next )
+        {
+                struct im_connection *ic = a->ic;
+                
+                if( ic && ic->flags & OPT_LOGGED_IN )
+                        imc_set_away( ic, u->away );
+        }
 }
 
@@ -497 +504 @@
                 else if( u->away )
                         irc_reply( irc, 301, "%s :%s", u->nick, u->away );
-                if( u->status_msg )
-                        irc_reply( irc, 333, "%s :Status: %s", u->nick, u->status_msg );
                 
                 irc_reply( irc, 318, "%s :End of /WHOIS list", nick );

lib/misc.c

@@ -34 +34 @@
 #include "nogaim.h"
 #include "base64.h"
-#include "md5.h"
 #include <stdio.h>
 #include <stdlib.h>
@@ -90 +89 @@
         { "gt",     ">" },
         { "amp",    "&" },
-        { "apos",   "'" },
         { "quot",   "\"" },
         { "aacute", "á" },
@@ -524 +522 @@
 
 /* Word wrapping. Yes, I know this isn't UTF-8 clean. I'm willing to take the risk. */
-char *word_wrap( const char *msg, int line_len )
+char *word_wrap( char *msg, int line_len )
 {
         GString *ret = g_string_sized_new( strlen( msg ) + 16 );

lib/misc.h

@@ -62 +62 @@
 G_MODULE_EXPORT struct ns_srv_reply *srv_lookup( char *service, char *protocol, char *domain );
 
-G_MODULE_EXPORT char *word_wrap( const char *msg, int line_len );
+G_MODULE_EXPORT char *word_wrap( char *msg, int line_len );
 
 G_MODULE_EXPORT gboolean ssl_sockerr_again( void *ssl );

protocols/jabber/io.c

@@ -375 +375 @@
         
         if( ( c = xt_find_node( node->children, "bind" ) ) )
-                jd->flags |= JFLAG_WANT_BIND;
+        {
+                reply = xt_new_node( "bind", NULL, xt_new_node( "resource", set_getstr( &ic->acc->set, "resource" ), NULL ) );
+                xt_add_attr( reply, "xmlns", XMLNS_BIND );
+                reply = jabber_make_packet( "iq", "set", NULL, reply );
+                jabber_cache_add( ic, reply, jabber_pkt_bind_sess );
+                
+                if( !jabber_write_packet( ic, reply ) )
+                        return XT_ABORT;
+                
+                jd->flags |= JFLAG_WAIT_BIND;
+        }
         
         if( ( c = xt_find_node( node->children, "session" ) ) )
-                jd->flags |= JFLAG_WANT_SESSION;
-        
-        if( jd->flags & JFLAG_AUTHENTICATED )
-                return jabber_pkt_bind_sess( ic, NULL, NULL );
+        {
+                reply = xt_new_node( "session", NULL, NULL );
+                xt_add_attr( reply, "xmlns", XMLNS_SESSION );
+                reply = jabber_make_packet( "iq", "set", NULL, reply );
+                jabber_cache_add( ic, reply, jabber_pkt_bind_sess );
+                
+                if( !jabber_write_packet( ic, reply ) )
+                        return XT_ABORT;
+                
+                jd->flags |= JFLAG_WAIT_SESSION;
+        }
+        
+        /* This flag is already set if we authenticated via SASL, so now
+           we can resume the session in the new stream, if we don't have
+           to bind/initialize the session. */
+        if( jd->flags & JFLAG_AUTHENTICATED && ( jd->flags & ( JFLAG_WAIT_BIND | JFLAG_WAIT_SESSION ) ) == 0 )
+        {
+                if( !jabber_get_roster( ic ) )
+                        return XT_ABORT;
+        }
         
         return XT_HANDLED;
@@ -415 +441 @@
         imcb_log( ic, "Converting stream to TLS" );
         
-        jd->flags |= JFLAG_STARTTLS_DONE;
         jd->ssl = ssl_starttls( jd->fd, jabber_connected_ssl, ic );
         
@@ -506 +531 @@
                 jd->r_inpa = b_input_add( jd->fd, GAIM_INPUT_READ, jabber_read_callback, ic );
         
-        greet = g_strdup_printf( "%s<stream:stream to=\"%s\" xmlns=\"jabber:client\" "
-                                  "xmlns:stream=\"http://etherx.jabber.org/streams\" version=\"1.0\">", 
-                                  ( jd->flags & JFLAG_STARTTLS_DONE ) ? "" : "<?xml version='1.0' ?>",
-                                  jd->server );
+        greet = g_strdup_printf( "<?xml version='1.0' ?>"
+                                 "<stream:stream to=\"%s\" xmlns=\"jabber:client\" "
+                                  "xmlns:stream=\"http://etherx.jabber.org/streams\" version=\"1.0\">", jd->server );
         
         st = jabber_write( ic, greet, strlen( greet ) );

protocols/jabber/iq.c

@@ -298 +298 @@
 {
         struct jabber_data *jd = ic->proto_data;
-        struct xt_node *c, *reply = NULL;
+        struct xt_node *c;
         char *s;
         
-        if( node && ( c = xt_find_node( node->children, "bind" ) ) )
+        if( ( c = xt_find_node( node->children, "bind" ) ) )
         {
                 c = xt_find_node( c->children, "jid" );
@@ -307 +307 @@
                     strcmp( s + 1, set_getstr( &ic->acc->set, "resource" ) ) != 0 )
                         imcb_log( ic, "Server changed session resource string to `%s'", s + 1 );
-        }
-        
-        if( jd->flags & JFLAG_WANT_BIND )
-        {
-                reply = xt_new_node( "bind", NULL, xt_new_node( "resource", set_getstr( &ic->acc->set, "resource" ), NULL ) );
-                xt_add_attr( reply, "xmlns", XMLNS_BIND );
-                jd->flags &= ~JFLAG_WANT_BIND;
-        }
-        else if( jd->flags & JFLAG_WANT_SESSION )
-        {
-                reply = xt_new_node( "session", NULL, NULL );
-                xt_add_attr( reply, "xmlns", XMLNS_SESSION );
-                jd->flags &= ~JFLAG_WANT_SESSION;
-        }
-        
-        if( reply != NULL )
-        {
-                reply = jabber_make_packet( "iq", "set", NULL, reply );
-                jabber_cache_add( ic, reply, jabber_pkt_bind_sess );
-                
-                if( !jabber_write_packet( ic, reply ) )
-                        return XT_ABORT;
-        }
-        else if( ( jd->flags & ( JFLAG_WANT_BIND | JFLAG_WANT_SESSION ) ) == 0 )
+                
+                jd->flags &= ~JFLAG_WAIT_BIND;
+        }
+        else
+        {
+                jd->flags &= ~JFLAG_WAIT_SESSION;
+        }
+        
+        if( ( jd->flags & ( JFLAG_WAIT_BIND | JFLAG_WAIT_SESSION ) ) == 0 )
         {
                 if( !jabber_get_roster( ic ) )

protocols/jabber/jabber.c

@@ -58 +58 @@
         char str[16];
         
-        s = set_add( &acc->set, "activity_timeout", "600", set_eval_int, acc );
-        
         g_snprintf( str, sizeof( str ), "%d", jabber_port_list[0] );
         s = set_add( &acc->set, "port", str, set_eval_int, acc );
@@ -69 +67 @@
         s->flags |= ACC_SET_OFFLINE_ONLY;
         
-        s = set_add( &acc->set, "resource_select", "activity", NULL, acc );
+        s = set_add( &acc->set, "resource_select", "priority", NULL, acc );
         
         s = set_add( &acc->set, "server", NULL, set_eval_account, acc );
@@ -82 +80 @@
         s = set_add( &acc->set, "xmlconsole", "false", set_eval_bool, acc );
         s->flags |= ACC_SET_OFFLINE_ONLY;
-        
-        acc->flags |= ACC_FLAG_AWAY_MESSAGE | ACC_FLAG_STATUS_MESSAGE;
 }
 
@@ -309 +305 @@
                 bud = jabber_buddy_by_ext_jid( ic, who, 0 );
         else
-                bud = jabber_buddy_by_jid( ic, who, GET_BUDDY_BARE_OK );
+                bud = jabber_buddy_by_jid( ic, who, 0 );
         
         node = xt_new_node( "body", message, NULL );
@@ -354 +350 @@
 static void jabber_get_info( struct im_connection *ic, char *who )
 {
+        struct jabber_data *jd = ic->proto_data;
         struct jabber_buddy *bud;
         
-        bud = jabber_buddy_by_jid( ic, who, GET_BUDDY_FIRST );
+        if( strchr( who, '/' ) )
+                bud = jabber_buddy_by_jid( ic, who, 0 );
+        else
+        {
+                char *s = jabber_normalize( who );
+                bud = g_hash_table_lookup( jd->buddies, s );
+                g_free( s );
+        }
         
         while( bud )
         {
-                imcb_log( ic, "Buddy %s (%d) information:", bud->full_jid, bud->priority );
-                if( bud->away_state )
-                        imcb_log( ic, "Away state: %s", bud->away_state->full_name );
-                imcb_log( ic, "Status message: %s", bud->away_message ? : "(none)" );
-                
+                imcb_log( ic, "Buddy %s (%d) information:\nAway state: %s\nAway message: %s",
+                                   bud->full_jid, bud->priority,
+                                   bud->away_state ? bud->away_state->full_name : "(none)",
+                                   bud->away_message ? : "(none)" );
                 bud = bud->next;
         }
@@ -374 +377 @@
 {
         struct jabber_data *jd = ic->proto_data;
-        
-        /* state_txt == NULL -> Not away.
-           Unknown state -> fall back to the first defined away state. */
-        jd->away_state = state_txt ? jabber_away_state_by_name( state_txt )
-                         ? : jabber_away_state_list : NULL;
-        
+        struct jabber_away_state *state;
+        
+        /* Save all this info. We need it, for example, when changing the priority setting. */
+        state = (void *) jabber_away_state_by_name( state_txt );
+        jd->away_state = state ? state : (void *) jabber_away_state_list; /* Fall back to "Away" if necessary. */
         g_free( jd->away_message );
         jd->away_message = ( message && *message ) ? g_strdup( message ) : NULL;

protocols/jabber/jabber.h

@@ -40 +40 @@
         JFLAG_STREAM_RESTART = 4,       /* Set when we want to restart the stream (after
                                            SASL or TLS). */
-        JFLAG_WANT_SESSION = 8,         /* Set if the server wants a <session/> tag
+        JFLAG_WAIT_SESSION = 8,         /* Set if we sent a <session> tag and need a reply
                                            before we continue. */
-        JFLAG_WANT_BIND = 16,           /* ... for <bind> tag. */
+        JFLAG_WAIT_BIND = 16,           /* ... for <bind> tag. */
         JFLAG_WANT_TYPING = 32,         /* Set if we ever sent a typing notification, this
                                            activates all XEP-85 related code. */
         JFLAG_XMLCONSOLE = 64,          /* If the user added an xmlconsole buddy. */
-        JFLAG_STARTTLS_DONE = 128,      /* If a plaintext session was converted to TLS. */
 } jabber_flags_t;
 
@@ -85 +84 @@
         /* After changing one of these two (or the priority setting), call
            presence_send_update() to inform the server about the changes. */
-        const struct jabber_away_state *away_state;
+        struct jabber_away_state *away_state;
         char *away_message;
         
@@ -108 +107 @@
 };
 
-/* Somewhat messy data structure: We have a hash table with the bare JID as
-   the key and the head of a struct jabber_buddy list as the value. The head
-   is always a bare JID. If the JID has other resources (often the case,
-   except for some transports that don't support multiple resources), those
-   follow. In that case, the bare JID at the beginning doesn't actually
-   refer to a real session and should only be used for operations that
-   support incomplete JIDs. */
 struct jabber_buddy
 {
@@ -128 +120 @@
         char *away_message;
         
-        time_t last_msg;
+        time_t last_act;
         jabber_buddy_flags_t flags;
         
@@ -216 +208 @@
         GET_BUDDY_EXACT = 2,    /* Get an exact match (only makes sense with bare JIDs). */
         GET_BUDDY_FIRST = 4,    /* No selection, simply get the first resource for this JID. */
-        GET_BUDDY_BARE = 8,     /* Get the bare version of the JID (possibly inexistent). */
-        GET_BUDDY_BARE_OK = 16, /* Allow returning a bare JID if that seems better. */
 } get_buddy_flags_t;
 

protocols/jabber/jabber_util.c

@@ -4 +4 @@
 *  Jabber module - Misc. stuff                                              *
 *                                                                           *
-*  Copyright 2006-2010 Wilmer van der Gaast <wilmer@gaast.net>              
+*  Copyright 2006 Wilmer van der Gaast <wilmer@gaast.net>                   *
 *                                                                           *
 *  This program is free software; you can redistribute it and/or modify     *
@@ -228 +228 @@
 {
         { "away",  "Away" },
-        { "chat",  "Free for Chat" },   /* WTF actually uses this? */
+        { "chat",  "Free for Chat" },
         { "dnd",   "Do not Disturb" },
         { "xa",    "Extended Away" },
+        { "",      "Online" },
         { "",      NULL }
 };
@@ -237 +238 @@
 {
         int i;
-        
-        if( code == NULL )
-                return NULL;
         
         for( i = 0; jabber_away_state_list[i].full_name; i ++ )
@@ -251 +249 @@
 {
         int i;
-        
-        if( name == NULL )
-                return NULL;
         
         for( i = 0; jabber_away_state_list[i].full_name; i ++ )
@@ -345 +340 @@
         if( ( bud = g_hash_table_lookup( jd->buddies, full_jid ) ) )
         {
-                /* The first entry is always a bare JID. If there are more, we
-                   should ignore the first one here. */
-                if( bud->next )
-                        bud = bud->next;
-                
                 /* If this is a transport buddy or whatever, it can't have more
                    than one instance, so this is always wrong: */
@@ -384 +374 @@
         else
         {
-                new->full_jid = new->bare_jid = g_strdup( full_jid );
+                /* Keep in mind that full_jid currently isn't really
+                   a full JID... */
+                new->bare_jid = g_strdup( full_jid );
                 g_hash_table_insert( jd->buddies, new->bare_jid, new );
-                
-                if( s )
-                {
-                        new->next = g_new0( struct jabber_buddy, 1 );
-                        new->next->bare_jid = new->bare_jid;
-                        new = new->next;
-                }
         }
         
@@ -418 +403 @@
 {
         struct jabber_data *jd = ic->proto_data;
-        struct jabber_buddy *bud, *head;
+        struct jabber_buddy *bud;
         char *s, *jid;
         
@@ -430 +415 @@
                 if( ( bud = g_hash_table_lookup( jd->buddies, jid ) ) )
                 {
-                        bare_exists = 1;
-                        
-                        if( bud->next )
-                                bud = bud->next;
-                        
                         /* Just return the first one for this bare JID. */
                         if( flags & GET_BUDDY_FIRST )
@@ -456 +436 @@
                                         break;
                 }
+                else
+                {
+                        /* This variable tells the if down here that the bare
+                           JID already exists and we should feel free to add
+                           more resources, if the caller asked for that. */
+                        bare_exists = 1;
+                }
                 
                 if( bud == NULL && ( flags & GET_BUDDY_CREAT ) &&
-                    ( bare_exists || imcb_find_buddy( ic, jid ) ) )
+                    ( !bare_exists || imcb_find_buddy( ic, jid ) ) )
                 {
                         *s = '/';
@@ -472 +459 @@
                 char *set;
                 
-                head = g_hash_table_lookup( jd->buddies, jid );
-                bud = ( head && head->next ) ? head->next : head;
+                bud = g_hash_table_lookup( jd->buddies, jid );
                 
                 g_free( jid );
@@ -490 +476 @@
                         /* Looks like the caller doesn't care about details. */
                         return bud;
-                else if( flags & GET_BUDDY_BARE )
-                        return head;
                 
                 best_prio = best_time = bud;
@@ -498 +482 @@
                         if( bud->priority > best_prio->priority )
                                 best_prio = bud;
-                        if( bud->last_msg > best_time->last_msg )
+                        if( bud->last_act > best_time->last_act )
                                 best_time = bud;
                 }
@@ -504 +488 @@
                 if( ( set = set_getstr( &ic->acc->set, "resource_select" ) ) == NULL )
                         return NULL;
-                else if( strcmp( set, "priority" ) == 0 )
+                else if( strcmp( set, "activity" ) == 0 )
+                        return best_time;
+                else /* if( strcmp( set, "priority" ) == 0 ) */
                         return best_prio;
-                else if( flags & GET_BUDDY_BARE_OK ) /* && strcmp( set, "activity" ) == 0 */
-                {
-                        if( best_time->last_msg + set_getint( &ic->acc->set, "activity_timeout" ) >= time( NULL ) )
-                                return best_time;
-                        else
-                                return head;
-                }
-                else
-                        return best_time;
         }
 }
@@ -556 +533 @@
 {
         struct jabber_data *jd = ic->proto_data;
-        struct jabber_buddy *bud, *prev = NULL, *bi;
+        struct jabber_buddy *bud, *prev, *bi;
         char *s, *full_jid;
         
@@ -566 +543 @@
         if( ( bud = g_hash_table_lookup( jd->buddies, full_jid ) ) )
         {
-                if( bud->next )
-                        bud = (prev=bud)->next;
-                
                 /* If there's only one item in the list (and if the resource
                    matches), removing it is simple. (And the hash reference
@@ -576 +550 @@
                       ( bud->resource && s && strcmp( bud->resource, s + 1 ) == 0 ) ) )
                 {
-                        return jabber_buddy_remove_bare( ic, full_jid );
+                        g_hash_table_remove( jd->buddies, bud->bare_jid );
+                        g_free( bud->bare_jid );
+                        g_free( bud->ext_jid );
+                        g_free( bud->full_jid );
+                        g_free( bud->away_message );
+                        g_free( bud );
+                        
+                        g_free( full_jid );
+                        
+                        return 1;
                 }
                 else if( s == NULL || bud->resource == NULL )
@@ -587 +570 @@
                 else
                 {
-                        for( bi = bud; bi; bi = (prev=bi)->next )
+                        for( bi = bud, prev = NULL; bi; bi = (prev=bi)->next )
                                 if( strcmp( bi->resource, s + 1 ) == 0 )
                                         break;
@@ -598 +581 @@
                                         prev->next = bi->next;
                                 else
-                                        /* Don't think this should ever happen anymore. */
+                                        /* The hash table should point at the second
+                                           item, because we're removing the first. */
                                         g_hash_table_replace( jd->buddies, bi->bare_jid, bi->next );
                                 

protocols/jabber/message.c

@@ -71 +71 @@
                         if( bud )
                         {
-                                bud->last_msg = time( NULL );
+                                bud->last_act = time( NULL );
                                 from = bud->ext_jid ? : bud->bare_jid;
                         }
@@ -80 +80 @@
                 if( type && strcmp( type, "headline" ) == 0 )
                 {
-                        if( ( c = xt_find_node( node->children, "subject" ) ) && c->text_len > 0 )
-                                g_string_append_printf( fullmsg, "Headline: %s\n", c->text );
+                        c = xt_find_node( node->children, "subject" );
+                        g_string_append_printf( fullmsg, "Headline: %s\n", c && c->text_len > 0 ? c->text : "" );
                         
                         /* <x xmlns="jabber:x:oob"><url>http://....</url></x> can contain a URL, it seems. */

protocols/jabber/presence.c

@@ -68 +68 @@
                 {
                         bud->away_state = NULL;
+                        /* Let's only set last_act if there's *no* away state,
+                           since it could be some auto-away thingy. */
+                        bud->last_act = time( NULL );
                 }
                 
@@ -187 +190 @@
                 int is_away = 0;
 
-                if( send_presence->away_state &&
-                    strcmp( send_presence->away_state->code, "chat" ) != 0 )
+                if( send_presence->away_state && !( *send_presence->away_state->code == 0 ||
+                    strcmp( send_presence->away_state->code, "chat" ) == 0 ) )
                         is_away = OPT_AWAY;
 
                 imcb_buddy_status( ic, send_presence->bare_jid, OPT_LOGGED_IN | is_away,
-                                   is_away ? send_presence->away_state->full_name : NULL,
+                                   ( is_away && send_presence->away_state ) ?
+                                   send_presence->away_state->full_name : NULL,
                                    send_presence->away_message );
         }
@@ -205 +209 @@
         struct jabber_data *jd = ic->proto_data;
         struct xt_node *node, *cap;
+        char *show = jd->away_state->code;
+        char *status = jd->away_message;
         struct groupchat *c;
         int st;
@@ -210 +216 @@
         node = jabber_make_packet( "presence", NULL, NULL, NULL );
         xt_add_child( node, xt_new_node( "priority", set_getstr( &ic->acc->set, "priority" ), NULL ) );
-        if( jd->away_state )
-                xt_add_child( node, xt_new_node( "show", jd->away_state->code, NULL ) );
-        if( jd->away_message )
-                xt_add_child( node, xt_new_node( "status", jd->away_message, NULL ) );
+        if( show && *show )
+                xt_add_child( node, xt_new_node( "show", show, NULL ) );
+        if( status )
+                xt_add_child( node, xt_new_node( "status", status, NULL ) );
         
         /* This makes the packet slightly bigger, but clients interested in

protocols/msn/msn.c

@@ -27 +27 @@
 #include "msn.h"
 
-int msn_chat_id;
-GSList *msn_connections;
-GSList *msn_switchboards;
-
-static char *set_eval_display_name( set_t *set, char *value );
+static char *msn_set_display_name( set_t *set, char *value );
 
 static void msn_init( account_t *acc )
 {
-        set_add( &acc->set, "display_name", NULL, set_eval_display_name, acc );
-        set_add( &acc->set, "local_display_name", "false", set_eval_bool, acc );
-        set_add( &acc->set, "mail_notifications", "false", set_eval_bool, acc );
+        set_t *s;
+        
+        s = set_add( &acc->set, "display_name", NULL, msn_set_display_name, acc );
+        s->flags |= ACC_SET_NOSAVE | ACC_SET_ONLINE_ONLY;
+
+        s = set_add( &acc->set, "mail_notifications", "false", set_eval_bool, acc );
 }
 
@@ -140 +139 @@
         
         if( l == NULL )
-                for( i = 0; *msn_away_state_list[i].code; i ++ )
-                        if( *msn_away_state_list[i].name )
-                                l = g_list_append( l, (void*) msn_away_state_list[i].name );
+                for( i = 0; msn_away_state_list[i].number > -1; i ++ )
+                        l = g_list_append( l, (void*) msn_away_state_list[i].name );
         
         return l;
@@ -151 +149 @@
         char buf[1024];
         struct msn_data *md = ic->proto_data;
-        
-        if( state )
-                md->away_state = msn_away_state_by_name( state ) ? :
-                                 msn_away_state_list + 1;
+        const struct msn_away_state *st;
+        
+        if( strcmp( state, GAIM_AWAY_CUSTOM ) == 0 )
+                st = msn_away_state_by_name( "Away" );
         else
-                md->away_state = msn_away_state_list;
-        
-        g_snprintf( buf, sizeof( buf ), "CHG %d %s\r\n", ++md->trId, md->away_state->code );
+                st = msn_away_state_by_name( state );
+        
+        if( !st ) st = msn_away_state_list;
+        md->away_state = st;
+        
+        g_snprintf( buf, sizeof( buf ), "CHG %d %s\r\n", ++md->trId, st->code );
         msn_write( ic, buf, strlen( buf ) );
 }
@@ -164 +165 @@
 static void msn_set_my_name( struct im_connection *ic, char *info )
 {
-        msn_set_display_name( ic, info );
+        msn_set_display_name( set_find( &ic->acc->set, "display_name" ), info );
 }
 
@@ -280 +281 @@
 }
 
-static char *set_eval_display_name( set_t *set, char *value )
+static char *msn_set_display_name( set_t *set, char *value )
 {
         account_t *acc = set->data;
         struct im_connection *ic = acc->ic;
-        
-        /* Allow any name if we're offline. */
+        struct msn_data *md;
+        char buf[1024], *fn;
+        
+        /* Double-check. */
         if( ic == NULL )
-                return value;
+                return NULL;
+        
+        md = ic->proto_data;
         
         if( strlen( value ) > 129 )
@@ -294 +299 @@
                 return NULL;
         }
+        
+        fn = msn_http_encode( value );
+        
+        g_snprintf( buf, sizeof( buf ), "REA %d %s %s\r\n", ++md->trId, ic->acc->user, fn );
+        msn_write( ic, buf, strlen( buf ) );
+        g_free( fn );
         
         /* Returning NULL would be better, because the server still has to
            confirm the name change. However, it looks a bit confusing to the
            user. */
-        return msn_set_display_name( ic, value ) ? value : NULL;
+        return value;
 }
 

protocols/msn/msn.h

@@ -97 +97 @@
 struct msn_away_state
 {
+        int number;
         char code[4];
         char name[16];
@@ -135 +136 @@
 #define STATUS_SB_CHAT_SPARE    8       /* Same, but also for groupchats (not used yet). */
 
-extern int msn_chat_id;
+int msn_chat_id;
 extern const struct msn_away_state msn_away_state_list[];
 extern const struct msn_status_code msn_status_code_list[];
@@ -144 +145 @@
    connection), the callback should check whether it's still listed here
    before doing *anything* else. */
-extern GSList *msn_connections;
-extern GSList *msn_switchboards;
+GSList *msn_connections;
+GSList *msn_switchboards;
 
 /* ns.c */
@@ -161 +162 @@
 char *msn_http_encode( const char *input );
 void msn_msgq_purge( struct im_connection *ic, GSList **list );
-gboolean msn_set_display_name( struct im_connection *ic, const char *rawname );
 
 /* tables.c */

protocols/msn/msn_util.c

@@ -38 +38 @@
                 imcb_error( ic, "Short write() to main server" );
                 imc_logout( ic, TRUE );
-                return 0;
-        }
-        
-        return 1;
+                return( 0 );
+        }
+        
+        return( 1 );
 }
 
@@ -171 +171 @@
                 
                 /* End of headers? */
-                if( ( i >= 4 && strncmp( text + i - 4, "\r\n\r\n", 4 ) == 0 ) ||
-                    ( i >= 2 && ( strncmp( text + i - 2, "\n\n", 2 ) == 0 ||   
-                                  strncmp( text + i - 2, "\r\r", 2 ) == 0 ) ) )
+                if( strncmp( text + i - 2, "\n\n", 2 ) == 0 ||
+                    strncmp( text + i - 4, "\r\n\r\n", 4 ) == 0 ||
+                    strncmp( text + i - 2, "\r\r", 2 ) == 0 )
                 {
                         break;
@@ -374 +374 @@
         *list = NULL;
         
-        imcb_log( ic, "%s", ret->str );
+        imcb_log( ic, ret->str );
         g_string_free( ret, TRUE );
 }
-
-gboolean msn_set_display_name( struct im_connection *ic, const char *rawname )
-{
-        char *fn = msn_http_encode( rawname );
-        struct msn_data *md = ic->proto_data;
-        char buf[1024];
-        
-        g_snprintf( buf, sizeof( buf ), "REA %d %s %s\r\n", ++md->trId, ic->acc->user, fn );
-        g_free( fn );
-        
-        return msn_write( ic, buf, strlen( buf ) ) != 0;
-}

protocols/msn/ns.c

@@ -35 +35 @@
 
 static void msn_auth_got_passport_token( struct msn_auth_data *mad );
-static gboolean msn_ns_got_display_name( struct im_connection *ic, char *name );
 
 gboolean msn_ns_connected( gpointer data, gint source, b_input_condition cond )
@@ -230 +229 @@
                         }
                 }
-                else if( num_parts >= 7 && strcmp( cmd[2], "OK" ) == 0 )
-                {
-                        if( num_parts == 7 )
-                                msn_ns_got_display_name( ic, cmd[4] );
-                        else
-                                imcb_log( ic, "Warning: Friendly name in server response was corrupted" );
+                else if( num_parts == 7 && strcmp( cmd[2], "OK" ) == 0 )
+                {
+                        set_t *s;
+                        
+                        http_decode( cmd[4] );
+                        
+                        strncpy( ic->displayname, cmd[4], sizeof( ic->displayname ) );
+                        ic->displayname[sizeof(ic->displayname)-1] = 0;
+                        
+                        if( ( s = set_find( &ic->acc->set, "display_name" ) ) )
+                        {
+                                g_free( s->value );
+                                s->value = g_strdup( cmd[4] );
+                        }
                         
                         imcb_log( ic, "Authenticated, getting buddy list" );
@@ -413 +420 @@
                 {
                         /* FIXME: Warn/Bomb about unknown away state? */
-                        st = msn_away_state_list + 1;
-                }
-                
-                imcb_buddy_status( ic, cmd[3], OPT_LOGGED_IN | 
-                                   ( st != msn_away_state_list ? OPT_AWAY : 0 ),
-                                   st->name, NULL );
+                        st = msn_away_state_list;
+                }
+                
+                imcb_buddy_status( ic, cmd[3], OPT_LOGGED_IN |
+                                   ( st->number ? OPT_AWAY : 0 ), st->name, NULL );
         }
         else if( strcmp( cmd[0], "FLN" ) == 0 )
@@ -443 +449 @@
                 {
                         /* FIXME: Warn/Bomb about unknown away state? */
-                        st = msn_away_state_list + 1;
-                }
-                
-                imcb_buddy_status( ic, cmd[2], OPT_LOGGED_IN | 
-                                   ( st != msn_away_state_list ? OPT_AWAY : 0 ),
-                                   st->name, NULL );
+                        st = msn_away_state_list;
+                }
+                
+                imcb_buddy_status( ic, cmd[2], OPT_LOGGED_IN |
+                                   ( st->number ? OPT_AWAY : 0 ), st->name, NULL );
         }
         else if( strcmp( cmd[0], "RNG" ) == 0 )
@@ -553 +558 @@
                 return( 0 );
         }
-#if 0
-        /* Discard this one completely for now since I don't care about the ack
-           and since MSN servers can apparently screw up the formatting. */
         else if( strcmp( cmd[0], "REA" ) == 0 )
         {
@@ -586 +588 @@
                 }
         }
-#endif
         else if( strcmp( cmd[0], "IPG" ) == 0 )
         {
@@ -662 +663 @@
                                 }
                                 
-                                g_free( arg1 );
-                                g_free( mtype );
+                                if( arg1 ) g_free( arg1 );
+                                if( mtype ) g_free( mtype );
                         }
                         else if( g_strncasecmp( ct, "text/x-msmsgsprofile", 20 ) == 0 )
@@ -671 +672 @@
                         else if( g_strncasecmp( ct, "text/x-msmsgsinitialemailnotification", 37 ) == 0 )
                         {
-                                if( set_getbool( &ic->acc->set, "mail_notifications" ) )
+                                char *inbox = msn_findheader( body, "Inbox-Unread:", blen );
+                                char *folders = msn_findheader( body, "Folders-Unread:", blen );
+                                
+                                if( inbox && folders && set_getbool( &ic->acc->set, "mail_notifications" ) )
                                 {
-                                        char *inbox = msn_findheader( body, "Inbox-Unread:", blen );
-                                        char *folders = msn_findheader( body, "Folders-Unread:", blen );
-
-                                        if( inbox && folders )
-                                                imcb_log( ic, "INBOX contains %s new messages, plus %s messages in other folders.", inbox, folders );
-                                        
-                                        g_free( inbox );
-                                        g_free( folders );
+                                        imcb_log( ic, "INBOX contains %s new messages, plus %s messages in other folders.", inbox, folders );
                                 }
+                                
+                                g_free( inbox );
+                                g_free( folders );
                         }
                         else if( g_strncasecmp( ct, "text/x-msmsgsemailnotification", 30 ) == 0 )
                         {
-                                if( set_getbool( &ic->acc->set, "mail_notifications" ) )
+                                char *from = msn_findheader( body, "From-Addr:", blen );
+                                char *fromname = msn_findheader( body, "From:", blen );
+                                
+                                if( from && fromname && set_getbool( &ic->acc->set, "mail_notifications" ) )
                                 {
-                                        char *from = msn_findheader( body, "From-Addr:", blen );
-                                        char *fromname = msn_findheader( body, "From:", blen );
-                                        
-                                        if( from && fromname )
-                                                imcb_log( ic, "Received an e-mail message from %s <%s>.", fromname, from );
-
-                                        g_free( from );
-                                        g_free( fromname );
+                                        imcb_log( ic, "Received an e-mail message from %s <%s>.", fromname, from );
                                 }
                         }
@@ -736 +732 @@
         }
 }
-
-static gboolean msn_ns_got_display_name( struct im_connection *ic, char *name )
-{
-        set_t *s;
-        
-        if( ( s = set_find( &ic->acc->set, "display_name" ) ) == NULL )
-                return FALSE; /* Shouldn't happen.. */
-        
-        http_decode( name );
-        
-        if( s->value && strcmp( s->value, name ) == 0 )
-        {
-                return TRUE;
-                /* The names match, nothing to worry about. */
-        }
-        else if( s->value != NULL &&
-                 ( strcmp( name, ic->acc->user ) == 0 ||
-                   set_getbool( &ic->acc->set, "local_display_name" ) ) )
-        {
-                /* The server thinks our display name is our e-mail address
-                   which is probably wrong, or the user *wants* us to do this:
-                   Always use the locally set display_name. */
-                return msn_set_display_name( ic, s->value );
-        }
-        else
-        {
-                if( s->value && *s->value )
-                        imcb_log( ic, "BitlBee thinks your display name is `%s' but "
-                                      "the MSN server says it's `%s'. Using the MSN "
-                                      "server's name. Set local_display_name to true "
-                                      "to use the local name.", s->value, name );
-                
-                if( g_utf8_validate( name, -1, NULL ) )
-                {
-                        g_free( s->value );
-                        s->value = g_strdup( name );
-                }
-                else
-                {
-                        imcb_log( ic, "Warning: Friendly name in server response was corrupted" );
-                }
-                
-                return TRUE;
-        }
-}

protocols/msn/tables.c

@@ -29 +29 @@
 const struct msn_away_state msn_away_state_list[] =
 {
-        { "NLN", "" },
-        { "AWY", "Away" },
-        { "BSY", "Busy" },
-        { "IDL", "Idle" },
-        { "BRB", "Be Right Back" },
-        { "PHN", "On the Phone" },
-        { "LUN", "Out to Lunch" },
-        { "HDN", "Hidden" },
-        { "",    "" }
+        {  0, "NLN", "Available" },
+        {  1, "BSY", "Busy" },
+        {  3, "IDL", "Idle" },
+        {  5, "BRB", "Be Right Back" },
+        {  7, "AWY", "Away" },
+        {  9, "PHN", "On the Phone" },
+        { 11, "LUN", "Out to Lunch" },
+        { 13, "HDN", "Hidden" },
+        { -1, "",    "" }
 };
+
+const struct msn_away_state *msn_away_state_by_number( int number )
+{
+        int i;
+        
+        for( i = 0; msn_away_state_list[i].number > -1; i ++ )
+                if( msn_away_state_list[i].number == number )
+                        return( msn_away_state_list + i );
+        
+        return( NULL );
+}
 
 const struct msn_away_state *msn_away_state_by_code( char *code )
@@ -44 +55 @@
         int i;
         
-        for( i = 0; *msn_away_state_list[i].code; i ++ )
+        for( i = 0; msn_away_state_list[i].number > -1; i ++ )
                 if( g_strcasecmp( msn_away_state_list[i].code, code ) == 0 )
                         return( msn_away_state_list + i );
         
-        return NULL;
+        return( NULL );
 }
 
@@ -55 +66 @@
         int i;
         
-        for( i = 0; *msn_away_state_list[i].code; i ++ )
+        for( i = 0; msn_away_state_list[i].number > -1; i ++ )
                 if( g_strcasecmp( msn_away_state_list[i].name, name ) == 0 )
                         return( msn_away_state_list + i );
         
-        return NULL;
+        return( NULL );
 }
 

protocols/nogaim.c

@@ -2 +2 @@
   * BitlBee -- An IRC to other IM-networks gateway                     *
   *                                                                    *
-  * Copyright 2002-2010 Wilmer van der Gaast and others                *
+  * Copyright 2002-2006 Wilmer van der Gaast and others                *
   \********************************************************************/
 
@@ -39 +39 @@
 
 static int remove_chat_buddy_silent( struct groupchat *b, const char *handle );
-static char *format_timestamp( irc_t *irc, time_t msg_ts );
 
 GSList *connections;
@@ -99 +98 @@
 void register_protocol (struct prpl *p)
 {
-        int i;
-        gboolean refused = global.conf->protocols != NULL;
- 
-        for (i = 0; global.conf->protocols && global.conf->protocols[i]; i++)
-        {
-                if (g_strcasecmp(p->name, global.conf->protocols[i]) == 0)
-                        refused = FALSE;
-        }
-
-        if (refused)
-                log_message(LOGLVL_WARNING, "Protocol %s disabled\n", p->name);
-        else
-                protocols = g_list_append(protocols, p);
+        protocols = g_list_append(protocols, p);
 }
 
@@ -286 +273 @@
         ic->flags |= OPT_LOGGED_IN;
         
-        /* Necessary to send initial presence status, even if we're not away. */
-        imc_away_send_update( ic );
+        /* Also necessary when we're not away, at least for some of the
+           protocols. */
+        imc_set_away( ic, u->away );
         
         /* Apparently we're connected successfully, so reset the
@@ -389 +377 @@
 /* list.c */
 
-void imcb_add_buddy( struct im_connection *ic, const char *handle, const char *group )
+void imcb_add_buddy( struct im_connection *ic, char *handle, char *group )
 {
         user_t *u;
@@ -463 +451 @@
 }
 
-void imcb_rename_buddy( struct im_connection *ic, const char *handle, const char *realname )
+void imcb_rename_buddy( struct im_connection *ic, char *handle, char *realname )
 {
         user_t *u = user_findhandle( ic, handle );
-        char *set;
         
         if( !u || !realname ) return;
@@ -479 +466 @@
                         imcb_log( ic, "User `%s' changed name to `%s'", u->nick, u->realname );
         }
-        
-        set = set_getstr( &ic->acc->set, "nick_source" );
-        if( strcmp( set, "handle" ) != 0 )
-        {
-                char *name = g_strdup( realname );
-                
-                if( strcmp( set, "first_name" ) == 0 )
-                {
-                        int i;
-                        for( i = 0; name[i] && !isspace( name[i] ); i ++ ) {}
-                        name[i] = '\0';
-                }
-                
-                imcb_buddy_nick_hint( ic, handle, name );
-                
-                g_free( name );
-        }
-}
-
-void imcb_remove_buddy( struct im_connection *ic, const char *handle, char *group )
+}
+
+void imcb_remove_buddy( struct im_connection *ic, char *handle, char *group )
 {
         user_t *u;
@@ -508 +478 @@
 /* Mainly meant for ICQ (and now also for Jabber conferences) to allow IM
    modules to suggest a nickname for a handle. */
-void imcb_buddy_nick_hint( struct im_connection *ic, const char *handle, const char *nick )
+void imcb_buddy_nick_hint( struct im_connection *ic, char *handle, char *nick )
 {
         user_t *u = user_findhandle( ic, handle );
@@ -653 +623 @@
         oo = u->online;
         
-        g_free( u->away );
-        g_free( u->status_msg );
-        u->away = u->status_msg = NULL;
+        if( u->away )
+        {
+                g_free( u->away );
+                u->away = NULL;
+        }
         
         if( ( flags & OPT_LOGGED_IN ) && !u->online )
@@ -693 +665 @@
                 }
         }
-        else
-        {
-                u->status_msg = g_strdup( message );
-        }
+        /* else waste_any_state_information_for_now(); */
         
         /* LISPy... */
@@ -721 +690 @@
 }
 
-void imcb_buddy_msg( struct im_connection *ic, const char *handle, char *msg, uint32_t flags, time_t sent_at )
+void imcb_buddy_msg( struct im_connection *ic, char *handle, char *msg, uint32_t flags, time_t sent_at )
 {
         irc_t *irc = ic->irc;
-        char *wrapped, *ts;
+        char *wrapped;
         user_t *u;
         
@@ -766 +735 @@
             ( ( ic->flags & OPT_DOES_HTML ) && set_getbool( &ic->irc->set, "strip_html" ) ) )
                 strip_html( msg );
-        
-        if( ( ts = format_timestamp( irc, sent_at ) ) )
-        {
-                char *new = g_strconcat( ts, msg, NULL );
-                g_free( ts );
-                ts = msg = new;
-        }
-        
+
         wrapped = word_wrap( msg, 425 );
         irc_msgfrom( irc, u->nick, wrapped );
         g_free( wrapped );
-        g_free( ts );
 }
 
@@ -862 +823 @@
 }
 
-void imcb_chat_msg( struct groupchat *c, const char *who, char *msg, uint32_t flags, time_t sent_at )
+void imcb_chat_msg( struct groupchat *c, char *who, char *msg, uint32_t flags, time_t sent_at )
 {
         struct im_connection *ic = c->ic;
@@ -881 +842 @@
         if( c && u )
         {
-                char *ts = format_timestamp( ic->irc, sent_at );
-                irc_privmsg( ic->irc, u, "PRIVMSG", c->channel, ts ? : "", wrapped );
-                g_free( ts );
+                irc_privmsg( ic->irc, u, "PRIVMSG", c->channel, "", wrapped );
         }
         else
@@ -936 +895 @@
 /* buddy_chat.c */
 
-void imcb_chat_add_buddy( struct groupchat *b, const char *handle )
+void imcb_chat_add_buddy( struct groupchat *b, char *handle )
 {
         user_t *u = user_findhandle( b->ic, handle );
@@ -971 +930 @@
 
 /* This function is one BIG hack... :-( EREWRITE */
-void imcb_chat_remove_buddy( struct groupchat *b, const char *handle, const char *reason )
+void imcb_chat_remove_buddy( struct groupchat *b, char *handle, char *reason )
 {
         user_t *u;
@@ -1077 +1036 @@
 }
 
-char *set_eval_timezone( set_t *set, char *value )
-{
-        char *s;
-        
-        if( strcmp( value, "local" ) == 0 ||
-            strcmp( value, "gmt" ) == 0 || strcmp( value, "utc" ) == 0 )
-                return value;
-        
-        /* Otherwise: +/- at the beginning optional, then one or more numbers,
-           possibly followed by a colon and more numbers. Don't bother bound-
-           checking them since users are free to shoot themselves in the foot. */
-        s = value;
-        if( *s == '+' || *s == '-' )
-                s ++;
-        
-        /* \d+ */
-        if( !isdigit( *s ) )
-                return SET_INVALID;
-        while( *s && isdigit( *s ) ) s ++;
-        
-        /* EOS? */
-        if( *s == '\0' )
-                return value;
-        
-        /* Otherwise, colon */
-        if( *s != ':' )
-                return SET_INVALID;
-        s ++;
-        
-        /* \d+ */
-        if( !isdigit( *s ) )
-                return SET_INVALID;
-        while( *s && isdigit( *s ) ) s ++;
-        
-        /* EOS */
-        return *s == '\0' ? value : SET_INVALID;
-}
-
-static char *format_timestamp( irc_t *irc, time_t msg_ts )
-{
-        time_t now_ts = time( NULL );
-        struct tm now, msg;
-        char *set;
-        
-        /* If the timestamp is <= 0 or less than a minute ago, discard it as
-           it doesn't seem to add to much useful info and/or might be noise. */
-        if( msg_ts <= 0 || msg_ts > now_ts - 60 )
-                return NULL;
-        
-        set = set_getstr( &irc->set, "timezone" );
-        if( strcmp( set, "local" ) == 0 )
-        {
-                localtime_r( &now_ts, &now );
-                localtime_r( &msg_ts, &msg );
-        }
-        else
-        {
-                int hr, min = 0, sign = 60;
-                
-                if( set[0] == '-' )
-                {
-                        sign *= -1;
-                        set ++;
-                }
-                else if( set[0] == '+' )
-                {
-                        set ++;
-                }
-                
-                if( sscanf( set, "%d:%d", &hr, &min ) >= 1 )
-                {
-                        msg_ts += sign * ( hr * 60 + min );
-                        now_ts += sign * ( hr * 60 + min );
-                }
-                
-                gmtime_r( &now_ts, &now );
-                gmtime_r( &msg_ts, &msg );
-        }
-        
-        if( msg.tm_year == now.tm_year && msg.tm_yday == now.tm_yday )
-                return g_strdup_printf( "\x02[\x02\x02\x02%02d:%02d:%02d\x02]\x02 ",
-                                        msg.tm_hour, msg.tm_min, msg.tm_sec );
-        else
-                return g_strdup_printf( "\x02[\x02\x02\x02%04d-%02d-%02d "
-                                        "%02d:%02d:%02d\x02]\x02 ",
-                                        msg.tm_year + 1900, msg.tm_mon, msg.tm_mday,
-                                        msg.tm_hour, msg.tm_min, msg.tm_sec );
-}
+
+
 
 /* The plan is to not allow straight calls to prpl functions anymore, but do
@@ -1202 +1075 @@
 }
 
-static char *imc_away_state_find( GList *gcm, char *away, char **message );
-
-int imc_away_send_update( struct im_connection *ic )
-{
-        char *away, *msg = NULL;
-        
-        away = set_getstr( &ic->acc->set, "away" ) ?
-             : set_getstr( &ic->irc->set, "away" );
-        if( away && *away )
-        {
-                GList *m = ic->acc->prpl->away_states( ic );
-                msg = ic->acc->flags & ACC_FLAG_AWAY_MESSAGE ? away : NULL;
-                away = imc_away_state_find( m, away, &msg ) ? : m->data;
-        }
-        else if( ic->acc->flags & ACC_FLAG_STATUS_MESSAGE )
-        {
-                away = NULL;
-                msg = set_getstr( &ic->acc->set, "status" ) ?
-                    : set_getstr( &ic->irc->set, "status" );
-        }
-        
-        ic->acc->prpl->set_away( ic, away, msg );
-        
-        return 1;
+static char *imc_away_alias_find( GList *gcm, char *away );
+
+int imc_set_away( struct im_connection *ic, char *away )
+{
+        GList *m, *ms;
+        char *s;
+        
+        if( !away ) away = "";
+        ms = m = ic->acc->prpl->away_states( ic );
+        
+        while( m )
+        {
+                if( *away )
+                {
+                        if( g_strncasecmp( m->data, away, strlen( m->data ) ) == 0 )
+                                break;
+                }
+                else
+                {
+                        if( g_strcasecmp( m->data, "Available" ) == 0 )
+                                break;
+                        if( g_strcasecmp( m->data, "Online" ) == 0 )
+                                break;
+                }
+                m = m->next;
+        }
+        
+        if( m )
+        {
+                ic->acc->prpl->set_away( ic, m->data, *away ? away : NULL );
+        }
+        else
+        {
+                s = imc_away_alias_find( ms, away );
+                if( s )
+                {
+                        ic->acc->prpl->set_away( ic, s, away );
+                        if( set_getbool( &ic->irc->set, "debug" ) )
+                                imcb_log( ic, "Setting away state to %s", s );
+                }
+                else
+                        ic->acc->prpl->set_away( ic, GAIM_AWAY_CUSTOM, away );
+        }
+        
+        return( 1 );
 }
 
@@ -1240 +1134 @@
 };
 
-static char *imc_away_state_find( GList *gcm, char *away, char **message )
+static char *imc_away_alias_find( GList *gcm, char *away )
 {
         GList *m;
         int i, j;
         
-        for( m = gcm; m; m = m->next )
-                if( g_strncasecmp( m->data, away, strlen( m->data ) ) == 0 )
-                {
-                        /* At least the Yahoo! module works better if message
-                           contains no data unless it adds something to what
-                           we have in state already. */
-                        if( strlen( m->data ) == strlen( away ) )
-                                *message = NULL;
-                        
-                        return m->data;
-                }
-        
         for( i = 0; *imc_away_alias_list[i]; i ++ )
         {
-                int keep_message;
-                
                 for( j = 0; imc_away_alias_list[i][j]; j ++ )
                         if( g_strncasecmp( away, imc_away_alias_list[i][j], strlen( imc_away_alias_list[i][j] ) ) == 0 )
-                        {
-                                keep_message = strlen( away ) != strlen( imc_away_alias_list[i][j] );
                                 break;
-                        }
                 
                 if( !imc_away_alias_list[i][j] )        /* If we reach the end, this row */
@@ -1274 +1151 @@
                 for( j = 0; imc_away_alias_list[i][j]; j ++ )
                 {
-                        for( m = gcm; m; m = m->next )
+                        m = gcm;
+                        while( m )
+                        {
                                 if( g_strcasecmp( imc_away_alias_list[i][j], m->data ) == 0 )
-                                {
-                                        if( !keep_message )
-                                                *message = NULL;
-                                        
-                                        return imc_away_alias_list[i][j];
-                                }
-                }
-                
-                /* No need to look further, apparently this state doesn't
-                   have any good alias for this protocol. */
-                break;
-        }
-        
-        return NULL;
+                                        return( imc_away_alias_list[i][j] );
+                                m = m->next;
+                        }
+                }
+        }
+        
+        return( NULL );
 }
 

protocols/nogaim.h

@@ -49 +49 @@
 
 #define WEBSITE "http://www.bitlbee.org/"
+#define GAIM_AWAY_CUSTOM "Custom"
 
 /* Sharing flags between all kinds of things. I just hope I won't hit any
@@ -217 +218 @@
         
         /* You can tell what away states your protocol supports, so that
-         * BitlBee will try to map the IRC away reasons to them. If your
-         * protocol doesn't have any, just return one generic "Away". */
+         * BitlBee will try to map the IRC away reasons to them, or use
+         * GAIM_AWAY_CUSTOM when calling skype_set_away(). */
         GList *(* away_states)(struct im_connection *ic);
         
@@ -275 +276 @@
  * user, usually after a login, or if the user added a buddy and the IM
  * server confirms that the add was successful. Don't forget to do this! */
-G_MODULE_EXPORT void imcb_add_buddy( struct im_connection *ic, const char *handle, const char *group );
-G_MODULE_EXPORT void imcb_remove_buddy( struct im_connection *ic, const char *handle, char *group );
+G_MODULE_EXPORT void imcb_add_buddy( struct im_connection *ic, char *handle, char *group );
+G_MODULE_EXPORT void imcb_remove_buddy( struct im_connection *ic, char *handle, char *group );
 G_MODULE_EXPORT struct buddy *imcb_find_buddy( struct im_connection *ic, char *handle );
-G_MODULE_EXPORT void imcb_rename_buddy( struct im_connection *ic, const char *handle, const char *realname );
-G_MODULE_EXPORT void imcb_buddy_nick_hint( struct im_connection *ic, const char *handle, const char *nick );
+G_MODULE_EXPORT void imcb_rename_buddy( struct im_connection *ic, char *handle, char *realname );
+G_MODULE_EXPORT void imcb_buddy_nick_hint( struct im_connection *ic, char *handle, char *nick );
 
 /* Buddy activity */
@@ -289 +290 @@
 /* Not implemented yet! */ G_MODULE_EXPORT void imcb_buddy_times( struct im_connection *ic, const char *handle, time_t login, time_t idle );
 /* Call when a handle says something. 'flags' and 'sent_at may be just 0. */
-G_MODULE_EXPORT void imcb_buddy_msg( struct im_connection *ic, const char *handle, char *msg, uint32_t flags, time_t sent_at );
+G_MODULE_EXPORT void imcb_buddy_msg( struct im_connection *ic, char *handle, char *msg, uint32_t flags, time_t sent_at );
 G_MODULE_EXPORT void imcb_buddy_typing( struct im_connection *ic, char *handle, uint32_t flags );
 G_MODULE_EXPORT void imcb_clean_handle( struct im_connection *ic, char *handle );
@@ -302 +303 @@
  *   user, too. */
 G_MODULE_EXPORT struct groupchat *imcb_chat_new( struct im_connection *ic, const char *handle );
-G_MODULE_EXPORT void imcb_chat_add_buddy( struct groupchat *b, const char *handle );
+G_MODULE_EXPORT void imcb_chat_add_buddy( struct groupchat *b, char *handle );
 /* To remove a handle from a group chat. Reason can be NULL. */
-G_MODULE_EXPORT void imcb_chat_remove_buddy( struct groupchat *b, const char *handle, const char *reason );
+G_MODULE_EXPORT void imcb_chat_remove_buddy( struct groupchat *b, char *handle, char *reason );
 /* To tell BitlBee 'who' said 'msg' in 'c'. 'flags' and 'sent_at' can be 0. */
-G_MODULE_EXPORT void imcb_chat_msg( struct groupchat *c, const char *who, char *msg, uint32_t flags, time_t sent_at );
+G_MODULE_EXPORT void imcb_chat_msg( struct groupchat *c, char *who, char *msg, uint32_t flags, time_t sent_at );
 /* System messages specific to a groupchat, so they can be displayed in the right context. */
 G_MODULE_EXPORT void imcb_chat_log( struct groupchat *c, char *format, ... ) G_GNUC_PRINTF( 2, 3 );
@@ -314 +315 @@
 
 /* Actions, or whatever. */
-int imc_away_send_update( struct im_connection *ic );
+int imc_set_away( struct im_connection *ic, char *away );
 int imc_buddy_msg( struct im_connection *ic, char *handle, char *msg, int flags );
 int imc_chat_msg( struct groupchat *c, char *msg, int flags );
@@ -324 +325 @@
 
 /* Misc. stuff */
-char *set_eval_timezone( set_t *set, char *value );
 char *set_eval_away_devoice( set_t *set, char *value );
 gboolean auto_reconnect( gpointer data, gint fd, b_input_condition cond );

protocols/oscar/oscar.c

@@ -373 +373 @@
         set_t *s;
         
+        s = set_add( &acc->set, "server", AIM_DEFAULT_LOGIN_SERVER, set_eval_account, acc );
+        s->flags |= ACC_SET_NOSAVE | ACC_SET_OFFLINE_ONLY;
+        
         if (isdigit(acc->user[0])) {
-                set_add(&acc->set, "ignore_auth_requests", "false", set_eval_bool, acc);
-        }
-        
-        s = set_add(&acc->set, "server", AIM_DEFAULT_LOGIN_SERVER, set_eval_account, acc);
-        s->flags |= ACC_SET_NOSAVE | ACC_SET_OFFLINE_ONLY;
-        
-        if(isdigit(acc->user[0])) {
-                s = set_add(&acc->set, "web_aware", "false", set_eval_bool, acc);
+                s = set_add( &acc->set, "web_aware", "false", set_eval_bool, acc );
                 s->flags |= ACC_SET_OFFLINE_ONLY;
         }
-        
-        acc->flags |= ACC_FLAG_AWAY_MESSAGE;
 }
 
@@ -1216 +1210 @@
  */
 static void gaim_icq_authask(struct im_connection *ic, guint32 uin, char *msg) {
-        struct icq_auth *data;
+        struct icq_auth *data = g_new(struct icq_auth, 1);
         char *reason = NULL;
         char *dialog_msg;
-
-        if (set_getbool(&ic->acc->set, "ignore_auth_requests"))
-                return;
-        
-        data = g_new(struct icq_auth, 1);
-
+        
         if (strlen(msg) > 6)
                 reason = msg + 6;
@@ -1963 +1952 @@
 static void oscar_set_away_aim(struct im_connection *ic, struct oscar_data *od, const char *state, const char *message)
 {
-        if (state == NULL)
-                state = "";
 
         if (!g_strcasecmp(state, _("Visible"))) {
@@ -1972 +1959 @@
                 aim_setextstatus(od->sess, od->conn, AIM_ICQ_STATE_INVISIBLE);
                 return;
-        } else if (message == NULL) {
-                message = state;
-        }
+        } /* else... */
 
         if (od->rights.maxawaymsglen == 0)
@@ -2017 +2002 @@
         }
 
-        if (state == NULL) {
+        if (!g_strcasecmp(state, "Online")) {
                 aim_setextstatus(od->sess, od->conn, AIM_ICQ_STATE_NORMAL);
         } else if (!g_strcasecmp(state, "Away")) {
@@ -2042 +2027 @@
                 aim_setextstatus(od->sess, od->conn, AIM_ICQ_STATE_INVISIBLE);
                 ic->away = g_strdup(msg);
-        } else {
+        } else if (!g_strcasecmp(state, GAIM_AWAY_CUSTOM)) {
                 if (no_message) {
                         aim_setextstatus(od->sess, od->conn, AIM_ICQ_STATE_NORMAL);
@@ -2291 +2276 @@
 {
         struct oscar_data *od = ic->proto_data;
-
-        if (od->icq) {
-                static GList *m = NULL;
-                m = g_list_append(m, "Away");
-                m = g_list_append(m, "Do Not Disturb");
-                m = g_list_append(m, "Not Available");
-                m = g_list_append(m, "Occupied");
-                m = g_list_append(m, "Free For Chat");
-                m = g_list_append(m, "Invisible");
-                return m;
-        } else {
-                static GList *m = NULL;
-                m = g_list_append(m, "Away");
-                return m;
-        }
+        GList *m = NULL;
+
+        if (!od->icq)
+                return g_list_append(m, GAIM_AWAY_CUSTOM);
+
+        m = g_list_append(m, "Online");
+        m = g_list_append(m, "Away");
+        m = g_list_append(m, "Do Not Disturb");
+        m = g_list_append(m, "Not Available");
+        m = g_list_append(m, "Occupied");
+        m = g_list_append(m, "Free For Chat");
+        m = g_list_append(m, "Invisible");
+
+        return m;
 }
 

protocols/yahoo/libyahoo2.c

@@ -855 +855 @@
 }
 
+static YList * bud_str2list(char *rawlist)
+{
+        YList * l = NULL;
+
+        char **lines;
+        char **split;
+        char **buddies;
+        char **tmp, **bud;
+
+        lines = y_strsplit(rawlist, "\n", -1);
+        for (tmp = lines; *tmp; tmp++) {
+                struct yahoo_buddy *newbud;
+
+                split = y_strsplit(*tmp, ":", 2);
+                if (!split)
+                        continue;
+                if (!split[0] || !split[1]) {
+                        y_strfreev(split);
+                        continue;
+                }
+                buddies = y_strsplit(split[1], ",", -1);
+
+                for (bud = buddies; bud && *bud; bud++) {
+                        newbud = y_new0(struct yahoo_buddy, 1);
+                        newbud->id = strdup(*bud);
+                        newbud->group = strdup(split[0]);
+
+                        if(y_list_find_custom(l, newbud, is_same_bud)) {
+                                FREE(newbud->id);
+                                FREE(newbud->group);
+                                FREE(newbud);
+                                continue;
+                        }
+
+                        newbud->real_name = NULL;
+
+                        l = y_list_append(l, newbud);
+
+                        NOTICE(("Added buddy %s to group %s", newbud->id, newbud->group));
+                }
+
+                y_strfreev(buddies);
+                y_strfreev(split);
+        }
+        y_strfreev(lines);
+
+        return l;
+}
+
 static char * getcookie(char *rawcookie)
 {
@@ -1311 +1360 @@
 }
 
-static void yahoo_process_status(struct yahoo_input_data *yid,
-        struct yahoo_packet *pkt)
+
+static void yahoo_process_status(struct yahoo_input_data *yid, struct yahoo_packet *pkt)
 {
         YList *l;
         struct yahoo_data *yd = yid->yd;
 
-        struct yahoo_process_status_entry *u;
+        struct user
+        {
+                char *name;     /* 7    name */
+                int   state;    /* 10   state */
+                int   flags;    /* 13   flags, bit 0 = pager, bit 1 = chat, bit 2 = game */
+                int   mobile;   /* 60   mobile */
+                char *msg;      /* 19   custom status message */
+                int   away;     /* 47   away (or invisible)*/
+                int   buddy_session;    /* 11   state */
+                int   f17;      /* 17   in chat? then what about flags? */
+                int   idle;     /* 137  seconds idle */
+                int   f138;     /* 138  state */
+                char *f184;     /* 184  state */
+                int   f192;     /* 192  state */
+                int   f10001;   /* 10001        state */
+                int   f10002;   /* 10002        state */
+                int   f198;     /* 198  state */
+                char *f197;     /* 197  state */
+                char *f205;     /* 205  state */
+                int   f213;     /* 213  state */
+        } *u;
 
         YList *users = 0;
-
+        
         if (pkt->service == YAHOO_SERVICE_LOGOFF && pkt->status == -1) {
-                YAHOO_CALLBACK(ext_yahoo_login_response) (yd->client_id,
-                        YAHOO_LOGIN_DUPL, NULL);
-                return;
-        }
-
-        /* Status updates may be spread accross multiple packets and not
-           even on buddy boundaries, so keeping some state is important.
-           So, continue where we left off, and only add a user entry to
-           the list once it's complete (301-315 End buddy). */
-        u = yd->half_user;
+                YAHOO_CALLBACK(ext_yahoo_login_response)(yd->client_id, YAHOO_LOGIN_DUPL, NULL);
+                return;
+        }
 
         for (l = pkt->hash; l; l = l->next) {
@@ -1337 +1399 @@
 
                 switch (pair->key) {
-                case 300:       /* Begin buddy */
-                        if (!strcmp(pair->value, "315") && !u) {
-                                u = yd->half_user = y_new0(struct yahoo_process_status_entry, 1);
+                case 0: /* we won't actually do anything with this */
+                        NOTICE(("key %d:%s", pair->key, pair->value));
+                        break;
+                case 1: /* we don't get the full buddy list here. */
+                        if (!yd->logged_in) {
+                                yd->logged_in = TRUE;
+                                if(yd->current_status < 0)
+                                        yd->current_status = yd->initial_status;
+                                YAHOO_CALLBACK(ext_yahoo_login_response)(yd->client_id, YAHOO_LOGIN_OK, NULL);
                         }
                         break;
-                case 301:       /* End buddy */
-                        if (!strcmp(pair->value, "315") && u) {
-                                /* Sometimes user info comes in an odd format with no
-                                   "begin buddy" but *with* an "end buddy". Don't add
-                                   it twice. */
-                                if (!y_list_find(users, u))
-                                        users = y_list_prepend(users, u);
-                                u = yd->half_user = NULL;
-                        }
-                        break;
-                case 0: /* we won't actually do anything with this */
+                case 8: /* how many online buddies we have */
                         NOTICE(("key %d:%s", pair->key, pair->value));
                         break;
-                case 1: /* we don't get the full buddy list here. */
-                        if (!yd->logged_in) {
-                                yd->logged_in = 1;
-                                if (yd->current_status < 0)
-                                        yd->current_status = yd->initial_status;
-                                YAHOO_CALLBACK(ext_yahoo_login_response) (yd->
-                                        client_id, YAHOO_LOGIN_OK, NULL);
-                        }
-                        break;
-                case 8: /* how many online buddies we have */
-                        NOTICE(("key %d:%s", pair->key, pair->value));
-                        break;
-                case 7: /* the current buddy */
-                        if (!u) {
-                                /* This will only happen in case of a single level message */
-                                u = y_new0(struct yahoo_process_status_entry, 1);
-                                users = y_list_prepend(users, u);
-                        }
+                case 7: /* the current buddy */
+                        u = y_new0(struct user, 1);
                         u->name = pair->value;
-                        break;
-                case 10:        /* state */
-                        u->state = strtol(pair->value, NULL, 10);
-                        break;
-                case 19:        /* custom status message */
-                        u->msg = pair->value;
-                        break;
-                case 47:        /* is it an away message or not. Not applicable for YMSG16 anymore */
-                        u->away = atoi(pair->value);
-                        break;
-                case 137:       /* seconds idle */
-                        u->idle = atoi(pair->value);
-                        break;
-                case 11:        /* this is the buddy's session id */
-                        u->buddy_session = atoi(pair->value);
-                        break;
-                case 17:        /* in chat? */
-                        u->f17 = atoi(pair->value);
-                        break;
-                case 13:        /* bitmask, bit 0 = pager, bit 1 = chat, bit 2 = game */
-                        u->flags = atoi(pair->value);
-                        break;
-                case 60:        /* SMS -> 1 MOBILE USER */
+                        users = y_list_prepend(users, u);
+                        break;
+                case 10: /* state */
+                        ((struct user*)users->data)->state = strtol(pair->value, NULL, 10);
+                        break;
+                case 19: /* custom status message */
+                        ((struct user*)users->data)->msg = pair->value;
+                        break;
+                case 47: /* is it an away message or not */
+                        ((struct user*)users->data)->away = atoi(pair->value);
+                        break;
+                case 137: /* seconds idle */
+                        ((struct user*)users->data)->idle = atoi(pair->value);
+                        break;
+                case 11: /* this is the buddy's session id */
+                        ((struct user*)users->data)->buddy_session = atoi(pair->value);
+                        break;
+                case 17: /* in chat? */
+                        ((struct user*)users->data)->f17 = atoi(pair->value);
+                        break;
+                case 13: /* bitmask, bit 0 = pager, bit 1 = chat, bit 2 = game */
+                        ((struct user*)users->data)->flags = atoi(pair->value);
+                        break;
+                case 60: /* SMS -> 1 MOBILE USER */
                         /* sometimes going offline makes this 2, but invisible never sends it */
-                        u->mobile = atoi(pair->value);
+                        ((struct user*)users->data)->mobile = atoi(pair->value);
                         break;
                 case 138:
-                        u->f138 = atoi(pair->value);
+                        ((struct user*)users->data)->f138 = atoi(pair->value);
                         break;
                 case 184:
-                        u->f184 = pair->value;
+                        ((struct user*)users->data)->f184 = pair->value;
                         break;
                 case 192:
-                        u->f192 = atoi(pair->value);
+                        ((struct user*)users->data)->f192 = atoi(pair->value);
                         break;
                 case 10001:
-                        u->f10001 = atoi(pair->value);
+                        ((struct user*)users->data)->f10001 = atoi(pair->value);
                         break;
                 case 10002:
-                        u->f10002 = atoi(pair->value);
+                        ((struct user*)users->data)->f10002 = atoi(pair->value);
                         break;
                 case 198:
-                        u->f198 = atoi(pair->value);
+                        ((struct user*)users->data)->f198 = atoi(pair->value);
                         break;
                 case 197:
-                        u->f197 = pair->value;
+                        ((struct user*)users->data)->f197 = pair->value;
                         break;
                 case 205:
-                        u->f205 = pair->value;
+                        ((struct user*)users->data)->f205 = pair->value;
                         break;
                 case 213:
-                        u->f213 = atoi(pair->value);
-                        break;
-                case 16:        /* Custom error message */
-                        YAHOO_CALLBACK(ext_yahoo_error) (yd->client_id,
-                                pair->value, 0, E_CUSTOM);
+                        ((struct user*)users->data)->f213 = atoi(pair->value);
+                        break;
+                case 16: /* Custom error message */
+                        YAHOO_CALLBACK(ext_yahoo_error)(yd->client_id, pair->value, 0, E_CUSTOM);
                         break;
                 default:
-                        WARNING(("unknown status key %d:%s", pair->key,
-                                        pair->value));
-                        break;
-                }
-        }
-
+                        WARNING(("unknown status key %d:%s", pair->key, pair->value));
+                        break;
+                }
+        }
+        
         while (users) {
                 YList *t = users;
-                struct yahoo_process_status_entry *u = users->data;
+                struct user *u = users->data;
 
                 if (u->name != NULL) {
-                        if (pkt->service ==
-                                YAHOO_SERVICE_LOGOFF
-                                /*|| u->flags == 0 No flags for YMSG16 */ ) {
-                                YAHOO_CALLBACK(ext_yahoo_status_changed) (yd->
-                                        client_id, u->name,
-                                        YAHOO_STATUS_OFFLINE, NULL, 1, 0, 0);
+                        if (pkt->service == YAHOO_SERVICE_LOGOFF) { /* || u->flags == 0) { Not in YMSG16 */
+                                YAHOO_CALLBACK(ext_yahoo_status_changed)(yd->client_id, u->name, YAHOO_STATUS_OFFLINE, NULL, 1, 0, 0);
                         } else {
                                 /* Key 47 always seems to be 1 for YMSG16 */
-                                if (!u->state)
+                                if(!u->state)
                                         u->away = 0;
                                 else
                                         u->away = 1;
 
-                                YAHOO_CALLBACK(ext_yahoo_status_changed) (yd->
-                                        client_id, u->name, u->state, u->msg,
-                                        u->away, u->idle, u->mobile);
+                                YAHOO_CALLBACK(ext_yahoo_status_changed)(yd->client_id, u->name, u->state, u->msg, u->away, u->idle, u->mobile);
                         }
                 }
@@ -1468 +1503 @@
 }
 
-static void yahoo_process_buddy_list(struct yahoo_input_data *yid,
-        struct yahoo_packet *pkt)
+static void yahoo_process_buddy_list(struct yahoo_input_data *yid, struct yahoo_packet *pkt)
 {
         struct yahoo_data *yd = yid->yd;
@@ -1481 +1515 @@
                 struct yahoo_pair *pair = l->data;
 
-                switch (pair->key) {
+                switch(pair->key) {
                 case 300:
                 case 301:
                 case 302:
-                        break;  /* Separators. Our logic does not need them */
                 case 303:
-                        if (318 == atoi(pair->value))
+                        if ( 315 == atoi(pair->value) )
                                 last_packet = 1;
                         break;
                 case 65:
+                        g_free(cur_group);
                         cur_group = strdup(pair->value);
                         break;
@@ -1496 +1530 @@
                         newbud = y_new0(struct yahoo_buddy, 1);
                         newbud->id = strdup(pair->value);
-                        if (cur_group)
+                        if(cur_group)
                                 newbud->group = strdup(cur_group);
-                        else if (yd->buddies) {
-                                struct yahoo_buddy *lastbud =
-                                        (struct yahoo_buddy *)y_list_nth(yd->
-                                        buddies,
-                                        y_list_length(yd->buddies) - 1)->data;
+                        else {
+                                struct yahoo_buddy *lastbud = (struct yahoo_buddy *)y_list_nth(
+                                                                yd->buddies, y_list_length(yd->buddies)-1)->data;
                                 newbud->group = strdup(lastbud->group);
-                        } else
-                                newbud->group = strdup("Buddies");
+                        }
 
                         yd->buddies = y_list_append(yd->buddies, newbud);
@@ -1512 +1543 @@
                 }
         }
+        
+        g_free(cur_group);
 
         /* we could be getting multiple packets here */
-        if (pkt->hash && !last_packet)
-                return;
-
-        YAHOO_CALLBACK(ext_yahoo_got_buddies) (yd->client_id, yd->buddies);
-
-        /* Logged in */
+        if (last_packet)
+                return;
+
+        YAHOO_CALLBACK(ext_yahoo_got_buddies)(yd->client_id, yd->buddies);
+
+        /*** We login at the very end of the packet communication */
         if (!yd->logged_in) {
-                yd->logged_in = 1;
-                if (yd->current_status < 0)
+                yd->logged_in = TRUE;
+                if(yd->current_status < 0)
                         yd->current_status = yd->initial_status;
-                YAHOO_CALLBACK(ext_yahoo_login_response) (yd->client_id,
-                        YAHOO_LOGIN_OK, NULL);
-
-                /*
-                yahoo_set_away(yd->client_id, yd->initial_status, NULL,
-                        (yd->initial_status == YAHOO_STATUS_AVAILABLE) ? 0 : 1);
-
-                yahoo_get_yab(yd->client_id);
-                */
-        }
-
-}
-
-static void yahoo_process_list(struct yahoo_input_data *yid,
-        struct yahoo_packet *pkt)
+                YAHOO_CALLBACK(ext_yahoo_login_response)(yd->client_id, YAHOO_LOGIN_OK, NULL);
+        }
+}
+
+static void yahoo_process_list(struct yahoo_input_data *yid, struct yahoo_packet *pkt)
 {
         struct yahoo_data *yd = yid->yd;
         YList *l;
 
-        /* we could be getting multiple packets here */
+        if (!yd->logged_in) {
+                yd->logged_in = TRUE;
+                if(yd->current_status < 0)
+                        yd->current_status = yd->initial_status;
+                YAHOO_CALLBACK(ext_yahoo_login_response)(yd->client_id, YAHOO_LOGIN_OK, NULL);
+        }
+
         for (l = pkt->hash; l; l = l->next) {
                 struct yahoo_pair *pair = l->data;
 
-                switch (pair->key) {
-                case 89:        /* identities */
+                switch(pair->key) {
+                case 87: /* buddies */
+                        if(!yd->rawbuddylist)
+                                yd->rawbuddylist = strdup(pair->value);
+                        else {
+                                yd->rawbuddylist = y_string_append(yd->rawbuddylist, pair->value);
+                        }
+                        break;
+
+                case 88: /* ignore list */
+                        if(!yd->ignorelist)
+                                yd->ignorelist = strdup("Ignore:");
+                        yd->ignorelist = y_string_append(yd->ignorelist, pair->value);
+                        break;
+
+                case 89: /* identities */
                         {
-                                char **identities =
-                                        y_strsplit(pair->value, ",", -1);
-                                int i;
-                                for (i = 0; identities[i]; i++)
-                                        yd->identities =
-                                                y_list_append(yd->identities,
+                        char **identities = y_strsplit(pair->value, ",", -1);
+                        int i;
+                        for(i=0; identities[i]; i++)
+                                yd->identities = y_list_append(yd->identities, 
                                                 strdup(identities[i]));
-                                y_strfreev(identities);
+                        y_strfreev(identities);
                         }
-                        YAHOO_CALLBACK(ext_yahoo_got_identities) (yd->client_id,
-                                yd->identities);
-                        break;
-                case 59:        /* cookies */
-                        if (pair->value[0] == 'Y') {
+                        YAHOO_CALLBACK(ext_yahoo_got_identities)(yd->client_id, yd->identities);
+                        break;
+                case 59: /* cookies */
+                        if(yd->ignorelist) {
+                                yd->ignore = bud_str2list(yd->ignorelist);
+                                FREE(yd->ignorelist);
+                                YAHOO_CALLBACK(ext_yahoo_got_ignore)(yd->client_id, yd->ignore);
+                        }
+                        if(yd->rawbuddylist) {
+                                yd->buddies = bud_str2list(yd->rawbuddylist);
+                                FREE(yd->rawbuddylist);
+                                YAHOO_CALLBACK(ext_yahoo_got_buddies)(yd->client_id, yd->buddies);
+                        }
+
+                        if(pair->value[0]=='Y') {
                                 FREE(yd->cookie_y);
                                 FREE(yd->login_cookie);
@@ -1570 +1621 @@
                                 yd->login_cookie = getlcookie(yd->cookie_y);
 
-                        } else if (pair->value[0] == 'T') {
+                        } else if(pair->value[0]=='T') {
                                 FREE(yd->cookie_t);
                                 yd->cookie_t = getcookie(pair->value);
 
-                        } else if (pair->value[0] == 'C') {
+                        } else if(pair->value[0]=='C') {
                                 FREE(yd->cookie_c);
                                 yd->cookie_c = getcookie(pair->value);
-                        }
-
-                        break;
-                case 3: /* my id */
-                case 90:        /* 1 */
-                case 100:       /* 0 */
-                case 101:       /* NULL */
-                case 102:       /* NULL */
-                case 93:        /* 86400/1440 */
-                        break;
-                }
-        }
-
-        if (yd->cookie_y && yd->cookie_t)       /* We don't get cookie_c anymore */
-                YAHOO_CALLBACK(ext_yahoo_got_cookies) (yd->client_id);
+                        } 
+
+                        if(yd->cookie_y && yd->cookie_t)
+                                YAHOO_CALLBACK(ext_yahoo_got_cookies)(yd->client_id);
+
+                        break;
+                case 3: /* my id */
+                case 90: /* 1 */
+                case 100: /* 0 */
+                case 101: /* NULL */
+                case 102: /* NULL */
+                case 93: /* 86400/1440 */
+                        break;
+                }
+        }
 }
 
@@ -2342 +2393 @@
 {
         struct yahoo_https_auth_data *had = req->data;
-        struct yahoo_input_data *yid;
-        struct yahoo_data *yd;
+        struct yahoo_input_data *yid = had->yid;
+        struct yahoo_data *yd = yid->yd;
         int st;
-        
-        if (y_list_find(inputs, had->yid) == NULL)
-                return;
-        
-        yid = had->yid;
-        yd = yid->yd;
         
         if (req->status_code != 200) {
@@ -2391 +2436 @@
 {
         struct yahoo_https_auth_data *had = req->data;
-        struct yahoo_input_data *yid;
-        struct yahoo_data *yd;
+        struct yahoo_input_data *yid = had->yid;
+        struct yahoo_data *yd = yid->yd;
         struct yahoo_packet *pack;
-        char *crumb = NULL;
+        char *crumb;
         int st;
-        
-        if (y_list_find(inputs, had->yid) == NULL)
-                return;
-        
-        yid = had->yid;
-        yd = yid->yd;
         
         md5_byte_t result[16];
@@ -4041 +4080 @@
 
         yd = yid->yd;
+
         old_status = yd->current_status;
-        yd->current_status = state;
+
+        if (msg && strncmp(msg,"Invisible",9)) {
+                yd->current_status = YAHOO_STATUS_CUSTOM;
+        } else {
+                yd->current_status = state;
+        }
 
         /* Thank you libpurple :) */
@@ -4057 +4102 @@
         snprintf(s, sizeof(s), "%d", yd->current_status);
         yahoo_packet_hash(pkt, 10, s);
-        yahoo_packet_hash(pkt, 19, msg && state == YAHOO_STATUS_CUSTOM ? msg : "");
+         
+        if (yd->current_status == YAHOO_STATUS_CUSTOM) {
+                yahoo_packet_hash(pkt, 19, msg);
+        } else {
+                yahoo_packet_hash(pkt, 19, "");
+        }
+        
         yahoo_packet_hash(pkt, 47, (away == 2)? "2": (away) ?"1":"0");
+
         yahoo_send_packet(yid, pkt, 0);
         yahoo_packet_free(pkt);

protocols/yahoo/yahoo.c

@@ -130 +130 @@
 {
         set_add( &acc->set, "mail_notifications", "false", set_eval_bool, acc );
-        
-        acc->flags |= ACC_FLAG_AWAY_MESSAGE | ACC_FLAG_STATUS_MESSAGE;
 }
 
@@ -199 +197 @@
 {
         struct byahoo_data *yd = (struct byahoo_data *) ic->proto_data;
-        
-        if( state && msg == NULL )
-        {
-                /* Use these states only if msg doesn't contain additional
-                   info since away messages are only supported with CUSTOM. */
-                if( g_strcasecmp( state, "Be Right Back" ) == 0 )
+        char *away;
+        
+        away = NULL;
+        
+        if( state && msg && g_strcasecmp( state, msg ) != 0 )
+        {
+                yd->current_status = YAHOO_STATUS_CUSTOM;
+                away = "";
+        }
+        else if( state )
+        {
+                /* Set msg to NULL since (if it isn't NULL already) it's equal
+                   to state. msg must be empty if we want to use an existing
+                   away state. */
+                msg = NULL;
+                
+                away = "";
+                if( g_strcasecmp( state, "Available" ) == 0 )
+                {
+                        yd->current_status = YAHOO_STATUS_AVAILABLE;
+                        away = NULL;
+                }
+                else if( g_strcasecmp( state, "Be Right Back" ) == 0 )
                         yd->current_status = YAHOO_STATUS_BRB;
                 else if( g_strcasecmp( state, "Busy" ) == 0 )
@@ -224 +239 @@
                 else if( g_strcasecmp( state, "Invisible" ) == 0 )
                         yd->current_status = YAHOO_STATUS_INVISIBLE;
-                else
-                        yd->current_status = YAHOO_STATUS_CUSTOM;
-        }
-        else if( msg )
-                yd->current_status = YAHOO_STATUS_CUSTOM;
+                else if( g_strcasecmp( state, GAIM_AWAY_CUSTOM ) == 0 )
+                {
+                        yd->current_status = YAHOO_STATUS_AVAILABLE;
+                        
+                        away = NULL;
+                }
+        }
         else
                 yd->current_status = YAHOO_STATUS_AVAILABLE;
         
-        yahoo_set_away( yd->y2_id, yd->current_status, msg, state ? 2 : 0 );
+        yahoo_set_away( yd->y2_id, yd->current_status, msg, away != NULL ? 2 : 0 );
 }
 
@@ -241 +258 @@
         if( m == NULL )
         {
+                m = g_list_append( m, "Available" );
                 m = g_list_append( m, "Be Right Back" );
                 m = g_list_append( m, "Busy" );
@@ -251 +269 @@
                 m = g_list_append( m, "Stepped Out" );
                 m = g_list_append( m, "Invisible" );
+                m = g_list_append( m, GAIM_AWAY_CUSTOM );
         }
         

protocols/yahoo/yahoo2_types.h

@@ -196 +196 @@
 
         void  *server_settings;
-        
-        struct yahoo_process_status_entry *half_user;
 };
 
@@ -263 +261 @@
 };
 
-struct yahoo_process_status_entry {
-        char *name;     /* 7      name */
-        int state;      /* 10     state */
-        int flags;      /* 13     flags, bit 0 = pager, bit 1 = chat, bit 2 = game */
-        int mobile;     /* 60     mobile */
-        char *msg;      /* 19     custom status message */
-        int away;       /* 47     away (or invisible) */
-        int buddy_session; /* 11  state */
-        int f17;        /* 17     in chat? then what about flags? */
-        int idle;       /* 137    seconds idle */
-        int f138;       /* 138    state */
-        char *f184;     /* 184    state */
-        int f192;       /* 192    state */
-        int f10001;     /* 10001  state */
-        int f10002;     /* 10002  state */
-        int f198;       /* 198    state */
-        char *f197;     /* 197    state */
-        char *f205;     /* 205    state */
-        int f213;       /* 213    state */
-};
-
 #ifdef __cplusplus
 }

root_commands.c

@@ -2 +2 @@
   * BitlBee -- An IRC to other IM-networks gateway                     *
   *                                                                    *
-  * Copyright 2002-2010 Wilmer van der Gaast and others                *
+  * Copyright 2002-2004 Wilmer van der Gaast and others                *
   \********************************************************************/
 
@@ -143 +143 @@
         storage_status_t status = storage_load( irc, cmd[1] );
         char *account_on[] = { "account", "on", NULL };
-        
-        if( strchr( irc->umode, 'R' ) != NULL )
-        {
-                irc_usermsg( irc, "You're already logged in." );
-                return;
-        }
         
         switch (status) {
@@ -654 +648 @@
                 irc_usermsg( irc, "Nick `%s' can't be changed", cmd[1] );
         }
-        else if( g_strcasecmp( cmd[1], irc->channel ) == 0 )
-        {
-                if( strchr( CTYPES, cmd[2][0] ) && nick_ok( cmd[2] + 1 ) )
-                {
-                        u = user_find( irc, irc->nick );
-                        
-                        irc_part( irc, u, irc->channel );
-                        g_free( irc->channel );
-                        irc->channel = g_strdup( cmd[2] );
-                        irc_join( irc, u, irc->channel );
-                        
-                        if( strcmp( cmd[0], "set_rename" ) != 0 )
-                                set_setstr( &irc->set, "control_channel", cmd[2] );
-                }
-        }
         else if( user_find( irc, cmd[2] ) && ( nick_cmp( cmd[1], cmd[2] ) != 0 ) )
         {
@@ -716 +695 @@
         
         return strcmp( irc->mynick, new_nick ) == 0 ? new_nick : SET_INVALID;
-}
-
-char *set_eval_control_channel( set_t *set, char *new_name )
-{
-        irc_t *irc = set->data;
-        
-        if( strcmp( irc->channel, new_name ) != 0 )
-        {
-                char *cmd[] = { "set_rename", irc->channel, new_name, NULL };
-                
-                cmd_rename( irc, cmd );
-        }
-        
-        return strcmp( irc->channel, new_name ) == 0 ? new_name : SET_INVALID;
 }
 
@@ -943 +908 @@
                 online = 1;
         else
-                online = away = 1;
+                online =  away = 1;
         
         if( strchr( irc->umode, 'b' ) != NULL )
@@ -956 +921 @@
                 if( online == 1 )
                 {
-                        char st[256] = "Online";
-                        
-                        if( u->status_msg )
-                                g_snprintf( st, sizeof( st ) - 1, "Online (%s)", u->status_msg );
-                        
                         g_snprintf( s, sizeof( s ) - 1, "%s@%s %s(%s)", u->user, u->host, u->ic->acc->prpl->name, u->ic->acc->user );
-                        irc_usermsg( irc, format, u->nick, s, st );
+                        irc_usermsg( irc, format, u->nick, s, "Online" );
                 }
                 
@@ -1155 +1115 @@
                 irc_usermsg( irc, "Unknown command: %s %s. Please use \x02help commands\x02 to get a list of available commands.", "chat", cmd[1] );
         }
+
+
+
+#if 0
+        account_t *a;
+        struct im_connection *ic;
+        char *chat, *channel, *nick = NULL, *password = NULL;
+        struct groupchat *c;
+        
+        if( !( a = account_get( irc, cmd[1] ) ) )
+        {
+                irc_usermsg( irc, "Invalid account" );
+                return;
+        }
+        else if( !( a->ic && ( a->ic->flags & OPT_LOGGED_IN ) ) )
+        {
+                irc_usermsg( irc, "That account is not on-line" );
+                return;
+        }
+        else if( a->prpl->chat_join == NULL )
+        {
+                irc_usermsg( irc, "Command `%s' not supported by this protocol", cmd[0] );
+                return;
+        }
+        ic = a->ic;
+        
+        chat = cmd[2];
+        if( cmd[3] )
+        {
+                if( strchr( CTYPES, cmd[3][0] ) == NULL )
+                        channel = g_strdup_printf( "&%s", cmd[3] );
+                else
+                        channel = g_strdup( cmd[3] );
+        }
+        else
+        {
+                char *s;
+                
+                channel = g_strdup_printf( "&%s", chat );
+                if( ( s = strchr( channel, '@' ) ) )
+                        *s = 0;
+        }
+        if( cmd[3] && cmd[4] )
+                nick = cmd[4];
+        else
+                nick = irc->nick;
+        if( cmd[3] && cmd[4] && cmd[5] )
+                password = cmd[5];
+        
+        if( !nick_ok( channel + 1 ) )
+        {
+                irc_usermsg( irc, "Invalid channel name: %s", channel );
+                g_free( channel );
+                return;
+        }
+        else if( g_strcasecmp( channel, irc->channel ) == 0 || irc_chat_by_channel( irc, channel ) )
+        {
+                irc_usermsg( irc, "Channel already exists: %s", channel );
+                g_free( channel );
+                return;
+        }
+        
+        if( ( c = a->prpl->chat_join( ic, chat, nick, password ) ) )
+        {
+                g_free( c->channel );
+                c->channel = channel;
+        }
+        else
+        {
+                irc_usermsg( irc, "Tried to join chat, not sure if this was successful" );
+                g_free( channel );
+        }
+#endif
 }
 

tests/check_jabber_util.c

@@ -14 +14 @@
         
         budw1 = jabber_buddy_add( ic, "wilmer@gaast.net/BitlBee" );
-        budw1->last_msg = time( NULL ) - 100;
+        budw1->last_act = time( NULL ) - 100;
         budw2 = jabber_buddy_add( ic, "WILMER@gaast.net/Telepathy" );
         budw2->priority = 2;
-        budw2->last_msg = time( NULL );
+        budw2->last_act = time( NULL );
         budw3 = jabber_buddy_add( ic, "wilmer@GAAST.NET/bitlbee" );
-        budw3->last_msg = time( NULL ) - 200;
+        budw3->last_act = time( NULL ) - 200;
         budw3->priority = 4;
         /* TODO(wilmer): Shouldn't this just return budw3? */
@@ -60 +60 @@
         fail_unless( jabber_buddy_remove( ic, "wilmer@gaast.net/Telepathy" ) );
         fail_unless( jabber_buddy_remove( ic, "wilmer@gaast.net/telepathy" ) );
-        
-        /* Test activity_timeout and GET_BUDDY_BARE_OK. */
-        fail_unless( jabber_buddy_by_jid( ic, "wilmer@gaast.net", GET_BUDDY_BARE_OK ) == budw1 );
-        budw1->last_msg -= 50;
-        fail_unless( ( bud = jabber_buddy_by_jid( ic, "wilmer@gaast.net", GET_BUDDY_BARE_OK ) ) != NULL );
-        fail_unless( strcmp( bud->full_jid, "wilmer@gaast.net" ) == 0 );
+        fail_unless( jabber_buddy_by_jid( ic, "wilmer@gaast.net", 0 ) == budw1 );
         
         fail_if( jabber_buddy_remove( ic, "wilmer@gaast.net" ) );
         fail_unless( jabber_buddy_by_jid( ic, "wilmer@gaast.net", 0 ) == budw1 );
         
-        fail_if( jabber_buddy_remove( ic, "wilmer@gaast.net" ) );
-        fail_unless( jabber_buddy_remove( ic, "wilmer@gaast.net/bitlbee" ) );
-        fail_unless( jabber_buddy_remove( ic, "wilmer@gaast.net/BitlBee" ) );
-        fail_if( jabber_buddy_by_jid( ic, "wilmer@gaast.net", GET_BUDDY_BARE_OK ) );
-        
         /* Check if remove_bare() indeed gets rid of all. */
-        /* disable this one for now.
         fail_unless( jabber_buddy_remove_bare( ic, "wilmer@gaast.net" ) );
         fail_if( jabber_buddy_by_jid( ic, "wilmer@gaast.net", 0 ) );
-        */
 
         fail_if( jabber_buddy_remove( ic, "nekkid@lamejab.net/Illegal" ) );
         fail_unless( jabber_buddy_remove( ic, "nekkid@lamejab.net" ) );
         fail_if( jabber_buddy_by_jid( ic, "nekkid@lamejab.net", 0 ) );
-        
-        /* Fixing a bug in this branch that caused information to get lost when
-           removing the first full JID from a list. */
-        jabber_buddy_add( ic, "bugtest@google.com/A" );
-        jabber_buddy_add( ic, "bugtest@google.com/B" );
-        jabber_buddy_add( ic, "bugtest@google.com/C" );
-        fail_unless( jabber_buddy_remove( ic, "bugtest@google.com/A" ) );
-        fail_unless( jabber_buddy_remove( ic, "bugtest@google.com/B" ) );
-        fail_unless( jabber_buddy_remove( ic, "bugtest@google.com/C" ) );
 }
 
@@ -106 +85 @@
         jd->buddies = g_hash_table_new( g_str_hash, g_str_equal );
         set_add( &ic->acc->set, "resource_select", "priority", NULL, ic->acc );
-        set_add( &ic->acc->set, "activity_timeout", "120", NULL, ic->acc );
         
         suite_add_tcase (s, tc_core);

unix.c

@@ -25 +25 @@
 
 #include "bitlbee.h"
-
-#include "arc.h"
-#include "base64.h"
 #include "commands.h"
+#include "crypting.h"
 #include "protocols/nogaim.h"
 #include "help.h"
 #include "ipc.h"
-#include "md5.h"
-#include "misc.h"
 #include <signal.h>
 #include <unistd.h>
@@ -44 +40 @@
 static void sighandler( int signal );
 
-static int crypt_main( int argc, char *argv[] );
-
 int main( int argc, char *argv[] )
 {
@@ -51 +45 @@
         char *old_cwd = NULL;
         struct sigaction sig, old;
-        
-        if( argc > 1 && strcmp( argv[1], "-x" ) == 0 )
-                return crypt_main( argc, argv );
         
         log_init();
@@ -168 +159 @@
 }
 
-static int crypt_main( int argc, char *argv[] )
-{
-        int pass_len;
-        unsigned char *pass_cr, *pass_cl;
-        
-        if( argc < 4 || ( strcmp( argv[2], "hash" ) != 0 &&
-                          strcmp( argv[2], "unhash" ) != 0 && argc < 5 ) )
-        {
-                printf( "Supported:\n"
-                        "  %s -x enc <key> <cleartext password>\n"
-                        "  %s -x dec <key> <encrypted password>\n"
-                        "  %s -x hash <cleartext password>\n"
-                        "  %s -x unhash <hashed password>\n"
-                        "  %s -x chkhash <hashed password> <cleartext password>\n",
-                        argv[0], argv[0], argv[0], argv[0], argv[0] );
-        }
-        else if( strcmp( argv[2], "enc" ) == 0 )
-        {
-                pass_len = arc_encode( argv[4], strlen( argv[4] ), (unsigned char**) &pass_cr, argv[3], 12 );
-                printf( "%s\n", base64_encode( pass_cr, pass_len ) );
-        }
-        else if( strcmp( argv[2], "dec" ) == 0 )
-        {
-                pass_len = base64_decode( argv[4], (unsigned char**) &pass_cr );
-                arc_decode( pass_cr, pass_len, (char**) &pass_cl, argv[3] );
-                printf( "%s\n", pass_cl );
-        }
-        else if( strcmp( argv[2], "hash" ) == 0 )
-        {
-                md5_byte_t pass_md5[21];
-                md5_state_t md5_state;
-                
-                random_bytes( pass_md5 + 16, 5 );
-                md5_init( &md5_state );
-                md5_append( &md5_state, (md5_byte_t*) argv[3], strlen( argv[3] ) );
-                md5_append( &md5_state, pass_md5 + 16, 5 ); /* Add the salt. */
-                md5_finish( &md5_state, pass_md5 );
-                
-                printf( "%s\n", base64_encode( pass_md5, 21 ) );
-        }
-        else if( strcmp( argv[2], "unhash" ) == 0 )
-        {
-                printf( "Hash %s submitted to a massive Beowulf cluster of\n"
-                        "overclocked 486s. Expect your answer next year somewhere around this time. :-)\n", argv[3] );
-        }
-        else if( strcmp( argv[2], "chkhash" ) == 0 )
-        {
-                char *hash = strncmp( argv[3], "md5:", 4 ) == 0 ? argv[3] + 4 : argv[3];
-                int st = md5_verify_password( argv[4], hash );
-                
-                printf( "Hash %s given password.\n", st == 0 ? "matches" : "does not match" );
-                
-                return st;
-        }
-        
-        return 0;
-}
-
 static void sighandler( int signal )
 {
@@ -281 +214 @@
         return( (double) time->tv_sec + (double) time->tv_usec / 1000000 );
 }
+
+

user.h

@@ -34 +34 @@
         
         char *away;
-        char *status_msg; /* Non-IRC extension, but nice on IM. */
         
         char is_private;