Changeset 0b3ffb1

Timestamp:

2010-05-19T19:46:43Z (14 years ago)

Author:

Wilmer van der Gaast <wilmer@…>

Branches:

master

Children:

907afe1

Parents:

2334048

Message:

Setting the HTML flag on a connection has a nasty side effect of escaping
a lot of "special" characters, and these HTML entities are not counted as
one character. :-(

So just strip HTML of incoming stuff and don't do anything with what goes
out. It's not required.

The story may actually be more complicated this, let's find out.

Files:

• lib/misc.c (modified) (2 diffs)
• protocols/twitter/twitter.c (modified) (1 diff)
• protocols/twitter/twitter_lib.c (modified) (2 diffs)

lib/misc.c

@@ -154 +154 @@
 {
         char *start = in;
-        char *out = g_malloc( strlen( in ) + 1 );
+        char out[strlen(in)+1];
         char *s = out, *cs;
         int i, matched;
         
-        memset( out, 0, strlen( in ) + 1 );
+        memset( out, 0, sizeof( out ) );
         
         while( *in )
@@ -220 +220 @@
         
         strcpy( start, out );
-        g_free( out );
 }
 

protocols/twitter/twitter.c

@@ -180 +180 @@
         twitter_connections = g_slist_append( twitter_connections, ic );
         ic->proto_data = td;
-        ic->flags |= OPT_DOES_HTML;
         
         td->user = acc->user;

protocols/twitter/twitter_lib.c

@@ -434 +434 @@
                 twitter_add_buddy(ic, status->user->screen_name, status->user->name);
                 
+                strip_html(status->text);
+                
                 // Say it!
                 if (g_strcasecmp(td->user, status->user->screen_name) == 0)
@@ -471 +473 @@
                 status = l->data;
                 
+                strip_html( status->text );
                 if( mode_one )
                         text = g_strdup_printf( "\002<\002%s\002>\002 %s",