Changeset 05816dd for protocols/yahoo

Timestamp:

2015-02-22T22:44:40Z (9 years ago)

Author:

dequis <dx@…>

Branches:

master

Children:

570f183

Parents:

91f06e5

git-author:

dequis <dx@…> (22-02-15 22:04:08)

git-committer:

dequis <dx@…> (22-02-15 22:44:40)

Message:

coverity: Fix some (harmless?) use-after-free with g_slist_remove()

These were passing a pointer to a variable right after it was g_free()'d

They are most likely harmless as g_slist_remove() probably just needs
the pointer location, but fixing it anyway.

File:

• protocols/yahoo/yahoo.c (modified) (1 diff)

protocols/yahoo/yahoo.c

@@ -733 +733 @@
                 inp = l->data;
                 if (inp->h == tag) {
+                        byahoo_inputs = g_slist_remove(byahoo_inputs, inp);
                         g_free(inp->d);
                         g_free(inp);
-                        byahoo_inputs = g_slist_remove(byahoo_inputs, inp);
                         break;
                 }