Changeset 027d2eb

Timestamp:

2005-12-02T11:43:47Z (19 years ago)

Author:

Wilmer van der Gaast <wilmer@…>

Branches:

master

Children:

f1df064

Parents:

626b446

Message:

Modified CHANGES, and extended the allowed port range a bit.

Files:

• doc/CHANGES (modified) (1 diff)
• protocols/jabber/jabber.c (modified) (2 diffs)

doc/CHANGES

@@ -19 +19 @@
   better consistency. Don't forget to update your scripts!
 - AIM typing notifications are supported now.
+- Jabber module only accepts ports 5220-5229 now, to prevent people from
+  abusing it as a port scanner. We aren't aware of any Jabber server that
+  runs on other ports than those. If you are, please warn us.
 
 Finished ...

protocols/jabber/jabber.c

@@ -55 +55 @@
 #define DEFAULT_PORT 5222
 #define DEFAULT_PORT_SSL 5223
+#define JABBER_PORT_MIN 5220
+#define JABBER_PORT_MAX 5229
 
 #define JABBER_GROUP "Friends"
@@ -590 +592 @@
         else if (port == -1 && ssl)
                 port = DEFAULT_PORT_SSL;
-        else if (port != 5222 && port != 5223) {
-                serv_got_crap(GJ_GC(gjc), "Only port numbers 5222 and 5223 are allowed for Jabber connections.");
+        else if (port < JABBER_PORT_MIN || port > JABBER_PORT_MAX) {
+                serv_got_crap(GJ_GC(gjc), "For security reasons, the Jabber port number must be in the %d-%d range.", JABBER_PORT_MIN, JABBER_PORT_MAX);
                 STATE_EVT(JCONN_STATE_OFF)
                 return;