source: tests/check_jabber_util.c @ ed1f5e8d

Last change on this file since ed1f5e8d was 2dc394c, checked in by dequis <dx@…>, at 2016-08-24T00:02:20Z

jabber: handle nulls in jabber_compare_jid

As far as I can see this isn't remotely exploitable (and if it were it
would be just DoS of the child process), but i'm still looking into it
  • Property mode set to 100644
File size: 6.1 KB
Line 
1#include <stdlib.h>
2#include <glib.h>
3#include <gmodule.h>
4#include <check.h>
5#include <string.h>
6#include <stdio.h>
7#include "jabber/jabber.h"
8
9static struct im_connection *ic;
10
11static void check_buddy_add(int l)
12{
13        struct jabber_buddy *budw1, *budw2, *budw3, *budn, *bud;
14
15        budw1 = jabber_buddy_add(ic, "wilmer@gaast.net/BitlBee");
16        budw1->last_msg = time(NULL) - 100;
17        budw2 = jabber_buddy_add(ic, "WILMER@gaast.net/Telepathy");
18        budw2->priority = 2;
19        budw2->last_msg = time(NULL);
20        budw3 = jabber_buddy_add(ic, "wilmer@GAAST.NET/bitlbee");
21        budw3->last_msg = time(NULL) - 200;
22        budw3->priority = 4;
23        /* TODO(wilmer): Shouldn't this just return budw3? */
24        fail_if(jabber_buddy_add(ic, "wilmer@gaast.net/Telepathy") != NULL);
25
26        budn = jabber_buddy_add(ic, "nekkid@lamejab.net");
27        /* Shouldn't be allowed if there's already a bare JID. */
28        fail_if(jabber_buddy_add(ic, "nekkid@lamejab.net/Illegal"));
29
30        /* Case sensitivity: Case only matters after the / */
31        fail_if(jabber_buddy_by_jid(ic, "wilmer@gaast.net/BitlBee", 0) ==
32                jabber_buddy_by_jid(ic, "wilmer@gaast.net/bitlbee", 0));
33        fail_if(jabber_buddy_by_jid(ic, "wilmer@gaast.net/telepathy", 0));
34
35        fail_unless(jabber_buddy_by_jid(ic, "wilmer@gaast.net/BitlBee", 0) == budw1);
36        fail_unless(jabber_buddy_by_jid(ic, "WILMER@GAAST.NET/BitlBee", GET_BUDDY_EXACT) == budw1);
37        fail_unless(jabber_buddy_by_jid(ic, "wilmer@GAAST.NET/BitlBee", GET_BUDDY_CREAT) == budw1);
38
39        fail_unless(jabber_buddy_by_jid(ic, "wilmer@gaast.net", GET_BUDDY_EXACT));
40        fail_unless(jabber_buddy_by_jid(ic, "WILMER@gaast.net", 0) == budw3);
41
42        /* Check O_FIRST and see if it's indeed the first item from the list. */
43        fail_unless((bud = jabber_buddy_by_jid(ic, "wilmer@gaast.net", GET_BUDDY_FIRST)) == budw1);
44        fail_unless(bud->next == budw2 && bud->next->next == budw3 && bud->next->next->next == NULL);
45
46        /* Change the resource_select setting, now we should get a different resource. */
47        set_setstr(&ic->acc->set, "resource_select", "activity");
48        fail_unless(jabber_buddy_by_jid(ic, "wilmer@GAAST.NET", 0) == budw2);
49
50        /* Some testing of bare JID handling (which is horrible). */
51        fail_if(jabber_buddy_by_jid(ic, "nekkid@lamejab.net/Illegal", 0));
52        fail_if(jabber_buddy_by_jid(ic, "NEKKID@LAMEJAB.NET/Illegal", GET_BUDDY_CREAT));
53        fail_unless(jabber_buddy_by_jid(ic, "nekkid@lamejab.net", 0) == budn);
54        fail_unless(jabber_buddy_by_jid(ic, "NEKKID@lamejab.net", GET_BUDDY_EXACT) == budn);
55        fail_unless(jabber_buddy_by_jid(ic, "nekkid@LAMEJAB.NET", GET_BUDDY_CREAT) == budn);
56
57        /* More case sensitivity testing, and see if remove works properly. */
58        fail_if(jabber_buddy_remove(ic, "wilmer@gaast.net/telepathy"));
59        fail_if(jabber_buddy_by_jid(ic, "wilmer@GAAST.NET/telepathy", GET_BUDDY_CREAT) == budw2);
60        fail_unless(jabber_buddy_remove(ic, "wilmer@gaast.net/Telepathy"));
61        fail_unless(jabber_buddy_remove(ic, "wilmer@gaast.net/telepathy"));
62
63        /* Test activity_timeout and GET_BUDDY_BARE_OK. */
64        fail_unless(jabber_buddy_by_jid(ic, "wilmer@gaast.net", GET_BUDDY_BARE_OK) == budw1);
65        budw1->last_msg -= 50;
66        fail_unless((bud = jabber_buddy_by_jid(ic, "wilmer@gaast.net", GET_BUDDY_BARE_OK)) != NULL);
67        fail_unless(strcmp(bud->full_jid, "wilmer@gaast.net") == 0);
68
69        fail_if(jabber_buddy_remove(ic, "wilmer@gaast.net"));
70        fail_unless(jabber_buddy_by_jid(ic, "wilmer@gaast.net", 0) == budw1);
71
72        fail_if(jabber_buddy_remove(ic, "wilmer@gaast.net"));
73        fail_unless(jabber_buddy_remove(ic, "wilmer@gaast.net/bitlbee"));
74        fail_unless(jabber_buddy_remove(ic, "wilmer@gaast.net/BitlBee"));
75        fail_if(jabber_buddy_by_jid(ic, "wilmer@gaast.net", GET_BUDDY_BARE_OK));
76
77        /* Check if remove_bare() indeed gets rid of all. */
78        /* disable this one for now.
79        fail_unless( jabber_buddy_remove_bare( ic, "wilmer@gaast.net" ) );
80        fail_if( jabber_buddy_by_jid( ic, "wilmer@gaast.net", 0 ) );
81        */
82
83        fail_if(jabber_buddy_remove(ic, "nekkid@lamejab.net/Illegal"));
84        fail_unless(jabber_buddy_remove(ic, "nekkid@lamejab.net"));
85        fail_if(jabber_buddy_by_jid(ic, "nekkid@lamejab.net", 0));
86
87        /* Fixing a bug in this branch that caused information to get lost when
88           removing the first full JID from a list. */
89        jabber_buddy_add(ic, "bugtest@google.com/A");
90        jabber_buddy_add(ic, "bugtest@google.com/B");
91        jabber_buddy_add(ic, "bugtest@google.com/C");
92        fail_unless(jabber_buddy_remove(ic, "bugtest@google.com/A"));
93        fail_unless(jabber_buddy_remove(ic, "bugtest@google.com/B"));
94        fail_unless(jabber_buddy_remove(ic, "bugtest@google.com/C"));
95}
96
97static void check_compareJID(int l)
98{
99        fail_unless(jabber_compare_jid("bugtest@google.com/B", "bugtest@google.com/A"));
100        fail_if(jabber_compare_jid("bugtest1@google.com/B", "bugtest@google.com/A"));
101        fail_if(jabber_compare_jid("bugtest@google.com/B", "bugtest1@google.com/A"));
102        fail_if(jabber_compare_jid("bugtest1@google.com/B", "bugtest2@google.com/A"));
103        fail_unless(jabber_compare_jid("bugtest@google.com/A", "bugtest@google.com/A"));
104        fail_if(jabber_compare_jid("", "bugtest@google.com/A"));
105        fail_if(jabber_compare_jid(NULL, ""));
106        fail_if(jabber_compare_jid("", NULL));
107}
108
109static void check_hipchat_slug(int l)
110{
111        int i;
112
113        const char *tests[] = {
114                "test !\"#$%&\'()*+,-./0123456789:;<=>?@ABC", "test_!#$%\()*+,-.0123456789;=?abc",
115                "test XYZ[\\]^_`abc", "test_xyz[\\]^_`abc",
116                "test {|}~¡¢£¤¥¦§¨©ª«¬\xad®¯°±²³´µ¶·¸¹º»¼½¾¿ÀÁÂÃÄÅÆ", "test_{|}~¡¢£¤¥¦§¨©ª«¬\xad®¯°±²³´µ¶·¸¹º»¼½¾¿àáâãäåæ",
117                "test IJ ij I ı I ı", "test_ij_ij_i_ı_i_ı",
118                NULL,
119        };
120
121        for (i = 0; tests[i]; i += 2) {
122                char *new = hipchat_make_channel_slug(tests[i]);
123                fail_unless(!strcmp(tests[i + 1], new));
124                g_free(new);
125        }
126}
127
128Suite *jabber_util_suite(void)
129{
130        Suite *s = suite_create("jabber/util");
131        TCase *tc_core = tcase_create("Buddy");
132        struct jabber_data *jd;
133
134        ic = g_new0(struct im_connection, 1);
135        ic->acc = g_new0(account_t, 1);
136        ic->proto_data = jd = g_new0(struct jabber_data, 1);
137        jd->buddies = g_hash_table_new(g_str_hash, g_str_equal);
138        set_add(&ic->acc->set, "resource_select", "priority", NULL, ic->acc);
139        set_add(&ic->acc->set, "activity_timeout", "120", NULL, ic->acc);
140
141        suite_add_tcase(s, tc_core);
142        tcase_add_test(tc_core, check_buddy_add);
143        tcase_add_test(tc_core, check_compareJID);
144        tcase_add_test(tc_core, check_hipchat_slug);
145        return s;
146}
Note: See TracBrowser for help on using the repository browser.