Context Navigation

conference.c @ 4466e3e

Last change on this file since 4466e3e was 9698fc0, checked in by dequis <dx@…>, at 2016-10-12T08:12:41Z

jabber: Don't pass a readonly empty string to imcb_chat_topic()

Fixes crashes when a topic is unset and strip_html is set to always.
Turns out that the strip_html() function does a strcpy at the end which
may write a single null byte over the null byte of the empty string, and
if it's not in writable memory, that blows up.

Thanks to iamthemcmaster / mcm for pointing this out

Property mode set to 100644

File size: 14.6 KB

Line
1	/***************************************************************************\
2	* *
3	* BitlBee - An IRC to IM gateway *
4	* Jabber module - Conference rooms *
5	* *
6	* Copyright 2007-2012 Wilmer van der Gaast <wilmer@gaast.net> *
7	* *
8	* This program is free software; you can redistribute it and/or modify *
9	* it under the terms of the GNU General Public License as published by *
10	* the Free Software Foundation; either version 2 of the License, or *
11	* (at your option) any later version. *
12	* *
13	* This program is distributed in the hope that it will be useful, *
14	* but WITHOUT ANY WARRANTY; without even the implied warranty of *
15	* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the *
16	* GNU General Public License for more details. *
17	* *
18	* You should have received a copy of the GNU General Public License along *
19	* with this program; if not, write to the Free Software Foundation, Inc., *
20	* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. *
21	* *
22	\***************************************************************************/
23
24	#include "jabber.h"
25	#include "sha1.h"
26
27	static xt_status jabber_chat_join_failed(struct im_connection ic, struct xt_node node, struct xt_node *orig);
28	static xt_status jabber_chat_self_message(struct im_connection ic, struct xt_node node, struct xt_node *orig);
29
30	struct groupchat jabber_chat_join(struct im_connection ic, const char room, const char nick, const char *password,
31	gboolean always_use_nicks)
32	{
33	struct jabber_chat *jc;
34	struct xt_node *node;
35	struct groupchat *c;
36	char *roomjid;
37
38	roomjid = g_strdup_printf("%s/%s", room, nick);
39	node = xt_new_node("x", NULL, NULL);
40	xt_add_attr(node, "xmlns", XMLNS_MUC);
41	if (password) {
42	xt_add_child(node, xt_new_node("password", password, NULL));
43	}
44	node = jabber_make_packet("presence", NULL, roomjid, node);
45	jabber_cache_add(ic, node, jabber_chat_join_failed);
46
47	if (!jabber_write_packet(ic, node)) {
48	g_free(roomjid);
49	return NULL;
50	}
51
52	jc = g_new0(struct jabber_chat, 1);
53	jc->name = jabber_normalize(room);
54
55	if ((jc->me = jabber_buddy_add(ic, roomjid)) == NULL) {
56	g_free(roomjid);
57	g_free(jc->name);
58	g_free(jc);
59	return NULL;
60	}
61
62	if (always_use_nicks) {
63	jc->flags = JCFLAG_ALWAYS_USE_NICKS;
64	}
65
66	/* roomjid isn't normalized yet, and we need an original version
67	of the nick to send a proper presence update. */
68	jc->my_full_jid = roomjid;
69
70	c = imcb_chat_new(ic, room);
71	c->data = jc;
72
73	return c;
74	}
75
76	struct groupchat jabber_chat_with(struct im_connection ic, char *who)
77	{
78	struct jabber_data *jd = ic->proto_data;
79	struct jabber_chat *jc;
80	struct groupchat *c;
81	sha1_state_t sum;
82	double now = gettime();
83	char uuid, rjid, *cserv;
84
85	sha1_init(&sum);
86	sha1_append(&sum, (uint8_t *) ic->acc->user, strlen(ic->acc->user));
87	sha1_append(&sum, (uint8_t *) &now, sizeof(now));
88	sha1_append(&sum, (uint8_t *) who, strlen(who));
89	uuid = sha1_random_uuid(&sum);
90
91	if (jd->flags & JFLAG_GTALK) {
92	cserv = g_strdup("groupchat.google.com");
93	} else {
94	/* Guess... */
95	cserv = g_strdup_printf("conference.%s", jd->server);
96	}
97
98	rjid = g_strdup_printf("private-chat-%s@%s", uuid, cserv);
99	g_free(uuid);
100	g_free(cserv);
101
102	c = jabber_chat_join(ic, rjid, jd->username, NULL, FALSE);
103	g_free(rjid);
104	if (c == NULL) {
105	return NULL;
106	}
107
108	jc = c->data;
109	jc->invite = g_strdup(who);
110
111	return c;
112	}
113
114	static xt_status jabber_chat_join_failed(struct im_connection ic, struct xt_node node, struct xt_node *orig)
115	{
116	struct jabber_error *err;
117	struct jabber_buddy *bud;
118	char *room;
119
120	room = xt_find_attr(orig, "to");
121	bud = jabber_buddy_by_jid(ic, room, 0);
122	err = jabber_error_parse(xt_find_node(node->children, "error"), XMLNS_STANZA_ERROR);
123	if (err) {
124	imcb_error(ic, "Error joining groupchat %s: %s%s%s", room, err->code,
125	err->text ? ": " : "", err->text ? err->text : "");
126	jabber_error_free(err);
127	}
128	if (bud) {
129	struct groupchat *c = jabber_chat_by_jid(ic, bud->bare_jid);
130	if (c) {
131	jabber_chat_free(c);
132	}
133	}
134
135	return XT_HANDLED;
136	}
137
138	static xt_status jabber_chat_self_message(struct im_connection ic, struct xt_node node, struct xt_node *orig)
139	{
140	/* This is a self message sent by this bitlbee - just drop it */
141	return XT_ABORT;
142	}
143
144	struct groupchat jabber_chat_by_jid(struct im_connection ic, const char *name)
145	{
146	char *normalized = jabber_normalize(name);
147	GSList *l;
148	struct groupchat *ret;
149	struct jabber_chat *jc;
150
151	for (l = ic->groupchats; l; l = l->next) {
152	ret = l->data;
153	jc = ret->data;
154	if (strcmp(normalized, jc->name) == 0) {
155	break;
156	}
157	}
158	g_free(normalized);
159
160	return l ? ret : NULL;
161	}
162
163	void jabber_chat_free(struct groupchat *c)
164	{
165	struct jabber_chat *jc = c->data;
166
167	jabber_buddy_remove_bare(c->ic, jc->name);
168
169	g_free(jc->my_full_jid);
170	g_free(jc->name);
171	g_free(jc->invite);
172	g_free(jc);
173
174	imcb_chat_free(c);
175	}
176
177	int jabber_chat_msg(struct groupchat c, char message, int flags)
178	{
179	struct im_connection *ic = c->ic;
180	struct jabber_chat *jc = c->data;
181	struct xt_node *node;
182
183	jc->flags \|= JCFLAG_MESSAGE_SENT;
184
185	node = xt_new_node("body", message, NULL);
186	node = jabber_make_packet("message", "groupchat", jc->name, node);
187
188	jabber_cache_add(ic, node, jabber_chat_self_message);
189
190	return !jabber_write_packet(ic, node);
191	}
192
193	int jabber_chat_topic(struct groupchat c, char topic)
194	{
195	struct im_connection *ic = c->ic;
196	struct jabber_chat *jc = c->data;
197	struct xt_node *node;
198
199	node = xt_new_node("subject", topic, NULL);
200	node = jabber_make_packet("message", "groupchat", jc->name, node);
201
202	if (!jabber_write_packet(ic, node)) {
203	xt_free_node(node);
204	return 0;
205	}
206	xt_free_node(node);
207
208	return 1;
209	}
210
211	int jabber_chat_leave(struct groupchat c, const char reason)
212	{
213	struct im_connection *ic = c->ic;
214	struct jabber_chat *jc = c->data;
215	struct xt_node *node;
216
217	node = xt_new_node("x", NULL, NULL);
218	xt_add_attr(node, "xmlns", XMLNS_MUC);
219	node = jabber_make_packet("presence", "unavailable", jc->my_full_jid, node);
220
221	if (!jabber_write_packet(ic, node)) {
222	xt_free_node(node);
223	return 0;
224	}
225	xt_free_node(node);
226
227	return 1;
228	}
229
230	void jabber_chat_invite(struct groupchat c, char who, char *message)
231	{
232	struct xt_node *node;
233	struct im_connection *ic = c->ic;
234	struct jabber_chat *jc = c->data;
235
236	node = xt_new_node("reason", message, NULL);
237
238	node = xt_new_node("invite", NULL, node);
239	xt_add_attr(node, "to", who);
240
241	node = xt_new_node("x", NULL, node);
242	xt_add_attr(node, "xmlns", XMLNS_MUC_USER);
243
244	node = jabber_make_packet("message", NULL, jc->name, node);
245
246	jabber_write_packet(ic, node);
247
248	xt_free_node(node);
249	}
250
251	static int jabber_chat_has_other_resources(struct im_connection ic, struct jabber_buddy bud)
252	{
253	struct jabber_buddy *cur;
254
255	for (cur = jabber_buddy_by_jid(ic, bud->bare_jid, GET_BUDDY_FIRST); cur; cur = cur->next) {
256	if (cur != bud && jabber_compare_jid(cur->ext_jid, bud->ext_jid)) {
257	return TRUE;
258	}
259	}
260
261	return FALSE;
262	}
263
264	/* Not really the same syntax as the normal pkt_ functions, but this isn't
265	called by the xmltree parser directly and this way I can add some extra
266	parameters so we won't have to repeat too many things done by the caller
267	already. */
268	void jabber_chat_pkt_presence(struct im_connection ic, struct jabber_buddy bud, struct xt_node *node)
269	{
270	struct groupchat *chat;
271	struct xt_node *c;
272	char *type = xt_find_attr(node, "type");
273	struct jabber_data *jd = ic->proto_data;
274	struct jabber_chat *jc;
275	char *s;
276
277	if ((chat = jabber_chat_by_jid(ic, bud->bare_jid)) == NULL) {
278	/* How could this happen?? We could do kill( self, 11 )
279	now or just wait for the OS to do it. :-) */
280	return;
281	}
282
283	jc = chat->data;
284
285	if (type == NULL && !(bud->flags & JBFLAG_IS_CHATROOM)) {
286	bud->flags \|= JBFLAG_IS_CHATROOM;
287	/* If this one wasn't set yet, this buddy just joined the chat.
288	Slightly hackish way of finding out eh? ;-) */
289
290	/* This is pretty messy... Here it sets ext_jid to the real
291	JID of the participant. Works for non-anonymized channels.
292	Might break if someone joins a chat twice, though. */
293	for (c = node->children; (c = xt_find_node(c, "x")); c = c->next) {
294	if ((s = xt_find_attr(c, "xmlns")) &&
295	(strcmp(s, XMLNS_MUC_USER) == 0)) {
296	struct xt_node *item;
297
298	item = xt_find_node(c->children, "item");
299	if ((s = xt_find_attr(item, "jid"))) {
300	/* Yay, found what we need. :-) */
301	bud->ext_jid = jabber_normalize(s);
302	break;
303	}
304	}
305	}
306
307	/* Make up some other handle, if necessary. */
308	if (bud->ext_jid == NULL) {
309	if (bud == jc->me) {
310	bud->ext_jid = g_strdup(jd->me);
311	} else {
312	int i;
313
314	/* Don't want the nick to be at the end, so let's
315	think of some slightly different notation to use
316	for anonymous groupchat participants in BitlBee. */
317	bud->ext_jid = g_strdup_printf("%s=%s", bud->resource, bud->bare_jid);
318
319	/* And strip any unwanted characters. */
320	for (i = 0; bud->resource[i]; i++) {
321	if (bud->ext_jid[i] == '=' \|\| bud->ext_jid[i] == '@') {
322	bud->ext_jid[i] = '_';
323	}
324	}
325	}
326	bud->flags \|= JBFLAG_IS_ANONYMOUS;
327	}
328
329	if (bud != jc->me && bud->flags & JBFLAG_IS_ANONYMOUS) {
330	/* If JIDs are anonymized, add them to the local
331	list for the duration of this chat. */
332	imcb_add_buddy(ic, bud->ext_jid, NULL);
333	imcb_buddy_nick_hint(ic, bud->ext_jid, bud->resource);
334	}
335
336	if (bud == jc->me && jc->invite != NULL) {
337	char *msg = g_strdup_printf("Please join me in room %s", jc->name);
338	jabber_chat_invite(chat, jc->invite, msg);
339	g_free(jc->invite);
340	g_free(msg);
341	jc->invite = NULL;
342	}
343
344	s = strchr(bud->ext_jid, '/');
345	if (s) {
346	s = 0; / Should NEVER be NULL, but who knows... */
347	}
348
349	if (bud != jc->me && (jc->flags & JCFLAG_ALWAYS_USE_NICKS) && !(bud->flags & JBFLAG_IS_ANONYMOUS)) {
350	imcb_buddy_nick_change(ic, bud->ext_jid, bud->resource);
351	}
352
353	imcb_chat_add_buddy(chat, bud->ext_jid);
354	if (s) {
355	*s = '/';
356	}
357	} else if (type) { /* type can only be NULL or "unavailable" in this function */
358	if ((bud->flags & JBFLAG_IS_CHATROOM) && bud->ext_jid && !jabber_chat_has_other_resources(ic, bud)) {
359	char *reason = NULL;
360	char *status = NULL;
361	char *status_text = NULL;
362
363	if ((c = xt_find_node_by_attr(node->children, "x", "xmlns", XMLNS_MUC_USER))) {
364	struct xt_node *c2 = c->children;
365
366	while ((c2 = xt_find_node(c2, "status"))) {
367	char *code = xt_find_attr(c2, "code");
368	if (g_strcmp0(code, "301") == 0) {
369	status = "Banned";
370	break;
371	} else if (g_strcmp0(code, "303") == 0) {
372	/* This could be handled in a cleverer way,
373	* but let's just show a literal part/join for now */
374	status = "Changing nicks";
375	break;
376	} else if (g_strcmp0(code, "307") == 0) {
377	status = "Kicked";
378	break;
379	}
380	c2 = c2->next;
381	}
382
383	/* Sometimes the status message is in presence/x/item/reason */
384	if ((c2 = xt_find_path(c, "item/reason")) && c2->text && c2->text_len) {
385	status_text = c2->text;
386	}
387	}
388
389	/* Sometimes the status message is right inside <presence> */
390	if ((c = xt_find_node(node->children, "status")) && c->text && c->text_len) {
391	status_text = c->text;
392	}
393
394	if (status_text && status) {
395	reason = g_strdup_printf("%s: %s", status, status_text);
396	} else {
397	reason = g_strdup(status_text ? : status);
398	}
399
400	s = strchr(bud->ext_jid, '/');
401	if (s) {
402	*s = 0;
403	}
404	imcb_chat_remove_buddy(chat, bud->ext_jid, reason);
405	if (bud != jc->me && bud->flags & JBFLAG_IS_ANONYMOUS) {
406	imcb_remove_buddy(ic, bud->ext_jid, reason);
407	}
408	if (s) {
409	*s = '/';
410	}
411
412	g_free(reason);
413	}
414
415	if (bud == jc->me) {
416	jabber_chat_free(chat);
417	}
418	}
419	}
420
421	void jabber_chat_pkt_message(struct im_connection ic, struct jabber_buddy bud, struct xt_node *node)
422	{
423	struct xt_node *subject = xt_find_node(node->children, "subject");
424	struct xt_node *body = xt_find_node(node->children, "body");
425	struct groupchat *chat = NULL;
426	struct jabber_chat *jc = NULL;
427	char *from = NULL;
428	char *nick = NULL;
429	char *final_from = NULL;
430	char *bare_jid = NULL;
431	guint32 flags = 0;
432
433	from = (bud) ? bud->full_jid : xt_find_attr(node, "from");
434
435	if (from) {
436	nick = strchr(from, '/');
437	if (nick) {
438	*nick = 0;
439	}
440	chat = jabber_chat_by_jid(ic, from);
441	if (nick) {
442	*nick = '/';
443	nick++;
444	}
445	}
446
447	jc = (chat) ? chat->data : NULL;
448
449	if (!bud) {
450	struct xt_node *c;
451	char *s;
452
453	/* Try some clever stuff to find out the real JID here */
454	c = xt_find_node_by_attr(node->children, "delay", "xmlns", XMLNS_DELAY);
455
456	if (c && ((s = xt_find_attr(c, "from")) \|\|
457	(s = xt_find_attr(c, "from_jid")))) {
458	/* This won't be useful if it's the MUC JID */
459	if (!(jc && jabber_compare_jid(s, jc->name))) {
460	/* Hopefully this one makes more sense! */
461	bud = jabber_buddy_by_jid(ic, s, GET_BUDDY_FIRST \| GET_BUDDY_CREAT);
462	}
463	}
464
465	}
466
467	if (subject && chat) {
468	char empty[1] = "";
469	char *subject_text = subject->text_len > 0 ? subject->text : empty;
470	if (g_strcmp0(chat->topic, subject_text) != 0) {
471	bare_jid = (bud) ? jabber_get_bare_jid(bud->ext_jid) : NULL;
472	imcb_chat_topic(chat, bare_jid, subject_text,
473	jabber_get_timestamp(node));
474	g_free(bare_jid);
475	bare_jid = NULL;
476	}
477	}
478
479	if (body == NULL \|\| body->text_len == 0) {
480	/* Meh. Empty messages aren't very interesting, no matter
481	how much some servers love to send them. */
482	return;
483	}
484
485	if (chat == NULL) {
486	if (nick == NULL) {
487	imcb_log(ic, "System message from unknown groupchat %s: %s", from, body->text);
488	} else {
489	imcb_log(ic, "Groupchat message from unknown JID %s: %s", from, body->text);
490	}
491
492	return;
493	} else if (chat != NULL && bud == NULL && nick == NULL) {
494	imcb_chat_log(chat, "From conference server: %s", body->text);
495	return;
496	} else if (jc && jc->flags & JCFLAG_MESSAGE_SENT && bud == jc->me &&
497	(jabber_cache_handle_packet(ic, node) == XT_ABORT)) {
498	/* Self message marked by this bitlbee, don't show it */
499	return;
500	}
501
502	if (bud) {
503	bare_jid = jabber_get_bare_jid(bud->ext_jid ? bud->ext_jid : bud->full_jid);
504	final_from = bare_jid;
505	if (bud == jc->me \|\| (g_strcasecmp(final_from, ic->acc->user) == 0)) {
506	flags = OPT_SELFMESSAGE;
507	}
508	} else {
509	final_from = nick;
510	}
511
512	imcb_chat_msg(chat, final_from, body->text, flags, jabber_get_timestamp(node));
513
514	g_free(bare_jid);
515	}

Note: See TracBrowser for help on using the repository browser.

Context Navigation

source: protocols/jabber/conference.c @ 4466e3e

Download in other formats: