Channels in user.xml with both type attribute and element fails to load

[Olof 'zibri' Johansson <olof@…>]

With a channel block in the user's XML configuration containing both a type attribute and a type setting element, bitlbee seems to have issues loading the channel settings. Instead of loading a "permanent" channel with chat_type = room, a temporary channel with chat_type = groupchat is loaded.

<channel name="#foobar" type="chat">
	<setting name="account">jabber</setting>
	<setting name="auto_join">false</setting>
	<setting name="chat_type">room</setting>
	<setting name="room">foobar@conference.talk.example.com</setting>
	<setting name="type">chat</setting>
</channel>

This behavior was seen after upgrading to bazaar commit 1005 (from 997, but I can't be sure that that is the version I actually used before I reconnected). Removing <setting name="type">chat</setting> makes bitlbee behave as expected again.

[dx]

Fixed in ​https://github.com/bitlbee/bitlbee/commit/25f6151ce38d07cd85f68c3e881acdf8652f6dc1