Modify

#571 closed enhancement (fixed)

BitlBee no-quit patch

Reported by: Florian E.J. Fruth Owned by:
Priority: normal Milestone:
Component: BitlBee Version: 1.2.4
Keywords: no quit, patch Cc: spammail01@…
IRC client+version: Client-independent Operating System: Linux
OS version/distro:

Description

Hi,

I updated the no-quit patch for bitlbee. As there is the possibility to use set I implemented a "set show_offline true/false" so everyone is happy ;)

Florian E.J. Fruth

Attachments (1)

bitlbee-1.2.4-show_offline.patch (38.3 KB) - added by Florian E.J. Fruth at 2010-03-12T21:06:25Z.
the patch

Download all attachments as: .zip

Change History (6)

Changed at 2010-03-12T21:06:25Z by Florian E.J. Fruth

the patch

comment:1 Changed at 2010-03-13T01:17:20Z by wilmer

Milestone: 1.2.x

Nice work, including a doc update. :-)

Let me take a closer look at this one of these days. People ask for this functionality for some time already but my worry is that everyone wants something slightly different and a quick fix won't have the flexibility people want.

To clarify, this patch makes away and offline people appear the same (in &bitlbee, without voice)?

comment:2 Changed at 2010-03-13T10:18:33Z by Florian E.J. Fruth

Read the Doc :P The normal bitlbee user status is the following:

Offline icq users => not visible in irc Away icq users => normal irc users (no voice, no op) (-v-o) Online users => voice (+v)

If you set "show_offline = true" then the behaviour changes to:

Offline users => normal irc users (-v-o - but still an away message set) Away users => voice (+v) Online users => op (+o)

comment:3 Changed at 2010-03-14T01:07:54Z by wilmer

D'oh, sorry about that. I was just quickly taking a look before going to sleep, but that's no excuse for not reading just a few lines of docs. :-)

I must admit I still have some mixed feelings about this. The fact that one needs to reconnect for things to take effect is unfortunate but acceptable; the "private" setting has the same behaviour.

The u->online property gets redefined as meaning "is in &bitlbee". This mostly works out well, but it breaks watch/ison/notify. Then again, fixing that could be an IRC protocol violation.

Also, turning on this setting now seems to imply away_devoice-like behaviour, even if the user doesn't want it. One could argue that the user probably doesn't care, but often these voice changes get much noisier than joins/quits. (BTW, instead of giving everyone an @ it may be nice to give them halfops instead?)

But all in all I'm afraid this is still a bit of a "it scratches my exact itch" solution. :-/

comment:4 Changed at 2010-05-09T23:35:35Z by wilmer

Resolution: fixed
Status: newclosed

Oh, BTW:

changeset:devel,567

Sorry for taking so long. The code is very messy now, but a rewrite is on its way already so I'm not too worried about it.

Modify Ticket

Action
as closed The ticket will remain with no owner.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.